Skip to contentSkip to conversation

package/coreutils: simplify the [ -> test symlink

PATCH New Yann E. MORIN 2 participants 2 messages Jun 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/coreutils: simplify the [ -> test symlink

Wheter we are mutli-call or multi-binaries, test is either a symlink to coreutils or a standalone binary.

Consequently, test always exists, and so we can simplify the [ symlink.

Cc Markus Mayer <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 package/coreutils/coreutils.mk | 6 ------
 1 file changed, 6 deletions(-)
package/coreutils/coreutils.mk +0 -6
index 6b8f3ba4b8..55aa92e753 100644
@@ -130,15 +130,9 @@ COREUTILS_CONF_OPTS += --enable-no-install-program=stdbuf
 endif
 
 # link for archaic shells
-ifeq ($(BR2_PACKAGE_COREUTILS_INDIVIDUAL_BINARIES),y)
 define COREUTILS_CREATE_TEST_SYMLINK
 	ln -fs test $(TARGET_DIR)/usr/bin/[
 endef
-else
-define COREUTILS_CREATE_TEST_SYMLINK
-	ln -fs coreutils $(TARGET_DIR)/usr/bin/[
-endef
-endif
 COREUTILS_POST_INSTALL_TARGET_HOOKS += COREUTILS_CREATE_TEST_SYMLINK
 
 # gnu thinks chroot is in bin, debian thinks it's in sbin
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/coreutils: simplify the [ -> test symlink

Quoted 11 lines · On Sat, 22 Jun 2019 15:19:36 +0200 "Yann E. MORIN" <[email protected]>…

Wheter we are mutli-call or multi-binaries, test is either a symlink to coreutils or a standalone binary.

Consequently, test always exists, and so we can simplify the [ symlink.

Cc Markus Mayer <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 package/coreutils/coreutils.mk | 6 ------
 1 file changed, 6 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com