Skip to contentSkip to conversation

parisc: asm: psw.h: missing header guard

PATCH Superseded Denis Efremov 2 participants 4 messages Jun 23, 2019 – Jun 24, 2019 PA-RISC architecture

lore
Share & tools
lore

Denis Efremov

author
#0 lore raw

PATCH 1/1 parisc: asm: psw.h: missing header guard

The psw.h header file contains #ifndef directive of the guard, but the complimentary #define directive is missing. The patch adds the appropriate #define to fix the header guard.

Signed-off-by Denis Efremov <[email protected]>
---
 arch/parisc/include/asm/psw.h | 1 +
 1 file changed, 1 insertion(+)
arch/parisc/include/asm/psw.h +1 -0
index 76c301146c31..7a175e866ed0 100644
@@ -1,5 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 #ifndef _PARISC_PSW_H
+#define _PARISC_PSW_H
 
 
 #define	PSW_I	0x00000001
Signature · 1 line
2.21.0
#1 lore raw
Quoted 14 lines · Denis Efremov

The psw.h header file contains #ifndef directive of the guard, but the complimentary #define directive is missing. The patch adds the appropriate #define to fix the header guard.

Signed-off-by Denis Efremov <[email protected]>
---
 arch/parisc/include/asm/psw.h | 1 +
 1 file changed, 1 insertion(+)
arch/parisc/include/asm/psw.h +0 -0
index 76c301146c31..7a175e866ed0 100644

arch/parisc/include/asm/psw.h line 6

Quoted 6 lines
arch/parisc/include/asm/psw.h +1 -0
@@ -1,5 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 #ifndef _PARISC_PSW_H
+#define _PARISC_PSW_H
 
 
 #define	PSW_I	0x00000001

You could have removed one of the 2 empty lines then.

Eike

author
#2 lore raw
Quoted 3 lines · Rolf Eike Beer

You could have removed one of the 2 empty lines then.

Will send the v2 in minutes.

Denis

author
#3 lore raw

PATCH v2 1/1 parisc: asm: psw.h: missing header guard

In reply to Denis Efremov

The psw.h header file contains #ifndef directive of the guard, but the complimentary #define directive is missing. The patch adds the appropriate #define to fix the header guard.

Signed-off-by Denis Efremov <[email protected]>
---
 arch/parisc/include/asm/psw.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/parisc/include/asm/psw.h +1 -1
index 76c301146c31..46921ffcc407 100644
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 #ifndef _PARISC_PSW_H
-
+#define _PARISC_PSW_H
 
 #define	PSW_I	0x00000001
 #define	PSW_D	0x00000002
Signature · 1 line
2.21.0