Skip to contentSkip to conversation

libcdaudio: fix compile on host systems without C++ support

PATCH New Peter Seiderer 4 participants 4 messages Jan 13, 2019 – Jun 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libcdaudio: fix compile on host systems without C++ support

Delivered libcdaudio configure tries to run a C++ check with the host C preprocessor. Fix it by enabling autoreconf (needs a patch for configure.ac/Makefile.am removing ancient lines).

Fixes [1]:

checking how to run the C++ preprocessor... /lib/cpp
configure: error: C++ preprocessor "/lib/cpp" fails sanity check

---
 .../0001-libcdaudio-enable-autoreconf.patch   | 43 +++++++++++++++++++
 package/libcdaudio/libcdaudio.mk              |  3 ++
 2 files changed, 46 insertions(+)
 create mode 100644 package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch new file +43 -0
new file mode 100644
index 0000000000..ab2296c042
@@ -0,0 +1,43 @@
+From 9c2873b1d9292bcf43c862b6777d41c40521424c Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <[email protected]>
+Date: Sun, 13 Jan 2019 22:27:42 +0100
+Subject: [PATCH] libcdaudio: enable autoreconf
+
+Fixes the following two autoreconf errors (by simple removing of the
+two offending lines):
+
+  configure.ac:20: error: automatic de-ANSI-fication support has been removed
+
+  Makefile.am:2: error: automatic de-ANSI-fication support has been removed
+
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ Makefile.am  | 1 -
+ configure.ac | 1 -
+ 2 files changed, 2 deletions(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index f639dd8..a32cfe6 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -1,5 +1,4 @@
+ ## Process this file with automake to produce Makefile.in
+-AUTOMAKE_OPTIONS = ansi2knr
+ SUBDIRS = src
+ 
+ bin_SCRIPTS = libcdaudio-config
+diff --git a/configure.ac b/configure.ac
+index bbdd42d..6699ceb 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -17,7 +17,6 @@ AM_CONFIG_HEADER(config.h)
+ AC_PROG_AWK
+ AC_PROG_CC
+ AC_PROG_CPP
+-AM_C_PROTOTYPES
+ AM_PROG_CC_STDC
+ AC_PROG_INSTALL
+ AC_PROG_LN_S
+-- 
+2.20.1
+
package/libcdaudio/libcdaudio.mk +3 -0
index 5d421eba7a..e2c1496287 100644
@@ -11,4 +11,7 @@ LIBCDAUDIO_CONFIG_SCRIPTS = libcdaudio-config
 LIBCDAUDIO_LICENSE = GPL-2.0+
 LIBCDAUDIO_LICENSE_FILES = COPYING
 
+# fix configure failure on host systems without C++ support
+LIBCDAUDIO_AUTORECONF = YES
+
 $(eval $(autotools-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 libcdaudio: fix compile on host systems without C++ support

Peter, All,

On 2019-01-13 22:47 +0100, Peter Seiderer spake thusly:

Quoted 10 lines

Delivered libcdaudio configure tries to run a C++ check with the host C preprocessor. Fix it by enabling autoreconf (needs a patch for configure.ac/Makefile.am removing ancient lines).

Fixes [1]:

checking how to run the C++ preprocessor... /lib/cpp
configure: error: C++ preprocessor "/lib/cpp" fails sanity check

Regards,
Yann E. MORIN.

Quoted 74 lines
---
 .../0001-libcdaudio-enable-autoreconf.patch   | 43 +++++++++++++++++++
 package/libcdaudio/libcdaudio.mk              |  3 ++
 2 files changed, 46 insertions(+)
 create mode 100644 package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch new file +43 -0
new file mode 100644
index 0000000000..ab2296c042
@@ -0,0 +1,43 @@
+From 9c2873b1d9292bcf43c862b6777d41c40521424c Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <[email protected]>
+Date: Sun, 13 Jan 2019 22:27:42 +0100
+Subject: [PATCH] libcdaudio: enable autoreconf
+
+Fixes the following two autoreconf errors (by simple removing of the
+two offending lines):
+
+  configure.ac:20: error: automatic de-ANSI-fication support has been removed
+
+  Makefile.am:2: error: automatic de-ANSI-fication support has been removed
+
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ Makefile.am  | 1 -
+ configure.ac | 1 -
+ 2 files changed, 2 deletions(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index f639dd8..a32cfe6 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -1,5 +1,4 @@
+ ## Process this file with automake to produce Makefile.in
+-AUTOMAKE_OPTIONS = ansi2knr
+ SUBDIRS = src
+ 
+ bin_SCRIPTS = libcdaudio-config
+diff --git a/configure.ac b/configure.ac
+index bbdd42d..6699ceb 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -17,7 +17,6 @@ AM_CONFIG_HEADER(config.h)
+ AC_PROG_AWK
+ AC_PROG_CC
+ AC_PROG_CPP
+-AM_C_PROTOTYPES
+ AM_PROG_CC_STDC
+ AC_PROG_INSTALL
+ AC_PROG_LN_S
+-- 
+2.20.1
+
package/libcdaudio/libcdaudio.mk +3 -0
index 5d421eba7a..e2c1496287 100644
@@ -11,4 +11,7 @@ LIBCDAUDIO_CONFIG_SCRIPTS = libcdaudio-config
 LIBCDAUDIO_LICENSE = GPL-2.0+
 LIBCDAUDIO_LICENSE_FILES = COPYING
 
+# fix configure failure on host systems without C++ support
+LIBCDAUDIO_AUTORECONF = YES
+
 $(eval $(autotools-package))
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 libcdaudio: fix compile on host systems without C++ support

In reply to Peter Seiderer
Quoted 10 lines · On Sun, 13 Jan 2019 22:47:22 +0100 Peter Seiderer <[email protected]> wrote:

Delivered libcdaudio configure tries to run a C++ check with the host C preprocessor. Fix it by enabling autoreconf (needs a patch for configure.ac/Makefile.am removing ancient lines).

Fixes [1]:

checking how to run the C++ preprocessor... /lib/cpp
configure: error: C++ preprocessor "/lib/cpp" fails sanity check

Contrary to what your commit title says, the problem does not occur when the host system lacks C++ support, it's when the target toolchain doesn't have C++ support. I have an Arch Linux system here (which is where the failure happens), and the host system has C++ support, but doesn't provide /lib/cpp.

I fixed up the commit title, commit log, and comment in the .mk file and applied.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 libcdaudio: fix compile on host systems without C++ support

Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Quoted 10 lines · On Sun, 13 Jan 2019 22:47:22 +0100 Peter Seiderer <[email protected]> wrote:

Delivered libcdaudio configure tries to run a C++ check with the host C preprocessor. Fix it by enabling autoreconf (needs a patch for configure.ac/Makefile.am removing ancient lines).

Fixes [1]:

checking how to run the C++ preprocessor... /lib/cpp
configure: error: C++ preprocessor "/lib/cpp" fails sanity check

Quoted 8 lines

Contrary to what your commit title says, the problem does not occur when the host system lacks C++ support, it's when the target toolchain doesn't have C++ support. I have an Arch Linux system here (which is where the failure happens), and the host system has C++ support, but doesn't provide /lib/cpp.

I fixed up the commit title, commit log, and comment in the .mk file and applied.

Committed to 2019.02.x and 2019.05.x with the same fixes, thanks.

Signature · 1 line
Bye, Peter Korsgaard