Skip to contentSkip to conversation

package/icu: adjust version information

PATCH New Thomas Petazzoni 2 participants 2 messages Jun 24, 2019 – Jun 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/icu: adjust version information

The icu upstream developers have a strange way of labelling their versions:

- The Github tags are named release-XX-Y, and therefore the versions referenced by by Release Monitoring look like 60-2 or 64-1.

- The tarballs contain the version with an underscore separator, i.e 60_2 or 64_1.

- The directories on http://download.icu-project.org/files/icu4c/
contain the version with a dot separator, i.e 60.2 or 64.1.

In order to have our <pkg>_VERSION match the one on Release Monitoring, we adjust it to use the underscore separator, and then further tweak the ICU_SOURCE and ICU_SITE definitions to keep everything working.

---
 package/icu/icu.mk | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
package/icu/icu.mk +6 -3
index a9466c8322..7bc1b97624 100644
@@ -4,9 +4,12 @@
 #
 ################################################################################
 
-ICU_VERSION = 60.2
-ICU_SOURCE = icu4c-$(subst .,_,$(ICU_VERSION))-src.tgz
-ICU_SITE = http://download.icu-project.org/files/icu4c/$(ICU_VERSION)
+# Git tags (and therefore versions on release-monitoring.org) use the
+# XX-Y format, but the tarballs are named XX_Y and the containing
+# directories XX.Y.
+ICU_VERSION = 60-2
+ICU_SOURCE = icu4c-$(subst -,_,$(ICU_VERSION))-src.tgz
+ICU_SITE = http://download.icu-project.org/files/icu4c/$(subst -,.,$(ICU_VERSION))
 ICU_LICENSE = ICU License
 ICU_LICENSE_FILES = LICENSE
 
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 package/icu: adjust version information

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

The icu upstream developers have a strange way of labelling their versions:
- The Github tags are named release-XX-Y, and therefore the versions referenced by by Release Monitoring look like 60-2 or 64-1.

- The tarballs contain the version with an underscore separator, i.e 60_2 or 64_1.

Quoted 7 lines

- The directories on http://download.icu-project.org/files/icu4c/
contain the version with a dot separator, i.e 60.2 or 64.1.

In order to have our <pkg>_VERSION match the one on Release Monitoring, we adjust it to use the underscore separator, and then further tweak the ICU_SOURCE and ICU_SITE definitions to keep everything working.

Sigh, what a mess! Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard