Skip to contentSkip to conversation

mm/vmalloc: fix a compile warning in mm

PATCH In review Weitao Hou 2 participants 2 messages Jun 24, 2019

Subsystems (2)
lore
Share & tools
lore

Weitao Hou

author
#0 lore raw

PATCH 1/1 mm/vmalloc: fix a compile warning in mm

mm/vmalloc.c: In function ‘pcpu_get_vm_areas’:
mm/vmalloc.c:976:4: warning: ‘lva’ may be used uninitialized in this function [-Wmaybe-uninitialized] insert_vmap_area_augment(lva, &va->rb_node,

---
 mm/vmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/vmalloc.c +1 -1
index 4c9e150e5ad3..78c5617fdf3f 100644
@@ -913,7 +913,7 @@ adjust_va_to_fit_type(struct vmap_area *va,
 	unsigned long nva_start_addr, unsigned long size,
 	enum fit_type type)
 {
-	struct vmap_area *lva;
+	struct vmap_area *lva = NULL;
 
 	if (type == FL_FIT_TYPE) {
 		/*
Signature · 1 line
2.18.0
maintainer
#1 lore raw

Hello, Hou.

It has already been fixed. Please have a look at:

https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-avoid-bogus-wmaybe-uninitialized-warning.patch
https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-avoid-bogus-wmaybe-uninitialized-warning-fix.patch

--
Vlad Rezki

Quoted 27 lines · Weitao Hou

mm/vmalloc.c: In function ‘pcpu_get_vm_areas’:
mm/vmalloc.c:976:4: warning: ‘lva’ may be used uninitialized in this function [-Wmaybe-uninitialized] insert_vmap_area_augment(lva, &va->rb_node,

---
 mm/vmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/vmalloc.c +1 -2
index 4c9e150e5ad3..78c5617fdf3f 100644
@@ -913,7 +913,7 @@ adjust_va_to_fit_type(struct vmap_area *va,
        unsigned long nva_start_addr, unsigned long size,
        enum fit_type type)
 {
-       struct vmap_area *lva;
+       struct vmap_area *lva = NULL;
 
        if (type == FL_FIT_TYPE) {
                /*
--

2.18.0

Signature · 1 line
Uladzislau Rezki