tests/kms_flip: improve logging when timing out

PATCH In review Simon Ser 3 participants 6 messages Jun 24, 2019 – Jun 25, 2019

lore

Share & tools

lore

Simon Ser

author

2019-06-24 08:28 UTC #0 lore raw

PATCH v3 1/1 tests/kms_flip: improve logging when timing out

Signed-off-by Simon Ser <[email protected]>

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105363
---

Changes from v2 to v3: always log the vblank duration (Arek)

 tests/kms_flip.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

tests/kms_flip.c +4 -2

index 2a158d97bbec..0a8d1c55a7aa 100755
@@ -686,14 +686,16 @@ static unsigned int run_test_step(struct test_output *o)
 	    !(o->pending_events & EVENT_VBLANK) && o->flip_state.count > 0) {
 		struct vblank_reply reply;
 		unsigned int exp_seq;
-		unsigned long start;
+		unsigned long start, end;
 
 		exp_seq = o->flip_state.current_seq;
 		start = gettime_us();
 		do_or_die(__wait_for_vblank(TEST_VBLANK_ABSOLUTE |
 					    TEST_VBLANK_BLOCK, o->pipe, exp_seq,
 					    0, &reply));
-		igt_assert(gettime_us() - start < 500);
+		end = gettime_us();
+		igt_debug("Vblank took %luus\n", end - start);
+		igt_assert(end - start < 500);
 		igt_assert_eq(reply.sequence, exp_seq);
 		igt_assert(timercmp(&reply.ts, &o->flip_state.last_ts, ==));
 	}

--
2.22.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-06-24 08:59 UTC #1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: improve logging when timing out (rev3)

== Series Details ==

Series: tests/kms_flip: improve logging when timing out (rev3)
URL : https://patchwork.freedesktop.org/series/62100/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6331 -> IGTPW_3191
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/62100/revisions/3/mbox/

Known issues
------------

Here are the changes found in IGTPW_3191 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@debugfs_test@read_all_entries:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/fi-icl-u3/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/fi-icl-u3/igt@debugfs_test@read_all_entries.html

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/fi-blb-e6850/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/fi-blb-e6850/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-skl-iommu: [PASS][5] -> [INCOMPLETE][6] ([fdo#108602])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/fi-skl-iommu/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/fi-skl-iommu/igt@i915_selftest@live_blt.html

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][7] -> [FAIL][8] ([fdo#109485])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/fi-kbl-7500u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/fi-kbl-7500u/igt@[email protected]

#### Possible fixes ####

* igt@gem_mmap_gtt@basic-small-bo:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/fi-icl-u3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/fi-icl-u3/igt@[email protected]

[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485

Participating hosts (48 -> 42)
------------------------------

Additional (1): fi-pnv-d510
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-icl-dsi fi-bdw-samus

Build changes
-------------

* IGT: IGT_5064 -> IGTPW_3191

CI_DRM_6331: a20afe5511160e9c1ea22b80b3be0226dfb0917a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3191: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/
IGT_5064: 22850c1906550fb97b405c019275dcfb34be8cf7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-06-24 10:13 UTC #2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_flip: improve logging when timing out (rev3)

In reply to Simon Ser

== Series Details ==

Series: tests/kms_flip: improve logging when timing out (rev3)
URL : https://patchwork.freedesktop.org/series/62100/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6331_full -> IGTPW_3191_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/62100/revisions/3/mbox/

Known issues
------------

Here are the changes found in IGTPW_3191_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_eio@banned:
- shard-glk: [PASS][1] -> [DMESG-WARN][2] ([fdo#110913 ]) +7 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-glk8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-glk1/igt@[email protected]

* igt@gem_eio@suspend:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([fdo#110913 ]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-kbl1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-kbl1/igt@[email protected]

* igt@gem_exec_reloc@basic-wc-cpu-active:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-apl3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-apl1/igt@[email protected]

* igt@gem_exec_whisper@normal:
- shard-iclb: [PASS][7] -> [DMESG-WARN][8] ([fdo#110913 ]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-iclb1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-iclb5/igt@[email protected]

* igt@gem_partial_pwrite_pread@write-snoop:
- shard-hsw: [PASS][9] -> [DMESG-WARN][10] ([fdo#110789] / [fdo#110913 ]) +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-hsw2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-hsw5/igt@[email protected]

* igt@gem_tiled_partial_pwrite_pread@reads:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#110789] / [fdo#110913 ]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-snb6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-snb7/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-hsw: [PASS][13] -> [SKIP][14] ([fdo#109271]) +20 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-hsw2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-hsw1/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([fdo#108566])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-apl5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-apl7/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [PASS][17] -> [INCOMPLETE][18] ([fdo#103540])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-hsw4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-hsw5/igt@[email protected]

* igt@kms_flip@modeset-vs-vblank-race:
- shard-glk: [PASS][19] -> [FAIL][20] ([fdo#103060])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-glk6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-glk8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#103167]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt.html

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#103166])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-iclb6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-iclb5/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-iclb6/igt@kms_psr@psr2_primary_mmap_gtt.html

* igt@kms_rmfb@close-fd:
- shard-snb: [PASS][27] -> [SKIP][28] ([fdo#109271]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-snb4/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-snb2/igt@[email protected]

* igt@kms_setmode@basic:
- shard-apl: [PASS][29] -> [FAIL][30] ([fdo#99912])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-apl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-apl8/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [DMESG-WARN][31] ([fdo#108566]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-apl7/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-apl3/igt@[email protected]

* igt@gem_eio@wait-wedge-immediate:
- shard-iclb: [DMESG-WARN][33] ([fdo#110913 ]) -> [PASS][34] +10 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-iclb2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-iclb5/igt@[email protected]

* igt@gem_partial_pwrite_pread@reads-snoop:
- shard-kbl: [DMESG-WARN][35] ([fdo#110913 ]) -> [PASS][36] +5 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-kbl4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-kbl3/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-hsw: [DMESG-WARN][37] ([fdo#110789] / [fdo#110913 ]) -> [PASS][38] +5 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-hsw5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-hsw4/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-glk: [DMESG-WARN][39] ([fdo#110913 ]) -> [PASS][40] +8 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-glk7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-glk8/igt@[email protected]

* igt@gem_persistent_relocs@forked-thrashing:
- shard-snb: [DMESG-WARN][41] ([fdo#110789] / [fdo#110913 ]) -> [PASS][42] +5 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-snb6/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-snb6/igt@[email protected]
- shard-apl: [DMESG-WARN][43] ([fdo#110913 ]) -> [PASS][44] +4 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-apl3/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-apl3/igt@[email protected]

* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: [FAIL][45] ([fdo#108686]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-hsw1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-hsw8/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-iclb: [INCOMPLETE][47] ([fdo#107713]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-iclb7/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-iclb5/igt@[email protected]

* igt@i915_pm_rpm@i2c:
- shard-hsw: [FAIL][49] ([fdo#104097]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-hsw2/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-hsw6/igt@[email protected]

* igt@i915_selftest@live_client:
- shard-glk: [DMESG-FAIL][51] -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-glk5/igt@i915_selftest@live_client.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-glk9/igt@i915_selftest@live_client.html

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-hsw: [SKIP][53] ([fdo#109271]) -> [PASS][54] +29 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-hsw1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-hsw4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff:
- shard-glk: [FAIL][55] ([fdo#103167]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-glk5/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-glk8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][57] ([fdo#103167]) -> [PASS][58] +5 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][59] ([fdo#109642]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-iclb8/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][61] ([fdo#109441]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

* igt@perf_pmu@rc6:
- shard-kbl: [SKIP][63] ([fdo#109271]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-kbl7/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-kbl1/igt@[email protected]

* igt@prime_busy@hang-bsd:
- shard-glk: [INCOMPLETE][65] ([fdo#103359] / [k.org#198133]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-glk4/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-glk4/igt@[email protected]

#### Warnings ####

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-apl: [INCOMPLETE][67] ([fdo#103927]) -> [SKIP][68] ([fdo#109271])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6331/shard-apl8/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3191/shard-apl4/igt@[email protected]

Participating hosts (10 -> 6)
------------------------------

Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005

Build changes
-------------

* IGT: IGT_5064 -> IGTPW_3191
* Piglit: piglit_4509 -> None

== Logs ==

Arkadiusz Hiler

Reviewed-by on v3 1/1

2019-06-24 12:02 UTC #3 lore raw

In reply to Simon Ser

Quoted 2 lines · Simon Ser

Signed-off-by Simon Ser <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105363

Reviewed-by Arkadiusz Hiler <[email protected]>

Please make sure that filters are updated before merging.
_______________________________________________
igt-dev mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Ser, Simon

author

2019-06-24 12:44 UTC #4 lore raw

Quoted 6 lines · Arkadiusz Hiler

Quoted 2 lines · Simon Ser
Signed-off-by Simon Ser <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105363
Reviewed-by Arkadiusz Hiler <[email protected]>
Please make sure that filters are updated before merging.

Martin, can you update the filters of that issue to include:

    igt_assert(end - start < 500);

Thanks
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Ser, Simon

author

2019-06-25 11:27 UTC #5 lore raw

Quoted 11 lines · Simon

Quoted 6 lines · Arkadiusz Hiler
Quoted 2 lines · Simon Ser
Signed-off-by Simon Ser <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105363
Reviewed-by Arkadiusz Hiler <[email protected]>
Please make sure that filters are updated before merging.
Martin, can you update the filters of that issue to include:
    igt_assert(end - start < 500);

Arek taught me how to do it in the end :)

Quoted 5 lines

Thanks
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev