Skip to contentSkip to conversation

vfio-ccw: make convert_ccw0_to_ccw1 static

PATCH In review Cornelia Huck 2 participants 2 messages Jun 24, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vfio-ccw: make convert_ccw0_to_ccw1 static

Reported by sparse.

Fixes 7f8e89a8f2fd ("vfio-ccw: Factor out the ccw0-to-ccw1 transition")

---
On top of my vfio-ccw branch.

s390 arch maintainers: let me know if I should queue it and send a pull request, or if you prefer to apply it directly.

---
 drivers/s390/cio/vfio_ccw_cp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/cio/vfio_ccw_cp.c +1 -1
index 9cddc1288059..a7b9dfd5b464 100644
@@ -161,7 +161,7 @@ static inline void pfn_array_idal_create_words(
 	idaws[0] += pa->pa_iova & (PAGE_SIZE - 1);
 }
 
-void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len)
+static void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len)
 {
 	struct ccw0 ccw0;
 	struct ccw1 *pccw1 = source;
Signature · 1 line
2.20.1
#1 lore raw
Quoted 9 lines · Cornelia Huck

Reported by sparse.

Fixes 7f8e89a8f2fd ("vfio-ccw: Factor out the ccw0-to-ccw1 transition")

---
On top of my vfio-ccw branch.

s390 arch maintainers: let me know if I should queue it and send a pull request, or if you prefer to apply it directly.

I still have to sort out some tooling for the s390 tree and I applied it directly. Thanks

Quoted 18 lines
---
 drivers/s390/cio/vfio_ccw_cp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/cio/vfio_ccw_cp.c +1 -1
index 9cddc1288059..a7b9dfd5b464 100644
@@ -161,7 +161,7 @@ static inline void pfn_array_idal_create_words(
 	idaws[0] += pa->pa_iova & (PAGE_SIZE - 1);
 }
 
-void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len)
+static void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len)
 {
 	struct ccw0 ccw0;
 	struct ccw1 *pccw1 = source;