iavf: allow null RX descriptors
Hello Mitch Williams,
This is a semi-automatic email about new static checker warnings.
The patch efa14c398582: "iavf: allow null RX descriptors" from May 14, 2019, leads to the following Smatch complaint:
drivers/net/ethernet/intel/iavf/iavf_txrx.c:1533 iavf_clean_rx_irq()
warn: variable dereferenced before check 'rx_buffer' (see line 1526)
drivers/net/ethernet/intel/iavf/iavf_txrx.c
1515
1516 size = (qword & IAVF_RXD_QW1_LENGTH_PBUF_MASK) >>
1517 IAVF_RXD_QW1_LENGTH_PBUF_SHIFT;
1518
1519 iavf_trace(clean_rx_irq, rx_ring, rx_desc, skb);
1520 rx_buffer = iavf_get_rx_buffer(rx_ring, size);
1521
1522 /* retrieve a buffer from the ring */
1523 if (skb)
skb is non-NULL so ignore this path.
1524 iavf_add_rx_frag(rx_ring, rx_buffer, skb, size);
1525 else if (ring_uses_build_skb(rx_ring))
1526 skb = iavf_build_skb(rx_ring, rx_buffer, size);
^^^^^^^^^
1527 else
1528 skb = iavf_construct_skb(rx_ring, rx_buffer, size);
^^^^^^^^^These functions both dereference "rx_buffer" and might set skb to NULL.
1529
1530 /* exit if we failed to retrieve a buffer */
1531 if (!skb) {
1532 rx_ring->rx_stats.alloc_buff_failed++;
1533 if (rx_buffer)
^^^^^^^^^^^^^
If "rx_buffer" is NULL then we would already have crashed.
1534 rx_buffer->pagecnt_bias++;
1535 break;
regards,
dan carpenter
Quoted 23 lines · Dan Carpenter
Hello Mitch Williams,
This is a semi-automatic email about new static checker warnings.
The patch
efa14c398582: "iavf: allow null RX descriptors" from May 14, 2019, leads to the following Smatch complaint:
drivers/net/ethernet/intel/iavf/iavf_txrx.c:1533iavf_clean_rx_irq()
warn: variable dereferenced before check 'rx_buffer' (see line 1526)
drivers/net/ethernet/intel/iavf/iavf_txrx.c
1515
1516 size = (qword &IAVF_RXD_QW1_LENGTH_PBUF_MASK) >>
1517IAVF_RXD_QW1_LENGTH_PBUF_SHIFT;
1518
1519iavf_trace(clean_rx_irq, rx_ring, rx_desc, skb);
1520rx_buffer=iavf_get_rx_buffer(rx_ring, size);
1521
1522 /* retrieve a buffer from the ring */
1523 if (skb)skb is non-NULL so ignore this path.
Quoted 8 lines
1524
iavf_add_rx_frag(rx_ring, rx_buffer, skb, size);
1525 else if (ring_uses_build_skb(rx_ring))1526 skb = iavf_build_skb(rx_ring, rx_buffer, size); ^^^^^^^^^ 1527 else 1528 skb = iavf_construct_skb(rx_ring, rx_buffer, size); ^^^^^^^^^These functions both dereference "
rx_buffer" and might set skb to NULL.
Oh... Huh. They aren't *supposed* to dereference rx_buffer, but the NULL checks are too late.
regards,
dan carpenter