Skip to contentSkip to conversation

drm: panel-orientation-quirks: Add extra quirk table entry GPD MicroPC

PATCH In review Hans de Goede 2 participants 5 messages Jun 24, 2019 – Jul 1, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover drm: panel-orientation-quirks: Add extra quirk table entry GPD MicroPC

Hi All,

Good news I have a contact inside GPD now and from now on their BIOS-es will have proper sys_vendor and product_name DMI strings. This means that we no longer need to do BIOS date matches and add a new BIOS date to drm_panel_orientation_quirks.c for each BIOS update.

The second batch of GPD MicroPC-s being delivered to users already uses these new strings, this patch adds a quirk for the 90 degree mounted LCD panel using the new DMI strings.

It would be nice to get this into 5.2, but it is not that urgent, so I believe that it is best to push this to drm-misc-next-fixes and then it can get added to 5.2.y once it hits Torvald's tree.

If someone can give this a review (it is a trivial patch really) and give me an Acked-by then I'll push this to drm-misc-next-fixes.

Regards,

Hans

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#1 lore raw

PATCH 1/1 drm: panel-orientation-quirks: Add extra quirk table entry for GPD MicroPC

Newer GPD MicroPC BIOS versions have proper DMI strings, add an extra quirk table entry for these new strings. This is good news, as this means that we no longer have to update the BIOS dates list with every BIOS update.

Fixes 652b8b086538("drm: panel-orientation-quirks: Add quirk for GPD MicroPC")
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +12 -0
index d8a0bcd02f34..ffd95bfeaa94 100644
@@ -90,6 +90,12 @@ static const struct drm_dmi_panel_orientation_data itworks_tw891 = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data lcd720x1280_rightside_up = {
+	.width = 720,
+	.height = 1280,
+	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
 static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = {
 	.width = 800,
 	.height = 1280,
@@ -123,6 +129,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
 		},
 		.driver_data = (void *)&gpd_micropc,
+	}, {	/* GPD MicroPC (later BIOS versions with proper DMI strings) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MicroPC"),
+		},
+		.driver_data = (void *)&lcd720x1280_rightside_up,
 	}, {	/*
 		 * GPD Pocket, note that the the DMI data is less generic then
 		 * it seems, devices with a board-vendor of "AMI Corporation"
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw
In reply to Hans de Goede

Hi all,

Quoted 11 lines · Hans de Goede

Hi All,

Good news I have a contact inside GPD now and from now on their BIOS-es will have proper sys_vendor and product_name DMI strings. This means that we no longer need to do BIOS date matches and add a new BIOS date to drm_panel_orientation_quirks.c for each BIOS update.

The second batch of GPD MicroPC-s being delivered to users already uses these new strings, this patch adds a quirk for the 90 degree mounted LCD panel using the new DMI strings.

Quoted 6 lines

It would be nice to get this into 5.2, but it is not that urgent, so I believe that it is best to push this to drm-misc-next-fixes and then it can get added to 5.2.y once it hits Torvald's tree.

If someone can give this a review (it is a trivial patch really) and give me an Acked-by then I'll push this to drm-misc-next-fixes.

Maarten, Maxime, ping? Can I get an Acked-by (or Reviewed-by) for this please so that I can push it to drm-misc-next-fixes ?

Thanks,

Hans

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Acked-by
#3 lore raw
Quoted 18 lines · Hans de Goede

Hi all,

Quoted 15 lines · Hans de Goede

Hi All,

Good news I have a contact inside GPD now and from now on their BIOS-es will have proper sys_vendor and product_name DMI strings. This means that we no longer need to do BIOS date matches and add a new BIOS date to drm_panel_orientation_quirks.c for each BIOS update.

The second batch of GPD MicroPC-s being delivered to users already uses these new strings, this patch adds a quirk for the 90 degree mounted LCD panel using the new DMI strings.

It would be nice to get this into 5.2, but it is not that urgent, so I believe that it is best to push this to drm-misc-next-fixes and then it can get added to 5.2.y once it hits Torvald's tree.

Quoted 5 lines
Quoted 2 lines

If someone can give this a review (it is a trivial patch really) and give me an Acked-by then I'll push this to drm-misc-next-fixes.

Maarten, Maxime, ping? Can I get an Acked-by (or Reviewed-by) for this please so that I can push it to drm-misc-next-fixes ?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

Hi,

Quoted 19 lines · Maxime Ripard
Quoted 18 lines · Hans de Goede

Hi all,

Quoted 15 lines · Hans de Goede

Hi All,

Good news I have a contact inside GPD now and from now on their BIOS-es will have proper sys_vendor and product_name DMI strings. This means that we no longer need to do BIOS date matches and add a new BIOS date to drm_panel_orientation_quirks.c for each BIOS update.

The second batch of GPD MicroPC-s being delivered to users already uses these new strings, this patch adds a quirk for the 90 degree mounted LCD panel using the new DMI strings.

It would be nice to get this into 5.2, but it is not that urgent, so I believe that it is best to push this to drm-misc-next-fixes and then it can get added to 5.2.y once it hits Torvald's tree.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

If someone can give this a review (it is a trivial patch really) and give me an Acked-by then I'll push this to drm-misc-next-fixes.

Maarten, Maxime, ping? Can I get an Acked-by (or Reviewed-by) for this please so that I can push it to drm-misc-next-fixes ?

Thanks, pushed to drm-misc-next-fixes.

Regards,

Hans
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel