Skip to contentSkip to conversation

Conversion of panel bindings to DT schema

PATCH Applied Rob Herring 4 participants 33 messages Jun 24, 2019 – Jun 27, 2019

Subsystems (8)

v2 of 3 Applied Latest is v3 →

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

v2 cover Conversion of panel bindings to DT schema

This series converts the common panel bindings to DT schema format. Besides the conversion of common panel properties, a few panel bindings are converted here as well. These are all the ones with references to panel-common.txt or panel-lvds.txt.

Rob

Rob Herring (15):
dt-bindings: display: rockchip-lvds: Remove panel references
dt-bindings: display: Convert common panel bindings to DT schema
dt-bindings: display: Convert ampire,am-480272h3tmqw-t01h panel to DT
schema
dt-bindings: display: Convert armadeus,st0700-adapt panel to DT schema
dt-bindings: display: Convert bananapi,s070wv20-ct16 panel to DT
schema
dt-bindings: display: Convert dlc,dlc0700yzg-1 panel to DT schema
dt-bindings: display: Convert pda,91-00156-a0 panel to DT schema
dt-bindings: display: Convert raspberrypi,7inch-touchscreen panel to
DT schema
dt-bindings: display: Convert tfc,s9700rtwv43tr-01b panel to DT schema
dt-bindings: display: Convert tpo,tpg110 panel to DT schema
dt-bindings: display: Convert panel-lvds to DT schema
dt-bindings: display: Convert innolux,ee101ia-01 panel to DT schema
dt-bindings: display: Convert mitsubishi,aa104xd12 panel to DT schema
dt-bindings: display: Convert mitsubishi,aa121td01 panel to DT schema
dt-bindings: display: Convert sgd,gktw70sdae4se panel to DT schema

 .../panel/ampire,am-480272h3tmqw-t01h.txt     |  26 ---
 .../panel/ampire,am-480272h3tmqw-t01h.yaml    |  42 +++++
 .../display/panel/arm,versatile-tft-panel.txt |   2 +-
 .../display/panel/armadeus,st0700-adapt.txt   |   9 --
 .../display/panel/armadeus,st0700-adapt.yaml  |  27 ++++
 .../display/panel/bananapi,s070wv20-ct16.txt  |  12 --
 .../display/panel/bananapi,s070wv20-ct16.yaml |  24 +++
 .../display/panel/dlc,dlc0700yzg-1.txt        |  13 --
 .../display/panel/dlc,dlc0700yzg-1.yaml       |  28 ++++
 .../display/panel/innolux,ee101ia-01d.txt     |   7 -
 .../display/panel/innolux,ee101ia-01d.yaml    |  22 +++
 .../bindings/display/panel/lvds.yaml          | 107 +++++++++++++
 .../display/panel/mitsubishi,aa104xd12.txt    |  47 ------
 .../display/panel/mitsubishi,aa104xd12.yaml   |  71 +++++++++
 .../display/panel/mitsubishi,aa121td01.txt    |  47 ------
 .../display/panel/mitsubishi,aa121td01.yaml   |  69 ++++++++
 .../bindings/display/panel/panel-common.txt   | 101 ------------
 .../bindings/display/panel/panel-common.yaml  | 149 ++++++++++++++++++
 .../bindings/display/panel/panel-lvds.txt     | 121 --------------
 .../bindings/display/panel/panel.txt          |   4 -
 .../display/panel/pda,91-00156-a0.txt         |  14 --
 .../display/panel/pda,91-00156-a0.yaml        |  25 +++
 .../panel/raspberrypi,7inch-touchscreen.txt   |  49 ------
 .../panel/raspberrypi,7inch-touchscreen.yaml  |  71 +++++++++
 .../display/panel/sgd,gktw70sdae4se.txt       |  41 -----
 .../display/panel/sgd,gktw70sdae4se.yaml      |  63 ++++++++
 .../bindings/display/panel/simple-panel.txt   |  29 +---
 .../display/panel/tfc,s9700rtwv43tr-01b.txt   |  15 --
 .../display/panel/tfc,s9700rtwv43tr-01b.yaml  |  30 ++++
 .../bindings/display/panel/tpo,tpg110.txt     |  70 --------
 .../bindings/display/panel/tpo,tpg110.yaml    | 101 ++++++++++++
 .../display/rockchip/rockchip-lvds.txt        |  11 --
 32 files changed, 831 insertions(+), 616 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/armadeus,st0700-adapt.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/armadeus,st0700-adapt.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml
 create mode 100644 Documentation/devicetree/bindings/display/panel/lvds.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/panel-common.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/panel-common.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.txt
 delete mode 100644 Documentation/devicetree/bindings/display/panel/panel.txt
 delete mode 100644 Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/raspberrypi,7inch-touchscreen.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/raspberrypi,7inch-touchscreen.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml
Signature · 1 line
2.20.1
author maintainer
#1 lore raw

PATCH v2 1/15 dt-bindings: display: rockchip-lvds: Remove panel references

The panel bindings are outside the scope of the Rockchip LVDS interface binding. The references are about to change too, so rather than update them just drop the section on the panel bindings.

---
 .../bindings/display/rockchip/rockchip-lvds.txt       | 11 -----------
 1 file changed, 11 deletions(-)
Documentation/devicetree/bindings/display/rockchip/rockchip-lvds.txt +0 -11
index da6939efdb43..7849ff039229 100644
@@ -32,17 +32,6 @@ Their connections are modeled using the OF graph bindings specified in
 - video port 0 for the VOP input, the remote endpoint maybe vopb or vopl
 - video port 1 for either a panel or subsequent encoder
 
-the lvds panel described by
-	Documentation/devicetree/bindings/display/panel/simple-panel.txt
-
-Panel required properties:
-- ports for remote LVDS output
-
-Panel optional properties:
-- data-mapping: should be "vesa-24","jeida-24" or "jeida-18".
-This describes decribed by:
-	Documentation/devicetree/bindings/display/panel/panel-lvds.txt
-
 Example:
 
 lvds_panel: lvds-panel {
Signature · 1 line
2.20.1
maintainer Applied
#2 lore raw

Re: [PATCH v2 01/15] dt-bindings: display: rockchip-lvds: Remove panel references

Am Montag, 24. Juni 2019, 23:56:35 CEST schrieb Rob Herring:

Quoted 10 lines

The panel bindings are outside the scope of the Rockchip LVDS interface binding. The references are about to change too, so rather than update them just drop the section on the panel bindings.

applied to drm-misc-next

Thanks
Heiko

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#3 lore raw

PATCH v2 2/15 dt-bindings: display: Convert common panel bindings to DT schema

In reply to Rob Herring

Convert the common panel bindings to DT schema consolidating scattered definitions to a single schema file.

The 'simple-panel' binding just a collection of properties and not a complete binding itself. All of the 'simple-panel' properties are covered by the panel-common.txt binding with the exception of the 'no-hpd' property, so add that to the schema.

As there are lots of references to simple-panel.txt, just keep the file with a reference to common.yaml for now until all the bindings are converted.

---
 .../display/panel/arm,versatile-tft-panel.txt |   2 +-
 .../bindings/display/panel/panel-common.txt   | 101 ------------
 .../bindings/display/panel/panel-common.yaml  | 149 ++++++++++++++++++
 .../bindings/display/panel/panel.txt          |   4 -
 .../bindings/display/panel/simple-panel.txt   |  29 +---
 5 files changed, 151 insertions(+), 134 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/panel-common.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/panel-common.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/panel.txt
Documentation/devicetree/bindings/display/panel/arm,versatile-tft-panel.txt +1 -1
index 248141c3c7e3..0601a9e34703 100644
@@ -10,7 +10,7 @@ Required properties:
 - compatible: should be "arm,versatile-tft-panel"
 
 Required subnodes:
-- port: see display/panel/panel-common.txt, graph.txt
+- port: see display/panel/panel-common.yaml, graph.txt
 
 
 Example:
Documentation/devicetree/bindings/display/panel/panel-common.txt deleted +0 -101

101 lines not on this page · raw message

Documentation/devicetree/bindings/display/panel/panel-common.yaml new file +149 -0

149 lines not on this page · raw message

Documentation/devicetree/bindings/display/panel/panel.txt deleted +0 -4
deleted file mode 100644
index e2e6867852b8..000000000000
@@ -1,4 +0,0 @@
-Common display properties
--------------------------
-
-- rotation:	Display rotation in degrees counter clockwise (0,90,180,270)
Documentation/devicetree/bindings/display/panel/simple-panel.txt +1 -28
index b2b872c710f2..e11208fb7da8 100644
@@ -1,28 +1 @@
-Simple display panel
-====================
-
-panel node
-----------
-
-Required properties:
-- power-supply: See panel-common.txt
-
-Optional properties:
-- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
-- enable-gpios: GPIO pin to enable or disable the panel
-- backlight: phandle of the backlight device attached to the panel
-- no-hpd: This panel is supposed to communicate that it's ready via HPD
-  (hot plug detect) signal, but the signal isn't hooked up so we should
-  hardcode the max delay from the panel spec when powering up the panel.
-
-Example:
-
-	panel: panel {
-		compatible = "cptt,claa101wb01";
-		ddc-i2c-bus = <&panelddc>;
-
-		power-supply = <&vdd_pnl_reg>;
-		enable-gpios = <&gpio 90 0>;
-
-		backlight = <&backlight>;
-	};
+See panel-common.yaml in this directory.
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#4 lore raw

PATCH v2 3/15 dt-bindings: display: Convert ampire,am-480272h3tmqw-t01h panel to DT schema

In reply to Rob Herring

Convert the ampire,am-480272h3tmqw-t01h panel binding to DT schema.

---
 .../panel/ampire,am-480272h3tmqw-t01h.txt     | 26 ------------
 .../panel/ampire,am-480272h3tmqw-t01h.yaml    | 42 +++++++++++++++++++
 2 files changed, 42 insertions(+), 26 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.txt deleted +0 -26
deleted file mode 100644
index 6812280cb109..000000000000
@@ -1,26 +0,0 @@
-Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
-
-This binding is compatible with the simple-panel binding, which is specified
-in simple-panel.txt in this directory.
-
-Required properties:
-- compatible: should be "ampire,am-480272h3tmqw-t01h"
-
-Optional properties:
-- power-supply: regulator to provide the supply voltage
-- enable-gpios: GPIO pin to enable or disable the panel
-- backlight: phandle of the backlight device attached to the panel
-
-Optional nodes:
-- Video port for RGB input.
-
-Example:
-	panel_rgb: panel-rgb {
-		compatible = "ampire,am-480272h3tmqw-t01h";
-		enable-gpios = <&gpioa 8 1>;
-		port {
-			panel_in_rgb: endpoint {
-				remote-endpoint = <&controller_out_rgb>;
-			};
-		};
-	};
Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml new file +42 -0

42 lines not on this page · raw message

Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#5 lore raw

PATCH v2 4/15 dt-bindings: display: Convert armadeus,st0700-adapt panel to DT schema

In reply to Rob Herring

Convert the armadeus,st0700-adapt panel binding to DT schema.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/armadeus,st0700-adapt.txt   |  9 -------
 .../display/panel/armadeus,st0700-adapt.yaml  | 27 +++++++++++++++++++
 2 files changed, 27 insertions(+), 9 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/armadeus,st0700-adapt.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/armadeus,st0700-adapt.yaml
Documentation/devicetree/bindings/display/panel/armadeus,st0700-adapt.txt deleted +0 -9
deleted file mode 100644
index a30d63db3c8f..000000000000
@@ -1,9 +0,0 @@
-Armadeus ST0700 Adapt. A Santek ST0700I5Y-RBSLW 7.0" WVGA (800x480) TFT with
-an adapter board.
-
-Required properties:
-- compatible: "armadeus,st0700-adapt"
-- power-supply: see panel-common.txt
-
-Optional properties:
-- backlight: see panel-common.txt
Documentation/devicetree/bindings/display/panel/armadeus,st0700-adapt.yaml new file +27 -0
new file mode 100644
index 000000000000..59376669442a
@@ -0,0 +1,27 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/armadeus,st0700-adapt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Armadeus ST0700 Adapter
+
+description:
+  A Santek ST0700I5Y-RBSLW 7.0" WVGA (800x480) TFT with an adapter board.
+
+maintainers:
+  - '"Sébastien Szymanski" <[email protected]>'
+  - Thierry Reding <[email protected]>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: armadeus,st0700-adapt
+
+required:
+  - compatible
+  - power-supply
+
+...
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v2 4/15
#6 lore raw

Re: [PATCH v2 04/15] dt-bindings: display: Convert armadeus,st0700-adapt panel to DT schema

Quoted 8 lines · Rob Herring

Convert the armadeus,st0700-adapt panel binding to DT schema.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#7 lore raw

PATCH v2 5/15 dt-bindings: display: Convert bananapi,s070wv20-ct16 panel to DT schema

In reply to Rob Herring

Convert the bananapi,s070wv20-ct16 panel binding to DT schema.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/bananapi,s070wv20-ct16.txt  | 12 ----------
 .../display/panel/bananapi,s070wv20-ct16.yaml | 24 +++++++++++++++++++
 2 files changed, 24 insertions(+), 12 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.yaml
Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt deleted +0 -12
deleted file mode 100644
index 35bc0c839f49..000000000000
@@ -1,12 +0,0 @@
-Banana Pi 7" (S070WV20-CT16) TFT LCD Panel
-
-Required properties:
-- compatible: should be "bananapi,s070wv20-ct16"
-- power-supply: see ./panel-common.txt
-
-Optional properties:
-- enable-gpios: see ./simple-panel.txt
-- backlight: see ./simple-panel.txt
-
-This binding is compatible with the simple-panel binding, which is specified
-in ./simple-panel.txt.
Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.yaml new file +24 -0
new file mode 100644
index 000000000000..2c1d3bf2baa0
@@ -0,0 +1,24 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/bananapi,s070wv20-ct16.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Banana Pi 7" (S070WV20-CT16) TFT LCD Panel
+
+maintainers:
+  - Chen-Yu Tsai <[email protected]>
+  - Thierry Reding <[email protected]>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: bananapi,s070wv20-ct16
+
+required:
+  - compatible
+  - power-supply
+
+...
Signature · 1 line
2.20.1
Reviewed-by on v2 5/15
#8 lore raw

Re: [PATCH v2 05/15] dt-bindings: display: Convert bananapi,s070wv20-ct16 panel to DT schema

Quoted 8 lines · Rob Herring

Convert the bananapi,s070wv20-ct16 panel binding to DT schema.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#9 lore raw

PATCH v2 6/15 dt-bindings: display: Convert dlc,dlc0700yzg-1 panel to DT schema

In reply to Rob Herring

Convert the dlc,dlc0700yzg-1 panel binding to DT schema.

Cc Philipp Zabel <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/dlc,dlc0700yzg-1.txt        | 13 ---------
 .../display/panel/dlc,dlc0700yzg-1.yaml       | 28 +++++++++++++++++++
 2 files changed, 28 insertions(+), 13 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml
Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt deleted +0 -13
deleted file mode 100644
index bf06bb025b08..000000000000
@@ -1,13 +0,0 @@
-DLC Display Co. DLC0700YZG-1 7.0" WSVGA TFT LCD panel
-
-Required properties:
-- compatible: should be "dlc,dlc0700yzg-1"
-- power-supply: See simple-panel.txt
-
-Optional properties:
-- reset-gpios: See panel-common.txt
-- enable-gpios: See simple-panel.txt
-- backlight: See simple-panel.txt
-
-This binding is compatible with the simple-panel binding, which is specified
-in simple-panel.txt in this directory.
Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml new file +28 -0
new file mode 100644
index 000000000000..1b0b63d46f3e
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/dlc,dlc0700yzg-1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: DLC Display Co. DLC0700YZG-1 7.0" WSVGA TFT LCD panel
+
+maintainers:
+  - Philipp Zabel <[email protected]>
+  - Thierry Reding <[email protected]>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: dlc,dlc0700yzg-1
+
+  reset-gpios: true
+  enable-gpios: true
+  backlight: true
+
+required:
+  - compatible
+  - power-supply
+
+...
Signature · 1 line
2.20.1
#10 lore raw

Re: [PATCH v2 06/15] dt-bindings: display: Convert dlc,dlc0700yzg-1 panel to DT schema

Hi,

Quoted 53 lines · Rob Herring

Convert the dlc,dlc0700yzg-1 panel binding to DT schema.

Cc Philipp Zabel <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/dlc,dlc0700yzg-1.txt        | 13 ---------
 .../display/panel/dlc,dlc0700yzg-1.yaml       | 28 +++++++++++++++++++
 2 files changed, 28 insertions(+), 13 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml
Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt deleted +0 -13
deleted file mode 100644
index bf06bb025b08..000000000000
@@ -1,13 +0,0 @@
-DLC Display Co. DLC0700YZG-1 7.0" WSVGA TFT LCD panel
-
-Required properties:
-- compatible: should be "dlc,dlc0700yzg-1"
-- power-supply: See simple-panel.txt
-
-Optional properties:
-- reset-gpios: See panel-common.txt
-- enable-gpios: See simple-panel.txt
-- backlight: See simple-panel.txt
-
-This binding is compatible with the simple-panel binding, which is specified
-in simple-panel.txt in this directory.
Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml new file +12 -0
new file mode 100644
index 000000000000..1b0b63d46f3e
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/dlc,dlc0700yzg-1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: DLC Display Co. DLC0700YZG-1 7.0" WSVGA TFT LCD panel
+
+maintainers:
+  - Philipp Zabel <[email protected]>
+  - Thierry Reding <[email protected]>
+

Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml line 22

Quoted 10 lines
Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml new file +10 -0
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: dlc,dlc0700yzg-1
+
+  reset-gpios: true
+  enable-gpios: true
+  backlight: true

Do we need to list them?

Since we don't have additionalItems, it doesn't really change anything since it will be validated by panel-common.

Either way, it should be consistent between your patches, and the previous patches in this series didn't list all the properties in the binding.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#11 lore raw

Re: [PATCH v2 06/15] dt-bindings: display: Convert dlc,dlc0700yzg-1 panel to DT schema

Quoted 70 lines · Maxime Ripard

Hi,

Quoted 53 lines · Rob Herring

Convert the dlc,dlc0700yzg-1 panel binding to DT schema.

Cc Philipp Zabel <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/dlc,dlc0700yzg-1.txt        | 13 ---------
 .../display/panel/dlc,dlc0700yzg-1.yaml       | 28 +++++++++++++++++++
 2 files changed, 28 insertions(+), 13 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml
Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt deleted +0 -13
deleted file mode 100644
index bf06bb025b08..000000000000
@@ -1,13 +0,0 @@
-DLC Display Co. DLC0700YZG-1 7.0" WSVGA TFT LCD panel
-
-Required properties:
-- compatible: should be "dlc,dlc0700yzg-1"
-- power-supply: See simple-panel.txt
-
-Optional properties:
-- reset-gpios: See panel-common.txt
-- enable-gpios: See simple-panel.txt
-- backlight: See simple-panel.txt
-
-This binding is compatible with the simple-panel binding, which is specified
-in simple-panel.txt in this directory.
Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml new file +12 -0
new file mode 100644
index 000000000000..1b0b63d46f3e
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/dlc,dlc0700yzg-1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: DLC Display Co. DLC0700YZG-1 7.0" WSVGA TFT LCD panel
+
+maintainers:
+  - Philipp Zabel <[email protected]>
+  - Thierry Reding <[email protected]>
+

Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml line 22

Quoted 10 lines
Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml new file +10 -0
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: dlc,dlc0700yzg-1
+
+  reset-gpios: true
+  enable-gpios: true
+  backlight: true

Do we need to list them?

Quoted 2 lines

Since we don't have additionalItems, it doesn't really change anything since it will be validated by panel-common.

I've gone back and forth on it. I think we need to express what properties from the common properties apply for a particular panel. I've been requiring panel bindings to be explicit here rather than just say "uses the simple-panel binding." For example, if 'power-supply' is not listed, does the panel have a single supply or multiple supplies that haven't haven't been considered?

Quoted 3 lines

Either way, it should be consistent between your patches, and the previous patches in this series didn't list all the properties in the binding.

Indeed.

Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#12 lore raw

PATCH v2 7/15 dt-bindings: display: Convert pda,91-00156-a0 panel to DT schema

In reply to Rob Herring

Convert the pda,91-00156-a0 panel binding to DT schema.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/pda,91-00156-a0.txt         | 14 -----------
 .../display/panel/pda,91-00156-a0.yaml        | 25 +++++++++++++++++++
 2 files changed, 25 insertions(+), 14 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.yaml
Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt deleted +0 -14
deleted file mode 100644
index 1639fb17a9f0..000000000000
@@ -1,14 +0,0 @@
-PDA 91-00156-A0 5.0" WVGA TFT LCD panel
-
-Required properties:
-- compatible: should be "pda,91-00156-a0"
-- power-supply: this panel requires a single power supply. A phandle to a
-regulator needs to be specified here. Compatible with panel-common binding which
-is specified in the panel-common.txt in this directory.
-- backlight: this panel's backlight is controlled by an external backlight
-controller. A phandle to this controller needs to be specified here.
-Compatible with panel-common binding which is specified in the panel-common.txt
-in this directory.
-
-This binding is compatible with the simple-panel binding, which is specified
-in simple-panel.txt in this directory.
Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.yaml new file +25 -0
new file mode 100644
index 000000000000..cea5bcb3c455
@@ -0,0 +1,25 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/pda,91-00156-a0.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: PDA 91-00156-A0 5.0" WVGA TFT LCD panel
+
+maintainers:
+  - Cristian Birsan <[email protected]>
+  - Thierry Reding <[email protected]>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: pda,91-00156-a0
+
+required:
+  - compatible
+  - power-supply
+  - backlight
+
+...
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v2 7/15
#13 lore raw

Re: [PATCH v2 07/15] dt-bindings: display: Convert pda,91-00156-a0 panel to DT schema

Quoted 8 lines · Rob Herring

Convert the pda,91-00156-a0 panel binding to DT schema.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#14 lore raw

PATCH v2 8/15 dt-bindings: display: Convert raspberrypi,7inch-touchscreen panel to DT schema

In reply to Rob Herring

Convert the raspberrypi,7inch-touchscreen panel binding to DT schema.

Cc Eric Anholt <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../panel/raspberrypi,7inch-touchscreen.txt   | 49 -------------
 .../panel/raspberrypi,7inch-touchscreen.yaml  | 71 +++++++++++++++++++
 2 files changed, 71 insertions(+), 49 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/raspberrypi,7inch-touchscreen.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/raspberrypi,7inch-touchscreen.yaml
Documentation/devicetree/bindings/display/panel/raspberrypi,7inch-touchscreen.txt deleted +0 -49
deleted file mode 100644
index e9e19c059260..000000000000
@@ -1,49 +0,0 @@
-This binding covers the official 7" (800x480) Raspberry Pi touchscreen
-panel.
-
-This DSI panel contains:
-
-- TC358762 DSI->DPI bridge
-- Atmel microcontroller on I2C for power sequencing the DSI bridge and
-  controlling backlight
-- Touchscreen controller on I2C for touch input
-
-and this binding covers the DSI display parts but not its touch input.
-
-Required properties:
-- compatible:	Must be "raspberrypi,7inch-touchscreen-panel"
-- reg:		Must be "45"
-- port:		See panel-common.txt
-
-Example:
-
-dsi1: dsi@7e700000 {
-	#address-cells = <1>;
-	#size-cells = <0>;
-	<...>
-
-	port {
-		dsi_out_port: endpoint {
-			remote-endpoint = <&panel_dsi_port>;
-		};
-	};
-};
-
-i2c_dsi: i2c {
-	compatible = "i2c-gpio";
-	#address-cells = <1>;
-	#size-cells = <0>;
-	gpios = <&gpio 28 0
-		 &gpio 29 0>;
-
-	lcd@45 {
-		compatible = "raspberrypi,7inch-touchscreen-panel";
-		reg = <0x45>;
-
-		port {
-			panel_dsi_port: endpoint {
-				remote-endpoint = <&dsi_out_port>;
-			};
-		};
-	};
-};
Documentation/devicetree/bindings/display/panel/raspberrypi,7inch-touchscreen.yaml new file +71 -0

71 lines not on this page · raw message

Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v2 8/15
#15 lore raw

Re: [PATCH v2 08/15] dt-bindings: display: Convert raspberrypi,7inch-touchscreen panel to DT schema

Quoted 9 lines · Rob Herring

Convert the raspberrypi,7inch-touchscreen panel binding to DT schema.

Cc Eric Anholt <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

author maintainer
#16 lore raw

PATCH v2 9/15 dt-bindings: display: Convert tfc,s9700rtwv43tr-01b panel to DT schema

In reply to Rob Herring

Convert the tfc,s9700rtwv43tr-01b panel binding to DT schema.

Cc Heiko Stuebner <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/tfc,s9700rtwv43tr-01b.txt   | 15 ----------
 .../display/panel/tfc,s9700rtwv43tr-01b.yaml  | 30 +++++++++++++++++++
 2 files changed, 30 insertions(+), 15 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.yaml
Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt deleted +0 -15
deleted file mode 100644
index dfb572f085eb..000000000000
@@ -1,15 +0,0 @@
-TFC S9700RTWV43TR-01B 7" Three Five Corp 800x480 LCD panel with
-resistive touch
-
-The panel is found on TI AM335x-evm.
-
-Required properties:
-- compatible: should be "tfc,s9700rtwv43tr-01b"
-- power-supply: See panel-common.txt
-
-Optional properties:
-- enable-gpios: GPIO pin to enable or disable the panel, if there is one
-- backlight: phandle of the backlight device attached to the panel
-
-This binding is compatible with the simple-panel binding, which is specified
-in simple-panel.txt in this directory.
Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.yaml new file +30 -0
new file mode 100644
index 000000000000..614f4a8d8403
@@ -0,0 +1,30 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/tfc,s9700rtwv43tr-01b.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TFC S9700RTWV43TR-01B 7" Three Five Corp 800x480 LCD panel with resistive touch
+
+maintainers:
+  - Jyri Sarha <[email protected]>
+  - Thierry Reding <[email protected]>
+
+description: |+
+  The panel is found on TI AM335x-evm.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: tfc,s9700rtwv43tr-01b
+
+  enable-gpios: true
+  backlight: true
+
+required:
+  - compatible
+  - power-supply
+
+...
Signature · 1 line
2.20.1
Reviewed-by on v2 9/15
#17 lore raw

Re: [PATCH v2 09/15] dt-bindings: display: Convert tfc,s9700rtwv43tr-01b panel to DT schema

Quoted 57 lines · Rob Herring

Convert the tfc,s9700rtwv43tr-01b panel binding to DT schema.

Cc Heiko Stuebner <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/tfc,s9700rtwv43tr-01b.txt   | 15 ----------
 .../display/panel/tfc,s9700rtwv43tr-01b.yaml  | 30 +++++++++++++++++++
 2 files changed, 30 insertions(+), 15 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.yaml
Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt deleted +0 -15
deleted file mode 100644
index dfb572f085eb..000000000000
@@ -1,15 +0,0 @@
-TFC S9700RTWV43TR-01B 7" Three Five Corp 800x480 LCD panel with
-resistive touch
-
-The panel is found on TI AM335x-evm.
-
-Required properties:
-- compatible: should be "tfc,s9700rtwv43tr-01b"
-- power-supply: See panel-common.txt
-
-Optional properties:
-- enable-gpios: GPIO pin to enable or disable the panel, if there is one
-- backlight: phandle of the backlight device attached to the panel
-
-This binding is compatible with the simple-panel binding, which is specified
-in simple-panel.txt in this directory.
Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.yaml new file +14 -0
new file mode 100644
index 000000000000..614f4a8d8403
@@ -0,0 +1,30 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/tfc,s9700rtwv43tr-01b.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TFC S9700RTWV43TR-01B 7" Three Five Corp 800x480 LCD panel with resistive touch
+
+maintainers:
+  - Jyri Sarha <[email protected]>
+  - Thierry Reding <[email protected]>
+
+description: |+
+  The panel is found on TI AM335x-evm.

Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.yaml line 24

Quoted 10 lines
Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.yaml new file +10 -0
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: tfc,s9700rtwv43tr-01b
+
+  enable-gpios: true
+  backlight: true

There's the same remark than on patch 6. Once figured out,

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#18 lore raw

PATCH v2 10/15 dt-bindings: display: Convert tpo,tpg110 panel to DT schema

In reply to Rob Herring

Convert the tpo,tpg110 panel binding to DT schema.

Cc Linus Walleij <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../bindings/display/panel/tpo,tpg110.txt     |  70 ------------
 .../bindings/display/panel/tpo,tpg110.yaml    | 101 ++++++++++++++++++
 2 files changed, 101 insertions(+), 70 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml
Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt deleted +0 -70
deleted file mode 100644
index 40f3d7c713bb..000000000000
@@ -1,70 +0,0 @@
-TPO TPG110 Panel
-================
-
-This panel driver is a component that acts as an intermediary
-between an RGB output and a variety of panels. The panel
-driver is strapped up in electronics to the desired resolution
-and other properties, and has a control interface over 3WIRE
-SPI. By talking to the TPG110 over SPI, the strapped properties
-can be discovered and the hardware is therefore mostly
-self-describing.
-
-       +--------+
-SPI -> |  TPO   | -> physical display
-RGB -> | TPG110 |
-       +--------+
-
-If some electrical strap or alternate resolution is desired,
-this can be set up by taking software control of the display
-over the SPI interface. The interface can also adjust
-for properties of the display such as gamma correction and
-certain electrical driving levels.
-
-The TPG110 does not know the physical dimensions of the panel
-connected, so this needs to be specified in the device tree.
-
-It requires a GPIO line for control of its reset line.
-
-The serial protocol has line names that resemble I2C but the
-protocol is not I2C but 3WIRE SPI.
-
-Required properties:
-- compatible : one of:
-  "ste,nomadik-nhk15-display", "tpo,tpg110"
-  "tpo,tpg110"
-- grestb-gpios : panel reset GPIO
-- width-mm : see display/panel/panel-common.txt
-- height-mm : see display/panel/panel-common.txt
-
-The device needs to be a child of an SPI bus, see
-spi/spi-bus.txt. The SPI child must set the following
-properties:
-- spi-3wire
-- spi-max-frequency = <3000000>;
-as these are characteristics of this device.
-
-The device node can contain one 'port' child node with one child
-'endpoint' node, according to the bindings defined in
-media/video-interfaces.txt. This node should describe panel's video bus.
-
-Example
--------
-
-panel: display@0 {
-	compatible = "tpo,tpg110";
-	reg = <0>;
-	spi-3wire;
-	/* 320 ns min period ~= 3 MHz */
-	spi-max-frequency = <3000000>;
-	/* Width and height from data sheet */
-	width-mm = <116>;
-	height-mm = <87>;
-	grestb-gpios = <&foo_gpio 5 GPIO_ACTIVE_LOW>;
-	backlight = <&bl>;
-
-	port {
-		nomadik_clcd_panel: endpoint {
-			remote-endpoint = <&foo>;
-		};
-	};
-};
Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml new file +101 -0

101 lines not on this page · raw message

Signature · 1 line
2.20.1
#19 lore raw

Re: [PATCH v2 10/15] dt-bindings: display: Convert tpo,tpg110 panel to DT schema

Quoted 9 lines · Rob Herring

Convert the tpo,tpg110 panel binding to DT schema.

Cc Linus Walleij <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Awesome, fixed up the MAINATINERS entry and applied and pushed for DRM next with my Reviewed-by.

Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#20 lore raw

Re: [PATCH v2 10/15] dt-bindings: display: Convert tpo,tpg110 panel to DT schema

Quoted 13 lines · Linus Walleij
Quoted 9 lines · Rob Herring

Convert the tpo,tpg110 panel binding to DT schema.

Cc Linus Walleij <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
Quoted 2 lines

Awesome, fixed up the MAINATINERS entry and applied and pushed for DRM next with my Reviewed-by.

You shouldn't have because this is dependent on patch 2 and panel-common.yaml. So now 'make dt_binding_check' is broken.

Rob

#21 lore raw

Re: [PATCH v2 10/15] dt-bindings: display: Convert tpo,tpg110 panel to DT schema

Quoted 13 lines · Rob Herring
Quoted 12 lines · Linus Walleij
Quoted 9 lines · Rob Herring

Convert the tpo,tpg110 panel binding to DT schema.

Cc Linus Walleij <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
Quoted 5 lines
Quoted 2 lines

Awesome, fixed up the MAINATINERS entry and applied and pushed for DRM next with my Reviewed-by.

You shouldn't have because this is dependent on patch 2 and panel-common.yaml. So now 'make dt_binding_check' is broken.

Ooops easily happens when I am only adressee on this patch and there is no mention of any dependencies.

Can I simply just merge the panel-common patch as well and we are all happy?

I can also pick up more panel binding patches, IMO the yaml conversions are especially uncontroversial and should have low threshold for merging.

Yours,
Linus Walleij

author maintainer
#22 lore raw

Re: [PATCH v2 10/15] dt-bindings: display: Convert tpo,tpg110 panel to DT schema

Quoted 15 lines · Linus Walleij
Quoted 13 lines · Rob Herring
Quoted 12 lines · Linus Walleij
Quoted 9 lines · Rob Herring

Convert the tpo,tpg110 panel binding to DT schema.

Cc Linus Walleij <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Awesome, fixed up the MAINATINERS entry and applied and pushed for DRM next with my Reviewed-by.

You shouldn't have because this is dependent on patch 2 and panel-common.yaml. So now 'make dt_binding_check' is broken.

Ooops easily happens when I am only adressee on this patch and there is no mention of any dependencies.

It's a series. I would assume the default is 1 person applies a series unless explicitly stated otherwise.

Quoted 2 lines

Can I simply just merge the panel-common patch as well and we are all happy?

I have drm-misc commit rights too, so I'll apply the whole lot when it's ready.

Quoted 3 lines

I can also pick up more panel binding patches, IMO the yaml conversions are especially uncontroversial and should have low threshold for merging.

Yes, but the threshold is at least 'make dt_binding_check' should not break. But don't worry, there are 2 other breakages in linux-next currently.

Rob

#23 lore raw

Re: [PATCH v2 10/15] dt-bindings: display: Convert tpo,tpg110 panel to DT schema

Quoted 7 lines · Rob Herring
Quoted 2 lines · Linus Walleij

Can I simply just merge the panel-common patch as well and we are all happy?

I have drm-misc commit rights too, so I'll apply the whole lot when it's ready.

Quoted 7 lines
Quoted 3 lines

I can also pick up more panel binding patches, IMO the yaml conversions are especially uncontroversial and should have low threshold for merging.

Yes, but the threshold is at least 'make dt_binding_check' should not break. But don't worry, there are 2 other breakages in linux-next currently.

OK let's try to live with it for now, if it makes you too much trouble we can just revert it, accidents happen.

Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by on v2 10/15
#24 lore raw

Re: [PATCH v2 10/15] dt-bindings: display: Convert tpo,tpg110 panel to DT schema

In reply to Rob Herring
Quoted 9 lines · Rob Herring

Convert the tpo,tpg110 panel binding to DT schema.

Cc Linus Walleij <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

author maintainer
#25 lore raw

PATCH v2 11/15 dt-bindings: display: Convert panel-lvds to DT schema

In reply to Rob Herring

Convert the panel-lvds binding to use DT schema. The panel-lvds schema inherits from the panel-common.yaml schema and specific LVDS panel bindings should inherit from this schema.

---
 .../bindings/display/panel/lvds.yaml          | 107 ++++++++++++++++
 .../bindings/display/panel/panel-lvds.txt     | 121 ------------------
 2 files changed, 107 insertions(+), 121 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/panel/lvds.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.txt
Documentation/devicetree/bindings/display/panel/lvds.yaml new file +107 -0
new file mode 100644
index 000000000000..d0083301acbe
@@ -0,0 +1,107 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/lvds.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LVDS Display Panel
+
+maintainers:
+  - Laurent Pinchart <[email protected]>
+  - Thierry Reding <[email protected]>
+
+description: |+
+  LVDS is a physical layer specification defined in ANSI/TIA/EIA-644-A. Multiple
+  incompatible data link layers have been used over time to transmit image data
+  to LVDS panels. This bindings supports display panels compatible with the
+  following specifications.
+
+  [JEIDA] "Digital Interface Standards for Monitor", JEIDA-59-1999, February
+  1999 (Version 1.0), Japan Electronic Industry Development Association (JEIDA)
+  [LDI] "Open LVDS Display Interface", May 1999 (Version 0.95), National
+  Semiconductor
+  [VESA] "VESA Notebook Panel Standard", October 2007 (Version 1.0), Video
+  Electronics Standards Association (VESA)
+
+  Device compatible with those specifications have been marketed under the
+  FPD-Link and FlatLink brands.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    contains:
+      const: panel-lvds
+    description:
+      Shall contain "panel-lvds" in addition to a mandatory panel-specific
+      compatible string defined in individual panel bindings. The "panel-lvds"
+      value shall never be used on its own.
+
+  data-mapping:
+    enum:
+      - jeida-18
+      - jeida-24
+      - vesa-24
+    description: |
+      The color signals mapping order.
+
+      LVDS data mappings are defined as follows.
+
+      - "jeida-18" - 18-bit data mapping compatible with the [JEIDA], [LDI] and
+        [VESA] specifications. Data are transferred as follows on 3 LVDS lanes.
+
+      Slot	    0       1       2       3       4       5       6
+            ________________                         _________________
+      Clock	                \_______________________/
+              ______  ______  ______  ______  ______  ______  ______
+      DATA0	><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
+      DATA1	><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
+      DATA2	><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
+
+      - "jeida-24" - 24-bit data mapping compatible with the [DSIM] and [LDI]
+        specifications. Data are transferred as follows on 4 LVDS lanes.
+
+      Slot	    0       1       2       3       4       5       6
+            ________________                         _________________
+      Clock	                \_______________________/
+              ______  ______  ______  ______  ______  ______  ______
+      DATA0	><__G2__><__R7__><__R6__><__R5__><__R4__><__R3__><__R2__><
+      DATA1	><__B3__><__B2__><__G7__><__G6__><__G5__><__G4__><__G3__><
+      DATA2	><_CTL2_><_CTL1_><_CTL0_><__B7__><__B6__><__B5__><__B4__><
+      DATA3	><_CTL3_><__B1__><__B0__><__G1__><__G0__><__R1__><__R0__><
+
+      - "vesa-24" - 24-bit data mapping compatible with the [VESA] specification.
+        Data are transferred as follows on 4 LVDS lanes.
+
+      Slot	    0       1       2       3       4       5       6
+            ________________                         _________________
+      Clock	                \_______________________/
+              ______  ______  ______  ______  ______  ______  ______
+      DATA0	><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
+      DATA1	><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
+      DATA2	><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
+      DATA3	><_CTL3_><__B7__><__B6__><__G7__><__G6__><__R7__><__R6__><
+
+      Control signals are mapped as follows.
+
+      CTL0: HSync
+      CTL1: VSync
+      CTL2: Data Enable
+      CTL3: 0
+
+  data-mirror:
+    type: boolean
+    description:
+      If set, reverse the bit order described in the data mappings below on all
+      data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
+
+required:
+  - compatible
+  - data-mapping
+  - width-mm
+  - height-mm
+  - panel-timing
+  - port
+
+...
Documentation/devicetree/bindings/display/panel/panel-lvds.txt deleted +0 -121

121 lines not on this page · raw message

Signature · 1 line
2.20.1
author maintainer
#26 lore raw

PATCH v2 12/15 dt-bindings: display: Convert innolux,ee101ia-01 panel to DT schema

In reply to Rob Herring

Convert the innolux,ee101ia-01 LVDS panel binding to DT schema.

---
 .../display/panel/innolux,ee101ia-01d.txt     |  7 ------
 .../display/panel/innolux,ee101ia-01d.yaml    | 22 +++++++++++++++++++
 2 files changed, 22 insertions(+), 7 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml
Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.txt deleted +0 -7
deleted file mode 100644
index e5ca4ccd55ed..000000000000
@@ -1,7 +0,0 @@
-Innolux Corporation 10.1" EE101IA-01D WXGA (1280x800) LVDS panel
-
-Required properties:
-- compatible: should be "innolux,ee101ia-01d"
-
-This binding is compatible with the lvds-panel binding, which is specified
-in panel-lvds.txt in this directory.
Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml new file +22 -0
new file mode 100644
index 000000000000..5cc97cbe17fa
@@ -0,0 +1,22 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/innolux,ee101ia-01d.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Innolux Corporation 10.1" EE101IA-01D WXGA (1280x800) LVDS panel
+
+maintainers:
+  - Heiko Stuebner <[email protected]>
+  - Thierry Reding <[email protected]>
+
+allOf:
+  - $ref: lvds.yaml#
+
+properties:
+  compatible:
+    items:
+      - const: innolux,ee101ia-01d
+      - {} # panel-lvds, but not listed here to avoid false select
+
+...
Signature · 1 line
2.20.1
author maintainer
#27 lore raw

PATCH v2 13/15 dt-bindings: display: Convert mitsubishi,aa104xd12 panel to DT schema

In reply to Rob Herring

Convert the mitsubishi,aa104xd12 LVDS panel binding to DT schema.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/mitsubishi,aa104xd12.txt    | 47 ------------
 .../display/panel/mitsubishi,aa104xd12.yaml   | 71 +++++++++++++++++++
 2 files changed, 71 insertions(+), 47 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.txt deleted +0 -47
deleted file mode 100644
index ced0121aed7d..000000000000
@@ -1,47 +0,0 @@
-Mitsubishi AA204XD12 LVDS Display Panel
-=======================================
-
-The AA104XD12 is a 10.4" XGA TFT-LCD display panel.
-
-These DT bindings follow the LVDS panel bindings defined in panel-lvds.txt
-with the following device-specific properties.
-
-
-Required properties:
-
-- compatible: Shall contain "mitsubishi,aa121td01" and "panel-lvds", in that
-  order.
-- vcc-supply: Reference to the regulator powering the panel VCC pins.
-
-
-Example
--------
-
-panel {
-	compatible = "mitsubishi,aa104xd12", "panel-lvds";
-	vcc-supply = <&vcc_3v3>;
-
-	width-mm = <210>;
-	height-mm = <158>;
-
-	data-mapping = "jeida-24";
-
-	panel-timing {
-		/* 1024x768 @65Hz */
-		clock-frequency = <65000000>;
-		hactive = <1024>;
-		vactive = <768>;
-		hsync-len = <136>;
-		hfront-porch = <20>;
-		hback-porch = <160>;
-		vfront-porch = <3>;
-		vback-porch = <29>;
-		vsync-len = <6>;
-	};
-
-	port {
-		panel_in: endpoint {
-			remote-endpoint = <&lvds_encoder>;
-		};
-	};
-};
Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml new file +71 -0

71 lines not on this page · raw message

Signature · 1 line
2.20.1
Reviewed-by on v2 13/15
#28 lore raw

Re: [PATCH v2 13/15] dt-bindings: display: Convert mitsubishi,aa104xd12 panel to DT schema

Quoted 7 lines · Rob Herring

Convert the mitsubishi,aa104xd12 LVDS panel binding to DT schema.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#29 lore raw

PATCH v2 14/15 dt-bindings: display: Convert mitsubishi,aa121td01 panel to DT schema

In reply to Rob Herring

Convert the mitsubishi,aa121td01 LVDS panel binding to DT schema.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/mitsubishi,aa121td01.txt    | 47 -------------
 .../display/panel/mitsubishi,aa121td01.yaml   | 69 +++++++++++++++++++
 2 files changed, 69 insertions(+), 47 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.txt deleted +0 -47
deleted file mode 100644
index d6e1097504fe..000000000000
@@ -1,47 +0,0 @@
-Mitsubishi AA121TD01 LVDS Display Panel
-=======================================
-
-The AA121TD01 is a 12.1" WXGA TFT-LCD display panel.
-
-These DT bindings follow the LVDS panel bindings defined in panel-lvds.txt
-with the following device-specific properties.
-
-
-Required properties:
-
-- compatible: Shall contain "mitsubishi,aa121td01" and "panel-lvds", in that
-  order.
-- vcc-supply: Reference to the regulator powering the panel VCC pins.
-
-
-Example
--------
-
-panel {
-	compatible = "mitsubishi,aa121td01", "panel-lvds";
-	vcc-supply = <&vcc_3v3>;
-
-	width-mm = <261>;
-	height-mm = <163>;
-
-	data-mapping = "jeida-24";
-
-	panel-timing {
-		/* 1280x800 @60Hz */
-		clock-frequency = <71000000>;
-		hactive = <1280>;
-		vactive = <800>;
-		hsync-len = <70>;
-		hfront-porch = <20>;
-		hback-porch = <70>;
-		vsync-len = <5>;
-		vfront-porch = <3>;
-		vback-porch = <15>;
-	};
-
-	port {
-		panel_in: endpoint {
-			remote-endpoint = <&lvds_encoder>;
-		};
-	};
-};
Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml new file +69 -0

69 lines not on this page · raw message

Signature · 1 line
2.20.1
Reviewed-by on v2 14/15
#30 lore raw

Re: [PATCH v2 14/15] dt-bindings: display: Convert mitsubishi,aa121td01 panel to DT schema

Quoted 7 lines · Rob Herring

Convert the mitsubishi,aa121td01 LVDS panel binding to DT schema.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#31 lore raw

PATCH v2 15/15 dt-bindings: display: Convert sgd,gktw70sdae4se panel to DT schema

In reply to Rob Herring

Convert the sgd,gktw70sdae4se LVDS panel binding to DT schema.

Cc Neil Armstrong <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../display/panel/sgd,gktw70sdae4se.txt       | 41 ------------
 .../display/panel/sgd,gktw70sdae4se.yaml      | 63 +++++++++++++++++++
 2 files changed, 63 insertions(+), 41 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.txt deleted +0 -41
deleted file mode 100644
index d06644b555bd..000000000000
@@ -1,41 +0,0 @@
-Solomon Goldentek Display GKTW70SDAE4SE LVDS Display Panel
-==========================================================
-
-The GKTW70SDAE4SE is a 7" WVGA TFT-LCD display panel.
-
-These DT bindings follow the LVDS panel bindings defined in panel-lvds.txt
-with the following device-specific properties.
-
-Required properties:
-
-- compatible: Shall contain "sgd,gktw70sdae4se" and "panel-lvds", in that order.
-
-Example
--------
-
-panel {
-	compatible = "sgd,gktw70sdae4se", "panel-lvds";
-
-	width-mm = <153>;
-	height-mm = <86>;
-
-	data-mapping = "jeida-18";
-
-	panel-timing {
-		clock-frequency = <32000000>;
-		hactive = <800>;
-		vactive = <480>;
-		hback-porch = <39>;
-		hfront-porch = <39>;
-		vback-porch = <29>;
-		vfront-porch = <13>;
-		hsync-len = <47>;
-		vsync-len = <2>;
-	};
-
-	port {
-		panel_in: endpoint {
-			remote-endpoint = <&lvds_encoder>;
-		};
-	};
-};
Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml new file +63 -0

63 lines not on this page · raw message

Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v2 15/15
#32 lore raw

Re: [PATCH v2 15/15] dt-bindings: display: Convert sgd,gktw70sdae4se panel to DT schema

Quoted 8 lines · Rob Herring

Convert the sgd,gktw70sdae4se LVDS panel binding to DT schema.

Cc Neil Armstrong <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com