ath10k: fix PCIE device wake up failed
PATCH 1/1 ath10k: fix PCIE device wake up failed
Observed PCIE device wake up failed after ~120 iterations of soft-reboot test. The error message is
"ath10k_pci 0000:01:00.0: failed to wake up device : -110"
The call trace as below:ath10k_pci_probe -> ath10k_pci_force_wake -> ath10k_pci_wake_wait -> ath10k_pci_is_awake
Once trigger the device to wake up, we will continuously check the RTC state until it returns RTC_STATE_V_ON or timeout.
But for QCA99x0 chips, we use wrong value for RTC_STATE_V_ON. Occasionally, we get 0x7 on the fist read, we thought as a failure case, but actually is the right value, also verified with the spec. So fix the issue by changing RTC_STATE_V_ON from 0x5 to 0x7, passed ~2000 iterations.
Tested HW: QCA9984
--- drivers/net/wireless/ath/ath10k/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/hw.c +1 -1
@@ -158,7 +158,7 @@ };const struct ath10k_hw_values qca99x0_values = { - .rtc_state_val_on =5 , + .rtc_state_val_on =7 , .ce_count =12 , .msi_assign_ce_max =12 , .num_target_ce_config_wlan =10 ,
Signature · 7 lines
1.9.1 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 17 lines · Miaoqing Pan
Observed PCIE device wake up failed after ~120 iterations of soft-reboot test. The error message is
"ath10k_pci0000:01:00.0: failed to wake up device : -110"The call trace as below:
ath10k_pci_probe->ath10k_pci_force_wake->ath10k_pci_wake_wait->ath10k_pci_is_awakeOnce trigger the device to wake up, we will continuously check the RTC state until it returns
RTC_STATE_V_ONor timeout.But for QCA99x0 chips, we use wrong value for
RTC_STATE_V_ON. Occasionally, we get0x7on the fist read, we thought as a failure case, but actually is the right value, also verified with the spec. So fix the issue by changingRTC_STATE_V_ONfrom0x5to0x7, passed ~2000 iterations.
Quoted 4 lines
Tested HW: QCA9984
Signed-off-by Miaoqing Pan <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
011d4111c8c6 ath10k: fix PCIE device wake up failed
Signature · 3 lines
https://patchwork.kernel.org/patch/10968039/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 17 lines · Miaoqing Pan
Observed PCIE device wake up failed after ~120 iterations of soft-reboot test. The error message is
"ath10k_pci0000:01:00.0: failed to wake up device : -110"The call trace as below:
ath10k_pci_probe->ath10k_pci_force_wake->ath10k_pci_wake_wait->ath10k_pci_is_awakeOnce trigger the device to wake up, we will continuously check the RTC state until it returns
RTC_STATE_V_ONor timeout.But for QCA99x0 chips, we use wrong value for
RTC_STATE_V_ON. Occasionally, we get0x7on the fist read, we thought as a failure case, but actually is the right value, also verified with the spec. So fix the issue by changingRTC_STATE_V_ONfrom0x5to0x7, passed ~2000 iterations.
Quoted 4 lines
Tested HW: QCA9984
Signed-off-by Miaoqing Pan <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
011d4111c8c6 ath10k: fix PCIE device wake up failed
Signature · 9 lines
https://patchwork.kernel.org/patch/10968039/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k