ath11k: fix variable name warnings
PATCH 1/5 ath11k: fix variable name warnings
drivers/net/wireless/ath/ath11k/wmi.h:2728: <BK_Minfree> drivers/net/wireless/ath/ath11k/wmi.h:2729: <BE_Minfree> drivers/net/wireless/ath/ath11k/wmi.h:2730: <VI_Minfree> drivers/net/wireless/ath/ath11k/wmi.h:2731: <VO_Minfree> drivers/net/wireless/ath/ath11k/wmi.h:2965: <bcn_txPower>
--- drivers/net/wireless/ath/ath11k/wmi.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/net/wireless/ath/ath11k/wmi.h +9 -9
@@ -2725,10 +2725,10 @@ struct wmi_resource_config {u32 num_ocb_schedules;u32 flag1;u32 smart_ant_cap; -u32 BK_Minfree; -u32 BE_Minfree; -u32 VI_Minfree; -u32 VO_Minfree; +u32 bk_minfree; +u32 be_minfree; +u32 vi_minfree; +u32 vo_minfree;u32 alloc_frag_desc_for_data_pkt;u32 num_ns_ext_tuples_cfg;u32 bpf_instruction_size;
@@ -2962,7 +2962,7 @@ struct wmi_vdev_start_request_cmd {u32 flags;struct wmi_ssid ssid;u32 bcn_tx_rate; -u32 bcn_txPower; +u32 bcn_txpower;u32 num_noa_descriptors;u32 disable_hw_ack;u32 preferred_tx_streams;
@@ -5122,10 +5122,10 @@ struct target_resource_config {u32 max_frag_entries;u32 max_peer_ext_stats;u32 smart_ant_cap; -u32 BK_Minfree; -u32 BE_Minfree; -u32 VI_Minfree; -u32 VO_Minfree; +u32 bk_minfree; +u32 be_minfree; +u32 vi_minfree; +u32 vo_minfree;u32 rx_batchmode;u32 tt_support;u32 atf_config;
Signature · 7 lines
1.9.1 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 2/5 ath11k: avoid unnecessary 'out of memory' message
drivers/net/wireless/ath/ath11k/dp_rx.c:573: Possible unnecessary 'out of memory' message drivers/net/wireless/ath/ath11k/wmi.c:4528: Possible unnecessary 'out of memory' message
--- drivers/net/wireless/ath/ath11k/dp_rx.c | 4 +--- drivers/net/wireless/ath/ath11k/wmi.c | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-)
drivers/net/wireless/ath/ath11k/dp_rx.c +1 -3
@@ -569,10 +569,8 @@ static void ath11k_dp_rx_tid_del_func(struct ath11k_dp *dp, void *ctx, } elem =kzalloc (sizeof (*elem),GFP_ATOMIC ); -if (!elem) { -ath11k_warn (ab,"failed to allocate memory for cache flush element\n" ); +if (!elem) goto free_desc; - } elem->ts = jiffies;memcpy (&elem->data, rx_tid,sizeof (*rx_tid));
drivers/net/wireless/ath/ath11k/wmi.c +0 -2
@@ -4527,9 +4527,7 @@ static int ath11k_reg_chan_list_event(struct ath11k_base *ab, u8 *evt_buf, u32 lstruct ath11k *ar; reg_info =kzalloc (sizeof (*reg_info),GFP_ATOMIC ); -if (!reg_info) { -ath11k_warn (ab,"Unable to allocate memory for processing chan_info event\n" ); ret = -ENOMEM ; goto fallback; }
Signature · 7 lines
1.9.1 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 3/5 ath11k: fix space related warnings
In reply to Karthikeyan Periyasamydrivers/net/wireless/ath/ath11k/dp.h:1482: Please don't use multiple blank lines drivers/net/wireless/ath/ath11k/dp_rx.c:1072: code indent should use tabs where possible drivers/net/wireless/ath/ath11k/dp_rx.c:1075: code indent should use tabs where possible drivers/net/wireless/ath/ath11k/wmi.c:2321: "(foo*)" should be "(foo *)"
--- drivers/net/wireless/ath/ath11k/dp.h | 1 - drivers/net/wireless/ath/ath11k/dp_rx.c | 4 ++-- drivers/net/wireless/ath/ath11k/wmi.c | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-)
drivers/net/wireless/ath/ath11k/dp.h +0 -1
@@ -1482,7 +1482,6 @@ struct ath11k_htt_extd_stats_msg {u8 data[0 ]; } __packed; -struct htt_mac_addr {u32 mac_addr_l32;u32 mac_addr_h16;
drivers/net/wireless/ath/ath11k/dp_rx.c +2 -2
@@ -1069,10 +1069,10 @@ static u32 ath11k_bw_to_mac80211_bwflags(u8 bw) mcs =HTT_USR_RATE_MCS (user_rate->rate_flags); sgi =HTT_USR_RATE_GI (user_rate->rate_flags); -/* Note: If host configured fixed rates and in some other special +/* Note: If host configured fixed rates and in some other special * cases, the broadcast/management frames are sent in different rates. * Firmware rate's control to be skipped for this? -*/ +*/ if (flags ==WMI_RATE_PREAMBLE_VHT && mcs >9 ) {ath11k_warn (ab,"Invalid VHT mcs %hhd peer stats" , mcs);
drivers/net/wireless/ath/ath11k/wmi.c +1 -1
@@ -2318,7 +2318,7 @@ int ath11k_wmi_pdev_peer_pktlog_filter(struct ath11k *ar, u8 *addr, u8 enable)FIELD_PREP (WMI_TLV_LEN ,0 ); ptr +=TLV_HDR_SIZE ; - info = (struct wmi_pdev_pktlog_filter_info *)ptr; + info = (struct wmi_pdev_pktlog_filter_info *)ptr;ether_addr_copy (info->peer_macaddr.addr, addr); info->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_PDEV_PEER_PKTLOG_FILTER_INFO) |
Signature · 7 lines
1.9.1 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 4/5 ath11k: avoid min() warning
In reply to Karthikeyan Periyasamydrivers/net/wireless/ath/ath11k/mac.c:4921: min() should probably be min_t(u32, ar->num_tx_chains, max(ath11k_mac_max_ht_nss(ht_mcs_mask),
--- drivers/net/wireless/ath/ath11k/mac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath11k/mac.c +3 -3
@@ -4920,9 +4920,9 @@ static void ath11k_mac_disable_peer_fixed_rate(void *data, nss = single_nss; }else { rate =WMI_FIXED_RATE_NONE ; - nss =min ((u32 )ar->num_tx_chains, -max (ath11k_mac_max_ht_nss (ht_mcs_mask), -ath11k_mac_max_vht_nss (vht_mcs_mask))); + nss =min_t (u32, ar->num_tx_chains, +max (ath11k_mac_max_ht_nss (ht_mcs_mask), +ath11k_mac_max_vht_nss (vht_mcs_mask)));/* If multiple rates across different preambles are given * we can reconfigure this info with all peers using PEER_ASSOC
Signature · 7 lines
1.9.1 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 5/5 ath11k: fix brace warning
In reply to Karthikeyan Periyasamydrivers/net/wireless/ath/ath11k/dp_rx.c:1287: that open brace { should be on the previous line
--- drivers/net/wireless/ath/ath11k/dp_rx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/wireless/ath/ath11k/dp_rx.c +1 -2
@@ -1284,8 +1284,7 @@ static void ath11k_htt_pktlog(struct ath11k_base *ab, struct sk_buff *skb) len =FIELD_GET (HTT_T2H_PPDU_STATS_INFO_PAYLOAD_SIZE , data->hdr); -if (len >ATH11K_HTT_PKTLOG_MAX_SIZE ) - { +if (len >ATH11K_HTT_PKTLOG_MAX_SIZE ) {ath11k_warn (ab,"htt pktlog buffer size %d, expected < %d\n" , len,ATH11K_HTT_PKTLOG_MAX_SIZE );
Signature · 7 lines
1.9.1 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 8 lines · Karthikeyan Periyasamy
drivers/net/wireless/ath/ath11k/wmi.h:2728: <BK_Minfree>drivers/net/wireless/ath/ath11k/wmi.h:2729: <BE_Minfree>drivers/net/wireless/ath/ath11k/wmi.h:2730: <VI_Minfree>drivers/net/wireless/ath/ath11k/wmi.h:2731: <VO_Minfree>drivers/net/wireless/ath/ath11k/wmi.h:2965: <bcn_txPower>Signed-off-by Karthikeyan Periyasamy <[email protected]>Signed-off-by Kalle Valo <[email protected]>
5 patches applied to ath11k-bringup branch of ath.git, thanks.
1f200e02d5c1 ath11k: fix variable name warnings 323d5816437a ath11k: avoid unnecessary 'out of memory' message f94a9da4292b ath11k: fix space related warnings e8ab43824092 ath11k: avoid min() warning 4fed41ea71bf ath11k: fix brace warning
Signature · 9 lines
https://patchwork.kernel.org/patch/11014649/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k