TTY Keyboard Status Request
Subsystems (13)
v2 cover TTY Keyboard Status Request
This patch series introduces TTY keyboard status request, a feature of the n_tty line discipline that reserves a character in struct termios (^T by default) and reacts to it by printing a short informational line to the terminal and sending a Unix signal to the tty's foreground process group. The processes may, in response to the signal, output a textual description of what they're doing.
The feature has been present in a similar form at least in Free/Open/NetBSD; it would be nice to have something like this in Linux as well. There is an LKML thread[1] where users have previously expressed the rationale for this.
The current implementation does not break existing kernel API in any way, since, fortunately, all the architectures supported by the kernel happen to have at least 1 free byte in the termios control character array.
The series should cleanly apply to tty-next.
To thoroughly test these, one might need at least a patched stty among other tools, so I've brought up a simple initrd generator[2] which can be used to create a lightweight environment to boot up in a VM and to fiddle with.
[1] https://lore.kernel.org/lkml/1415200663.3247743.187387481.75CE9317@webmail.messagingengine.com/
[2] https://github.com/porrided/tty-kb-status-userspace
v2 <- v1: removed useless debugging bits.
Discussion of v1:
https://lore.kernel.org/lkml/[email protected]/
Arseny Maslennikov (7):
signal.h: Define SIGINFO on all architectures
tty: termios: Reserve space for VSTATUS in .c_cc
n_tty: Send SIGINFO to fg pgrp on status request character linux/signal.h: Ignore SIGINFO by default in new tasks
tty: Add NOKERNINFO lflag to termios
n_tty: ->ops->write: Cut core logic out to a separate function
n_tty: Provide an informational line on VSTATUS receipt
arch/alpha/include/asm/termios.h | 4 +- arch/alpha/include/uapi/asm/termbits.h | 2 + arch/arm/include/uapi/asm/signal.h | 1 + arch/h8300/include/uapi/asm/signal.h | 1 + arch/ia64/include/asm/termios.h | 4 +- arch/ia64/include/uapi/asm/signal.h | 1 + arch/ia64/include/uapi/asm/termbits.h | 2 + arch/m68k/include/uapi/asm/signal.h | 1 + arch/mips/include/asm/termios.h | 4 +- arch/mips/include/uapi/asm/signal.h | 1 + arch/mips/include/uapi/asm/termbits.h | 2 + arch/parisc/include/asm/termios.h | 4 +- arch/parisc/include/uapi/asm/signal.h | 1 + arch/parisc/include/uapi/asm/termbits.h | 2 + arch/powerpc/include/asm/termios.h | 4 +- arch/powerpc/include/uapi/asm/signal.h | 1 + arch/powerpc/include/uapi/asm/termbits.h | 2 + arch/s390/include/asm/termios.h | 4 +- arch/s390/include/uapi/asm/signal.h | 1 + arch/sparc/include/asm/termios.h | 4 +- arch/sparc/include/uapi/asm/signal.h | 2 + arch/sparc/include/uapi/asm/termbits.h | 2 + arch/x86/include/uapi/asm/signal.h | 1 + arch/xtensa/include/uapi/asm/signal.h | 1 + arch/xtensa/include/uapi/asm/termbits.h | 2 + drivers/tty/Makefile | 3 +- drivers/tty/n_tty.c | 70 ++++- drivers/tty/n_tty_status.c | 337 +++++++++++++++++++++++ include/asm-generic/termios.h | 4 +- include/linux/sched.h | 7 + include/linux/signal.h | 5 +- include/linux/tty.h | 7 +- include/uapi/asm-generic/signal.h | 1 + include/uapi/asm-generic/termbits.h | 2 + 34 files changed, 457 insertions(+), 33 deletions(-) create mode 100644 drivers/tty/n_tty_status.c
Signature · 1 line
2.20.1
PATCH v2 1/7 signal.h: Define SIGINFO on all architectures
This complementary patch defines SIGINFO as a synonym for SIGPWR on every architecture supported by the kernel.
The particular signal number chosen does not really matter and is only required for the related tty functionality to work properly, so if it does not suite expectations, any suggestions are warmly welcome.
SIGPWR looks like a nice candidate for this role, because it is defined on every supported arch and is already defined as a synonym for SIGINFO on alpha; SIGPWR is currently only used to inform PID 1 of power failures, and daemons that care about low-level events do not tend to have a controlling terminal.
However, on sparcs SIGPWR is a synonym for SIGLOST, a signal unique to that architecture, with a narrow set of intended uses that do not combine well with interactively requesting status. SIGLOST is not used by any kernel code at the moment.
I'm not sure there is a more reasonable alternative right now.
--- arch/arm/include/uapi/asm/signal.h | 1 + arch/h8300/include/uapi/asm/signal.h | 1 + arch/ia64/include/uapi/asm/signal.h | 1 + arch/m68k/include/uapi/asm/signal.h | 1 + arch/mips/include/uapi/asm/signal.h | 1 + arch/parisc/include/uapi/asm/signal.h | 1 + arch/powerpc/include/uapi/asm/signal.h | 1 + arch/s390/include/uapi/asm/signal.h | 1 + arch/sparc/include/uapi/asm/signal.h | 2 ++ arch/x86/include/uapi/asm/signal.h | 1 + arch/xtensa/include/uapi/asm/signal.h | 1 + include/uapi/asm-generic/signal.h | 1 + 12 files changed, 13 insertions(+)
arch/arm/include/uapi/asm/signal.h +1 -0
@@ -50,6 +50,7 @@ typedef unsigned long sigset_t;#define SIGLOST 29 */ #define SIGPWR 30 +#define SIGINFO SIGPWR#define SIGSYS 31#define SIGUNUSED 31
arch/h8300/include/uapi/asm/signal.h +1 -0
@@ -50,6 +50,7 @@ typedef unsigned long sigset_t;#define SIGLOST 29 */ #define SIGPWR 30 +#define SIGINFO SIGPWR#define SIGSYS 31#define SIGUNUSED 31
arch/ia64/include/uapi/asm/signal.h +1 -0
@@ -45,6 +45,7 @@#define SIGLOST 29 */ #define SIGPWR 30 +#define SIGINFO SIGPWR#define SIGSYS 31/* signal 31 is no longer "unused", but the SIGUNUSED macro remains for backwards compatibility */ #define SIGUNUSED 31
arch/m68k/include/uapi/asm/signal.h +1 -0
@@ -50,6 +50,7 @@ typedef unsigned long sigset_t;#define SIGLOST 29 */ #define SIGPWR 30 +#define SIGINFO SIGPWR#define SIGSYS 31#define SIGUNUSED 31
arch/mips/include/uapi/asm/signal.h +1 -0
@@ -43,6 +43,7 @@ typedef unsigned long old_sigset_t; /* at least 32 bits */#define SIGCHLD 18/* Child status has changed (POSIX). */ #define SIGCLD SIGCHLD/* Same as SIGCHLD (System V). */ #define SIGPWR 19/* Power failure restart (System V). */ +#define SIGINFO SIGPWR/* Keyboard status request (4.2 BSD). */ #define SIGWINCH 20/* Window size change (4.3 BSD, Sun). */ #define SIGURG 21/* Urgent condition on socket (4.2 BSD). */ #define SIGIO 22/* I/O now possible (4.2 BSD). */
arch/parisc/include/uapi/asm/signal.h +1 -0
@@ -22,6 +22,7 @@#define SIGUSR2 17#define SIGCHLD 18#define SIGPWR 19 +#define SIGINFO SIGPWR#define SIGVTALRM 20#define SIGPROF 21#define SIGIO 22
arch/powerpc/include/uapi/asm/signal.h +1 -0
@@ -53,6 +53,7 @@ typedef struct {#define SIGLOST 29 */ #define SIGPWR 30 +#define SIGINFO SIGPWR#define SIGSYS 31#define SIGUNUSED 31
arch/s390/include/uapi/asm/signal.h +1 -0
@@ -58,6 +58,7 @@ typedef unsigned long sigset_t;#define SIGLOST 29 */ #define SIGPWR 30 +#define SIGINFO SIGPWR#define SIGSYS 31#define SIGUNUSED 31
arch/sparc/include/uapi/asm/signal.h +2 -0
@@ -71,6 +71,8 @@#define SIGWINCH 28#define SIGLOST 29#define SIGPWR SIGLOST +/* XXX: is it OK for SIGINFO to collide with LOST? */ +#define SIGINFO SIGPWR#define SIGUSR1 30#define SIGUSR2 31
arch/x86/include/uapi/asm/signal.h +1 -0
@@ -55,6 +55,7 @@ typedef unsigned long sigset_t;#define SIGLOST 29 */ #define SIGPWR 30 +#define SIGINFO SIGPWR#define SIGSYS 31#define SIGUNUSED 31
arch/xtensa/include/uapi/asm/signal.h +1 -0
@@ -65,6 +65,7 @@ typedef struct {#define SIGPOLL SIGIO/* #define SIGLOST 29 */ #define SIGPWR 30 +#define SIGINFO SIGPWR#define SIGSYS 31#define SIGUNUSED 31
include/uapi/asm-generic/signal.h +1 -0
@@ -43,6 +43,7 @@#define SIGLOST 29 */ #define SIGPWR 30 +#define SIGINFO SIGPWR#define SIGSYS 31#define SIGUNUSED 31
Signature · 1 line
2.20.1
PATCH v2 2/7 tty: termios: Reserve space for VSTATUS in .c_cc
In reply to Arseny MaslennikovThere was no architecture we had to increase NCCS on, so the size of struct termios did not change.
--- arch/alpha/include/asm/termios.h | 4 ++-- arch/alpha/include/uapi/asm/termbits.h | 1 + arch/ia64/include/asm/termios.h | 4 ++-- arch/ia64/include/uapi/asm/termbits.h | 1 + arch/mips/include/asm/termios.h | 4 ++-- arch/mips/include/uapi/asm/termbits.h | 1 + arch/parisc/include/asm/termios.h | 4 ++-- arch/parisc/include/uapi/asm/termbits.h | 1 + arch/powerpc/include/asm/termios.h | 4 ++-- arch/powerpc/include/uapi/asm/termbits.h | 1 + arch/s390/include/asm/termios.h | 4 ++-- arch/sparc/include/asm/termios.h | 4 ++-- arch/sparc/include/uapi/asm/termbits.h | 1 + arch/xtensa/include/uapi/asm/termbits.h | 1 + include/asm-generic/termios.h | 4 ++-- include/uapi/asm-generic/termbits.h | 1 + 16 files changed, 24 insertions(+), 16 deletions(-)
arch/alpha/include/asm/termios.h +2 -2
@@ -8,9 +8,9 @@werase=^W kill=^U reprint=^R sxtc=\0 intr=^C quit=^\ susp=^Z <OSF/1 VDSUSP> start=^Q stop=^S lnext=^V discard=^U -vmin=\1 vtime=\0 +vmin=\1 vtime=\0 vstatus=^T */ -#define INIT_C_CC "\004\000\000\177\027\025\022\000\003\034\032\000\021\023\026\025\001\000" +#define INIT_C_CC "\004\000\000\177\027\025\022\000\003\034\032\000\021\023\026\025\001\000\024"/* * Translate a "termio" structure into a "termios". Ugh.
arch/alpha/include/uapi/asm/termbits.h +1 -0
@@ -70,6 +70,7 @@ struct ktermios {#define VDISCARD 15#define VMIN 16#define VTIME 17 +#define VSTATUS 18/* c_iflag bits */ #define IGNBRK 0000001
arch/ia64/include/asm/termios.h +2 -2
@@ -15,9 +15,9 @@eof=^D vtime=\0 vmin=\1 sxtc=\0 start=^Q stop=^S susp=^Z eol=\0 reprint=^R discard=^U werase=^W lnext=^V -eol2=\0 +eol2=\0 status=^T */ -#define INIT_C_CC "\003\034\177\025\004\0\1\0\021\023\032\0\022\017\027\026\0" +#define INIT_C_CC "\003\034\177\025\004\0\1\0\021\023\032\0\022\017\027\026\0\024"/* * Translate a "termio" structure into a "termios". Ugh.
arch/ia64/include/uapi/asm/termbits.h +1 -0
@@ -67,6 +67,7 @@ struct ktermios {#define VWERASE 14#define VLNEXT 15#define VEOL2 16 +#define VSTATUS 17/* c_iflag bits */ #define IGNBRK 0000001
arch/mips/include/asm/termios.h +2 -2
@@ -17,9 +17,9 @@* vmin=\1 vtime=\0 eol2=\0 swtc=\0 * start=^Q stop=^S susp=^Z vdsusp= * reprint=^R discard=^U werase=^W lnext=^V -* eof=^D eol=\0 +* eof=^D eol=\0 status=^T */ -#define INIT_C_CC "\003\034\177\025\1\0\0\0\021\023\032\0\022\017\027\026\004\0" +#define INIT_C_CC "\003\034\177\025\1\0\0\0\021\023\032\0\022\017\027\026\004\0\024"#include <linux/string.h>
arch/mips/include/uapi/asm/termbits.h +1 -0
@@ -78,6 +78,7 @@ struct ktermios {#define VLNEXT 15/* Literal-next character [IEXTEN]. */ #define VEOF 16/* End-of-file character [ICANON]. */ #define VEOL 17/* End-of-line character [ICANON]. */ +#define VSTATUS 18/* Status request character [ISIG]. */ /* c_iflag bits */ #define IGNBRK 0000001/* Ignore break condition. */
arch/parisc/include/asm/termios.h +2 -2
@@ -9,9 +9,9 @@eof=^D vtime=\0 vmin=\1 sxtc=\0 start=^Q stop=^S susp=^Z eol=\0 reprint=^R discard=^U werase=^W lnext=^V -eol2=\0 +eol2=\0 status=^T */ -#define INIT_C_CC "\003\034\177\025\004\0\1\0\021\023\032\0\022\017\027\026\0" +#define INIT_C_CC "\003\034\177\025\004\0\1\0\021\023\032\0\022\017\027\026\0\024"/* * Translate a "termio" structure into a "termios". Ugh.
arch/parisc/include/uapi/asm/termbits.h +1 -0
@@ -58,6 +58,7 @@ struct ktermios {#define VWERASE 14#define VLNEXT 15#define VEOL2 16 +#define VSTATUS 17/* c_iflag bits */
arch/powerpc/include/asm/termios.h +2 -2
@@ -10,8 +10,8 @@#include <uapi/asm/termios.h> -/* ^C ^\ del ^U ^D 1 0 0 0 0 ^W ^R ^Z ^Q ^S ^V ^U */ -#define INIT_C_CC "\003\034\177\025\004\001\000\000\000\000\027\022\032\021\023\026\025" +/* ^C ^\ del ^U ^D 1 0 0 0 0 ^W ^R ^Z ^Q ^S ^V ^U ^T */ +#define INIT_C_CC "\003\034\177\025\004\001\000\000\000\000\027\022\032\021\023\026\025\024"#include <asm-generic/termios-base.h>
arch/powerpc/include/uapi/asm/termbits.h +1 -0
@@ -62,6 +62,7 @@ struct ktermios {#define VSTOP 14#define VLNEXT 15#define VDISCARD 16 +#define VSTATUS 17/* c_iflag bits */ #define IGNBRK 0000001
arch/s390/include/asm/termios.h +2 -2
@@ -14,9 +14,9 @@eof=^D vtime=\0 vmin=\1 sxtc=\0 start=^Q stop=^S susp=^Z eol=\0 reprint=^R discard=^U werase=^W lnext=^V -eol2=\0 +eol2=\0 status=^T */ -#define INIT_C_CC "\003\034\177\025\004\0\1\0\021\023\032\0\022\017\027\026\0" +#define INIT_C_CC "\003\034\177\025\004\0\1\0\021\023\032\0\022\017\027\026\0\024"#define user_termios_to_kernel_termios (k, u) copy_from_user(k, u, sizeof(struct termios2))#define kernel_termios_to_user_termios (u, k) copy_to_user(u, k, sizeof(struct termios2))
arch/sparc/include/asm/termios.h +2 -2
@@ -20,9 +20,9 @@eof=^D eol=\0 eol2=\0 sxtc=\0 start=^Q stop=^S susp=^Z dsusp=^Y reprint=^R discard=^U werase=^W lnext=^V -vmin=\1 vtime=\0 +vmin=\1 vtime=\0 status=^T */ -#define INIT_C_CC "\003\034\177\025\004\000\000\000\021\023\032\031\022\025\027\026\001" +#define INIT_C_CC "\003\034\177\025\004\000\000\000\021\023\032\031\022\025\027\026\001\000\024"/* * Translate a "termio" structure into a "termios". Ugh.
arch/sparc/include/uapi/asm/termbits.h +1 -0
@@ -80,6 +80,7 @@ struct ktermios {#define VDISCARD 13#define VWERASE 14#define VLNEXT 15 +#define VSTATUS 16/* Kernel keeps vmin/vtime separated, user apps assume vmin/vtime is * shared with eof/eol
arch/xtensa/include/uapi/asm/termbits.h +1 -0
@@ -72,6 +72,7 @@ struct ktermios {#define VWERASE 14#define VLNEXT 15#define VEOL2 16 +#define VSTATUS 17/* c_iflag bits */
include/asm-generic/termios.h +2 -2
@@ -10,9 +10,9 @@eof=^D vtime=\0 vmin=\1 sxtc=\0 start=^Q stop=^S susp=^Z eol=\0 reprint=^R discard=^U werase=^W lnext=^V -eol2=\0 +eol2=\0 status=^T */ -#define INIT_C_CC "\003\034\177\025\004\0\1\0\021\023\032\0\022\017\027\026\0" +#define INIT_C_CC "\003\034\177\025\004\0\1\0\021\023\032\0\022\017\027\026\0\024"/* * Translate a "termio" structure into a "termios". Ugh.
include/uapi/asm-generic/termbits.h +1 -0
@@ -58,6 +58,7 @@ struct ktermios {#define VWERASE 14#define VLNEXT 15#define VEOL2 16 +#define VSTATUS 17/* c_iflag bits */ #define IGNBRK 0000001
Signature · 1 line
2.20.1
PATCH v2 3/7 n_tty: Send SIGINFO to fg pgrp on status request character
In reply to Arseny MaslennikovNo kerninfo line is printed yet.
No existing implementation of this on any Unix-like system echoes the status character; no existing implementation discards or flushes pending input on VSTATUS receipt.
There are existing popular TUI applications (e. g. mutt) that only turn off icanon and not iexten, but still do not expect any special treatment of the status request character — thus we require all three:
isig, icanon and iexten to trigger this.
--- drivers/tty/n_tty.c | 15 +++++++++++++-- include/linux/tty.h | 1 + 2 files changed, 14 insertions(+), 2 deletions(-)
drivers/tty/n_tty.c +13 -2
@@ -79,6 +79,10 @@#define ECHO_BLOCK 256#define ECHO_DISCARD_WATERMARK N_TTY_BUF_SIZE - (ECHO_BLOCK + 32) +#define SIG_FLUSHING_MASK ( \ + rt_sigmask(SIGINT) | rt_sigmask(SIGQUIT) | \ + rt_sigmask(SIGTSTP) ) +#define SIG_FLUSHING (sig) ((1 << sig) & SIG_FLUSHING_MASK)#undef N_TTY_TRACE#ifdef N_TTY_TRACE
@@ -1122,7 +1126,7 @@ static void isig(int sig, struct tty_struct *tty) {struct n_tty_data *ldata = tty->disc_data; -if (L_NOFLSH (tty)) { +if (L_NOFLSH (tty) || (!SIG_FLUSHING (sig))) {/* signal only */ __isig (sig, tty);
@@ -1244,7 +1248,8 @@ n_tty_receive_signal_char(struct tty_struct *tty, int signal, unsigned char c)if (I_IXON (tty))start_tty (tty);if (L_ECHO (tty)) { -echo_char (c, tty); +if (c !=STATUS_CHAR (tty)) +echo_char (c, tty);commit_echoes (tty); }else process_echoes (tty);
@@ -1294,6 +1299,9 @@ n_tty_receive_char_special(struct tty_struct *tty, unsigned char c) }else if (c ==SUSP_CHAR (tty)) {n_tty_receive_signal_char (tty,SIGTSTP , c);return 0 ; + }else if (c ==STATUS_CHAR (tty)) { +n_tty_receive_signal_char (tty,SIGINFO , c); +return 0 ; } }
@@ -1848,6 +1856,9 @@ static void n_tty_set_termios(struct tty_struct *tty, struct ktermios *old)set_bit (INTR_CHAR (tty), ldata->char_map);set_bit (QUIT_CHAR (tty), ldata->char_map);set_bit (SUSP_CHAR (tty), ldata->char_map); +if (L_ICANON (tty) &&L_IEXTEN (tty)) { +set_bit (STATUS_CHAR (tty), ldata->char_map); + } }clear_bit (__DISABLED_CHAR, ldata->char_map); ldata->raw =0 ;
include/linux/tty.h +1 -0
@@ -120,6 +120,7 @@ struct tty_bufhead {#define WERASE_CHAR (tty) ((tty)->termios.c_cc[VWERASE])#define LNEXT_CHAR (tty) ((tty)->termios.c_cc[VLNEXT])#define EOL2_CHAR (tty) ((tty)->termios.c_cc[VEOL2]) +#define STATUS_CHAR (tty) ((tty)->termios.c_cc[VSTATUS])#define _I_FLAG (tty, f) ((tty)->termios.c_iflag & (f))#define _O_FLAG (tty, f) ((tty)->termios.c_oflag & (f))
Signature · 1 line
2.20.1
PATCH v2 4/7 linux/signal.h: Ignore SIGINFO by default in new tasks
In reply to Arseny MaslennikovThis matches the behaviour of other Unix-like systems that have SIGINFO and causes less harm to processes that do not install handlers for this signal, making the keyboard status character non-fatal for them.
This is implemented with the assumption that SIGINFO is defined to be equivalent to SIGPWR; still, there is no reason for PWR to result in termination of the signal recipient anyway — it does not indicate there is a fatal problem with the recipient's execution context (like e.g. FPE/ILL do), and we have TERM/KILL for explicit termination requests.
--- include/linux/signal.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
include/linux/signal.h +3 -2
@@ -360,7 +360,7 @@ extern bool unhandled_signal(struct task_struct *tsk, int sig);* | SIGSYS/SIGUNUSED | coredump | * | SIGSTKFLT | terminate | * | SIGWINCH | ignore | -* | SIGPWR | terminate | +* | SIGPWR | ignore | * | SIGRTMIN-SIGRTMAX | terminate | * +--------------------+------------------+ * | non-POSIX signal | default action |
@@ -411,7 +411,8 @@ extern bool unhandled_signal(struct task_struct *tsk, int sig);#define SIG_KERNEL_IGNORE_MASK (\ rt_sigmask(SIGCONT) | rt_sigmask(SIGCHLD) | \ - rt_sigmask(SIGWINCH) | rt_sigmask(SIGURG) ) + rt_sigmask(SIGWINCH) | rt_sigmask(SIGURG) | \ + rt_sigmask(SIGINFO) )#define SIG_SPECIFIC_SICODES_MASK (\ rt_sigmask(SIGILL) | rt_sigmask(SIGFPE) | \
Signature · 1 line
2.20.1
Re: [PATCH v2 4/7] linux/signal.h: Ignore SIGINFO by default in new tasks
Quoted 10 lines · Arseny Maslennikov
This matches the behaviour of other Unix-like systems that have SIGINFO and causes less harm to processes that do not install handlers for this signal, making the keyboard status character non-fatal for them.
This is implemented with the assumption that SIGINFO is defined to be equivalent to SIGPWR; still, there is no reason for PWR to result in termination of the signal recipient anyway — it does not indicate there is a fatal problem with the recipient's execution context (like e.g. FPE/ILL do), and we have TERM/KILL for explicit termination requests.
So this is a consequence of trying to overload SIGINFO with SIGPWR. At least on some legacy Unix systems, the way SIGPWR worked was that init would broadcast SIGPWR to all userspace process (with system daemons on an exception list so they could get shutdown last). Applications which didn't have a SIGPWR handler registered, would just exit. Those that did, were expected to clean up in preparation with the impending shutdown. After some period of time, then processes would get hard killed and then system daemons would get shut down and the system would cleanly shut itself down.
So SIGPWR acted much like SIGHUP, and that's why the default behavior was "terminate". Now, as far as I know, we've not actually used in that way, at least for most common distributions, but there is a sane reason why things are they way there are, and in there are people who have been using SIGPWR the way it had originally been intended, there is risk in overloading SIGINFO with SIGPWR --- in particular, typing ^T might cause some enterprise database to start shutting itself down. :-)
(In particular it might be worth checking Linux ports of Oracle and DB2.)
- Ted
Re: [PATCH v2 4/7] linux/signal.h: Ignore SIGINFO by default in new tasks
Quoted 5 lines · Theodore Ts'o
Quoted 4 lines · Arseny Maslennikov
This matches the behaviour of other Unix-like systems that have SIGINFO and causes less harm to processes that do not install handlers for this signal, making the keyboard status character non-fatal for them.
Quoted 8 lines
Quoted 6 lines
This is implemented with the assumption that SIGINFO is defined to be equivalent to SIGPWR; still, there is no reason for PWR to result in termination of the signal recipient anyway — it does not indicate there is a fatal problem with the recipient's execution context (like e.g. FPE/ILL do), and we have TERM/KILL for explicit termination requests.
So this is a consequence of trying to overload SIGINFO with SIGPWR.
Pretty much.
Quoted 9 lines
At least on some legacy Unix systems, the way SIGPWR worked was that init would broadcast SIGPWR to all userspace process (with system daemons on an exception list so they could get shutdown last). Applications which didn't have a SIGPWR handler registered, would just exit. Those that did, were expected to clean up in preparation with the impending shutdown. After some period of time, then processes would get hard killed and then system daemons would get shut down and the system would cleanly shut itself down.
Quoted 7 lines
So SIGPWR acted much like SIGHUP, and that's why the default behavior was "terminate". Now, as far as I know, we've not actually used in that way, at least for most common distributions, but there is a sane reason why things are they way there are, and in there are people who have been using SIGPWR the way it had originally been intended, there is risk in overloading SIGINFO with SIGPWR --- in particular, typing ^T might cause some enterprise database to start shutting itself down. :-)
Only if that enterprise database:
1) has a controlling terminal (a strange condition for a daemon, IMHO)
2) that terminal has the status character set in the struct termios.
Quoted 3 lines
(In particular it might be worth checking Linux ports of Oracle and DB2.)
A quick google got me this document:
https://docs.oracle.com/cd/B28359_01/server.111/b32009.pdf
It only ever mentions CHLD, CONT, INT, PIPE, TERM, URG and IO.
I have no real experience with neither DB2 nor Oracle DB, though, and no way to get hold of that kind of software, so I don't know where to look further. If we'd like to be really sure no one's hurt we'll need someone with actual expertise here.
Re: [PATCH v2 4/7] linux/signal.h: Ignore SIGINFO by default in new tasks
In reply to Theodore Ts'oQuoted 4 lines · Theodore Ts'o
<...>
(In particular it might be worth checking Linux ports of Oracle and DB2.)
A couple of weeks of asking around got me to have a look at a DB2 9.7 instance.
sn1:~ # uname -a
Linux sn1 2.6.16.60-0.54.5-ppc64 #1 SMP Fri Sep 4 01:28:03 UTC 2009 ppc64 ppc64 ppc64 GNU/Linux
That particular deployment used the following set of processes:
sn1:~ # ps -eo user,ppid,pid,pgid,sid,tty,state,cmd | grep db2 | grep -v java
bgpsysdb 8505 672 8504 7146 ? S db2fmp ( ,0,0,0,0,0,0,0,1,0,8a6678,14,1e014,2,0,1,171fc0,0x110000000,0x110000000,1600000,18002,2,384f00b7 bgpsysdb 8505 687 8504 7146 ? S db2fmp ( ,0,0,0,0,0,0,0,1,0,8a6678,14,1e014,2,0,1,191fc0,0x110000000,0x110000000,1600000,18002,2,384f80b9 bgpsysdb 8505 4309 8504 7146 ? S db2fmp ( ,0,0,0,0,0,0,0,1,0,8a6678,14,1e014,2,0,1,151fc0,0x110000000,0x110000000,1600000,18002,2,6f5080c5 root 1 8505 8504 7146 ? S db2wdog 0 bgpsysdb 8505 8511 8511 7146 ? S db2sysc 0 root 8511 8512 8511 7146 ? S db2ckpwd 0 root 8511 8513 8511 7146 ? S db2ckpwd 0 root 8511 8514 8511 7146 ? S db2ckpwd 0 bgpsysdb 8505 8630 8504 7146 ? S db2acd 0 ,0,0,0,1,0,0,0,1,0,8a6678,14,1e014,2,0,1,11fc0,0x110000000,0x110000000,1600000,18002,2,398072 bgpsysdb 8505 15280 8504 7146 ? S db2fmp ( ,1,0,0,0,0,0,0,1,0,8a6678,14,1e014,2,0,1,31fc0,0x110000000,0x110000000,1600000,18002,2,bd80bb bgpsysdb 8505 16032 8504 7146 ? S db2fmp ( ,0,0,0,0,0,0,0,1,0,8a6678,14,1e014,2,0,1,b1fc0,0x110000000,0x110000000,1600000,18002,2,81980ba bgpsysdb 8505 16073 8504 7146 ? S db2fmp ( ,0,0,0,0,0,0,0,1,0,8a6678,14,1e014,2,0,1,91fc0,0x110000000,0x110000000,1600000,18002,2,12300c0 bgpsysdb 8505 17683 8504 7146 ? S db2fmp ( ,0,0,0,0,0,0,0,1,0,8a6678,14,1e014,2,0,1,131fc0,0x110000000,0x110000000,1600000,18002,2,248600db bgpsysdb 8505 30731 8504 7146 ? S db2fmp ( ,0,0,0,0,0,0,0,1,0,8a6678,14,1e014,2,0,1,f1fc0,0x110000000,0x110000000,1600000,18002,2,370080d1
None of them has a controlling tty, so ^T pressed at any tty won't send them a signal.
To get an idea on how do they handle signals, we can look at /proc/*/status:
sn1:~ # cat /proc/{8512,8505,687,8511}/status | egrep '^(Pid|Sig|Shd)'
Pid: 687 SigQ: 0/128000 SigPnd: 0000000000000000 ShdPnd: 0000000000000000 SigBlk: 0000000000000000 SigIgn: fffffffe2bbaf007 SigCgt: 00000001c44004f8 Pid: 8505 SigQ: 0/128000 SigPnd: 0000000000000000 ShdPnd: 0000000000000000 SigBlk: fffffffe7ffbfeff SigIgn: fffffffe2fbaf007 SigCgt: 00000001c0410ef8 Pid: 8511 SigQ: 0/128000 SigPnd: 0000000000000000 ShdPnd: 0000000000000000 SigBlk: fffffffe7ffbfeff SigIgn: fffffffe23b3c005 SigCgt: 00000001dc483efa Pid: 8512 SigQ: 0/128000 SigPnd: 0000000000000000 ShdPnd: 0000000000000000 SigBlk: 0000000000000000 SigIgn: fffffffe2fbbf007 SigCgt: 00000001c0400ef8
It can be seen from the above that SIGPWR in particular is always ignored and sometimes blocked, which means its default disposition has no effect.
This leads me to think that DB2 in particular would be unaffected by the patch set.
p.s.: I do not have shell access to the machine, and never did; the commands cited in this email were executed by a person who does, and the output was handed back to me.
PATCH v2 5/7 tty: Add NOKERNINFO lflag to termios
In reply to Arseny Maslennikov--- arch/alpha/include/uapi/asm/termbits.h | 1 + arch/ia64/include/uapi/asm/termbits.h | 1 + arch/mips/include/uapi/asm/termbits.h | 1 + arch/parisc/include/uapi/asm/termbits.h | 1 + arch/powerpc/include/uapi/asm/termbits.h | 1 + arch/sparc/include/uapi/asm/termbits.h | 1 + arch/xtensa/include/uapi/asm/termbits.h | 1 + include/linux/tty.h | 1 + include/uapi/asm-generic/termbits.h | 1 + 9 files changed, 9 insertions(+)
arch/alpha/include/uapi/asm/termbits.h +1 -0
@@ -204,6 +204,7 @@ struct ktermios {#define PENDIN 0x20000000#define IEXTEN 0x00000400#define EXTPROC 0x10000000 +#define NOKERNINFO 0x40000000/* Values for the ACTION argument to `tcflow'. */ #define TCOOFF 0
arch/ia64/include/uapi/asm/termbits.h +1 -0
@@ -190,6 +190,7 @@ struct ktermios {#define PENDIN 0040000#define IEXTEN 0100000#define EXTPROC 0200000 +#define NOKERNINFO 0400000/* tcflow() and TCXONC use these */ #define TCOOFF 0
arch/mips/include/uapi/asm/termbits.h +1 -0
@@ -206,6 +206,7 @@ struct ktermios {#define TOSTOP 0100000/* Send SIGTTOU for background output. */ #define ITOSTOP TOSTOP#define EXTPROC 0200000/* External processing on pty */ +#define NOKERNINFO 0400000/* Disable kernel output from VSTATUS. */ /* ioctl (fd, TIOCSERGETLSR, &result) where result may be as below */ #define TIOCSER_TEMT 0x01/* Transmitter physically empty */
arch/parisc/include/uapi/asm/termbits.h +1 -0
@@ -183,6 +183,7 @@ struct ktermios {#define PENDIN 0040000#define IEXTEN 0100000#define EXTPROC 0200000 +#define NOKERNINFO 0400000/* tcflow() and TCXONC use these */ #define TCOOFF 0
arch/powerpc/include/uapi/asm/termbits.h +1 -0
@@ -192,6 +192,7 @@ struct ktermios {#define PENDIN 0x20000000#define IEXTEN 0x00000400#define EXTPROC 0x10000000 +#define NOKERNINFO 0x40000000/* Values for the ACTION argument to `tcflow'. */ #define TCOOFF 0
arch/sparc/include/uapi/asm/termbits.h +1 -0
@@ -225,6 +225,7 @@ struct ktermios {#define PENDIN 0x00004000#define IEXTEN 0x00008000#define EXTPROC 0x00010000 +#define NOKERNINFO 0x00020000/* modem lines */ #define TIOCM_LE 0x001
arch/xtensa/include/uapi/asm/termbits.h +1 -0
@@ -199,6 +199,7 @@ struct ktermios {#define PENDIN 0040000#define IEXTEN 0100000#define EXTPROC 0200000 +#define NOKERNINFO 0400000/* tcflow() and TCXONC use these */
include/linux/tty.h +1 -0
@@ -186,6 +186,7 @@ struct tty_bufhead {#define L_PENDIN (tty) _L_FLAG((tty), PENDIN)#define L_IEXTEN (tty) _L_FLAG((tty), IEXTEN)#define L_EXTPROC (tty) _L_FLAG((tty), EXTPROC) +#define L_NOKERNINFO (tty) _L_FLAG((tty), NOKERNINFO)struct device ;struct signal_struct ;
include/uapi/asm-generic/termbits.h +1 -0
@@ -181,6 +181,7 @@ struct ktermios {#define PENDIN 0040000#define IEXTEN 0100000#define EXTPROC 0200000 +#define NOKERNINFO 0400000/* tcflow() and TCXONC use these */ #define TCOOFF 0
Signature · 1 line
2.20.1
PATCH v2 6/7 n_tty: ->ops->write: Cut core logic out to a separate function
In reply to Arseny MaslennikovTo simplify internal re-use of the line discipline's write method, we isolate the work it does to its own function.
Since in-kernel callers might not refer to the tty through a file, the struct file* argument might make no sense, so we also stop tty_io_nonblock() from dereferencing file too early, allowing to pass NULL as the referring file here.
--- drivers/tty/n_tty.c | 33 ++++++++++++++++++++++----------- include/linux/tty.h | 2 +- 2 files changed, 23 insertions(+), 12 deletions(-)
drivers/tty/n_tty.c +22 -11
@@ -2309,22 +2309,15 @@ static ssize_t n_tty_read(struct tty_struct *tty, struct file *file,* lock themselves) */ -static ssize_t n_tty_write (struct tty_struct *tty,struct file *file, -const unsigned char *buf,size_t nr) +static ssize_t do_n_tty_write (struct tty_struct *tty,struct file *file, +const unsigned char *buf,size_t nr) {const unsigned char *b = buf;DEFINE_WAIT_FUNC (wait, woken_wake_function);int c;ssize_t retval =0 ; -/* Job control check -- must be done at start (POSIX.1 7.1.1.4). */ -if (L_TOSTOP (tty) && file->f_op->write != redirected_tty_write) { - retval =tty_check_change (tty); -if (retval) -return retval; - } - -down_read (&tty->termios_rwsem); +lockdep_assert_held_read (&tty->termios_rwsem);/* Write out any echoed characters that are still pending */ process_echoes (tty);
@@ -2392,10 +2385,28 @@ static ssize_t n_tty_write(struct tty_struct *tty, struct file *file,remove_wait_queue (&tty->write_wait, &wait);if (nr && tty->fasync)set_bit (TTY_DO_WRITE_WAKEUP , &tty->flags); -up_read (&tty->termios_rwsem);return (b - buf) ? b - buf : retval; } +static ssize_t n_tty_write (struct tty_struct *tty,struct file *file, +const unsigned char *buf,size_t nr) +{ +ssize_t retval =0 ; + +/* Job control check -- must be done at start (POSIX.1 7.1.1.4). */ +if (L_TOSTOP (tty) && file->f_op->write != redirected_tty_write) { + retval =tty_check_change (tty); +if (retval) +return retval; + } + +down_read (&tty->termios_rwsem); + retval =do_n_tty_write (tty, file, buf, nr); +up_read (&tty->termios_rwsem); + +return retval; +} +/** * n_tty_poll - poll method for N_TTY * @tty: terminal device
include/linux/tty.h +1 -1
@@ -388,7 +388,7 @@ static inline void tty_set_flow_change(struct tty_struct *tty, int val)static inline bool tty_io_nonblock (struct tty_struct *tty,struct file *file) { -return file->f_flags &O_NONBLOCK || +return (file && file->f_flags &O_NONBLOCK ) ||test_bit (TTY_LDISC_CHANGING , &tty->flags); }
Signature · 1 line
2.20.1
PATCH v2 7/7 n_tty: Provide an informational line on VSTATUS receipt
In reply to Arseny MaslennikovIf the three termios local flags isig, icanon, iexten are enabled and the local flag nokerninfo is disabled for a tty governed by the n_tty line discipline, then on receiving the keyboard status character n_tty will generate a status message and write it out to the tty before sending SIGINFO to the tty's foreground process group.
This kerninfo line contains information about the current system load as well as some properties of "the most interesting" process in the tty's current foreground process group, namely:
- its PID as seen inside its deepest PID namespace;
* the whole process group ought to be in a single PID namespace, so this is actually deterministic
- its saved command name truncated to 16 bytes (task_struct::comm);
* at the time of writing TASK_COMM_LEN == 16
- its state and some related bits, procps-style;
- for S and D: its symbolic wait channel, if available; or a short description for other process states instead;
- its user, system and real rusage time values;
- its resident set size (as well as the high watermark) in kilobytes.
The "most interesting" process is chosen as follows:
- runnables over everything
- uninterruptibles over everything else
- among 2 runnables pick the biggest utime + stime
- any unresolved ties are decided in favour of greatest PID.
While the kerninfo line is not very useful for debugging the kernel itself, since we have much more powerful debugging tools, it still gives the user behind the terminal some meaningful feedback to a VSTATUS that works even if no processes respond.
--- drivers/tty/Makefile | 3 +- drivers/tty/n_tty.c | 22 +++ drivers/tty/n_tty_status.c | 337 +++++++++++++++++++++++++++++++++++++ include/linux/sched.h | 7 + include/linux/tty.h | 3 + 5 files changed, 371 insertions(+), 1 deletion(-) create mode 100644 drivers/tty/n_tty_status.c
drivers/tty/Makefile +2 -1
@@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_TTY) += tty_io.o n_tty.o tty_ioctl.o tty_ldisc.o \ +obj-$(CONFIG_TTY) += tty_io.o tty_ioctl.o tty_ldisc.o \ tty_buffer.o tty_port.o tty_mutex.o \ tty_ldsem.o tty_baudrate.o tty_jobctrl.o \ + n_tty.o n_tty_status.o \ n_null.o obj-$(CONFIG_LEGACY_PTYS) += pty.o obj-$(CONFIG_UNIX98_PTYS) += pty.o
drivers/tty/n_tty.c +22 -0
@@ -34,6 +34,7 @@#include <linux/signal.h> #include <linux/fcntl.h> #include <linux/sched.h> +#include <linux/kallsyms.h> #include <linux/interrupt.h> #include <linux/tty.h> #include <linux/timer.h>
@@ -79,6 +80,8 @@#define ECHO_BLOCK 256#define ECHO_DISCARD_WATERMARK N_TTY_BUF_SIZE - (ECHO_BLOCK + 32) +#define STATUS_LINE_LEN (2 * KSYM_NAME_LEN) +#define SIG_FLUSHING_MASK ( \ rt_sigmask(SIGINT) | rt_sigmask(SIGQUIT) | \ rt_sigmask(SIGTSTP) )
@@ -158,6 +161,8 @@ static inline unsigned char *echo_buf_addr(struct n_tty_data *ldata, size_t i)return &ldata->echo_buf[i & (N_TTY_BUF_SIZE -1 )]; } +static void n_tty_status_line (struct tty_struct *tty); +/* If we are not echoing the data, perhaps this is a secret so erase it */ static void zero_buffer (struct tty_struct *tty,u8 *buffer,int size) {
@@ -1300,6 +1305,8 @@ n_tty_receive_char_special(struct tty_struct *tty, unsigned char c)n_tty_receive_signal_char (tty,SIGTSTP , c);return 0 ; }else if (c ==STATUS_CHAR (tty)) { +if (!L_NOKERNINFO (tty)) +n_tty_status_line (tty);n_tty_receive_signal_char (tty,SIGINFO , c);return 0 ; }
@@ -2489,6 +2496,21 @@ static int n_tty_ioctl(struct tty_struct *tty, struct file *file, } } +static void n_tty_status_line (struct tty_struct *tty) +{ +struct n_tty_data *ldata = tty->disc_data; +char *msg, *buf; + msg = buf =kzalloc (STATUS_LINE_LEN ,GFP_KERNEL ); +tty_sprint_status_line (tty, buf +1 ,STATUS_LINE_LEN -1 ); +/* The only current caller of this takes output_lock for us. */ +if (ldata->column !=0 ) + *msg ='\n' ; +else + msg++; +do_n_tty_write (tty,NULL , msg,strlen (msg)); +kfree (buf); +} +static struct tty_ldisc_ops n_tty_ops = { .magic =TTY_LDISC_MAGIC , .name ="n_tty" ,
drivers/tty/n_tty_status.c new file +337 -0
337 lines not on this page · raw message
include/linux/sched.h +7 -0
@@ -1229,6 +1229,8 @@ static inline struct pid *task_pid(struct task_struct *task)* task_xid_nr() : global id, i.e. the id seen from the init namespace; * task_xid_vnr() : virtual id, i.e. the id seen from the pid namespace of * current. +* task_xid_vinr() : virtual inner id, i.e. the id seen from the namespace of +* the task itself; * task_xid_nr_ns() : id seen from the ns specified; * * see also pid_nr() etc in include/linux/pid.h
@@ -1250,6 +1252,11 @@ static inline pid_t task_pid_vnr(struct task_struct *tsk)return __task_pid_nr_ns (tsk,PIDTYPE_PID ,NULL ); } +static inline pid_t task_pid_vinr (struct task_struct *tsk) +{ +return __task_pid_nr_ns (tsk,PIDTYPE_PID ,ns_of_pid (task_pid (tsk))); +} +static inline pid_t task_tgid_nr (struct task_struct *tsk) {
include/linux/tty.h +3 -0
@@ -725,6 +725,9 @@ extern void __init n_tty_init(void);static inline void n_tty_init (void ) { }#endif +/* n_tty_status.c */ +extern void tty_sprint_status_line (struct tty_struct *tty,char *msg,size_t size); +/* tty_audit.c */ #ifdef CONFIG_AUDIT extern void tty_audit_add_data(struct tty_struct *tty, const void *data,
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerRe: [PATCH v2 7/7] n_tty: Provide an informational line on VSTATUS receipt
Quoted 6 lines · Arseny Maslennikov
If the three termios local flags isig, icanon, iexten are enabled and the local flag nokerninfo is disabled for a tty governed by the
n_ttyline discipline, then on receiving the keyboard status charactern_ttywill generate a status message and write it out to the tty before sending SIGINFO to the tty's foreground process group.
Quoted 13 lines
This kerninfo line contains information about the current system load as well as some properties of "the most interesting" process in the tty's current foreground process group, namely:
- its PID as seen inside its deepest PID namespace;
* the whole process group ought to be in a single PID namespace, so this is actually deterministic
- its saved command name truncated to 16 bytes (task_struct::comm);
* at the time of writingTASK_COMM_LEN== 16
- its state and some related bits, procps-style;
- for S and D: its symbolic wait channel, if available; or a short description for other process states instead;
- its user, system and real rusage time values;
- its resident set size (as well as the high watermark) in kilobytes.
Why is this really all needed as we have the SysRq handlers that report all of this today?
Quoted 5 lines
The "most interesting" process is chosen as follows:
- runnables over everything
- uninterruptibles over everything else
- among 2 runnables pick the biggest utime + stime
- any unresolved ties are decided in favour of greatest PID.
This does not feel like something that the tty core code should be doing at all.
Quoted 4 lines
While the kerninfo line is not very useful for debugging the kernel itself, since we have much more powerful debugging tools, it still gives the user behind the terminal some meaningful feedback to a VSTATUS that works even if no processes respond.
That's what SysRq is for. If there's a specific set of values that we don't currently report in that facility, why not just add the information there? It's much simpler and "safer" that way.
thanks,
greg k-h
Re: [PATCH v2 7/7] n_tty: Provide an informational line on VSTATUS receipt
Quoted 21 lines · Greg Kroah-Hartman
Quoted 6 lines · Arseny Maslennikov
If the three termios local flags isig, icanon, iexten are enabled and the local flag nokerninfo is disabled for a tty governed by the
n_ttyline discipline, then on receiving the keyboard status charactern_ttywill generate a status message and write it out to the tty before sending SIGINFO to the tty's foreground process group.Quoted 13 lines
This kerninfo line contains information about the current system load as well as some properties of "the most interesting" process in the tty's current foreground process group, namely:
- its PID as seen inside its deepest PID namespace;
* the whole process group ought to be in a single PID namespace, so this is actually deterministic
- its saved command name truncated to 16 bytes (task_struct::comm);
* at the time of writingTASK_COMM_LEN== 16
- its state and some related bits, procps-style;
- for S and D: its symbolic wait channel, if available; or a short description for other process states instead;
- its user, system and real rusage time values;
- its resident set size (as well as the high watermark) in kilobytes.
Quoted 2 lines
Why is this really all needed as we have the SysRq handlers that report all of this today?
Different use-cases have different needs; SysRq is targeted at a different audience; see below.
Quoted 8 lines
Quoted 5 lines
The "most interesting" process is chosen as follows:
- runnables over everything
- uninterruptibles over everything else
- among 2 runnables pick the biggest utime + stime
- any unresolved ties are decided in favour of greatest PID.This does not feel like something that the tty core code should be doing at all.
Yes, this selection part is quite clumsy. In defense of it, one could argue that we already have the whole n_tty implemented in kernel-space.
One way we could get rid of this is to display a summarized statistic for the whole pgrp: pgid, oldest real time, cumulative utime and stime, cumulative memory usage. Would this be more acceptable? Are there any other ideas?
Quoted 8 lines
Quoted 4 lines
While the kerninfo line is not very useful for debugging the kernel itself, since we have much more powerful debugging tools, it still gives the user behind the terminal some meaningful feedback to a VSTATUS that works even if no processes respond.
That's what SysRq is for. If there's a specific set of values that we don't currently report in that facility, why not just add the information there? It's much simpler and "safer" that way.
SysRq is intended for the person either administrating the system to be used in emergency (e.g. f for the oom kill, the famous s-u-b combo also comes to mind) or debugging the kernel, and it indeed does a much better job for those purposes. In both use-cases mentioned the person has access to the system console, where the sysrq button handlers produce all their output, if any, and to either a physical keyboard / serial console or to /proc/sysrq-trigger, whose mode is 0200 (writable by uid 0 only).
The use-case for this is different: the ^T-line as proposed by this patch is for the user that interacts with a system through a terminal, who wants to be informed not about the whole system (sort of what SysRq-t tells you), but about what they run on that particular tty. This is much less about "why does my system/kernel seem to hang?" or exposing low-level internals (registers, hrtimers, locks, ...), and more about "is my SSH terminal session unresponsive?" and "I ran a command, it doesn't finish, how's it doing?".
e.g. A user might want to know if their SSH connection is alive without interrupting anything, while having no access both to SysRq and console, and no one in fg pgrp actually handles SIGINFO.
SysRq is system-wide, whereas this is per-terminal and only cares about one tty which the status char is pressed at and its foreground pgrp (most likely it's the foreground shell job).
I hope this is clear enough.
Greg Kroah-Hartman
maintainerRe: [PATCH v2 7/7] n_tty: Provide an informational line on VSTATUS receipt
Quoted 34 lines · Arseny Maslennikov
Quoted 21 lines · Greg Kroah-Hartman
Quoted 6 lines · Arseny Maslennikov
If the three termios local flags isig, icanon, iexten are enabled and the local flag nokerninfo is disabled for a tty governed by the
n_ttyline discipline, then on receiving the keyboard status charactern_ttywill generate a status message and write it out to the tty before sending SIGINFO to the tty's foreground process group.Quoted 13 lines
This kerninfo line contains information about the current system load as well as some properties of "the most interesting" process in the tty's current foreground process group, namely:
- its PID as seen inside its deepest PID namespace;
* the whole process group ought to be in a single PID namespace, so this is actually deterministic
- its saved command name truncated to 16 bytes (task_struct::comm);
* at the time of writingTASK_COMM_LEN== 16
- its state and some related bits, procps-style;
- for S and D: its symbolic wait channel, if available; or a short description for other process states instead;
- its user, system and real rusage time values;
- its resident set size (as well as the high watermark) in kilobytes.Quoted 2 lines
Why is this really all needed as we have the SysRq handlers that report all of this today?
Different use-cases have different needs; SysRq is targeted at a different audience; see below.
Quoted 6 lines
Quoted 5 lines
The "most interesting" process is chosen as follows:
- runnables over everything
- uninterruptibles over everything else
- among 2 runnables pick the biggest utime + stime
- any unresolved ties are decided in favour of greatest PID.
Quoted 5 lines
Quoted 2 lines
This does not feel like something that the tty core code should be doing at all.
Yes, this selection part is quite clumsy. In defense of it, one could argue that we already have the whole
n_ttyimplemented in kernel-space.
One could argue that :)
Quoted 4 lines
One way we could get rid of this is to display a summarized statistic for the whole pgrp: pgid, oldest real time, cumulative utime and stime, cumulative memory usage. Would this be more acceptable? Are there any other ideas?
Given that I really think you are just making something up here that no one really is needing for their workflow, but would just be "cool to have", I say do whatever you think is right.
And there is nothing wrong with "cool to have" things, I'm not trying to dismiss this, it's just that all new features come with the "you must support this until the end of time" requirement that we must balance it with.
Quoted 17 lines
Quoted 8 lines
Quoted 4 lines
While the kerninfo line is not very useful for debugging the kernel itself, since we have much more powerful debugging tools, it still gives the user behind the terminal some meaningful feedback to a VSTATUS that works even if no processes respond.
That's what SysRq is for. If there's a specific set of values that we don't currently report in that facility, why not just add the information there? It's much simpler and "safer" that way.
SysRq is intended for the person either administrating the system to be used in emergency (e.g. f for the oom kill, the famous s-u-b combo also comes to mind) or debugging the kernel, and it indeed does a much better job for those purposes. In both use-cases mentioned the person has access to the system console, where the sysrq button handlers produce all their output, if any, and to either a physical keyboard / serial console or to
/proc/sysrq-trigger, whose mode is 0200 (writable by uid 0 only).
Quoted 4 lines
The use-case for this is different: the ^T-line as proposed by this patch is for the user that interacts with a system through a terminal, who wants to be informed not about the whole system (sort of what SysRq-t tells you), but about what they run on that particular tty.
Ok, fair enough, although if you just add a new sysrq option for "what is running on this tty", would that help resolve this?
Quoted 7 lines
This is much less about "why does my system/kernel seem to hang?" or exposing low-level internals (registers, hrtimers, locks, ...), and more about "is my SSH terminal session unresponsive?" and "I ran a command, it doesn't finish, how's it doing?".
e.g. A user might want to know if their SSH connection is alive without interrupting anything, while having no access both to SysRq and console, and no one in fg pgrp actually handles SIGINFO.
If you have access to a tty, you should have access to sysrq, right?
Quoted 5 lines
SysRq is system-wide, whereas this is per-terminal and only cares about one tty which the status char is pressed at and its foreground pgrp (most likely it's the foreground shell job).
I hope this is clear enough.
It is, yes. My big objection is the crazy code I point out above, as well as the "create a totally new interface when we might be able to use an existing one" that you need to convince me is really required :)
thanks,
greg k-h
Re: [PATCH v2 7/7] n_tty: Provide an informational line on VSTATUS receipt
Hi!
Quoted 7 lines
Quoted 4 lines
The use-case for this is different: the ^T-line as proposed by this patch is for the user that interacts with a system through a terminal, who wants to be informed not about the whole system (sort of what SysRq-t tells you), but about what they run on that particular tty.
Ok, fair enough, although if you just add a new sysrq option for "what is running on this tty", would that help resolve this?
This is meant for unpriviledged users, unlike sysrq.
Quoted 9 lines
Quoted 7 lines
This is much less about "why does my system/kernel seem to hang?" or exposing low-level internals (registers, hrtimers, locks, ...), and more about "is my SSH terminal session unresponsive?" and "I ran a command, it doesn't finish, how's it doing?".
e.g. A user might want to know if their SSH connection is alive without interrupting anything, while having no access both to SysRq and console, and no one in fg pgrp actually handles SIGINFO.If you have access to a tty, you should have access to sysrq, right?
No. This is supposed to work over ssh. SysRq is not supposed to work over ssh; that would be a security hole.
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH v2 7/7] n_tty: Provide an informational line on VSTATUS receipt
In reply to Greg Kroah-HartmanQuoted 9 lines · Greg Kroah-Hartman
Quoted 5 lines
SysRq is system-wide, whereas this is per-terminal and only cares about one tty which the status char is pressed at and its foreground pgrp (most likely it's the foreground shell job).
I hope this is clear enough.
It is, yes. My big objection is the crazy code I point out above, as well as the "create a totally new interface when we might be able to use an existing one" that you need to convince me is really required :)
It's not a new interface, it's a multiple decades old BSD interface our tcgetattr man page already mentions, which seems to be one of the big things BSD people miss when using Linux, and which I tried and failed to implement without kernel support months ago.
I wasn't involved in this kernel patch effort, I got pointed at news coverage about it by the Android Bionic maintainer:
http://lists.landley.net/pipermail/toybox-landley.net/2019-June/010536.html
Which is how I wound up cc'd on this thread.
I don't think Android specifically cares about SIGINFO, but they're trying to support building Android on MacOSX, which means trying to support building it on FreeBSD, which involves outreach to the BSD community, and they brought up the lack of ctrl-T and siginfo as a thing they really missed when having to deal with the Linux command line.
(The fact there _was_ news coverage of the patch for somebody to point me at may also be an indication of interest floating around out there...)
Rob
Re: [PATCH v2 7/7] n_tty: Provide an informational line on VSTATUS receipt
In reply to Greg Kroah-HartmanSorry for the delay, yesterday was rough.
Quoted 36 lines · Greg Kroah-Hartman
Quoted 22 lines · Arseny Maslennikov
Quoted 11 lines · Greg Kroah-Hartman
Quoted 7 lines · Arseny Maslennikov
If the three termios local flags isig, icanon, iexten are enabled and the local flag nokerninfo is disabled for a tty governed by the
n_ttyline discipline, then on receiving the keyboard status charactern_ttywill generate a status message and write it out to the tty before sending SIGINFO to the tty's foreground process group.<...>
Why is this really all needed as we have the SysRq handlers that report all of this today?
Different use-cases have different needs; SysRq is targeted at a different audience; see below.
Quoted 6 lines
Quoted 5 lines
The "most interesting" process is chosen as follows:
- runnables over everything
- uninterruptibles over everything else
- among 2 runnables pick the biggest utime + stime
- any unresolved ties are decided in favour of greatest PID.Quoted 5 lines
Quoted 2 lines
This does not feel like something that the tty core code should be doing at all.
Yes, this selection part is quite clumsy. In defense of it, one could argue that we already have the whole
n_ttyimplemented in kernel-space.One could argue that :)
Quoted 4 lines
One way we could get rid of this is to display a summarized statistic for the whole pgrp: pgid, oldest real time, cumulative utime and stime, cumulative memory usage. Would this be more acceptable? Are there any other ideas?
Quoted 9 lines
Given that I really think you are just making something up here that no one really is needing for their workflow, but would just be "cool to have", I say do whatever you think is right.
And there is nothing wrong with "cool to have" things, I'm not trying to dismiss this, it's just that all new features come with the "you must support this until the end of time" requirement that we must balance it with.
To be fair, the kerninfo line itself is intended for the user's eyes; it can't even be programmatically read by anyone in a Linux system except pty masters, so I don't feel it has to be particularly stable, since changing its contents won't break anyone.
So IMO we could still tweak something about it after we merge this. Of course this cannot be said about the signal part of the patch series, which interfaces with processes and is a proper part of the outward kernel API, thus subject to the kernel's policy.
Quoted 17 lines
Quoted 17 lines
Quoted 8 lines
Quoted 4 lines
While the kerninfo line is not very useful for debugging the kernel itself, since we have much more powerful debugging tools, it still gives the user behind the terminal some meaningful feedback to a VSTATUS that works even if no processes respond.
That's what SysRq is for. If there's a specific set of values that we don't currently report in that facility, why not just add the information there? It's much simpler and "safer" that way.
SysRq is intended for the person either administrating the system to be used in emergency (e.g. f for the oom kill, the famous s-u-b combo also comes to mind) or debugging the kernel, and it indeed does a much better job for those purposes. In both use-cases mentioned the person has access to the system console, where the sysrq button handlers produce all their output, if any, and to either a physical keyboard / serial console or to
/proc/sysrq-trigger, whose mode is 0200 (writable by uid 0 only).
Quoted 8 lines
Quoted 4 lines
The use-case for this is different: the ^T-line as proposed by this patch is for the user that interacts with a system through a terminal, who wants to be informed not about the whole system (sort of what SysRq-t tells you), but about what they run on that particular tty.
Ok, fair enough, although if you just add a new sysrq option for "what is running on this tty", would that help resolve this?
I see at least two problems here:
1) sysrq is not accessible by unprivileged users (and here goes the whole idea of sysrq being designed for different purposes, etc.)
2) Even if we fix it and somehow allow unpriv users to do the equivalent of `echo $letter > /proc/sysrq-trigger' for a particular letter, there still are UI issues. (yes, UI issues are better dealt with outside the kernel, but that's not the point) It still has to dump info to the particular tty (let's remember, console is unaccessible and shared to the whole system), that is a novelty for sysrq. There still is the open question about how to make a VSTATUS press trigger that sysrq button in addition to signalling fg pgrp without shoving this bit into every other userspace program.
To sum up, this looks worse to me than integrating with n_tty.
In general, the main appeal of the feature is in it being activated by a single keypress handled by the line discipline, from any tty.
Quoted 10 lines
Quoted 7 lines
This is much less about "why does my system/kernel seem to hang?" or exposing low-level internals (registers, hrtimers, locks, ...), and more about "is my SSH terminal session unresponsive?" and "I ran a command, it doesn't finish, how's it doing?".
e.g. A user might want to know if their SSH connection is alive without interrupting anything, while having no access both to SysRq and console, and no one in fg pgrp actually handles SIGINFO.If you have access to a tty, you should have access to sysrq, right?
No.
SSH gives you access to a pty, which doesn't seem to handle BREAK; the BREAK SysRq activation method does not work there.
As Pavel correctly noted, if the user is unprivileged, they can't use /proc/sysrq-trigger as well.
Quoted 10 lines
Quoted 5 lines
SysRq is system-wide, whereas this is per-terminal and only cares about one tty which the status char is pressed at and its foreground pgrp (most likely it's the foreground shell job).
I hope this is clear enough.
It is, yes. My big objection is the crazy code I point out above, as well as the "create a totally new interface when we might be able to use an existing one" that you need to convince me is really required :)
The signal part (patches [1-4]/7) is not really new, since we've had Unix-like signals for ages.
(You've probably meant the [5-7]/7, but there's no such thing as a too detailed explanation).
The compelling reasons for a new signal are:
- it provides asynchronous process notification, as opposed to e. g. a POLLIN on a file descriptor, which is not noticed by the recipient until they poll(2);
- to make use of the mechanism, an existing app does not have to be rewritten in a certain way — a signal handler just gets called, if the signal is not blocked — so it's easy to use from applications.
- it aligns well with the current practice of the line discipline relaying user requests to processes via signals.
As for the line: before I started writing the patch I thought a lot about how we could move the status line logic away from n_tty and, when ^T is pressed, have it notify someone in userspace, who would look up all the pieces in /proc and write() the line to the tty. Obviously this approach should be much more flexible and easier to maintain from the kernel perspective. One candidate for this could actually be the tty's session leader (most often that's the interactive shell).
To be convenient, the feature needs to have at least the following qualities:
- the status line has to come first, since it's the only invariant; this way it's easy to visually find if needed and just as easy to ignore otherwise;
- the reaction to VSTATUS has to be as responsive as it can reasonably be and as the system load allows. (btw, SysRq does well in this regard, but the drawbacks outweigh this, see above)
The only way we can secure the first point is to signal a process, wait for it to get scheduled, wait a little more for it to compose and send output, and only then to signal the pgrp and be done. This is potentially slow and might lock up the tty's input receive queue for sizable amounts of time. What if the session leader opts-in to do this and then ignores this kind of request / never responds altogether? This gets messy fast. So we can't guarantee the second point.
If we focus on responsiveness, we can't wait for processes at all, so we ping them and be done with it. This means no output ordering guarantees, it all gets interleaved and, consequently, less readable and less useful overall.
Further tweaking the protocol gives the risk of making it too complicated.
So I gave up on the idea and went with this patch, which ticks both boxes mentioned above. Of course, I'd love to have an ideal solution, and a pony too. :)
(Or perhaps I'm thinking inside the box and missing a clue and someone reading this does not. This is a public list, anyway)
Re: [PATCH v2 7/7] n_tty: Provide an informational line on VSTATUS receipt
In reply to Greg Kroah-HartmanQuoted 21 lines · Greg Kroah-Hartman
Quoted 6 lines · Arseny Maslennikov
If the three termios local flags isig, icanon, iexten are enabled and the local flag nokerninfo is disabled for a tty governed by the
n_ttyline discipline, then on receiving the keyboard status charactern_ttywill generate a status message and write it out to the tty before sending SIGINFO to the tty's foreground process group.Quoted 13 lines
This kerninfo line contains information about the current system load as well as some properties of "the most interesting" process in the tty's current foreground process group, namely:
- its PID as seen inside its deepest PID namespace;
* the whole process group ought to be in a single PID namespace, so this is actually deterministic
- its saved command name truncated to 16 bytes (task_struct::comm);
* at the time of writingTASK_COMM_LEN== 16
- its state and some related bits, procps-style;
- for S and D: its symbolic wait channel, if available; or a short description for other process states instead;
- its user, system and real rusage time values;
- its resident set size (as well as the high watermark) in kilobytes.
Quoted 2 lines
Why is this really all needed as we have the SysRq handlers that report all of this today?
People were lamenting the lack of siginfo in linux back in May, I offered to try to implement it, several people jumped in to offer suggestions, and it turns out you can't really do it without kernel support.
https://twitter.com/landley/status/1131764323196522498
Quoted 8 lines
Quoted 5 lines
The "most interesting" process is chosen as follows:
- runnables over everything
- uninterruptibles over everything else
- among 2 runnables pick the biggest utime + stime
- any unresolved ties are decided in favour of greatest PID.This does not feel like something that the tty core code should be doing at all.
I couldn't figure out how to do it without kernel support when I tried.
http://lists.landley.net/pipermail/toybox-landley.net/2019-May/010461.html
Rob
Quoted 79 lines · Arseny Maslennikov
This patch series introduces TTY keyboard status request, a feature of the
n_ttyline discipline that reserves a character in struct termios (^T by default) and reacts to it by printing a short informational line to the terminal and sending a Unix signal to the tty's foreground process group. The processes may, in response to the signal, output a textual description of what they're doing.The feature has been present in a similar form at least in Free/Open/NetBSD; it would be nice to have something like this in Linux as well. There is an LKML thread[1] where users have previously expressed the rationale for this.
The current implementation does not break existing kernel API in any way, since, fortunately, all the architectures supported by the kernel happen to have at least 1 free byte in the termios control character array.
The series should cleanly apply to tty-next.
To thoroughly test these, one might need at least a patched stty among other tools, so I've brought up a simple initrd generator[2] which can be used to create a lightweight environment to boot up in a VM and to fiddle with.
[1] https://lore.kernel.org/lkml/1415200663.3247743.187387481.75CE9317@webmail.messagingengine.com/
[2] https://github.com/porrided/tty-kb-status-userspacev2 <- v1: removed useless debugging bits.
Discussion of v1:
https://lore.kernel.org/lkml/[email protected]/Arseny Maslennikov (7):
signal.h: Define SIGINFO on all architectures
tty: termios: Reserve space for VSTATUS in .c_cc
n_tty: Send SIGINFO to fg pgrp on status request characterlinux/signal.h: Ignore SIGINFO by default in new tasks
tty: Add NOKERNINFO lflag to termios
n_tty: ->ops->write: Cut core logic out to a separate function
n_tty: Provide an informational line on VSTATUS receiptarch/alpha/include/asm/termios.h | 4 +- arch/alpha/include/uapi/asm/termbits.h | 2 + arch/arm/include/uapi/asm/signal.h | 1 + arch/h8300/include/uapi/asm/signal.h | 1 + arch/ia64/include/asm/termios.h | 4 +- arch/ia64/include/uapi/asm/signal.h | 1 + arch/ia64/include/uapi/asm/termbits.h | 2 + arch/m68k/include/uapi/asm/signal.h | 1 + arch/mips/include/asm/termios.h | 4 +- arch/mips/include/uapi/asm/signal.h | 1 + arch/mips/include/uapi/asm/termbits.h | 2 + arch/parisc/include/asm/termios.h | 4 +- arch/parisc/include/uapi/asm/signal.h | 1 + arch/parisc/include/uapi/asm/termbits.h | 2 + arch/powerpc/include/asm/termios.h | 4 +- arch/powerpc/include/uapi/asm/signal.h | 1 + arch/powerpc/include/uapi/asm/termbits.h | 2 + arch/s390/include/asm/termios.h | 4 +- arch/s390/include/uapi/asm/signal.h | 1 + arch/sparc/include/asm/termios.h | 4 +- arch/sparc/include/uapi/asm/signal.h | 2 + arch/sparc/include/uapi/asm/termbits.h | 2 + arch/x86/include/uapi/asm/signal.h | 1 + arch/xtensa/include/uapi/asm/signal.h | 1 + arch/xtensa/include/uapi/asm/termbits.h | 2 + drivers/tty/Makefile | 3 +- drivers/tty/n_tty.c | 70 ++++- drivers/tty/n_tty_status.c | 337 +++++++++++++++++++++++ include/asm-generic/termios.h | 4 +- include/linux/sched.h | 7 + include/linux/signal.h | 5 +- include/linux/tty.h | 7 +- include/uapi/asm-generic/signal.h | 1 + include/uapi/asm-generic/termbits.h | 2 + 34 files changed, 457 insertions(+), 33 deletions(-) create mode 100644 drivers/tty/n_tty_status.c
Quoted 1 line
Date: Tue, 25 Jun 2019 19:11:46 +0300
Ping.
The series should cleanly apply to 5.3-rc2 and to tty-next as of writing this email.