Skip to contentSkip to conversation

deprecate -mem-path fallback to anonymous RAM

PATCH Superseded Igor Mammedov 4 participants 5 messages Jun 25, 2019 – Jun 26, 2019

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 deprecate -mem-path fallback to anonymous RAM

Fallback might affect guest or worse whole host performance or functionality if backing file were used to share guest RAM with another process.

Patch deprecates fallback so that we could remove it in future and ensure that QEMU will provide expected behavior and fail if it can't use user provided backing file.

---
v2:
* improve text language
(Markus Armbruster <[email protected]>)

 numa.c               | 6 ++++--
 qemu-deprecated.texi | 9 +++++++++
 2 files changed, 13 insertions(+), 2 deletions(-)
numa.c +4 -2
index 91a29138a2..c15e53e92d 100644
@@ -494,8 +494,10 @@ static void allocate_system_memory_nonnuma(MemoryRegion *mr, Object *owner,
             if (mem_prealloc) {
                 exit(1);
             }
-            error_report("falling back to regular RAM allocation.");
-
+            warn_report("falling back to regular RAM allocation");
+            error_printf("This is deprecated. Make sure that -mem-path "
+                         " specified path has sufficient resources to allocate"
+                         " -m specified RAM amount or QEMU will fail to start");
             /* Legacy behavior: if allocation failed, fall back to
              * regular RAM allocation.
              */
qemu-deprecated.texi +9 -0
index 2fe9b72121..1b7f3b10dc 100644
@@ -112,6 +112,15 @@ QEMU using implicit generic or board specific splitting rule.
 Use @option{memdev} with @var{memory-backend-ram} backend or @option{mem} (if
 it's supported by used machine type) to define mapping explictly instead.
 
+@subsection -mem-path fallback to RAM (since 4.1)
+Currently if guest RAM allocation from file pointed by @option{mem-path}
+fails, QEMU falls back to allocating from RAM, which might result
+in unpredictable behavior since the backing file specified by the user
+is ignored. In the future, users will be responsible for making sure
+the backing storage specified with @option{-mem-path} can actually provide
+the guest RAM configured with @option{-m} and fail to start up if RAM allocation
+is unsuccessful.
+
 @section QEMU Machine Protocol (QMP) commands
 
 @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)
Signature · 1 line
2.18.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Igor Mammedov

Fallback might affect guest or worse whole host performance or functionality if backing file were used to share guest RAM with another process.

Patch deprecates fallback so that we could remove it in future and ensure that QEMU will provide expected behavior and fail if it can't use user provided backing file.

Quoted 8 lines

---
v2:
* improve text language
(Markus Armbruster <[email protected]>)

 numa.c               | 6 ++++--
 qemu-deprecated.texi | 9 +++++++++
 2 files changed, 13 insertions(+), 2 deletions(-)

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#2 lore raw
In reply to Igor Mammedov
Quoted 8 lines · Igor Mammedov

Fallback might affect guest or worse whole host performance or functionality if backing file were used to share guest RAM with another process.

Patch deprecates fallback so that we could remove it in future and ensure that QEMU will provide expected behavior and fail if it can't use user provided backing file.

Quoted 6 lines

---
v2:
* improve text language
(Markus Armbruster <[email protected]>)

Is this deprecation introspectible? Does it need to be?

Do we even need a deprecation period, or can we declare this a bug fix (it was a bug that we didn't fail outright on an impossible request) and do it immediately?

If it is not a bug fix, perhaps it could be made introspectible by having a new boolean parameter to opt in to the failure now, rather than 2 releases from now?

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org
#3 lore raw
Quoted 16 lines · Eric Blake
Quoted 8 lines · Igor Mammedov

Fallback might affect guest or worse whole host performance or functionality if backing file were used to share guest RAM with another process.

Patch deprecates fallback so that we could remove it in future and ensure that QEMU will provide expected behavior and fail if it can't use user provided backing file.

Quoted 6 lines

---
v2:
* improve text language
(Markus Armbruster <[email protected]>)

Quoted 5 lines

Is this deprecation introspectible? Does it need to be?

Do we even need a deprecation period, or can we declare this a bug fix (it was a bug that we didn't fail outright on an impossible request) and do it immediately?

I think it is hard to call it a bug when we added explicit extra code to make it work as it does today.

It is really a misguided feature.

Quoted 3 lines

If it is not a bug fix, perhaps it could be made introspectible by having a new boolean parameter to opt in to the failure now, rather than 2 releases from now?

From libvirt's POV I don't see a need for introspection. There's no special action we need to take to deal with the new behaviour - it is ultimately just providing the behaviour we kind of assumed it already had.

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Reviewed-by on v2 1/1
#4 lore raw
In reply to Igor Mammedov
Quoted 23 lines · Igor Mammedov

Fallback might affect guest or worse whole host performance or functionality if backing file were used to share guest RAM with another process.

Patch deprecates fallback so that we could remove it in future and ensure that QEMU will provide expected behavior and fail if it can't use user provided backing file.

---
v2:
* improve text language
(Markus Armbruster <[email protected]>)

 numa.c               | 6 ++++--
 qemu-deprecated.texi | 9 +++++++++
 2 files changed, 13 insertions(+), 2 deletions(-)
numa.c +0 -0
index 91a29138a2..c15e53e92d 100644

numa.c static void allocate_system_memory_nonnuma(MemoryRegion *mr, Object *owner, · line 500

Quoted 9 lines
numa.c +4 -2
@@ -494,8 +494,10 @@ static void allocate_system_memory_nonnuma(MemoryRegion *mr, Object *owner,
             if (mem_prealloc) {
                 exit(1);
             }
-            error_report("falling back to regular RAM allocation.");
-
+            warn_report("falling back to regular RAM allocation");
+            error_printf("This is deprecated. Make sure that -mem-path "
+                         " specified path has sufficient resources to allocate"
+                         " -m specified RAM amount or QEMU will fail to start");

The "or QEMU will fail to start" is confusing, I'm afraid. *This* QEMU won't. A future QEMU may. Suggest to simply delete the confusing part.

Quoted 9 lines
numa.c +0 -0
             /* Legacy behavior: if allocation failed, fall back to
              * regular RAM allocation.
              */
qemu-deprecated.texi +0 -0
index 2fe9b72121..1b7f3b10dc 100644
@@ -112,6 +112,15 @@ QEMU using implicit generic or board specific splitting rule.
 Use @option{memdev} with @var{memory-backend-ram} backend or @option{mem} (if

qemu-deprecated.texi QEMU using implicit generic or board specific splitting rule. · line 122

Quoted 10 lines
qemu-deprecated.texi +8 -0
 it's supported by used machine type) to define mapping explictly instead.
 
+@subsection -mem-path fallback to RAM (since 4.1)
+Currently if guest RAM allocation from file pointed by @option{mem-path}
+fails, QEMU falls back to allocating from RAM, which might result
+in unpredictable behavior since the backing file specified by the user
+is ignored. In the future, users will be responsible for making sure
+the backing storage specified with @option{-mem-path} can actually provide
+the guest RAM configured with @option{-m} and fail to start up if RAM allocation
+is unsuccessful.

Grammar nit: the subject of "fail to start up" is "users", oopsie. Suggest ", and QEMU will fail to start up".

qemu-deprecated.texi QEMU using implicit generic or board specific splitting rule. · line 126

Quoted 4 lines
qemu-deprecated.texi +1 -0
+
 @section QEMU Machine Protocol (QMP) commands
 
 @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)

With these tweaks: