Skip to contentSkip to conversation

ARM: davinci: da830-evm: add missing regulator constraints for OHCI

PATCH In review Bartosz Golaszewski 2 participants 3 messages Jun 25, 2019 – Jul 1, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: davinci: da830-evm: add missing regulator constraints for OHCI

From: Bartosz Golaszewski <[email protected]>

We need to enable status changes for the fixed power supply for the USB controller.

Fixes 274e4c336192 ("ARM: davinci: da830-evm: add a fixed regulator for ohci-da8xx")
---
 arch/arm/mach-davinci/board-da830-evm.c | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-davinci/board-da830-evm.c +3 -0
index aba10a2bc6b9..a273ab25c668 100644
@@ -61,6 +61,9 @@ static struct regulator_consumer_supply da830_evm_usb_supplies[] = {
 static struct regulator_init_data da830_evm_usb_vbus_data = {
 	.consumer_supplies	= da830_evm_usb_supplies,
 	.num_consumer_supplies	= ARRAY_SIZE(da830_evm_usb_supplies),
+	.constraints    = {
+		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
+	},
 };
 
 static struct fixed_voltage_config da830_evm_usb_vbus = {
Signature · 1 line
2.21.0
#1 lore raw

PATCH 2/2 ARM: davinci: omapl138-hawk: add missing regulator constraints for OHCI

From: Bartosz Golaszewski <[email protected]>

We need to enable status changes for the fixed power supply for the USB controller.

Fixes 1d272894ec4f ("ARM: davinci: omapl138-hawk: add a fixed regulator for ohci-da8xx")
---
 arch/arm/mach-davinci/board-omapl138-hawk.c | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-davinci/board-omapl138-hawk.c +3 -0
index db177a6a7e48..5390a8630cf0 100644
@@ -306,6 +306,9 @@ static struct regulator_consumer_supply hawk_usb_supplies[] = {
 static struct regulator_init_data hawk_usb_vbus_data = {
 	.consumer_supplies	= hawk_usb_supplies,
 	.num_consumer_supplies	= ARRAY_SIZE(hawk_usb_supplies),
+	.constraints    = {
+		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
+	},
 };
 
 static struct fixed_voltage_config hawk_usb_vbus = {
Signature · 1 line
2.21.0
#2 lore raw
In reply to Bartosz Golaszewski
Quoted 8 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We need to enable status changes for the fixed power supply for the USB controller.

Fixes 274e4c336192 ("ARM: davinci: da830-evm: add a fixed regulator for ohci-da8xx")

For both these patches as well, the offending commit was introduced in v5.2 so I dropped the stable tag while applying.

Will send pull request tomorrow after some build and boot testing.

Thanks,
Sekhar