Skip to contentSkip to conversation

gpio: mockup: no need to check return value of debugfs_create functions

PATCH In review Bartosz Golaszewski 3 participants 4 messages Jun 26, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 gpio: mockup: no need to check return value of debugfs_create functions

From: Greg Kroah-Hartman <[email protected]>

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

Cc Bamvor Jian Zhang <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
[Bartosz: removed one more check for debugfs return value]

---
v1 -> v2:
- fix build warning found by kbuild
- fix build error found by kbuild

v2 -> v3:
- remove one more unnecessary ifdef

 drivers/gpio/gpio-mockup.c | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)
drivers/gpio/gpio-mockup.c +5 -16
index b6a4efce7c92..f1a9c0544e3f 100644
@@ -315,7 +315,6 @@ static void gpio_mockup_debugfs_setup(struct device *dev,
 				      struct gpio_mockup_chip *chip)
 {
 	struct gpio_mockup_dbgfs_private *priv;
-	struct dentry *evfile;
 	struct gpio_chip *gc;
 	const char *devname;
 	char *name;
@@ -325,32 +324,25 @@ static void gpio_mockup_debugfs_setup(struct device *dev,
 	devname = dev_name(&gc->gpiodev->dev);
 
 	chip->dbg_dir = debugfs_create_dir(devname, gpio_mockup_dbg_dir);
-	if (IS_ERR_OR_NULL(chip->dbg_dir))
-		goto err;
 
 	for (i = 0; i < gc->ngpio; i++) {
 		name = devm_kasprintf(dev, GFP_KERNEL, "%d", i);
 		if (!name)
-			goto err;
+			return;
 
 		priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
 		if (!priv)
-			goto err;
+			return;
 
 		priv->chip = chip;
 		priv->offset = i;
 		priv->desc = &gc->gpiodev->descs[i];
 
-		evfile = debugfs_create_file(name, 0200, chip->dbg_dir, priv,
-					     &gpio_mockup_debugfs_ops);
-		if (IS_ERR_OR_NULL(evfile))
-			goto err;
+		debugfs_create_file(name, 0200, chip->dbg_dir, priv,
+				    &gpio_mockup_debugfs_ops);
 	}
 
 	return;
-
-err:
-	dev_err(dev, "error creating debugfs files\n");
 }
 
 static int gpio_mockup_name_lines(struct device *dev,
@@ -447,8 +439,7 @@ static int gpio_mockup_probe(struct platform_device *pdev)
 	if (rv)
 		return rv;
 
-	if (!IS_ERR_OR_NULL(gpio_mockup_dbg_dir))
-		gpio_mockup_debugfs_setup(dev, chip);
+	gpio_mockup_debugfs_setup(dev, chip);
 
 	return 0;
 }
@@ -501,8 +492,6 @@ static int __init gpio_mockup_init(void)
 	}
 
 	gpio_mockup_dbg_dir = debugfs_create_dir("gpio-mockup", NULL);
-	if (IS_ERR_OR_NULL(gpio_mockup_dbg_dir))
-		gpio_mockup_err("error creating debugfs directory\n");
 
 	err = platform_driver_register(&gpio_mockup_driver);
 	if (err) {
Signature · 1 line
2.21.0
Reviewed-by on v3 1/1
#1 lore raw
Quoted 13 lines · Bartosz Golaszewski

From: Greg Kroah-Hartman <[email protected]>

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

Cc Bamvor Jian Zhang <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
[Bartosz: removed one more check for debugfs return value]
Quoted 7 lines

---
v1 -> v2:
- fix build warning found by kbuild
- fix build error found by kbuild

v2 -> v3:
- remove one more unnecessary ifdef

Looks good

Will you send me this in a pull request with the rest of the stuff you have queued?

Yours,
Linus Walleij

#2 lore raw

śr., 26 cze 2019 o 13:54 Linus Walleij <[email protected]> napisał(a):

Quoted 24 lines · Bartosz Golaszewski
Quoted 14 lines

From: Greg Kroah-Hartman <[email protected]>

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

Cc Bamvor Jian Zhang <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
[Bartosz: removed one more check for debugfs return value]
Quoted 7 lines

---
v1 -> v2:
- fix build warning found by kbuild
- fix build error found by kbuild

v2 -> v3:
- remove one more unnecessary ifdef

Quoted 8 lines

Looks good

Will you send me this in a pull request with the rest of the stuff you have queued?

Yours,
Linus Walleij

Yes, I'll do it shortly.

Bart

#3 lore raw
In reply to Bartosz Golaszewski
Quoted 6 lines · Bartosz Golaszewski

From: Greg Kroah-Hartman <[email protected]>

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

Quoted 6 lines
Cc Bamvor Jian Zhang <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
[Bartosz: removed one more check for debugfs return value]

THank you for making this change. I'm on the road all this week and have had very limited time for email and doing any work like this.

Your change looks good to me!

greg k-h