Skip to contentSkip to conversation

ARM: am3517-evm: Remove undefined pinmuxing

PATCH New Adam Ford 2 participants 4 messages Jun 26, 2019 – Jul 27, 2019

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 ARM: am3517-evm: Remove undefined pinmuxing

The pinmux controller on AM3517 is the same as OMAP3, however according to the AM3517 TRM, there are no valid entries between 48002180 and 48002210, which are supported by other OMAP3 devices. This patch removes the references undefined pin muxing.

board/logicpd/am3517evm/am3517evm.h +0 -12
index 99a08032e0..94d8802b9b 100644
@@ -294,18 +294,6 @@ const omap3_sysinfo sysinfo = {
 	MUX_VAL(CP(HECC1_TXD),		(IEN  | PTU | EN  | M0)) \
 	MUX_VAL(CP(HECC1_RXD),		(IEN  | PTU | EN  | M0)) \
 	/* HSUSB */\
-	MUX_VAL(CP(HSUSB0_CLK),		(IEN  | PTD | DIS | M0)) \
-	MUX_VAL(CP(HSUSB0_STP),		(IDIS | PTU | EN  | M0)) \
-	MUX_VAL(CP(HSUSB0_DIR),		(IEN  | PTD | DIS | M0)) \
-	MUX_VAL(CP(HSUSB0_NXT),		(IEN  | PTD | DIS | M0)) \
-	MUX_VAL(CP(HSUSB0_DATA0),	(IEN  | PTD | DIS | M0)) \
-	MUX_VAL(CP(HSUSB0_DATA1),	(IEN  | PTD | DIS | M0)) \
-	MUX_VAL(CP(HSUSB0_DATA2),	(IEN  | PTD | DIS | M0)) \
-	MUX_VAL(CP(HSUSB0_DATA3),	(IEN  | PTD | DIS | M0)) \
-	MUX_VAL(CP(HSUSB0_DATA4),	(IEN  | PTD | DIS | M0)) \
-	MUX_VAL(CP(HSUSB0_DATA5),	(IEN  | PTD | DIS | M0)) \
-	MUX_VAL(CP(HSUSB0_DATA6),	(IEN  | PTD | DIS | M0)) \
-	MUX_VAL(CP(HSUSB0_DATA7),	(IEN  | PTD | DIS | M0)) \
 	MUX_VAL(CP(USB0_DRVBUS),	(IEN  | PTD | EN  | M0)) \
 	/* HDQ */\
 	MUX_VAL(CP(HDQ_SIO),		(IEN  | PTU | EN  | M0)) \
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/1 ARM: am3517-evm: Remove undefined pinmuxing

Quoted 6 lines · Adam Ford

The pinmux controller on AM3517 is the same as OMAP3, however according to the AM3517 TRM, there are no valid entries between 48002180 and 48002210, which are supported by other OMAP3 devices. This patch removes the references undefined pin muxing.

Please do NOT apply this patch.

It seems to work OK on newer hardware, but this patch appears to break older hardware, but I am not sure why since these registers are not listed in the TRM.

Thank you,

adam

Quoted 28 lines
board/logicpd/am3517evm/am3517evm.h +0 -13
index 99a08032e0..94d8802b9b 100644
@@ -294,18 +294,6 @@ const omap3_sysinfo sysinfo = {
        MUX_VAL(CP(HECC1_TXD),          (IEN  | PTU | EN  | M0)) \
        MUX_VAL(CP(HECC1_RXD),          (IEN  | PTU | EN  | M0)) \
        /* HSUSB */\
-       MUX_VAL(CP(HSUSB0_CLK),         (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_STP),         (IDIS | PTU | EN  | M0)) \
-       MUX_VAL(CP(HSUSB0_DIR),         (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_NXT),         (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA0),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA1),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA2),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA3),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA4),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA5),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA6),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA7),       (IEN  | PTD | DIS | M0)) \
        MUX_VAL(CP(USB0_DRVBUS),        (IEN  | PTD | EN  | M0)) \
        /* HDQ */\
        MUX_VAL(CP(HDQ_SIO),            (IEN  | PTU | EN  | M0)) \
--

2.17.1

author
#2 lore raw

PATCH 1/1 ARM: am3517-evm: Remove undefined pinmuxing

Quoted 8 lines · Adam Ford
Quoted 6 lines · Adam Ford

The pinmux controller on AM3517 is the same as OMAP3, however according to the AM3517 TRM, there are no valid entries between 48002180 and 48002210, which are supported by other OMAP3 devices. This patch removes the references undefined pin muxing.

Tom,

I noticed this was in your ti branch. I was hoping you could avoid applying it because it breaks older hardware.

adam

Quoted 38 lines

Please do NOT apply this patch.

It seems to work OK on newer hardware, but this patch appears to break older hardware, but I am not sure why since these registers are not listed in the TRM.

Thank you,

adam

Quoted 28 lines
board/logicpd/am3517evm/am3517evm.h +0 -13
index 99a08032e0..94d8802b9b 100644
@@ -294,18 +294,6 @@ const omap3_sysinfo sysinfo = {
        MUX_VAL(CP(HECC1_TXD),          (IEN  | PTU | EN  | M0)) \
        MUX_VAL(CP(HECC1_RXD),          (IEN  | PTU | EN  | M0)) \
        /* HSUSB */\
-       MUX_VAL(CP(HSUSB0_CLK),         (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_STP),         (IDIS | PTU | EN  | M0)) \
-       MUX_VAL(CP(HSUSB0_DIR),         (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_NXT),         (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA0),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA1),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA2),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA3),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA4),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA5),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA6),       (IEN  | PTD | DIS | M0)) \
-       MUX_VAL(CP(HSUSB0_DATA7),       (IEN  | PTD | DIS | M0)) \
        MUX_VAL(CP(USB0_DRVBUS),        (IEN  | PTD | EN  | M0)) \
        /* HDQ */\
        MUX_VAL(CP(HDQ_SIO),            (IEN  | PTU | EN  | M0)) \
--

2.17.1

#3 lore raw

PATCH 1/1 ARM: am3517-evm: Remove undefined pinmuxing

Quoted 10 lines · Adam Ford
Quoted 8 lines · Adam Ford
Quoted 6 lines · Adam Ford

The pinmux controller on AM3517 is the same as OMAP3, however according to the AM3517 TRM, there are no valid entries between 48002180 and 48002210, which are supported by other OMAP3 devices. This patch removes the references undefined pin muxing.

Quoted 4 lines

Tom,

I noticed this was in your ti branch. I was hoping you could avoid applying it because it breaks older hardware.

Thanks for the reminder, dropped!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190727/6b73ab43/attachment.sig>