Skip to contentSkip to conversation

drivers: kernel: sched: Fix return value assignment

PATCH New Jiunn Chang 3 participants 7 messages Jun 26, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: kernel: sched: Fix return value assignment

hrtimer_forward_now() returns u64, so change overrun to u64.

Signed-off-by Jiunn Chang <c0d1n61at3 at gmail.com>
---
 kernel/sched/fair.c | 2 +-
 kernel/sched/rt.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched/fair.c +1 -1
index f35930f5e528..c6bcae7d4e49 100644
@@ -4896,7 +4896,7 @@ static enum hrtimer_restart sched_cfs_period_timer(struct hrtimer *timer)
 	struct cfs_bandwidth *cfs_b =
 		container_of(timer, struct cfs_bandwidth, period_timer);
 	unsigned long flags;
-	int overrun;
+	u64 overrun;
 	int idle = 0;
 	int count = 0;
 
kernel/sched/rt.c +1 -1
index 1e6b909dca36..f5d3893914f5 100644
@@ -19,7 +19,7 @@ static enum hrtimer_restart sched_rt_period_timer(struct hrtimer *timer)
 	struct rt_bandwidth *rt_b =
 		container_of(timer, struct rt_bandwidth, rt_period_timer);
 	int idle = 0;
-	int overrun;
+	u64 overrun;
 
 	raw_spin_lock(&rt_b->rt_runtime_lock);
 	for (;;) {
Signature · 1 line
2.22.0
#1 lore raw

PATCH 1/1 drivers: media: pci: cx88: Fix return value assignment

hrtimer_forward_now() returns u64, so change missed to u64.

Signed-off-by Jiunn Chang <c0d1n61at3 at gmail.com>
---
 drivers/media/pci/cx88/cx88-input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/pci/cx88/cx88-input.c +1 -1
index 27f690b54e0c..fa5ce464b0ba 100644
@@ -167,7 +167,7 @@ static void cx88_ir_handle_key(struct cx88_IR *ir)
 
 static enum hrtimer_restart cx88_ir_work(struct hrtimer *timer)
 {
-	unsigned long missed;
+	u64 missed;
 	struct cx88_IR *ir = container_of(timer, struct cx88_IR, timer);
 
 	cx88_ir_handle_key(ir);
Signature · 1 line
2.22.0
#2 lore raw

PATCH 1/1 drivers: media: pci: cx88: Fix return value assignment

Quoted 23 lines · Jiunn Chang

hrtimer_forward_now() returns u64, so change missed to u64.

Signed-off-by Jiunn Chang <c0d1n61at3 at gmail.com>
---
 drivers/media/pci/cx88/cx88-input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/pci/cx88/cx88-input.c +1 -1
index 27f690b54e0c..fa5ce464b0ba 100644
@@ -167,7 +167,7 @@ static void cx88_ir_handle_key(struct cx88_IR *ir)
 
 static enum hrtimer_restart cx88_ir_work(struct hrtimer *timer)
 {
-	unsigned long missed;
+	u64 missed;
 	struct cx88_IR *ir = container_of(timer, struct cx88_IR, timer);
 
 	cx88_ir_handle_key(ir);
Signature · 1 line
2.22.0

Hello,

Looks like this patch was already submitted by someone else.

Please ignore unless the other patches have been dropped.

Regards,

Jiunn

#3 lore raw

PATCH 1/1 drivers: rtc: Fix return value assignment

In reply to Jiunn Chang

hrtimer_forward_now() returns u64, so change count to u64.

Signed-off-by Jiunn Chang <c0d1n61at3 at gmail.com>
---
 drivers/rtc/interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/interface.c +1 -1
index 4124f4dd376b..72b7ddc43116 100644
@@ -633,7 +633,7 @@ enum hrtimer_restart rtc_pie_update_irq(struct hrtimer *timer)
 {
 	struct rtc_device *rtc;
 	ktime_t period;
-	int count;
+	u64 count;
 
 	rtc = container_of(timer, struct rtc_device, pie_timer);
 
Signature · 1 line
2.22.0
#4 lore raw

PATCH 1/1 drivers: rtc: Fix return value assignment

Quoted 23 lines · Jiunn Chang

hrtimer_forward_now() returns u64, so change count to u64.

Signed-off-by Jiunn Chang <c0d1n61at3 at gmail.com>
---
 drivers/rtc/interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/interface.c +1 -1
index 4124f4dd376b..72b7ddc43116 100644
@@ -633,7 +633,7 @@ enum hrtimer_restart rtc_pie_update_irq(struct hrtimer *timer)
 {
 	struct rtc_device *rtc;
 	ktime_t period;
-	int count;
+	u64 count;
 
 	rtc = container_of(timer, struct rtc_device, pie_timer);
 
Signature · 1 line
2.22.0

Hello,

Looks like this patch was already submitted by someone else.

Please ignore unless the other patches have been dropped.

Regards,

Jiunn

#5 lore raw

PATCH 1/1 drivers: rtc: Fix return value assignment

In reply to Jiunn Chang

Hello,

Please do use subject lines matching the style for the subsystem.

Also, you should definitively send patches to the subsystem mailing list so that tools like patchwork would see them.

Quoted 12 lines · Jiunn Chang

hrtimer_forward_now() returns u64, so change count to u64.

Signed-off-by Jiunn Chang <c0d1n61at3 at gmail.com>
---
 drivers/rtc/interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/interface.c +0 -0
index 4124f4dd376b..72b7ddc43116 100644

drivers/rtc/interface.c enum hrtimer_restart rtc_pie_update_irq(struct hrtimer *timer) · line 637

Quoted 6 lines
drivers/rtc/interface.c +1 -1
@@ -633,7 +633,7 @@ enum hrtimer_restart rtc_pie_update_irq(struct hrtimer *timer)
 {
 	struct rtc_device *rtc;
 	ktime_t period;
-	int count;
+	u64 count;
 

Finally, I'm sorry but someone already beat you to it (and made almost the same mistakes):

https://patchwork.ozlabs.org/patch/1117613/

Quoted 5 lines
drivers/rtc/interface.c +0 -0
 	rtc = container_of(timer, struct rtc_device, pie_timer);
 
Signature · 1 line
2.22.0
Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH 1/1 drivers: kernel: sched: Fix return value assignment

In reply to Jiunn Chang
Quoted 37 lines · Jiunn Chang

hrtimer_forward_now() returns u64, so change overrun to u64.

Signed-off-by Jiunn Chang <c0d1n61at3 at gmail.com>
---
 kernel/sched/fair.c | 2 +-
 kernel/sched/rt.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched/fair.c +1 -1
index f35930f5e528..c6bcae7d4e49 100644
@@ -4896,7 +4896,7 @@ static enum hrtimer_restart sched_cfs_period_timer(struct hrtimer *timer)
 	struct cfs_bandwidth *cfs_b =
 		container_of(timer, struct cfs_bandwidth, period_timer);
 	unsigned long flags;
-	int overrun;
+	u64 overrun;
 	int idle = 0;
 	int count = 0;
 
kernel/sched/rt.c +1 -1
index 1e6b909dca36..f5d3893914f5 100644
@@ -19,7 +19,7 @@ static enum hrtimer_restart sched_rt_period_timer(struct hrtimer *timer)
 	struct rt_bandwidth *rt_b =
 		container_of(timer, struct rt_bandwidth, rt_period_timer);
 	int idle = 0;
-	int overrun;
+	u64 overrun;
 
 	raw_spin_lock(&rt_b->rt_runtime_lock);
 	for (;;) {
Signature · 1 line
2.22.0

Hello,

Looks like this patch was already submitted by someone else.

Please ignore unless the other patches have been dropped.

Regards,

Jiunn