mempool/octeontx2: fix build with ICC
PATCH 1/1 mempool/octeontx2: fix build with ICC
The Intel compiler is pickier about casts and generates:otx2_mempool_ops.c(344): error #191: type qualifier is meaningless on cast type
int64_t * const addr = (int64_t * const)
^
This is because of the nature of const.
In this example, the expression is being cast into a pointer
that can not be modified. This is meanlingless because the expression is already a lvalue.
See https://en.wikipedia.org/wiki/Const_(computer_programming)
--- drivers/mempool/octeontx2/otx2_mempool_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mempool/octeontx2/otx2_mempool_ops.c +1 -1
@@ -341,7 +341,7 @@ otx2_npa_deq(struct rte_mempool *mp, void **obj_table, unsigned int n)unsigned int index;uint64_t obj; -int64_t *const addr = (int64_t *const ) +int64_t *const addr = (int64_t *) (npa_lf_aura_handle_to_base (mp->pool_id) +NPA_LF_AURA_OP_ALLOCX (0 ));for (index =0 ; index < n; index++, obj_table++) {
Signature · 1 line
2.20.1
Quoted 9 lines · Stephen Hemminger
The Intel compiler is pickier about casts and generates:
otx2_mempool_ops.c(344): error #191: type qualifier is meaningless on cast type
int64_t* const addr = (int64_t* const)
^
This is because of the nature of const.
In this example, the expression is being cast into a pointer
that can not be modified. This is meanlingless because the expression is already a lvalue.
Quoted 4 lines
See https://en.wikipedia.org/wiki/Const_(computer_programming)
Fixes d7a0da3c0043 ("mempool/octeontx2: add fast path mempool ops")Signed-off-by Stephen Hemminger <[email protected]>
Applied, thanks.