staging: erofs: return the error value if fill_inline_data() fails
PATCH RESEND v2 1/1 staging: erofs: return the error value if fill_inline_data() fails
From: Yue Hu <[email protected]>
We should consider the error returned by fill_inline_data() when filling last page in fill_inode(). If not getting inode will be successful even though last page is bad. That is illogical. Also change -EAGAIN to 0 in fill_inline_data() to stand for successful filling.
Signed-off-by Yue Hu <huyue2 at yulong.com>
Reviewed-by Gao Xiang <gaoxiang25 at huawei.com>
Reviewed-by Chao Yu <yuchao0 at huawei.com>
---
no change
drivers/staging/erofs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/erofs/inode.c +2 -2
@@ -156,7 +156,7 @@ static int fill_inline_data(struct inode *inode, void *data, inode->i_link = lnk;set_inode_fast_symlink (inode); } -return -EAGAIN ; +return 0 ; }static int fill_inode (struct inode *inode,int isdir)
@@ -223,7 +223,7 @@ static int fill_inode(struct inode *inode, int isdir) inode->i_mapping->a_ops = &erofs_raw_access_aops;/* fill last page if inline data is available */ -fill_inline_data (inode, data, ofs); + err =fill_inline_data (inode, data, ofs); } out_unlock:
Signature · 1 line
1.9.1