ath11k: add hal dbg mask and utilized for hal stats
PATCH 1/1 ath11k: add hal dbg mask and utilized for hal stats
Added HAL debug mask. Replaced use of ath11k_info() in ath11k_hal_reo_status_queue_stats() with ath11k_dbg(), which utilizes new HAL debug mask.
--- drivers/net/wireless/ath/ath11k/debug.h | 1 + drivers/net/wireless/ath/ath11k/hal_rx.c | 24 ++++++++++++------------ 2 files changed, 13 insertions(+), 12 deletions(-)
drivers/net/wireless/ath/ath11k/debug.h +1 -0
@@ -21,6 +21,7 @@ enum ath11k_debug_mask {ATH11K_DBG_MGMT =0x00000100 ,ATH11K_DBG_REG =0x00000200 ,ATH11K_DBG_TESTMODE =0x00000400 , + ATH11k_DBG_HAL =0x00000800 , ATH11K_DBG_ANY = 0xffffffff, };
drivers/net/wireless/ath/ath11k/hal_rx.c +12 -12
@@ -482,30 +482,30 @@ void ath11k_hal_reo_status_queue_stats(struct ath11k_base *ab, u32 *reo_desc,FIELD_GET (HAL_REO_STATUS_HDR_INFO0_EXEC_STATUS , desc->hdr.info0); -ath11k_info (ab,"Queue stats status:\n" ); -ath11k_info (ab,"header: cmd_num %d status %d\n" , +ath11k_dbg (ab, ATH11k_DBG_HAL,"Queue stats status:\n" ); +ath11k_dbg (ab, ATH11k_DBG_HAL,"header: cmd_num %d status %d\n" , status->uniform_hdr.cmd_num, status->uniform_hdr.cmd_status); -ath11k_info (ab,"ssn %ld cur_idx %ld\n" , +ath11k_dbg (ab, ATH11k_DBG_HAL,"ssn %ld cur_idx %ld\n" ,FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO0_SSN , desc->info0),FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO0_CUR_IDX , desc->info0)); -ath11k_info (ab,"pn = [%08x, %08x, %08x, %08x]\n" , +ath11k_dbg (ab, ATH11k_DBG_HAL,"pn = [%08x, %08x, %08x, %08x]\n" , desc->pn[0 ], desc->pn[1 ], desc->pn[2 ], desc->pn[3 ]); -ath11k_info (ab,"last_rx: enqueue_tstamp %08x dequeue_tstamp %08x\n" , +ath11k_dbg (ab, ATH11k_DBG_HAL,"last_rx: enqueue_tstamp %08x dequeue_tstamp %08x\n" , desc->last_rx_enqueue_timestamp, desc->last_rx_dequeue_timestamp); -ath11k_info (ab,"rx_bitmap [%08x %08x %08x %08x %08x %08x %08x %08x]\n" , +ath11k_dbg (ab, ATH11k_DBG_HAL,"rx_bitmap [%08x %08x %08x %08x %08x %08x %08x %08x]\n" , desc->rx_bitmap[0 ], desc->rx_bitmap[1 ], desc->rx_bitmap[2 ], desc->rx_bitmap[3 ], desc->rx_bitmap[4 ], desc->rx_bitmap[5 ], desc->rx_bitmap[6 ], desc->rx_bitmap[7 ]); -ath11k_info (ab,"count: cur_mpdu %ld cur_msdu %ld\n" , +ath11k_dbg (ab, ATH11k_DBG_HAL,"count: cur_mpdu %ld cur_msdu %ld\n" ,FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO1_MPDU_COUNT , desc->info1),FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO1_MSDU_COUNT , desc->info1)); - ath11k_info(ab, "fwd_timeout %ld fwd_bar %ld dup_count %ld\n", + ath11k_dbg(ab, ATH11k_DBG_HAL, "fwd_timeout %ld fwd_bar %ld dup_count %ld\n", FIELD_GET( HAL_REO_GET_QUEUE_STATS_STATUS_INFO2_TIMEOUT_COUNT, desc->info2),
@@ -514,22 +514,22 @@ void ath11k_hal_reo_status_queue_stats(struct ath11k_base *ab, u32 *reo_desc,FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO2_DUPLICATE_COUNT , desc->info2)); -ath11k_info (ab,"frames_in_order %ld bar_rcvd %ld\n" , +ath11k_dbg (ab, ATH11k_DBG_HAL,"frames_in_order %ld bar_rcvd %ld\n" ,FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO3_FIO_COUNT , desc->info3),FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO3_BAR_RCVD_CNT , desc->info3)); -ath11k_info (ab,"num_mpdus %d num_msdus %d total_bytes %d\n" , +ath11k_dbg (ab, ATH11k_DBG_HAL,"num_mpdus %d num_msdus %d total_bytes %d\n" , desc->num_mpdu_frames, desc->num_msdu_frames, desc->total_bytes); -ath11k_info (ab,"late_rcvd %ld win_jump_2k %ld hole_cnt %ld\n" , +ath11k_dbg (ab, ATH11k_DBG_HAL,"late_rcvd %ld win_jump_2k %ld hole_cnt %ld\n" ,FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO4_LATE_RX_MPDU , desc->info4),FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO4_WINDOW_JMP2K , desc->info4),FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO4_HOLE_COUNT , desc->info4)); -ath11k_info (ab,"looping count %ld\n" , +ath11k_dbg (ab, ATH11k_DBG_HAL,"looping count %ld\n" ,FIELD_GET (HAL_REO_GET_QUEUE_STATS_STATUS_INFO5_LOOPING_CNT , desc->info5)); }
Signature · 7 lines
2.7.4 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 5 lines · Muna Sinada
Added HAL debug mask. Replaced use of
ath11k_info()inath11k_hal_reo_status_queue_stats()withath11k_dbg(), which utilizes new HAL debug mask.Signed-off-by Muna Sinada <[email protected]>
This added new checkpatch warnings:
drivers/net/wireless/ath/ath11k/hal_rx.c:492: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hal_rx.c:495: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hal_rx.c:500: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hal_rx.c:502: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hal_rx.c:505: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hal_rx.c:509: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hal_rx.c:514: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hal_rx.c:523: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hal_rx.c:528: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hal_rx.c:531: Alignment should match open parenthesis drivers/net/wireless/ath/ath11k/hal_rx.c:538: Alignment should match open parenthesis
I fixed them in the pending branch:
Signature · 6 lines
Kalle Valo _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 6 lines · Muna Sinada
Added HAL debug mask. Replaced use of
ath11k_info()inath11k_hal_reo_status_queue_stats()withath11k_dbg(), which utilizes new HAL debug mask.Signed-off-by Muna Sinada <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath11k-bringup branch of ath.git, thanks.
a84ef1e54ac9 ath11k: add hal dbg mask and utilized for hal stats
Signature · 9 lines
https://patchwork.kernel.org/patch/11016319/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k