Skip to contentSkip to conversation

glibc: Fix locale DEPENDS

PATCH In review Joshua Watt 5 participants 9 messages Jun 27, 2019 – Aug 27, 2019

lore
Share & tools
lore

Joshua Watt

author
#0 lore raw

PATCH 1/1 glibc: Fix locale DEPENDS

gettext is required to generate the glibc locales in do_compile. If not present, glibc will skip the generation which isn't reproducible.

Signed-off-by Joshua Watt <[email protected]>
---
 meta/recipes-core/glibc/glibc_2.29.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.29.bb +1 -1
index 073d1533e37..c400ee10b0f 100644
@@ -5,7 +5,7 @@ LIC_FILES_CHKSUM = "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72 \
       file://posix/rxspencer/COPYRIGHT;md5=dc5485bb394a13b2332ec1c785f5d83a \
       file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
 
-DEPENDS += "gperf-native bison-native make-native"
+DEPENDS += "gperf-native bison-native make-native gettext-native"
 
 PV = "2.29"
Signature · 1 line
2.21.0
#1 lore raw
Quoted 13 lines · Joshua Watt

gettext is required to generate the glibc locales in do_compile. If not present, glibc will skip the generation which isn't reproducible.

Signed-off-by Joshua Watt <[email protected]>
---
 meta/recipes-core/glibc/glibc_2.29.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.29.bb +0 -0
index 073d1533e37..c400ee10b0f 100644

meta/recipes-core/glibc/glibc_2.29.bb LIC_FILES_CHKSUM = "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72 \ · line 8

Quoted 5 lines
meta/recipes-core/glibc/glibc_2.29.bb +1 -1
@@ -5,7 +5,7 @@ LIC_FILES_CHKSUM = "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72 \
       file://posix/rxspencer/COPYRIGHT;md5=dc5485bb394a13b2332ec1c785f5d83a \
       file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
 
-DEPENDS += "gperf-native bison-native make-native"
+DEPENDS += "gperf-native bison-native make-native gettext-native"

Dont we want this to respect the NLS flag or similar?

Ross

author
#2 lore raw
Quoted 17 lines · Ross
Quoted 16 lines · Joshua Watt

gettext is required to generate the glibc locales in do_compile. If not present, glibc will skip the generation which isn't reproducible.

Signed-off-by Joshua Watt <[email protected]>
---
  meta/recipes-core/glibc/glibc_2.29.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.29.bb +0 -0
index 073d1533e37..c400ee10b0f 100644
@@ -5,7 +5,7 @@ LIC_FILES_CHKSUM = "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72 \
        file://posix/rxspencer/COPYRIGHT;md5=dc5485bb394a13b2332ec1c785f5d83a \
        file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
Quoted 3 lines

meta/recipes-core/glibc/glibc_2.29.bb LIC_FILES_CHKSUM = "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72 \ · line 8

Quoted 2 lines
meta/recipes-core/glibc/glibc_2.29.bb +1 -1
-DEPENDS += "gperf-native bison-native make-native"
+DEPENDS += "gperf-native bison-native make-native gettext-native"

Dont we want this to respect the NLS flag or similar?

Sorry, I'm not quite sure I follow... I didn't find anything related to NLS in the glibc recipes? Would you mind clarifying?

Quoted 2 lines

Ross

#3 lore raw
In reply to Joshua Watt
Quoted 3 lines · Joshua Watt

gettext is required to generate the glibc locales in do_compile. If not present, glibc will skip the generation which isn't reproducible.

I guess you mean not deterministic rather than not reproducible?

Quoted 26 lines
Signed-off-by Joshua Watt <[email protected]>
---
 meta/recipes-core/glibc/glibc_2.29.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.29.bb +1 -2
index 073d1533e37..c400ee10b0f 100644
@@ -5,7 +5,7 @@ LIC_FILES_CHKSUM = "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72 \
       file://posix/rxspencer/COPYRIGHT;md5=dc5485bb394a13b2332ec1c785f5d83a \
       file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
 
-DEPENDS += "gperf-native bison-native make-native"
+DEPENDS += "gperf-native bison-native make-native gettext-native"
 
 PV = "2.29"
 
--

2.21.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#4 lore raw
Quoted 4 lines · Andre McCurdy
Quoted 2 lines · Joshua Watt

gettext is required to generate the glibc locales in do_compile. If not present, glibc will skip the generation which isn't reproducible.

I guess you mean not deterministic rather than not reproducible?

Correct. I found all these in the context of trying to get reproducible builds working, but that is a more accurate statement.

Quoted 27 lines
Quoted 27 lines
Signed-off-by Joshua Watt <[email protected]>
---
  meta/recipes-core/glibc/glibc_2.29.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.29.bb +1 -2
index 073d1533e37..c400ee10b0f 100644
@@ -5,7 +5,7 @@ LIC_FILES_CHKSUM = "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72 \
        file://posix/rxspencer/COPYRIGHT;md5=dc5485bb394a13b2332ec1c785f5d83a \
        file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
 
-DEPENDS += "gperf-native bison-native make-native"
+DEPENDS += "gperf-native bison-native make-native gettext-native"
 
  PV = "2.29"
 
--

2.21.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#5 lore raw
In reply to Joshua Watt
Quoted 14 lines · Joshua Watt

gettext is required to generate the glibc locales in do_compile. If not present, glibc will skip the generation which isn't reproducible.

Signed-off-by Joshua Watt <[email protected]>
---
 meta/recipes-core/glibc/glibc_2.29.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.29.bb +0 -0
index 073d1533e37..c400ee10b0f 100644

meta/recipes-core/glibc/glibc_2.29.bb LIC_FILES_CHKSUM = · line 10

Quoted 7 lines
meta/recipes-core/glibc/glibc_2.29.bb +1 -1
@@ -5,7 +5,7 @@ LIC_FILES_CHKSUM =
 "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72 \
 
 file://posix/rxspencer/COPYRIGHT;md5=dc5485bb394a13b2332ec1c785f5d83a \
       file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
 
-DEPENDS += "gperf-native bison-native make-native"
+DEPENDS += "gperf-native bison-native make-native gettext-native"

I think we have had this dependency proposed in past and one think that worries me is that it will cause serialization a bit more and can affect bulls times wasn’t there a minimal gettext at some point and I wonder if that could satisfy needs here

Quoted 8 lines
meta/recipes-core/glibc/glibc_2.29.bb +0 -1
 PV = "2.29"
 
--

2.21.0

#6 lore raw

Are you thinking of gettext-minimal-native? It is used by gettext.bbclass if USE_NLS is “no”.

//Peter

From: [email protected] <[email protected]> On Behalf Of Khem Raj
Sent: den 28 juni 2019 18:37
To: Joshua Watt <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] glibc: Fix locale DEPENDS

On Thu, Jun 27, 2019 at 9:54 AM Joshua Watt <[email protected]<mailto:[email protected]>> wrote:
gettext is required to generate the glibc locales in do_compile. If not
present, glibc will skip the generation which isn't reproducible.

Signed-off-by Joshua Watt <[email protected]<mailto:[email protected]>>
---
 meta/recipes-core/glibc/glibc_2.29.bb<http://glibc_2.29.bb> | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.29.bb<http://glibc_2.29.bb> +1 -1
index 073d1533e37..c400ee10b0f 100644
@@ -5,7 +5,7 @@ LIC_FILES_CHKSUM = "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72 \
       file://posix/rxspencer/COPYRIGHT;md5=dc5485bb394a13b2332ec1c785f5d83a \
       file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c<file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72%20/%0b %20 %20 %20 file:/posix/rxspencer/COPYRIGHT;md5=dc5485bb394a13b2332ec1c785f5d83a%20/%0b %20 %20 %20 file:/COPYING.LIB;md5=4fbd65380cdd255951079008b364516c>"
 
-DEPENDS += "gperf-native bison-native make-native"
+DEPENDS += "gperf-native bison-native make-native gettext-native"

I think we have had this dependency proposed in past and one think that worries me is that it will cause serialization a bit more and can affect bulls times wasn’t there a minimal gettext at some point and I wonder if that could satisfy needs here

PV = "2.29"

--
2.21.0

#7 lore raw

Yes, I think so.

Quoted 61 lines · Peter Kjellerstedt

Are you thinking of gettext-minimal-native? It is used by gettext.bbclass if USE_NLS is “no”.

//Peter

*From:* [email protected] < [email protected]> *On Behalf Of *Khem Raj *Sent:* den 28 juni 2019 18:37
*To:* Joshua Watt <[email protected]>
*Cc:* [email protected]
*Subject:* Re: [OE-core] [PATCH] glibc: Fix locale DEPENDS

On Thu, Jun 27, 2019 at 9:54 AM Joshua Watt <[email protected]> wrote:

gettext is required to generate the glibc locales in do_compile. If not present, glibc will skip the generation which isn't reproducible.

Signed-off-by Joshua Watt <[email protected]>
---
 meta/recipes-core/glibc/glibc_2.29.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.29.bb +1 -1
index 073d1533e37..c400ee10b0f 100644
@@ -5,7 +5,7 @@ LIC_FILES_CHKSUM = "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72
 \
 
 file://posix/rxspencer/COPYRIGHT;md5=dc5485bb394a13b2332ec1c785f5d83a \
       file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
 
-DEPENDS += "gperf-native bison-native make-native"
+DEPENDS += "gperf-native bison-native make-native gettext-native"

I think we have had this dependency proposed in past and one think that worries me is that it will cause serialization a bit more and can affect bulls times wasn’t there a minimal gettext at some point and I wonder if that could satisfy needs here

PV = "2.29"

--
2.21.0

author
#8 lore raw
Quoted 2 lines · Khem Raj

Yes, I think so.

Oops, I forgot to mark the latest patch in-reply-to this one. It's
here: http://lists.openembedded.org/pipermail/openembedded-core/2019-August/286123.html

Quoted 54 lines · Peter Kjellerstedt
Quoted 52 lines

Are you thinking of gettext-minimal-native? It is used by gettext.bbclass if USE_NLS is “no”.

//Peter

From: [email protected] <[email protected]> On Behalf Of Khem Raj
Sent: den 28 juni 2019 18:37
To: Joshua Watt <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] glibc: Fix locale DEPENDS

On Thu, Jun 27, 2019 at 9:54 AM Joshua Watt <[email protected]> wrote:

gettext is required to generate the glibc locales in do_compile. If not present, glibc will skip the generation which isn't reproducible.

Signed-off-by Joshua Watt <[email protected]>
---
 meta/recipes-core/glibc/glibc_2.29.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.29.bb +1 -1
index 073d1533e37..c400ee10b0f 100644
@@ -5,7 +5,7 @@ LIC_FILES_CHKSUM = "file://LICENSES;md5=cfc0ed77a9f62fa62eded042ebe31d72 \
       file://posix/rxspencer/COPYRIGHT;md5=dc5485bb394a13b2332ec1c785f5d83a \
       file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
 
-DEPENDS += "gperf-native bison-native make-native"
+DEPENDS += "gperf-native bison-native make-native gettext-native"

I think we have had this dependency proposed in past and one think that worries me is that it will cause serialization a bit more and can affect bulls times wasn’t there a minimal gettext at some point and I wonder if that could satisfy needs here

PV = "2.29"

--
2.21.0