tests/i915/gem_ctx_switch: Update with engine discovery
PATCH 1/1 tests/i915/gem_ctx_switch: Update with engine discovery
From: Tvrtko Ursulin <[email protected]>
I converted this one as an example, or at least to drive the discussion, how more complex tests can be converted.
I have kept the legacy execbuf abi testing prefixed with "legacy-".
New tests were added to exercise physical engines via engine discovery and also "all" tests have been updated in the same way.
To keep things simpler and avoid having to create separate contexts legacy tests have to be first since the __for_each_physical_engine iterator would otherwise configure the default context and confuse the test.
So legacy tests run on the unconfigured (with engine map) context and use a new helper gem_eb_flags_to_engine to look up the engine from the intel_execution_engines2 static list. This is only to enable the core test code to be shared.
Places where new contexts are created had to be updated to either equally configure the contexts or not. Another new helper, gem_context_has_engine_map was added to enable this.
Also beware of drive-by formatting changes.
--- lib/i915/gem_engine_topology.c | 27 +++++ lib/i915/gem_engine_topology.h | 5 + tests/i915/gem_ctx_switch.c | 138 ++++++++++++++++++-------- tests/intel-ci/blacklist.txt | 2 +- tests/intel-ci/fast-feedback.testlist | 3 +- 5 files changed, 132 insertions(+), 43 deletions(-)
lib/i915/gem_engine_topology.c +27 -0
@@ -289,3 +289,30 @@ bool gem_has_engine_topology(int fd)return !__gem_context_get_param (fd, ¶m); } + +const struct intel_execution_engine2 * +gem_eb_flags_to_engine (unsigned int flags) +{ +const struct intel_execution_engine2 *e2; + +__for_each_static_engine (e2) { +if (e2->flags == flags) +return e2; + } + +return NULL ; +} + +bool gem_context_has_engine_map (int fd,uint32_t ctx) +{ +struct drm_i915_gem_context_param param = { + .param =I915_CONTEXT_PARAM_ENGINES , + .ctx_id = ctx + }; +int ret; + + ret =__gem_context_get_param (fd, ¶m); +igt_assert_eq (ret,0 ); + +return param.size; +}
lib/i915/gem_engine_topology.h +5 -0
@@ -53,6 +53,11 @@ int gem_context_lookup_engine(int fd, uint64_t engine, uint32_t ctx_id,void gem_context_set_all_engines (int fd,uint32_t ctx); +bool gem_context_has_engine_map (int fd,uint32_t ctx); + +const struct intel_execution_engine2 * +gem_eb_flags_to_engine (unsigned int flags); +#define __for_each_static_engine (e__) \ for ((e__) = intel_execution_engines2; (e__)->name; (e__)++)
tests/i915/gem_ctx_switch.c +97 -41
278 lines not on this page · raw message
tests/intel-ci/blacklist.txt +1 -1
@@ -25,7 +25,7 @@ igt@gem_cs_prefetch(@.*)? igt@gem_ctx_create@(?!.*basic).* igt@gem_ctx_exec@(?!.*basic).* igt@gem_ctx_shared@*exhaust* -igt@gem_ctx_switch@(?!.*basic).* +igt@gem_ctx_switch@.*(forked|interruptible).* igt@gem_ctx_thrash(@.*)? igt@gem_evict_alignment(@.*)? igt@gem_evict_everything(@.*)?
tests/intel-ci/fast-feedback.testlist +2 -1
@@ -14,7 +14,8 @@ igt@gem_ctx_create@basic-files igt@gem_ctx_exec@basic igt@gem_ctx_param@basic igt@gem_ctx_param@basic-default -igt@gem_ctx_switch@basic-default +igt@gem_ctx_switch@legacy-render +igt@gem_ctx_switch@rcs0 igt@gem_exec_basic@basic-all igt@gem_exec_create@basic igt@gem_exec_fence@basic-busy-default
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Tvrtko Ursulin (2019-06-27 11:20:19)
Quoted 57 lines
tests/i915/gem_ctx_switch.c +9
-6@@ -55,7 +55,7 @@ static double elapsed(const struct timespec *start, const struct timespec *end)static int measure_qlen (int fd,struct drm_i915_gem_execbuffer2 *execbuf, -unsigned int *engine,unsigned int nengine, +const struct intel_engine_data *engines,int timeout) { const struct drm_i915_gem_exec_object2 * const obj =@@ -63,15 +63,17 @@ static int measure_qlen(int fd,uint32_t ctx[64 ];int min =INT_MAX , max =0 ; -for (int i =0 ; i <ARRAY_SIZE (ctx); i++) +for (int i =0 ; i <ARRAY_SIZE (ctx); i++) { ctx[i] =gem_context_create (fd); +gem_context_set_all_engines (fd, ctx[i]); + } -for (unsigned int n =0 ; n < nengine; n++) { +for (unsigned int n =0 ; n < engines->nengines; n++) {uint64_t saved = execbuf->flags;struct timespec tv = {};int q; - execbuf->flags |= engine[n]; + execbuf->flags |= engines->engines[n].flags;for (int i =0 ; i <ARRAY_SIZE (ctx); i++) { execbuf->rsvd1 = ctx[i];@@ -90,7 +92,8 @@ static int measure_qlen(int fd,* Be conservative and aim not to overshoot timeout, so scale * down by 8 for hopefully a max of 12.5% error. */ - q =ARRAY_SIZE (ctx) * timeout *1e9 /igt_nsec_elapsed (&tv) /8 +1 ; + q =ARRAY_SIZE (ctx) * timeout *1e9 /igt_nsec_elapsed (&tv) / +8 +1 ;if (q < min) min = q;if (q > max)@@ -107,7 +110,7 @@ static int measure_qlen(int fd, }static void single (int fd,uint32_t handle, -const struct intel_execution_engine *e, +const struct intel_execution_engine2 *e2,unsigned flags,const int ncpus,int timeout)@@ -125,13 +128,14 @@ static void single(int fd, uint32_t handle, shared =mmap (NULL ,4096 ,PROT_WRITE ,MAP_SHARED |MAP_ANON ,-1 ,0 );igt_assert (shared !=MAP_FAILED );
tests/i915/gem_ctx_switch.c static void single(int fd, uint32_t handle, · line 138
Quoted 10 lines
tests/i915/gem_ctx_switch.c +3
-2-gem_require_ring (fd, e->exec_id | e->flags); -for (n =0 ; n <64 ; n++) {if (flags &QUEUE ) contexts[n] =gem_queue_create (fd);else contexts[n] =gem_context_create (fd); + +if (gem_context_has_engine_map (fd,0 )) +gem_context_set_all_engines (fd, contexts[n]);
That was a moment of doubt on how well setting engines on a "queue" worked :)
Quoted 201 lines
tests/i915/gem_ctx_switch.c +74
-29}memset (&obj,0 ,sizeof (obj));@@ -152,12 +156,12 @@ static void single(int fd, uint32_t handle, execbuf.buffers_ptr =to_user_pointer (&obj); execbuf.buffer_count =1 ; execbuf.rsvd1 = contexts[0 ]; - execbuf.flags = e->exec_id | e->flags; + execbuf.flags = e2->flags; execbuf.flags |=LOCAL_I915_EXEC_HANDLE_LUT ; execbuf.flags |=LOCAL_I915_EXEC_NO_RELOC ;igt_require (__gem_execbuf (fd, &execbuf) ==0 );if (__gem_execbuf (fd, &execbuf)) { - execbuf.flags = e->exec_id | e->flags; + execbuf.flags = e2->flags; reloc.target_handle = obj.handle;gem_execbuf (fd, &execbuf); }@@ -190,7 +194,8 @@ static void single(int fd, uint32_t handle,clock_gettime (CLOCK_MONOTONIC , &now);igt_info ("[%d] %s: %'u cycles: %.3fus%s\n" , - child, e->name, count,elapsed (&start, &now)*1e6 / count, + child, e2->name, count, +elapsed (&start, &now) *1e6 / count, flags &INTERRUPTIBLE ?" (interruptible)" :"" ); shared[child].elapsed =elapsed (&start, &now);@@ -209,7 +214,7 @@ static void single(int fd, uint32_t handle, }igt_info ("Total %s: %'lu cycles: %.3fus%s\n" , - e->name, total, max*1e6 / total, + e2->name, total, max*1e6 / total, flags &INTERRUPTIBLE ?" (interruptible)" :"" ); }@@ -223,25 +228,20 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout) {struct drm_i915_gem_execbuffer2 execbuf;struct drm_i915_gem_exec_object2 obj[2 ]; -unsigned int engine[16 ], e; -const char *name[16 ]; +struct intel_engine_data engines = { };uint32_t contexts[65 ]; -unsigned int nengine;int n, qlen; - nengine =0 ; -for_each_physical_engine (fd, e) { - engine[nengine] = e; - name[nengine] = e__->name; - nengine++; - } -igt_require (nengine); + engines =intel_init_engine_list (fd,0 ); +igt_require (engines.nengines);for (n =0 ; n <ARRAY_SIZE (contexts); n++) {if (flags &QUEUE ) contexts[n] =gem_queue_create (fd);else contexts[n] =gem_context_create (fd); + +gem_context_set_all_engines (fd, contexts[n]); }memset (obj,0 ,sizeof (obj));@@ -256,7 +256,7 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout)igt_require (__gem_execbuf (fd, &execbuf) ==0 );gem_sync (fd, handle); - qlen =measure_qlen (fd, &execbuf, engine, nengine, timeout); + qlen =measure_qlen (fd, &execbuf, &engines, timeout);igt_info ("Using timing depth of %d batches\n" , qlen); execbuf.buffers_ptr =to_user_pointer (obj);@@ -264,13 +264,15 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout)for (int pot =2 ; pot <=64 ; pot *=2 ) {for (int nctx = pot -1 ; nctx <= pot +1 ; nctx++) { - igt_fork(child, nengine) { + igt_fork(child, engines.nengines) {struct timespec start, now;unsigned int count =0 ; obj[0 ].handle =gem_create (fd,4096 ); - execbuf.flags |= engine[child]; -for (int loop =0 ; loop <ARRAY_SIZE (contexts); loop++) { + execbuf.flags |= engines.engines[child].flags; +for (int loop =0 ; + loop <ARRAY_SIZE (contexts); + loop++) { execbuf.rsvd1 = contexts[loop];gem_execbuf (fd, &execbuf); }@@ -279,7 +281,8 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout)clock_gettime (CLOCK_MONOTONIC , &start); do { for (int loop = 0; loop < qlen; loop++) { - execbuf.rsvd1 = contexts[loop % nctx]; + execbuf.rsvd1 = + contexts[loop % nctx]; gem_execbuf(fd, &execbuf); } count += qlen;@@ -291,8 +294,11 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout)gem_close (fd, obj[0 ].handle);igt_info ("[%d:%d] %s: %'u cycles: %.3fus%s (elapsed: %.3fs)\n" , - nctx, child, name[child], count,elapsed (&start, &now)*1e6 / count, - flags &INTERRUPTIBLE ?" (interruptible)" :"" , + nctx, child, + engines.engines[child].name, count, +elapsed (&start, &now) *1e6 / count, + flags &INTERRUPTIBLE ? +" (interruptible)" :"" ,elapsed (&start, &now)); }igt_waitchildren ();@@ -306,6 +312,7 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout) igt_main {const int ncpus =sysconf (_SC_NPROCESSORS_ONLN); +const struct intel_execution_engine2 *e2;const struct intel_execution_engine *e; static const struct { const char *name;@@ -338,7 +345,49 @@ igt_mainigt_fork_hang_detector (fd); } +/* Legacy testing must be first. */ for (e = intel_execution_engines; e->name; e++) { + e2 =gem_eb_flags_to_engine (e->exec_id | e->flags); +if (!e2) +continue ;/* I915_EXEC_BSD with no ring selectors */ + +for (typeof (*phases) *p = phases; p->name; p++) { + igt_subtest_group { + igt_fixture { +gem_require_ring (fd, e2->flags); +if (p->require) +igt_require (p->require (fd)); + } + +igt_subtest_f ("legacy-%s%s%s" , + e->name, + *p->name ?"-" :"" , + p->name) +single (fd, light, e2, p->flags,1 ,5 ); + +igt_skip_on_simulation (); + +igt_subtest_f ("legacy-%s%s-heavy%s" , + e->exec_id ==0 ?"basic-" :"" , + e->name, + p->name) +single (fd, heavy, e2, p->flags,1 ,5 ); +igt_subtest_f ("legacy-forked-%s%s" , + e->name, + p->name) +single (fd, light, e2, p->flags, ncpus, +150 ); +igt_subtest_f ("legacy-forked-%s-heavy%s" , + e->name, + p->name) +single (fd, heavy, e2, p->flags, ncpus, +150 ); + } + } + } + +/* Must come after legacy subtests. */ +__for_each_physical_engine (fd, e2) {for (typeof (*phases) *p = phases; p->name; p++) { igt_subtest_group { igt_fixture {@@ -346,33 +395,40 @@ igt_mainigt_require (p->require (fd)); } - igt_subtest_f("%s%s%s", e->exec_id == 0 ? "basic-" : "", e->name, p->name) -single (fd, light, e, p->flags,1 ,5 ); +igt_subtest_f ("%s%s%s" , + e2->name, + *p->name ?"-" :"" , + p->name) +single (fd, light, e2, p->flags,1 ,5 );igt_skip_on_simulation (); - igt_subtest_f("%s%s-heavy%s", e->exec_id == 0 ? "basic-" : "", e->name, p->name) -single (fd, heavy, e, p->flags,1 ,5 ); - igt_subtest_f("forked-%s%s", e->name, p->name) -single (fd, light, e, p->flags, ncpus,150 ); - igt_subtest_f("forked-%s-heavy%s", e->name, p->name) -single (fd, heavy, e, p->flags, ncpus,150 ); + igt_subtest_f("%s-heavy%s", e2->name, p->name) +single (fd, heavy, e2, p->flags,1 ,5 ); +igt_subtest_f ("%s-forked%s" , e2->name, p->name)
tests/i915/gem_ctx_switch.c igt_main · line 418
Quoted 10 lines
tests/i915/gem_ctx_switch.c +7
-0+single (fd, light, e2, p->flags, ncpus, +150 ); +igt_subtest_f ("%s-forked-heavy%s" , + e2->name, + p->name) +single (fd, heavy, e2, p->flags, ncpus, +150 ); } } }
Ok, that looks like what I would expect. For crux tests, we iterate over both the legacy ring selector, and along the engine[] indices.
tests/i915/gem_ctx_switch.c igt_main · line 423
Quoted 6 lines
tests/i915/gem_ctx_switch.c +2
-2- igt_subtest("basic-all-light") + igt_subtest("all-light")all (fd, light,0 ,5 ); - igt_subtest("basic-all-heavy") + igt_subtest("all-heavy")all (fd, heavy,0 ,5 );
And for "all" tests where we are just trying to utilise all engines at once, we only care about the underlying HW utilisation and so the new query interface works best.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 58 lines · Chris Wilson
Quoting Tvrtko Ursulin (2019-06-27 11:20:19)
Quoted 57 lines
tests/i915/gem_ctx_switch.c +9
-6@@ -55,7 +55,7 @@ static double elapsed(const struct timespec *start, const struct timespec *end)static int measure_qlen (int fd,struct drm_i915_gem_execbuffer2 *execbuf, -unsigned int *engine,unsigned int nengine, +const struct intel_engine_data *engines,int timeout) { const struct drm_i915_gem_exec_object2 * const obj =@@ -63,15 +63,17 @@ static int measure_qlen(int fd,uint32_t ctx[64 ];int min =INT_MAX , max =0 ; -for (int i =0 ; i <ARRAY_SIZE (ctx); i++) +for (int i =0 ; i <ARRAY_SIZE (ctx); i++) { ctx[i] =gem_context_create (fd); +gem_context_set_all_engines (fd, ctx[i]); + } -for (unsigned int n =0 ; n < nengine; n++) { +for (unsigned int n =0 ; n < engines->nengines; n++) {uint64_t saved = execbuf->flags;struct timespec tv = {};int q; - execbuf->flags |= engine[n]; + execbuf->flags |= engines->engines[n].flags;for (int i =0 ; i <ARRAY_SIZE (ctx); i++) { execbuf->rsvd1 = ctx[i];@@ -90,7 +92,8 @@ static int measure_qlen(int fd,* Be conservative and aim not to overshoot timeout, so scale * down by 8 for hopefully a max of 12.5% error. */ - q =ARRAY_SIZE (ctx) * timeout *1e9 /igt_nsec_elapsed (&tv) /8 +1 ; + q =ARRAY_SIZE (ctx) * timeout *1e9 /igt_nsec_elapsed (&tv) / +8 +1 ;if (q < min) min = q;if (q > max)@@ -107,7 +110,7 @@ static int measure_qlen(int fd, }static void single (int fd,uint32_t handle, -const struct intel_execution_engine *e, +const struct intel_execution_engine2 *e2,unsigned flags,const int ncpus,int timeout)@@ -125,13 +128,14 @@ static void single(int fd, uint32_t handle, shared =mmap (NULL ,4096 ,PROT_WRITE ,MAP_SHARED |MAP_ANON ,-1 ,0 );igt_assert (shared !=MAP_FAILED );
Quoted 13 lines
tests/i915/gem_ctx_switch.c static void single(int fd, uint32_t handle, · line 138
Quoted 10 lines
tests/i915/gem_ctx_switch.c +3
-2-gem_require_ring (fd, e->exec_id | e->flags); -for (n =0 ; n <64 ; n++) {if (flags &QUEUE ) contexts[n] =gem_queue_create (fd);else contexts[n] =gem_context_create (fd); + +if (gem_context_has_engine_map (fd,0 )) +gem_context_set_all_engines (fd, contexts[n]);That was a moment of doubt on how well setting engines on a "queue" worked :)
Why it wouldn't work?
Quoted 223 lines
Quoted 202 lines
tests/i915/gem_ctx_switch.c +74
-29}memset (&obj,0 ,sizeof (obj));@@ -152,12 +156,12 @@ static void single(int fd, uint32_t handle, execbuf.buffers_ptr =to_user_pointer (&obj); execbuf.buffer_count =1 ; execbuf.rsvd1 = contexts[0 ]; - execbuf.flags = e->exec_id | e->flags; + execbuf.flags = e2->flags; execbuf.flags |=LOCAL_I915_EXEC_HANDLE_LUT ; execbuf.flags |=LOCAL_I915_EXEC_NO_RELOC ;igt_require (__gem_execbuf (fd, &execbuf) ==0 );if (__gem_execbuf (fd, &execbuf)) { - execbuf.flags = e->exec_id | e->flags; + execbuf.flags = e2->flags; reloc.target_handle = obj.handle;gem_execbuf (fd, &execbuf); }@@ -190,7 +194,8 @@ static void single(int fd, uint32_t handle,clock_gettime (CLOCK_MONOTONIC , &now);igt_info ("[%d] %s: %'u cycles: %.3fus%s\n" , - child, e->name, count,elapsed (&start, &now)*1e6 / count, + child, e2->name, count, +elapsed (&start, &now) *1e6 / count, flags &INTERRUPTIBLE ?" (interruptible)" :"" ); shared[child].elapsed =elapsed (&start, &now);@@ -209,7 +214,7 @@ static void single(int fd, uint32_t handle, }igt_info ("Total %s: %'lu cycles: %.3fus%s\n" , - e->name, total, max*1e6 / total, + e2->name, total, max*1e6 / total, flags &INTERRUPTIBLE ?" (interruptible)" :"" ); }@@ -223,25 +228,20 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout) {struct drm_i915_gem_execbuffer2 execbuf;struct drm_i915_gem_exec_object2 obj[2 ]; -unsigned int engine[16 ], e; -const char *name[16 ]; +struct intel_engine_data engines = { };uint32_t contexts[65 ]; -unsigned int nengine;int n, qlen; - nengine =0 ; -for_each_physical_engine (fd, e) { - engine[nengine] = e; - name[nengine] = e__->name; - nengine++; - } -igt_require (nengine); + engines =intel_init_engine_list (fd,0 ); +igt_require (engines.nengines);for (n =0 ; n <ARRAY_SIZE (contexts); n++) {if (flags &QUEUE ) contexts[n] =gem_queue_create (fd);else contexts[n] =gem_context_create (fd); + +gem_context_set_all_engines (fd, contexts[n]); }memset (obj,0 ,sizeof (obj));@@ -256,7 +256,7 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout)igt_require (__gem_execbuf (fd, &execbuf) ==0 );gem_sync (fd, handle); - qlen =measure_qlen (fd, &execbuf, engine, nengine, timeout); + qlen =measure_qlen (fd, &execbuf, &engines, timeout);igt_info ("Using timing depth of %d batches\n" , qlen); execbuf.buffers_ptr =to_user_pointer (obj);@@ -264,13 +264,15 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout)for (int pot =2 ; pot <=64 ; pot *=2 ) {for (int nctx = pot -1 ; nctx <= pot +1 ; nctx++) { - igt_fork(child, nengine) { + igt_fork(child, engines.nengines) {struct timespec start, now;unsigned int count =0 ; obj[0 ].handle =gem_create (fd,4096 ); - execbuf.flags |= engine[child]; -for (int loop =0 ; loop <ARRAY_SIZE (contexts); loop++) { + execbuf.flags |= engines.engines[child].flags; +for (int loop =0 ; + loop <ARRAY_SIZE (contexts); + loop++) { execbuf.rsvd1 = contexts[loop];gem_execbuf (fd, &execbuf); }@@ -279,7 +281,8 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout)clock_gettime (CLOCK_MONOTONIC , &start); do { for (int loop = 0; loop < qlen; loop++) { - execbuf.rsvd1 = contexts[loop % nctx]; + execbuf.rsvd1 = + contexts[loop % nctx]; gem_execbuf(fd, &execbuf); } count += qlen;@@ -291,8 +294,11 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout)gem_close (fd, obj[0 ].handle);igt_info ("[%d:%d] %s: %'u cycles: %.3fus%s (elapsed: %.3fs)\n" , - nctx, child, name[child], count,elapsed (&start, &now)*1e6 / count, - flags &INTERRUPTIBLE ?" (interruptible)" :"" , + nctx, child, + engines.engines[child].name, count, +elapsed (&start, &now) *1e6 / count, + flags &INTERRUPTIBLE ? +" (interruptible)" :"" ,elapsed (&start, &now)); }igt_waitchildren ();@@ -306,6 +312,7 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout) igt_main {const int ncpus =sysconf (_SC_NPROCESSORS_ONLN); +const struct intel_execution_engine2 *e2;const struct intel_execution_engine *e; static const struct { const char *name;@@ -338,7 +345,49 @@ igt_mainigt_fork_hang_detector (fd); } +/* Legacy testing must be first. */ for (e = intel_execution_engines; e->name; e++) { + e2 =gem_eb_flags_to_engine (e->exec_id | e->flags); +if (!e2) +continue ;/* I915_EXEC_BSD with no ring selectors */ + +for (typeof (*phases) *p = phases; p->name; p++) { + igt_subtest_group { + igt_fixture { +gem_require_ring (fd, e2->flags); +if (p->require) +igt_require (p->require (fd)); + } + +igt_subtest_f ("legacy-%s%s%s" , + e->name, + *p->name ?"-" :"" , + p->name) +single (fd, light, e2, p->flags,1 ,5 ); + +igt_skip_on_simulation (); + +igt_subtest_f ("legacy-%s%s-heavy%s" , + e->exec_id ==0 ?"basic-" :"" , + e->name, + p->name) +single (fd, heavy, e2, p->flags,1 ,5 ); +igt_subtest_f ("legacy-forked-%s%s" , + e->name, + p->name) +single (fd, light, e2, p->flags, ncpus, +150 ); +igt_subtest_f ("legacy-forked-%s-heavy%s" , + e->name, + p->name) +single (fd, heavy, e2, p->flags, ncpus, +150 ); + } + } + } + +/* Must come after legacy subtests. */ +__for_each_physical_engine (fd, e2) {for (typeof (*phases) *p = phases; p->name; p++) { igt_subtest_group { igt_fixture {@@ -346,33 +395,40 @@ igt_mainigt_require (p->require (fd)); } - igt_subtest_f("%s%s%s", e->exec_id == 0 ? "basic-" : "", e->name, p->name) -single (fd, light, e, p->flags,1 ,5 ); +igt_subtest_f ("%s%s%s" , + e2->name, + *p->name ?"-" :"" , + p->name) +single (fd, light, e2, p->flags,1 ,5 );igt_skip_on_simulation (); - igt_subtest_f("%s%s-heavy%s", e->exec_id == 0 ? "basic-" : "", e->name, p->name) -single (fd, heavy, e, p->flags,1 ,5 ); - igt_subtest_f("forked-%s%s", e->name, p->name) -single (fd, light, e, p->flags, ncpus,150 ); - igt_subtest_f("forked-%s-heavy%s", e->name, p->name) -single (fd, heavy, e, p->flags, ncpus,150 ); + igt_subtest_f("%s-heavy%s", e2->name, p->name) +single (fd, heavy, e2, p->flags,1 ,5 ); +igt_subtest_f ("%s-forked%s" , e2->name, p->name)tests/i915/gem_ctx_switch.c igt_main · line 418
Quoted 10 lines
tests/i915/gem_ctx_switch.c +7
-0+single (fd, light, e2, p->flags, ncpus, +150 ); +igt_subtest_f ("%s-forked-heavy%s" , + e2->name, + p->name) +single (fd, heavy, e2, p->flags, ncpus, +150 ); } } }Ok, that looks like what I would expect. For crux tests, we iterate over both the legacy ring selector, and along the engine[] indices.
tests/i915/gem_ctx_switch.c igt_main · line 423
Quoted 6 lines
tests/i915/gem_ctx_switch.c +2
-2- igt_subtest("basic-all-light") + igt_subtest("all-light")all (fd, light,0 ,5 ); - igt_subtest("basic-all-heavy") + igt_subtest("all-heavy")all (fd, heavy,0 ,5 );
Quoted 3 lines
And for "all" tests where we are just trying to utilise all engines at once, we only care about the underlying HW utilisation and so the new query interface works best.
Cool, so no complaints?
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Tvrtko Ursulin (2019-06-27 11:55:56)
Quoted 21 lines · Chris Wilson
Quoted 5 lines
Quoting Tvrtko Ursulin (2019-06-27 11:20:19)
Quoted 4 lines
tests/i915/gem_ctx_switch.c +0
-0@@ -125,13 +128,14 @@ static void single(int fd, uint32_t handle, shared =mmap (NULL ,4096 ,PROT_WRITE ,MAP_SHARED |MAP_ANON ,-1 ,0 );igt_assert (shared !=MAP_FAILED );Quoted 13 lines
tests/i915/gem_ctx_switch.c static void single(int fd, uint32_t handle, · line 138
Quoted 10 lines
tests/i915/gem_ctx_switch.c +3
-2-gem_require_ring (fd, e->exec_id | e->flags); -for (n =0 ; n <64 ; n++) {if (flags &QUEUE ) contexts[n] =gem_queue_create (fd);else contexts[n] =gem_context_create (fd); + +if (gem_context_has_engine_map (fd,0 )) +gem_context_set_all_engines (fd, contexts[n]);That was a moment of doubt on how well setting engines on a "queue" worked :)
Quoted 1 line
Why it wouldn't work?
Because I expected to have made a mistake :)
Quoted 10 lines
Quoted 10 lines
Ok, that looks like what I would expect. For crux tests, we iterate over both the legacy ring selector, and along the engine[] indices.
Quoted 6 lines
tests/i915/gem_ctx_switch.c +2
-2- igt_subtest("basic-all-light") + igt_subtest("all-light")all (fd, light,0 ,5 ); -igt_subtest ("basic-all-heavy" ) +igt_subtest ("all-heavy" )all(fd, heavy, 0, 5);
Quoted 5 lines
Quoted 3 lines
And for "all" tests where we are just trying to utilise all engines at once, we only care about the underlying HW utilisation and so the new query interface works best.
Cool, so no complaints?
Strategy works for me. We can argue about which tests need both and hopefully come up with a minimum set that gives good coverage of active legacy ABI.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH v2 1/1 tests/i915/gem_ctx_switch: Update with engine discovery
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
I converted this one as an example, or at least to drive the discussion, how more complex tests can be converted.
I have kept the legacy execbuf abi testing prefixed with "legacy-".
New tests were added to exercise physical engines via engine discovery and also "all" tests have been updated in the same way.
To keep things simpler and avoid having to create separate contexts legacy tests have to be first since the __for_each_physical_engine iterator would otherwise configure the default context and confuse the test.
So legacy tests run on the unconfigured (with engine map) context and use a new helper gem_eb_flags_to_engine to look up the engine from the intel_execution_engines2 static list. This is only to enable the core test code to be shared.
Places where new contexts are created had to be updated to either equally configure the contexts or not. Another new helper, gem_context_has_engine_map was added to enable this.
Also beware of drive-by formatting changes.
v2:
* Fix hyphen mess in subtest names.
--- lib/i915/gem_engine_topology.c | 27 ++++++ lib/i915/gem_engine_topology.h | 5 + tests/i915/gem_ctx_switch.c | 127 +++++++++++++++++--------- tests/intel-ci/blacklist.txt | 2 +- tests/intel-ci/fast-feedback.testlist | 3 +- 5 files changed, 121 insertions(+), 43 deletions(-)
lib/i915/gem_engine_topology.c +27 -0
@@ -289,3 +289,30 @@ bool gem_has_engine_topology(int fd)return !__gem_context_get_param (fd, ¶m); } + +const struct intel_execution_engine2 * +gem_eb_flags_to_engine (unsigned int flags) +{ +const struct intel_execution_engine2 *e2; + +__for_each_static_engine (e2) { +if (e2->flags == flags) +return e2; + } + +return NULL ; +} + +bool gem_context_has_engine_map (int fd,uint32_t ctx) +{ +struct drm_i915_gem_context_param param = { + .param =I915_CONTEXT_PARAM_ENGINES , + .ctx_id = ctx + }; +int ret; + + ret =__gem_context_get_param (fd, ¶m); +igt_assert_eq (ret,0 ); + +return param.size; +}
lib/i915/gem_engine_topology.h +5 -0
@@ -53,6 +53,11 @@ int gem_context_lookup_engine(int fd, uint64_t engine, uint32_t ctx_id,void gem_context_set_all_engines (int fd,uint32_t ctx); +bool gem_context_has_engine_map (int fd,uint32_t ctx); + +const struct intel_execution_engine2 * +gem_eb_flags_to_engine (unsigned int flags); +#define __for_each_static_engine (e__) \ for ((e__) = intel_execution_engines2; (e__)->name; (e__)++)
tests/i915/gem_ctx_switch.c +86 -41
267 lines not on this page · raw message
tests/intel-ci/blacklist.txt +1 -1
@@ -25,7 +25,7 @@ igt@gem_cs_prefetch(@.*)? igt@gem_ctx_create@(?!.*basic).* igt@gem_ctx_exec@(?!.*basic).* igt@gem_ctx_shared@*exhaust* -igt@gem_ctx_switch@(?!.*basic).* +igt@gem_ctx_switch@.*(forked|interruptible).* igt@gem_ctx_thrash(@.*)? igt@gem_evict_alignment(@.*)? igt@gem_evict_everything(@.*)?
tests/intel-ci/fast-feedback.testlist +2 -1
@@ -14,7 +14,8 @@ igt@gem_ctx_create@basic-files igt@gem_ctx_exec@basic igt@gem_ctx_param@basic igt@gem_ctx_param@basic-default -igt@gem_ctx_switch@basic-default +igt@gem_ctx_switch@legacy-render +igt@gem_ctx_switch@rcs0 igt@gem_exec_basic@basic-all igt@gem_exec_create@basic igt@gem_exec_fence@basic-busy-default
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Hi Tvrtko,
lib/i915/gem_engine_topology.c bool gem_has_engine_topology(int fd) · line 304
Quoted 12 lines
lib/i915/gem_engine_topology.c +12
-0+const struct intel_execution_engine2 * +gem_eb_flags_to_engine (unsigned int flags) +{ +const struct intel_execution_engine2 *e2; + +__for_each_static_engine (e2) { +if (e2->flags == flags) +return e2; + } + +return NULL ; +}
the amount of "helpers" is getting almost unbearable for a simple mind like mine.
This means that we can get rid of
gem_execbuf_flags_to_engine_class
gem_ring_is_physical_engine
gem_ring_has_physical_engine
in igt_gt.c, right?
lib/i915/gem_engine_topology.c bool gem_has_engine_topology(int fd) · line 317
Quoted 12 lines
lib/i915/gem_engine_topology.c +12
-0+bool gem_context_has_engine_map (int fd,uint32_t ctx) +{ +struct drm_i915_gem_context_param param = { + .param =I915_CONTEXT_PARAM_ENGINES , + .ctx_id = ctx + }; +int ret; + + ret =__gem_context_get_param (fd, ¶m); +igt_assert_eq (ret,0 ); + +return param.size;
a small nitpick: bool to me means '0' or '1'.
So, if you do 'return param.size', I would call the function gem_context_get_param_size, otherwise I would return '!!param.size' and keep it bool.
(We are also somehow abusing on the size definition of bool in C99/C17 or previous.)
I'm not asking you to change it, but it would make me happier :)
Quoted 52 lines
(quoted diff) +1
-0+}lib/i915/gem_engine_topology.h +5
-0@@ -53,6 +53,11 @@ int gem_context_lookup_engine(int fd, uint64_t engine, uint32_t ctx_id,void gem_context_set_all_engines (int fd,uint32_t ctx); +bool gem_context_has_engine_map (int fd,uint32_t ctx); + +const struct intel_execution_engine2 * +gem_eb_flags_to_engine (unsigned int flags); +#define __for_each_static_engine (e__) \ for ((e__) = intel_execution_engines2; (e__)->name; (e__)++)tests/i915/gem_ctx_switch.c +6
-4@@ -55,7 +55,7 @@ static double elapsed(const struct timespec *start, const struct timespec *end)static int measure_qlen (int fd,struct drm_i915_gem_execbuffer2 *execbuf, -unsigned int *engine,unsigned int nengine, +const struct intel_engine_data *engines,int timeout) { const struct drm_i915_gem_exec_object2 * const obj =@@ -63,15 +63,17 @@ static int measure_qlen(int fd,uint32_t ctx[64 ];int min =INT_MAX , max =0 ; -for (int i =0 ; i <ARRAY_SIZE (ctx); i++) +for (int i =0 ; i <ARRAY_SIZE (ctx); i++) { ctx[i] =gem_context_create (fd); +gem_context_set_all_engines (fd, ctx[i]); + } -for (unsigned int n =0 ; n < nengine; n++) { +for (unsigned int n =0 ; n < engines->nengines; n++) {uint64_t saved = execbuf->flags;struct timespec tv = {};int q; - execbuf->flags |= engine[n]; + execbuf->flags |= engines->engines[n].flags;for (int i =0 ; i <ARRAY_SIZE (ctx); i++) { execbuf->rsvd1 = ctx[i];
tests/i915/gem_ctx_switch.c static int measure_qlen(int fd, · line 96
Quoted 6 lines
tests/i915/gem_ctx_switch.c +2
-1@@ -90,7 +92,8 @@ static int measure_qlen(int fd,* Be conservative and aim not to overshoot timeout, so scale * down by 8 for hopefully a max of 12.5% error. */ - q =ARRAY_SIZE (ctx) * timeout *1e9 /igt_nsec_elapsed (&tv) /8 +1 ; + q =ARRAY_SIZE (ctx) * timeout *1e9 /igt_nsec_elapsed (&tv) / +8 +1 ;
I don't know whether it's me who is paranoic, but the change above doesn't match the commit log.
Quoted 73 lines
tests/i915/gem_ctx_switch.c +10
-10if (q < min) min = q;if (q > max)@@ -107,7 +110,7 @@ static int measure_qlen(int fd, }static void single (int fd,uint32_t handle, -const struct intel_execution_engine *e, +const struct intel_execution_engine2 *e2,unsigned flags,const int ncpus,int timeout)@@ -125,13 +128,14 @@ static void single(int fd, uint32_t handle, shared =mmap (NULL ,4096 ,PROT_WRITE ,MAP_SHARED |MAP_ANON ,-1 ,0 );igt_assert (shared !=MAP_FAILED ); -gem_require_ring (fd, e->exec_id | e->flags); -for (n =0 ; n <64 ; n++) {if (flags &QUEUE ) contexts[n] =gem_queue_create (fd);else contexts[n] =gem_context_create (fd); + +if (gem_context_has_engine_map (fd,0 )) +gem_context_set_all_engines (fd, contexts[n]); }memset (&obj,0 ,sizeof (obj));@@ -152,12 +156,12 @@ static void single(int fd, uint32_t handle, execbuf.buffers_ptr =to_user_pointer (&obj); execbuf.buffer_count =1 ; execbuf.rsvd1 = contexts[0 ]; - execbuf.flags = e->exec_id | e->flags; + execbuf.flags = e2->flags; execbuf.flags |=LOCAL_I915_EXEC_HANDLE_LUT ; execbuf.flags |=LOCAL_I915_EXEC_NO_RELOC ;igt_require (__gem_execbuf (fd, &execbuf) ==0 );if (__gem_execbuf (fd, &execbuf)) { - execbuf.flags = e->exec_id | e->flags; + execbuf.flags = e2->flags; reloc.target_handle = obj.handle;gem_execbuf (fd, &execbuf); }@@ -190,7 +194,8 @@ static void single(int fd, uint32_t handle,clock_gettime (CLOCK_MONOTONIC , &now);igt_info ("[%d] %s: %'u cycles: %.3fus%s\n" , - child, e->name, count,elapsed (&start, &now)*1e6 / count, + child, e2->name, count, +elapsed (&start, &now) *1e6 / count, flags &INTERRUPTIBLE ?" (interruptible)" :"" ); shared[child].elapsed =elapsed (&start, &now);@@ -209,7 +214,7 @@ static void single(int fd, uint32_t handle, }igt_info ("Total %s: %'lu cycles: %.3fus%s\n" , - e->name, total, max*1e6 / total, + e2->name, total, max*1e6 / total, flags &INTERRUPTIBLE ?" (interruptible)" :"" ); }@@ -223,25 +228,20 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout) {struct drm_i915_gem_execbuffer2 execbuf;struct drm_i915_gem_exec_object2 obj[2 ]; -unsigned int engine[16 ], e; -const char *name[16 ]; +struct intel_engine_data engines = { };uint32_t contexts[65 ]; -unsigned int nengine;int n, qlen;
tests/i915/gem_ctx_switch.c static void all(int fd, uint32_t handle, unsigned flags, int timeout) · line 236
Quoted 10 lines
tests/i915/gem_ctx_switch.c +2
-7- nengine =0 ; -for_each_physical_engine (fd, e) { - engine[nengine] = e; - name[nengine] = e__->name; - nengine++; - } -igt_require (nengine); + engines =intel_init_engine_list (fd,0 ); +igt_require (engines.nengines);
Off-topic:
This I guess can be the "flags" mapping that Chris was suggesting once, I guess we can achieve that by just doing the above without adding helpers (which would drive crazy people like me).
The rest of the patch I trust you it works :)
(however the devotion to whatever is legacy doesn't leave me with a good taste after all the work done)
You can add my Reviewed-by: Andi Shyti <[email protected]>
Thanks, this patch clarifies a few more things as well, Andi
_______________________________________________
igt-dev mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Andi Shyti (2019-06-27 21:15:30)
Quoted 15 lines
lib/i915/gem_engine_topology.c bool gem_has_engine_topology(int fd) · line 317
Quoted 12 lines
lib/i915/gem_engine_topology.c +12
-0+bool gem_context_has_engine_map (int fd,uint32_t ctx) +{ +struct drm_i915_gem_context_param param = { + .param =I915_CONTEXT_PARAM_ENGINES , + .ctx_id = ctx + }; +int ret; + + ret =__gem_context_get_param (fd, ¶m); +igt_assert_eq (ret,0 ); + +return param.size;a small nitpick: bool to me means '0' or '1'.
Quoted 3 lines
So, if you do 'return param.size', I would call the function
gem_context_get_param_size, otherwise I would return '!!param.size' and keep it bool.
An integer in boolean context is 0 or 1, the !! is implicit. We use that quite frequently, e.g. bool has_ptr(void **x) { return *x; }
Quoted 2 lines
(We are also somehow abusing on the size definition of bool in C99/C17 or previous.)
I hope we never assume the size or alignment of bool. I always hope the compiler will just reduce it to the control flags for inline predicates. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 19 lines · Andi Shyti
Hi Tvrtko,
lib/i915/gem_engine_topology.c bool gem_has_engine_topology(int fd) · line 304
Quoted 12 lines
lib/i915/gem_engine_topology.c +12
-0+const struct intel_execution_engine2 * +gem_eb_flags_to_engine (unsigned int flags) +{ +const struct intel_execution_engine2 *e2; + +__for_each_static_engine (e2) { +if (e2->flags == flags) +return e2; + } + +return NULL ; +}the amount of "helpers" is getting almost unbearable for a simple mind like mine.
Quoted 7 lines
This means that we can get rid of
gem_execbuf_flags_to_engine_class
gem_ring_is_physical_engine
gem_ring_has_physical_enginein
igt_gt.c, right?
If/when there are no callers left we can like everything. I dont' know if that is the case right now.
Quoted 15 lines
lib/i915/gem_engine_topology.c bool gem_has_engine_topology(int fd) · line 317
Quoted 12 lines
lib/i915/gem_engine_topology.c +12
-0+bool gem_context_has_engine_map (int fd,uint32_t ctx) +{ +struct drm_i915_gem_context_param param = { + .param =I915_CONTEXT_PARAM_ENGINES , + .ctx_id = ctx + }; +int ret; + + ret =__gem_context_get_param (fd, ¶m); +igt_assert_eq (ret,0 ); + +return param.size;a small nitpick: bool to me means '0' or '1'.
Quoted 3 lines
So, if you do 'return param.size', I would call the function
gem_context_get_param_size, otherwise I would return '!!param.size' and keep it bool.
Some people would then complain !! was not needed. ~o~
And actually I think I want to remove the distinction of no map and map with no engines for the callers of this helpers. So returning size would not work for that.
Quoted 4 lines
(We are also somehow abusing on the size definition of bool in C99/C17 or previous.)
I'm not asking you to change it, but it would make me happier :)
I don't understand the issue with size definition. Size is u32 - will not implicit conversion to bool just work?
Quoted 50 lines
Quoted 50 lines
(quoted diff) +1
-0+}lib/i915/gem_engine_topology.h +5
-0@@ -53,6 +53,11 @@ int gem_context_lookup_engine(int fd, uint64_t engine, uint32_t ctx_id,void gem_context_set_all_engines (int fd,uint32_t ctx); +bool gem_context_has_engine_map (int fd,uint32_t ctx); + +const struct intel_execution_engine2 * +gem_eb_flags_to_engine (unsigned int flags); +#define __for_each_static_engine (e__) \ for ((e__) = intel_execution_engines2; (e__)->name; (e__)++)tests/i915/gem_ctx_switch.c +6
-4@@ -55,7 +55,7 @@ static double elapsed(const struct timespec *start, const struct timespec *end)static int measure_qlen (int fd,struct drm_i915_gem_execbuffer2 *execbuf, -unsigned int *engine,unsigned int nengine, +const struct intel_engine_data *engines,int timeout) { const struct drm_i915_gem_exec_object2 * const obj =@@ -63,15 +63,17 @@ static int measure_qlen(int fd,uint32_t ctx[64 ];int min =INT_MAX , max =0 ; -for (int i =0 ; i <ARRAY_SIZE (ctx); i++) +for (int i =0 ; i <ARRAY_SIZE (ctx); i++) { ctx[i] =gem_context_create (fd); +gem_context_set_all_engines (fd, ctx[i]); + } -for (unsigned int n =0 ; n < nengine; n++) { +for (unsigned int n =0 ; n < engines->nengines; n++) {uint64_t saved = execbuf->flags;struct timespec tv = {};int q; - execbuf->flags |= engine[n]; + execbuf->flags |= engines->engines[n].flags;
Quoted 12 lines
tests/i915/gem_ctx_switch.c static int measure_qlen(int fd, · line 96
Quoted 9 lines
tests/i915/gem_ctx_switch.c +2
-1for (int i =0 ; i <ARRAY_SIZE (ctx); i++) { execbuf->rsvd1 = ctx[i];@@ -90,7 +92,8 @@ static int measure_qlen(int fd,* Be conservative and aim not to overshoot timeout, so scale * down by 8 for hopefully a max of 12.5% error. */ - q =ARRAY_SIZE (ctx) * timeout *1e9 /igt_nsec_elapsed (&tv) /8 +1 ; + q =ARRAY_SIZE (ctx) * timeout *1e9 /igt_nsec_elapsed (&tv) / +8 +1 ;I don't know whether it's me who is paranoic, but the change above doesn't match the commit log.
What do you mean:
"""
Also beware of drive-by formatting changes.
"""
;)
File to many lines falling of 80 char so I tidied it alongside.
Quoted 75 lines
Quoted 75 lines
tests/i915/gem_ctx_switch.c +10
-10if (q < min) min = q;if (q > max)@@ -107,7 +110,7 @@ static int measure_qlen(int fd, }static void single (int fd,uint32_t handle, -const struct intel_execution_engine *e, +const struct intel_execution_engine2 *e2,unsigned flags,const int ncpus,int timeout)@@ -125,13 +128,14 @@ static void single(int fd, uint32_t handle, shared =mmap (NULL ,4096 ,PROT_WRITE ,MAP_SHARED |MAP_ANON ,-1 ,0 );igt_assert (shared !=MAP_FAILED ); -gem_require_ring (fd, e->exec_id | e->flags); -for (n =0 ; n <64 ; n++) {if (flags &QUEUE ) contexts[n] =gem_queue_create (fd);else contexts[n] =gem_context_create (fd); + +if (gem_context_has_engine_map (fd,0 )) +gem_context_set_all_engines (fd, contexts[n]); }memset (&obj,0 ,sizeof (obj));@@ -152,12 +156,12 @@ static void single(int fd, uint32_t handle, execbuf.buffers_ptr =to_user_pointer (&obj); execbuf.buffer_count =1 ; execbuf.rsvd1 = contexts[0 ]; - execbuf.flags = e->exec_id | e->flags; + execbuf.flags = e2->flags; execbuf.flags |=LOCAL_I915_EXEC_HANDLE_LUT ; execbuf.flags |=LOCAL_I915_EXEC_NO_RELOC ;igt_require (__gem_execbuf (fd, &execbuf) ==0 );if (__gem_execbuf (fd, &execbuf)) { - execbuf.flags = e->exec_id | e->flags; + execbuf.flags = e2->flags; reloc.target_handle = obj.handle;gem_execbuf (fd, &execbuf); }@@ -190,7 +194,8 @@ static void single(int fd, uint32_t handle,clock_gettime (CLOCK_MONOTONIC , &now);igt_info ("[%d] %s: %'u cycles: %.3fus%s\n" , - child, e->name, count,elapsed (&start, &now)*1e6 / count, + child, e2->name, count, +elapsed (&start, &now) *1e6 / count, flags &INTERRUPTIBLE ?" (interruptible)" :"" ); shared[child].elapsed =elapsed (&start, &now);@@ -209,7 +214,7 @@ static void single(int fd, uint32_t handle, }igt_info ("Total %s: %'lu cycles: %.3fus%s\n" , - e->name, total, max*1e6 / total, + e2->name, total, max*1e6 / total, flags &INTERRUPTIBLE ?" (interruptible)" :"" ); }@@ -223,25 +228,20 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout) {struct drm_i915_gem_execbuffer2 execbuf;struct drm_i915_gem_exec_object2 obj[2 ]; -unsigned int engine[16 ], e; -const char *name[16 ]; +struct intel_engine_data engines = { };uint32_t contexts[65 ]; -unsigned int nengine;int n, qlen;
Quoted 14 lines
tests/i915/gem_ctx_switch.c static void all(int fd, uint32_t handle, unsigned flags, int timeout) · line 236
Quoted 9 lines
tests/i915/gem_ctx_switch.c +2
-7- nengine =0 ; -for_each_physical_engine (fd, e) { - engine[nengine] = e; - name[nengine] = e__->name; - nengine++; - } -igt_require (nengine); + engines =intel_init_engine_list (fd,0 ); +igt_require (engines.nengines);Off-topic:
This I guess can be the "flags" mapping that Chris was suggesting once, I guess we can achieve that by just doing the above without adding helpers (which would drive crazy people like me).
I don't remember what was this flags mapping. Something to return a list of eb->flags for all physical engines? Not sure I like that since flags carry is very limited information. Having a list of engine objects sounds much better.
Quoted 8 lines
The rest of the patch I trust you it works :)
(however the devotion to whatever is legacy doesn't leave me with a good taste after all the work done)You can add my Reviewed-by: Andi Shyti <[email protected]>
Thanks, this patch clarifies a few more things as well,
Thanks!
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 17 lines
Quoted 17 lines
lib/i915/gem_engine_topology.c bool gem_has_engine_topology(int fd) · line 304
Quoted 11 lines
lib/i915/gem_engine_topology.c +11
-0+gem_eb_flags_to_engine(unsigned int flags) +{ +const struct intel_execution_engine2 *e2; + +__for_each_static_engine (e2) { +if (e2->flags == flags) +return e2; + } + +return NULL ; +}the amount of "helpers" is getting almost unbearable for a simple mind like mine.
This means that we can get rid of
Quoted 8 lines
Quoted 5 lines
gem_execbuf_flags_to_engine_class
gem_ring_is_physical_engine
gem_ring_has_physical_enginein
igt_gt.c, right?If/when there are no callers left we can like everything. I dont' know if that is the case right now.
No, not yet, but this replaces the logical meaning of the function above... but... there is still lots of legacy involved :(
Quoted 14 lines
Quoted 7 lines
lib/i915/gem_engine_topology.c bool gem_has_engine_topology(int fd) · line 317
Quoted 1 line
lib/i915/gem_engine_topology.c +1
-0+return param.size;a small nitpick: bool to me means '0' or '1'.
So, if you do 'return param.size', I would call the function
gem_context_get_param_size, otherwise I would return '!!param.size' and keep it bool.Some people would then complain !! was not needed. ~o~
And actually I think I want to remove the distinction of no map and map with no engines for the callers of this helpers. So returning size would not work for that.
Quoted 7 lines
Quoted 4 lines
(We are also somehow abusing on the size definition of bool in C99/C17 or previous.)
I'm not asking you to change it, but it would make me happier :)
I don't understand the issue with size definition. Size is u32 - will not implicit conversion to bool just work?
This is fine, it's just some philosophical thinking that for me bool should be true false.
-----------------
(If we want to be purists, this would rather be
return param.size ? true : false;
which basically changes nothing, but sticks to the meaining of "bool" and it would be to much anyway)
Quoted 9 lines
Quoted 6 lines
tests/i915/gem_ctx_switch.c static int measure_qlen(int fd, · line 96
Quoted 3 lines
tests/i915/gem_ctx_switch.c +2
-1- q =ARRAY_SIZE (ctx) * timeout *1e9 /igt_nsec_elapsed (&tv) /8 +1 ; + q =ARRAY_SIZE (ctx) * timeout *1e9 /igt_nsec_elapsed (&tv) / +8 +1 ;I don't know whether it's me who is paranoic, but the change above doesn't match the commit log.
What do you mean:
Quoted 7 lines
"""
Also beware of drive-by formatting changes.
""";)
File to many lines falling of 80 char so I tidied it alongside.
I'm not saying that this change is wrong, just that it's out of the context of the patch and it should lay in a different change (I'm not very strong in this case, though, but I've seen such cases too many times in this list).
Quoted 9 lines
Quoted 7 lines
The rest of the patch I trust you it works :)
(however the devotion to whatever is legacy doesn't leave me with a good taste after all the work done)You can add my Reviewed-by: Andi Shyti <[email protected]>
Thanks, this patch clarifies a few more things as well,
Thanks!
Thank you,
Andi
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_ctx_switch: Update with engine discovery
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: tests/i915/gem_ctx_switch: Update with engine discovery
URL : https://patchwork.freedesktop.org/series/62845/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6373 -> IGTPW_3202
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/62845/revisions/1/mbox/
New tests
---------
New tests have been introduced between CI_DRM_6373 and IGTPW_3202:
### New IGT tests (2) ###
* igt@gem_ctx_switch@legacy-render:
- Statuses : 43 pass(s) 2 skip(s)
- Exec time: [0.0, 5.17] s
* igt@gem_ctx_switch@rcs0:
- Statuses : 43 pass(s) 2 skip(s)
- Exec time: [0.0, 5.14] s
Known issues
------------
Here are the changes found in IGTPW_3202 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-no-display:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/fi-icl-u3/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-kbl-r: [PASS][3] -> [DMESG-WARN][4] ([fdo#111012])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-kbl-r/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/fi-kbl-r/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([fdo#109485])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/fi-kbl-7500u/igt@[email protected]
#### Possible fixes ####
* igt@gem_flink_basic@flink-lifetime:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-u3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/fi-icl-u3/igt@[email protected]
* igt@gem_mmap@basic-small-bo:
- fi-icl-dsi: [DMESG-WARN][9] ([fdo#106107]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-dsi/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/fi-icl-dsi/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][11] ([fdo#108511]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-skl-6770hq/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/fi-skl-6770hq/igt@[email protected]
* igt@i915_selftest@live_client:
- fi-icl-dsi: [INCOMPLETE][13] ([fdo#107713]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-dsi/igt@i915_selftest@live_client.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/fi-icl-dsi/igt@i915_selftest@live_client.html
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#111012]: https://bugs.freedesktop.org/show_bug.cgi?id=111012
Participating hosts (52 -> 45)
------------------------------
Additional (1): fi-skl-gvtdvm
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5069 -> IGTPW_3202
CI_DRM_6373: cc7ffe2a301509ba233652ec17d0f74c18b5c8a9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3202: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/
IGT_5069: 439a9f5d615f31f03cc3a3a5cbab19367a1af763 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+++ 180 lines
--- 116 lines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_ctx_switch: Update with engine discovery (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: tests/i915/gem_ctx_switch: Update with engine discovery (rev2)
URL : https://patchwork.freedesktop.org/series/62845/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6373 -> IGTPW_3203
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/62845/revisions/2/mbox/
New tests
---------
New tests have been introduced between CI_DRM_6373 and IGTPW_3203:
### New IGT tests (2) ###
* igt@gem_ctx_switch@legacy-render:
- Statuses : 42 pass(s) 3 skip(s)
- Exec time: [0.0, 5.17] s
* igt@gem_ctx_switch@rcs0:
- Statuses : 42 pass(s) 3 skip(s)
- Exec time: [0.0, 5.17] s
Known issues
------------
Here are the changes found in IGTPW_3203 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-blb-e6850/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/fi-blb-e6850/igt@[email protected]
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-r: [PASS][3] -> [DMESG-WARN][4] ([fdo#111012])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-kbl-r/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/fi-kbl-r/igt@[email protected]
* igt@i915_selftest@live_sanitycheck:
- fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][7] -> [DMESG-WARN][8] ([fdo#102614])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-hsw-peppy/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/fi-hsw-peppy/igt@[email protected]
#### Possible fixes ####
* igt@gem_flink_basic@flink-lifetime:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-u3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/fi-icl-u3/igt@[email protected]
* igt@gem_mmap@basic-small-bo:
- fi-icl-dsi: [DMESG-WARN][11] ([fdo#106107]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-dsi/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/fi-icl-dsi/igt@[email protected]
* igt@i915_selftest@live_client:
- fi-icl-dsi: [INCOMPLETE][13] ([fdo#107713]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-dsi/igt@i915_selftest@live_client.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/fi-icl-dsi/igt@i915_selftest@live_client.html
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111012]: https://bugs.freedesktop.org/show_bug.cgi?id=111012
Participating hosts (52 -> 45)
------------------------------
Additional (1): fi-skl-gvtdvm
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5069 -> IGTPW_3203
CI_DRM_6373: cc7ffe2a301509ba233652ec17d0f74c18b5c8a9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3203: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/
IGT_5069: 439a9f5d615f31f03cc3a3a5cbab19367a1af763 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+++ 180 lines
--- 116 lines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/i915/gem_ctx_switch: Update with engine discovery
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: tests/i915/gem_ctx_switch: Update with engine discovery
URL : https://patchwork.freedesktop.org/series/62845/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6373_full -> IGTPW_3202_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/62845/revisions/1/mbox/
New tests
---------
New tests have been introduced between CI_DRM_6373_full and IGTPW_3202_full:
### New IGT tests (48) ###
* igt@gem_ctx_switch@all-heavy:
- Statuses : 6 pass(s)
- Exec time: [98.42, 103.98] s
* igt@gem_ctx_switch@all-light:
- Statuses : 6 pass(s)
- Exec time: [102.44, 150.81] s
* igt@gem_ctx_switch@bcs0:
- Statuses : 5 pass(s)
- Exec time: [5.01, 5.06] s
* igt@gem_ctx_switch@bcs0--queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.08] s
* igt@gem_ctx_switch@bcs0-heavy:
- Statuses : 6 pass(s)
- Exec time: [6.24, 21.52] s
* igt@gem_ctx_switch@bcs0-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 22.40] s
* igt@gem_ctx_switch@legacy-blt:
- Statuses : 6 pass(s)
- Exec time: [5.01, 5.08] s
* igt@gem_ctx_switch@legacy-blt--queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.07] s
* igt@gem_ctx_switch@legacy-blt-heavy:
- Statuses : 6 pass(s)
- Exec time: [6.55, 21.87] s
* igt@gem_ctx_switch@legacy-blt-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 21.96] s
* igt@gem_ctx_switch@legacy-bsd1:
- Statuses : 6 pass(s)
- Exec time: [5.01, 5.08] s
* igt@gem_ctx_switch@legacy-bsd1--queue:
- Statuses : 3 pass(s) 2 skip(s)
- Exec time: [0.0, 5.05] s
* igt@gem_ctx_switch@legacy-bsd1-heavy:
- Statuses : 6 pass(s)
- Exec time: [5.34, 21.81] s
* igt@gem_ctx_switch@legacy-bsd1-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 21.90] s
* igt@gem_ctx_switch@legacy-bsd2:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 5.03] s
* igt@gem_ctx_switch@legacy-bsd2--queue:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 5.03] s
* igt@gem_ctx_switch@legacy-bsd2-heavy:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 12.16] s
* igt@gem_ctx_switch@legacy-bsd2-heavy-queue:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 12.33] s
* igt@gem_ctx_switch@legacy-render:
- Statuses : 6 pass(s)
- Exec time: [5.02, 5.09] s
* igt@gem_ctx_switch@legacy-render--queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.08] s
* igt@gem_ctx_switch@legacy-render-heavy:
- Statuses : 6 pass(s)
- Exec time: [5.24, 14.06] s
* igt@gem_ctx_switch@legacy-render-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 14.09] s
* igt@gem_ctx_switch@legacy-vebox:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0, 5.07] s
* igt@gem_ctx_switch@legacy-vebox--queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.06] s
* igt@gem_ctx_switch@legacy-vebox-heavy:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0, 21.27] s
* igt@gem_ctx_switch@legacy-vebox-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 21.46] s
* igt@gem_ctx_switch@queue-heavy:
- Statuses : 3 pass(s) 2 skip(s)
- Exec time: [0.0, 108.00] s
* igt@gem_ctx_switch@queue-light:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 145.36] s
* igt@gem_ctx_switch@rcs0:
- Statuses : 6 pass(s)
- Exec time: [5.02, 5.09] s
* igt@gem_ctx_switch@rcs0--queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.10] s
* igt@gem_ctx_switch@rcs0-heavy:
- Statuses : 6 pass(s)
- Exec time: [5.27, 14.29] s
* igt@gem_ctx_switch@rcs0-heavy-queue:
- Statuses : 3 pass(s) 2 skip(s)
- Exec time: [0.0, 14.31] s
* igt@gem_ctx_switch@vcs0:
- Statuses : 6 pass(s)
- Exec time: [5.02, 5.08] s
* igt@gem_ctx_switch@vcs0--queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.08] s
* igt@gem_ctx_switch@vcs0-heavy:
- Statuses : 6 pass(s)
- Exec time: [5.42, 22.18] s
* igt@gem_ctx_switch@vcs0-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 21.95] s
* igt@gem_ctx_switch@vcs1:
- Statuses : 1 pass(s)
- Exec time: [5.03] s
* igt@gem_ctx_switch@vcs1--queue:
- Statuses : 1 pass(s)
- Exec time: [5.03] s
* igt@gem_ctx_switch@vcs1-heavy:
- Statuses : 1 pass(s)
- Exec time: [16.11] s
* igt@gem_ctx_switch@vcs1-heavy-queue:
- Statuses : 1 pass(s)
- Exec time: [12.33] s
* igt@gem_ctx_switch@vcs2:
- Statuses : 1 pass(s)
- Exec time: [5.03] s
* igt@gem_ctx_switch@vcs2--queue:
- Statuses : 1 pass(s)
- Exec time: [5.03] s
* igt@gem_ctx_switch@vcs2-heavy:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_switch@vcs2-heavy-queue:
- Statuses : 1 pass(s)
- Exec time: [12.86] s
* igt@gem_ctx_switch@vecs0:
- Statuses : 5 pass(s)
- Exec time: [5.02, 5.08] s
* igt@gem_ctx_switch@vecs0--queue:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 5.08] s
* igt@gem_ctx_switch@vecs0-heavy:
- Statuses : 5 pass(s)
- Exec time: [5.39, 21.27] s
* igt@gem_ctx_switch@vecs0-heavy-queue:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 21.60] s
Known issues
------------
Here are the changes found in IGTPW_3202_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-iclb8/igt@[email protected]
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([fdo#108686] / [fdo#110853])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-glk9/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-glk9/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-apl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-64x64-offscreen:
- shard-glk: [PASS][7] -> [INCOMPLETE][8] ([fdo#103359] / [k.org#198133])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-glk1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-glk3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-64x64-random:
- shard-apl: [PASS][9] -> [FAIL][10] ([fdo#103232])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-apl5/igt@[email protected]
- shard-kbl: [PASS][11] -> [FAIL][12] ([fdo#103232])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-kbl4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-kbl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([fdo#105345])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-kbl2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-kbl2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103167]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-iclb1/igt@[email protected]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: [PASS][17] -> [INCOMPLETE][18] ([fdo#103927]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-apl8/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#103166])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-iclb8/igt@[email protected]
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb2/igt@kms_psr@psr2_basic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-iclb1/igt@kms_psr@psr2_basic.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][23] -> [FAIL][24] ([fdo#99912])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-apl8/igt@[email protected]
- shard-kbl: [PASS][25] -> [FAIL][26] ([fdo#99912])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-kbl2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-kbl3/igt@[email protected]
* igt@kms_sysfs_edid_timing:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#100047])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb5/igt@kms_sysfs_edid_timing.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-iclb3/igt@kms_sysfs_edid_timing.html
#### Possible fixes ####
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: [FAIL][29] ([fdo#108686]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-hsw1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-hsw7/igt@[email protected]
* igt@i915_pm_rpm@i2c:
- shard-hsw: [FAIL][31] ([fdo#104097]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-hsw1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-hsw5/igt@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-apl: [DMESG-WARN][33] -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl5/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-apl1/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
- shard-kbl: [FAIL][35] ([fdo#103232]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-kbl7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-kbl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
- shard-hsw: [SKIP][37] ([fdo#109271]) -> [PASS][38] +23 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-hsw8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
- shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][41] ([fdo#109441]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb4/igt@kms_psr@psr2_dpms.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-iclb2/igt@kms_psr@psr2_dpms.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][43] ([fdo#108566]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-apl1/igt@[email protected]
#### Warnings ####
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][45] ([fdo#109349]) -> [DMESG-WARN][46] ([fdo#107724])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/shard-iclb2/igt@[email protected]
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#105345]: https://bugs.freedesktop.org/show_bug.cgi?id=105345
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110853]: https://bugs.freedesktop.org/show_bug.cgi?id=110853
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_5069 -> IGTPW_3202
* Piglit: piglit_4509 -> None
CI_DRM_6373: cc7ffe2a301509ba233652ec17d0f74c18b5c8a9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3202: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/
IGT_5069: 439a9f5d615f31f03cc3a3a5cbab19367a1af763 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3202/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/i915/gem_ctx_switch: Update with engine discovery (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: tests/i915/gem_ctx_switch: Update with engine discovery (rev2)
URL : https://patchwork.freedesktop.org/series/62845/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6373_full -> IGTPW_3203_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/62845/revisions/2/mbox/
New tests
---------
New tests have been introduced between CI_DRM_6373_full and IGTPW_3203_full:
### New IGT tests (48) ###
* igt@gem_ctx_switch@all-heavy:
- Statuses : 6 pass(s)
- Exec time: [98.33, 104.92] s
* igt@gem_ctx_switch@all-light:
- Statuses : 5 pass(s)
- Exec time: [109.07, 154.59] s
* igt@gem_ctx_switch@bcs0:
- Statuses : 6 pass(s)
- Exec time: [5.02, 5.08] s
* igt@gem_ctx_switch@bcs0-heavy:
- Statuses : 6 pass(s)
- Exec time: [6.55, 22.11] s
* igt@gem_ctx_switch@bcs0-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 22.02] s
* igt@gem_ctx_switch@bcs0-queue:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 5.07] s
* igt@gem_ctx_switch@legacy-blt:
- Statuses : 6 pass(s)
- Exec time: [5.01, 5.08] s
* igt@gem_ctx_switch@legacy-blt-heavy:
- Statuses : 6 pass(s)
- Exec time: [6.25, 21.77] s
* igt@gem_ctx_switch@legacy-blt-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 22.47] s
* igt@gem_ctx_switch@legacy-blt-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.07] s
* igt@gem_ctx_switch@legacy-bsd1:
- Statuses : 6 pass(s)
- Exec time: [5.02, 5.08] s
* igt@gem_ctx_switch@legacy-bsd1-heavy:
- Statuses : 6 pass(s)
- Exec time: [5.51, 22.21] s
* igt@gem_ctx_switch@legacy-bsd1-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 22.40] s
* igt@gem_ctx_switch@legacy-bsd1-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.07] s
* igt@gem_ctx_switch@legacy-bsd2:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 5.03] s
* igt@gem_ctx_switch@legacy-bsd2-heavy:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 15.67] s
* igt@gem_ctx_switch@legacy-bsd2-heavy-queue:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 12.25] s
* igt@gem_ctx_switch@legacy-bsd2-queue:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 5.04] s
* igt@gem_ctx_switch@legacy-render:
- Statuses : 6 pass(s)
- Exec time: [5.03, 5.10] s
* igt@gem_ctx_switch@legacy-render-heavy:
- Statuses : 6 pass(s)
- Exec time: [5.26, 14.24] s
* igt@gem_ctx_switch@legacy-render-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 13.98] s
* igt@gem_ctx_switch@legacy-render-queue:
- Statuses : 3 pass(s) 2 skip(s)
- Exec time: [0.0, 5.09] s
* igt@gem_ctx_switch@legacy-vebox:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0, 5.08] s
* igt@gem_ctx_switch@legacy-vebox-heavy:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0, 21.50] s
* igt@gem_ctx_switch@legacy-vebox-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 21.70] s
* igt@gem_ctx_switch@legacy-vebox-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.07] s
* igt@gem_ctx_switch@queue-heavy:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 108.16] s
* igt@gem_ctx_switch@queue-light:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 158.26] s
* igt@gem_ctx_switch@rcs0:
- Statuses : 6 pass(s)
- Exec time: [5.03, 5.11] s
* igt@gem_ctx_switch@rcs0-heavy:
- Statuses : 6 pass(s)
- Exec time: [5.25, 14.31] s
* igt@gem_ctx_switch@rcs0-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 15.39] s
* igt@gem_ctx_switch@rcs0-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.09] s
* igt@gem_ctx_switch@vcs0:
- Statuses : 6 pass(s)
- Exec time: [5.02, 5.08] s
* igt@gem_ctx_switch@vcs0-heavy:
- Statuses : 6 pass(s)
- Exec time: [5.41, 21.56] s
* igt@gem_ctx_switch@vcs0-heavy-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 22.05] s
* igt@gem_ctx_switch@vcs0-queue:
- Statuses : 4 pass(s) 2 skip(s)
- Exec time: [0.0, 5.07] s
* igt@gem_ctx_switch@vcs1:
- Statuses : 1 pass(s)
- Exec time: [5.03] s
* igt@gem_ctx_switch@vcs1-heavy:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_switch@vcs1-heavy-queue:
- Statuses : 1 pass(s)
- Exec time: [16.81] s
* igt@gem_ctx_switch@vcs1-queue:
- Statuses : 1 pass(s)
- Exec time: [5.04] s
* igt@gem_ctx_switch@vcs2:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_switch@vcs2-heavy:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_switch@vcs2-heavy-queue:
- Statuses :
- Exec time: [None] s
* igt@gem_ctx_switch@vcs2-queue:
- Statuses : 1 pass(s)
- Exec time: [5.02] s
* igt@gem_ctx_switch@vecs0:
- Statuses : 5 pass(s)
- Exec time: [5.03, 5.08] s
* igt@gem_ctx_switch@vecs0-heavy:
- Statuses : 5 pass(s)
- Exec time: [5.38, 21.28] s
* igt@gem_ctx_switch@vecs0-heavy-queue:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 21.54] s
* igt@gem_ctx_switch@vecs0-queue:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 5.08] s
Known issues
------------
Here are the changes found in IGTPW_3203_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_swapping@non-threaded:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([fdo#108686] / [fdo#110853])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl5/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-apl2/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-apl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x21-random:
- shard-kbl: [PASS][5] -> [FAIL][6] ([fdo#103232])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-kbl4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-kbl3/igt@[email protected]
- shard-apl: [PASS][7] -> [FAIL][8] ([fdo#103232])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-apl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [PASS][9] -> [FAIL][10] ([fdo#103167]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-iclb2/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103166])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-iclb6/igt@[email protected]
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb2/igt@kms_psr@psr2_basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-iclb7/igt@kms_psr@psr2_basic.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][15] -> [FAIL][16] ([fdo#99912])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-apl5/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][17] -> [INCOMPLETE][18] ([fdo#103665])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-kbl2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-kbl4/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@i2c:
- shard-hsw: [FAIL][19] ([fdo#104097]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-hsw1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-hsw7/igt@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-apl: [DMESG-WARN][21] -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl5/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-apl5/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
- shard-kbl: [FAIL][23] ([fdo#103232]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-kbl7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-kbl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
- shard-hsw: [SKIP][25] ([fdo#109271]) -> [PASS][26] +23 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-hsw2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
- shard-iclb: [FAIL][27] ([fdo#103167]) -> [PASS][28] +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][29] ([fdo#109441]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb4/igt@kms_psr@psr2_dpms.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-iclb2/igt@kms_psr@psr2_dpms.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][31] ([fdo#108566]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/shard-apl1/igt@[email protected]
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110853]: https://bugs.freedesktop.org/show_bug.cgi?id=110853
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_5069 -> IGTPW_3203
* Piglit: piglit_4509 -> None
CI_DRM_6373: cc7ffe2a301509ba233652ec17d0f74c18b5c8a9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3203: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/
IGT_5069: 439a9f5d615f31f03cc3a3a5cbab19367a1af763 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3203/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Tvrtko Ursulin (2019-06-27 11:20:19)
Quoted 10 lines
From: Tvrtko Ursulin <[email protected]>
I converted this one as an example, or at least to drive the discussion, how more complex tests can be converted.
I have kept the legacy execbuf abi testing prefixed with "legacy-".
New tests were added to exercise physical engines via engine discovery and also "all" tests have been updated in the same way.
Quoted 8 lines
To keep things simpler and avoid having to create separate contexts legacy tests have to be first since the
__for_each_physical_engineiterator would otherwise configure the default context and confuse the test.So legacy tests run on the unconfigured (with engine map) context and use a new helper
gem_eb_flags_to_engineto look up the engine from theintel_execution_engines2static list. This is only to enable the core test code to be shared.
Note that this misses the I915_EXEC_DEFAULT slot. That a rather significant oversight.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Tvrtko Ursulin (2019-06-27 11:20:19)
lib/i915/gem_engine_topology.c bool gem_has_engine_topology(int fd) · line 315
Quoted 10 lines
lib/i915/gem_engine_topology.c +10
-0+bool gem_context_has_engine_map (int fd,uint32_t ctx) +{ +struct drm_i915_gem_context_param param = { + .param =I915_CONTEXT_PARAM_ENGINES , + .ctx_id = ctx + }; +int ret; + + ret =__gem_context_get_param (fd, ¶m); +igt_assert_eq (ret,0 );
ret is -EINVAL if the parameter doesn't exist on older kernels, where naturally we have no engine map!
bool result;
result = false;
if (__gem_context_get_param(fd, ¶m) == 0)
result = param.size;
return result;
?
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev