Skip to contentSkip to conversation

perf tools: Fix bison warnings for pure parser

PATCH In review Andi Kleen 3 participants 3 messages Jun 27, 2019 – Jul 2, 2019 perf events

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 perf tools: Fix bison warnings for pure parser

From: Andi Kleen <[email protected]>

bison 3.4.1 complains during a perf build:

util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
1 | %pure-parser
| ^~~~~~~~~~~~
CC /home/andi/lsrc/obj-perf/ui/browsers/map.o
util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]

util/expr.y:13.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
13 | %pure-parser

      | ^~~~~~~~~~~~

util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]

Change the declarations to %define api.pure

---
 tools/perf/util/expr.y         | 2 +-
 tools/perf/util/parse-events.y | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/perf/util/expr.y +1 -1
index 432b8560cf51..803c0929c205 100644
@@ -10,7 +10,7 @@
 #define MAXIDLEN 256
 %}
 
-%pure-parser
+%define api.pure
 %parse-param { double *final_val }
 %parse-param { struct parse_ctx *ctx }
 %parse-param { const char **pp }
tools/perf/util/parse-events.y +1 -1
index 6ad8d4914969..4eb10c27c30f 100644
@@ -1,4 +1,4 @@
-%pure-parser
+%define api.pure
 %parse-param {void *_parse_state}
 %parse-param {void *scanner}
 %lex-param {void* scanner}
Signature · 1 line
2.21.0
#1 lore raw
Quoted 10 lines · Andi Kleen

From: Andi Kleen <[email protected]>

bison 3.4.1 complains during a perf build:

util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
1 | %pure-parser
| ^~~~~~~~~~~~
CC /home/andi/lsrc/obj-perf/ui/browsers/map.o
util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]

Quoted 8 lines

util/expr.y:13.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
13 | %pure-parser

      | ^~~~~~~~~~~~

util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]

Change the declarations to %define api.pure

looks good, let's hope it'll pass Arnaldo's build test

jirka

Quoted 31 lines
---
 tools/perf/util/expr.y         | 2 +-
 tools/perf/util/parse-events.y | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/perf/util/expr.y +1 -1
index 432b8560cf51..803c0929c205 100644
@@ -10,7 +10,7 @@
 #define MAXIDLEN 256
 %}
 
-%pure-parser
+%define api.pure
 %parse-param { double *final_val }
 %parse-param { struct parse_ctx *ctx }
 %parse-param { const char **pp }
tools/perf/util/parse-events.y +1 -1
index 6ad8d4914969..4eb10c27c30f 100644
@@ -1,4 +1,4 @@
-%pure-parser
+%define api.pure
 %parse-param {void *_parse_state}
 %parse-param {void *scanner}
 %lex-param {void* scanner}
Signature · 1 line
2.21.0
#2 lore raw

Em Fri, Jun 28, 2019 at 10:05:07AM +0200, Jiri Olsa escreveu:

Quoted 16 lines · Andi Kleen
Quoted 15 lines

From: Andi Kleen <[email protected]>

bison 3.4.1 complains during a perf build:

util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
1 | %pure-parser
| ^~~~~~~~~~~~
CC /home/andi/lsrc/obj-perf/ui/browsers/map.o
util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]

util/expr.y:13.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
13 | %pure-parser

      | ^~~~~~~~~~~~

util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]

Quoted 5 lines
Quoted 3 lines

Change the declarations to %define api.pure

looks good, let's hope it'll pass Arnaldo's build test

starting the tests now...

Quoted 33 lines

jirka

Quoted 31 lines
---
 tools/perf/util/expr.y         | 2 +-
 tools/perf/util/parse-events.y | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/perf/util/expr.y +1 -1
index 432b8560cf51..803c0929c205 100644
@@ -10,7 +10,7 @@
 #define MAXIDLEN 256
 %}
 
-%pure-parser
+%define api.pure
 %parse-param { double *final_val }
 %parse-param { struct parse_ctx *ctx }
 %parse-param { const char **pp }
tools/perf/util/parse-events.y +1 -1
index 6ad8d4914969..4eb10c27c30f 100644
@@ -1,4 +1,4 @@
-%pure-parser
+%define api.pure
 %parse-param {void *_parse_state}
 %parse-param {void *scanner}
 %lex-param {void* scanner}
Signature · 1 line
2.21.0
Signature · 1 line
- Arnaldo