Skip to contentSkip to conversation

lib/i915: Use engine discovery in gem_test_engines

PATCH In review Tvrtko Ursulin 3 participants 4 messages Jun 27, 2019 – Jun 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/i915: Use engine discovery in gem_test_engines

From: Tvrtko Ursulin <[email protected]>

If request is to verify all engines work, use the new engine discovery API so we can actually test all.

There is a sporadic and mysterious, possibly memory corruption issue surronding this area so lets see if this changes the pattern.

It is easy to do in this function due it re-opening the driver and throwing it away. So there are no concerns that the modified default context can affect any other test.

References: https://bugzilla.freedesktop.org/show_bug.cgi?id=110667

---
 lib/i915/gem_submission.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
lib/i915/gem_submission.c +6 -2
index 2fd460d5ed2b..a8bb45c6ac8f 100644
@@ -28,6 +28,8 @@
 
 #include <i915_drm.h>
 
+#include "i915/gem_engine_topology.h"
+
 #include "igt_core.h"
 #include "igt_gt.h"
 #include "igt_sysfs.h"
@@ -215,8 +217,10 @@ void gem_test_engine(int i915, unsigned int engine)
 	gem_write(i915, obj.handle, 0, &bbe, sizeof(bbe));
 
 	if (engine == ALL_ENGINES) {
-		for_each_physical_engine(i915, engine) {
-			execbuf.flags = engine;
+		const struct intel_execution_engine2 *e2;
+
+		__for_each_physical_engine(i915, e2) {
+			execbuf.flags = e2->flags;
 			gem_execbuf(i915, &execbuf);
 		}
 	} else {
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v1 1/1
#1 lore raw

Quoting Tvrtko Ursulin (2019-06-27 13:25:52)

Quoted 7 lines

From: Tvrtko Ursulin <[email protected]>

If request is to verify all engines work, use the new engine discovery API so we can actually test all.

There is a sporadic and mysterious, possibly memory corruption issue surronding this area so lets see if this changes the pattern.

While I do not think the purely on-stack parameters here are subject to memory corruption, nor should the validation path for the execbuf parameters be affected by suspend, if this makes the problem go away, I can be blissfully ignorant as to what was the actual cause.

Quoted 6 lines

It is easy to do in this function due it re-opening the driver and throwing it away. So there are no concerns that the modified default context can affect any other test.

References: https://bugzilla.freedesktop.org/show_bug.cgi?id=110667

-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/i915: Use engine discovery in gem_test_engines

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: lib/i915: Use engine discovery in gem_test_engines
URL : https://patchwork.freedesktop.org/series/62854/
State : success

== Summary ==

CI Bug Log - changes from IGT_5070 -> IGTPW_3205
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/62854/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_3205 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_mmap_gtt@basic-small-bo-tiledy:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/fi-icl-u3/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-skl-iommu: [PASS][3] -> [INCOMPLETE][4] ([fdo#108602])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/fi-skl-iommu/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/fi-skl-iommu/igt@i915_selftest@live_blt.html

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: [PASS][5] -> [FAIL][6] ([fdo#103167])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/fi-icl-u3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/fi-icl-u3/igt@[email protected]

#### Possible fixes ####

* igt@gem_workarounds@basic-read:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/fi-icl-u3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/fi-icl-u3/igt@[email protected]

* igt@i915_module_load@reload-no-display:
- fi-icl-dsi: [INCOMPLETE][9] ([fdo#107713]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/fi-icl-dsi/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/fi-icl-dsi/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- fi-kbl-r: [DMESG-WARN][11] ([fdo#111012]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/fi-kbl-r/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/fi-kbl-r/igt@[email protected]

* igt@kms_flip@basic-plain-flip:
- fi-icl-dsi: [DMESG-WARN][13] ([fdo#106107]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/fi-icl-dsi/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/fi-icl-dsi/igt@[email protected]

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#111012]: https://bugs.freedesktop.org/show_bug.cgi?id=111012

Participating hosts (52 -> 44)
------------------------------

Additional (2): fi-bdw-gvtdvm fi-skl-gvtdvm
Missing (10): fi-kbl-soraka fi-ilk-m540 fi-bdw-5557u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ivb-3770 fi-icl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

* IGT: IGT_5070 -> IGTPW_3205

CI_DRM_6374: 0c5076215689ad865b43ec530552a573dded361a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3205: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/
IGT_5070: 250475af7bc52ba64956e6b35591fdd7176954d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for lib/i915: Use engine discovery in gem_test_engines

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: lib/i915: Use engine discovery in gem_test_engines
URL : https://patchwork.freedesktop.org/series/62854/
State : success

== Summary ==

CI Bug Log - changes from IGT_5070_full -> IGTPW_3205_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/62854/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_3205_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_eio@unwedge-stress:
- shard-snb: [PASS][1] -> [FAIL][2] ([fdo#109661])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-snb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-snb7/igt@[email protected]

* igt@i915_pm_rpm@i2c:
- shard-hsw: [PASS][3] -> [FAIL][4] ([fdo#104097])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-hsw4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-hsw8/igt@[email protected]

* igt@i915_pm_rpm@legacy-planes-dpms:
- shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713] / [fdo#108840] / [fdo#109960])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-iclb5/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-iclb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-hsw: [PASS][7] -> [SKIP][8] ([fdo#109271]) +19 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-hsw4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-hsw1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-apl: [PASS][9] -> [FAIL][10] ([fdo#103167])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-apl2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-apl5/igt@[email protected]
- shard-kbl: [PASS][11] -> [FAIL][12] ([fdo#103167])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-kbl6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-kbl6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109642])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-iclb2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-iclb8/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +5 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-apl2/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-apl8/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][21] ([fdo#110854]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-iclb3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-iclb2/igt@[email protected]

* igt@i915_selftest@mock_requests:
- shard-glk: [INCOMPLETE][23] ([fdo#103359] / [k.org#198133]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-glk7/igt@i915_selftest@mock_requests.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-glk1/igt@i915_selftest@mock_requests.html

* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-hsw: [FAIL][25] ([fdo#103355]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-hsw8/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-hsw7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite:
- shard-hsw: [SKIP][27] ([fdo#109271]) -> [PASS][28] +22 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-hsw5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][29] ([fdo#103167]) -> [PASS][30] +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-iclb1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-iclb7/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-apl: [DMESG-WARN][31] ([fdo#108566]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-apl4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-apl5/igt@[email protected]

* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][33] ([fdo#109441]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_cpu.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html

* igt@perf_pmu@rc6-runtime-pm:
- shard-apl: [FAIL][35] ([fdo#105010]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-apl4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-apl2/igt@[email protected]

#### Warnings ####

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][37] ([fdo#109349]) -> [DMESG-WARN][38] ([fdo#107724])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5070/shard-iclb4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/shard-iclb2/igt@[email protected]

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#109960]: https://bugs.freedesktop.org/show_bug.cgi?id=109960
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (7 -> 6)
------------------------------

Missing (1): shard-skl

Build changes
-------------

* IGT: IGT_5070 -> IGTPW_3205

CI_DRM_6374: 0c5076215689ad865b43ec530552a573dded361a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3205: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/
IGT_5070: 250475af7bc52ba64956e6b35591fdd7176954d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3205/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev