staging/rtl8723bs/hal: fix comparison to true/false is error prone
PATCH 10/10 staging/rtl8723bs/hal: fix comparison to true/false is error prone
fix below issues reported by checkpatch
CHECK: Using comparison to false is error prone
CHECK: Using comparison to true is error prone
Signed-off-by Hariprasad Kelam <[email protected]>
--- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8723bs/hal/hal_btcoex.c +5 -5
@@ -290,7 +290,7 @@ static u8 halbtcoutsrc_IsWifiBusy(struct adapter *padapter)if (check_fwstate (pmlmepriv,WIFI_ASOC_STATE ) == true) {if (check_fwstate (pmlmepriv,WIFI_AP_STATE ) == true)return true; -if (true == pmlmepriv->LinkDetectInfo.bBusyTraffic) +if (pmlmepriv->LinkDetectInfo.bBusyTraffic)return true; }
@@ -310,12 +310,12 @@ static u32 _halbtcoutsrc_GetWifiLinkStatus(struct adapter *padapter)if (check_fwstate (pmlmepriv,WIFI_ASOC_STATE ) == true) {if (check_fwstate (pmlmepriv,WIFI_AP_STATE ) == true) { -if (true == bp2p) +if (bp2p) portConnectedStatus |=WIFI_P2P_GO_CONNECTED ;else portConnectedStatus |=WIFI_AP_CONNECTED ; }else { -if (true == bp2p) +if (bp2p) portConnectedStatus |=WIFI_P2P_GC_CONNECTED ;else portConnectedStatus |=WIFI_STA_CONNECTED ;
@@ -372,7 +372,7 @@ static u8 halbtcoutsrc_GetWifiScanAPNum(struct adapter *padapter) pmlmeext = &padapter->mlmeextpriv; -if (GLBtcWiFiInScanState == false) { +if (!GLBtcWiFiInScanState) {if (pmlmeext->sitesurvey_res.bss_cnt >0xFF ) scan_AP_num =0xFF ;else
@@ -1444,7 +1444,7 @@ void hal_btcoex_IQKNotify(struct adapter *padapter, u8 state)void hal_btcoex_BtInfoNotify (struct adapter *padapter,u8 length,u8 *tmpBuf) { -if (GLBtcWiFiInIQKState == true) +if (GLBtcWiFiInIQKState)return ;EXhalbtcoutsrc_BtInfoNotify (&GLBtCoexist, tmpBuf, length);
Signature · 1 line
2.7.4
On Sat, Jun 29, 2019 at 04:07:51PM +0530, Hariprasad Kelam wrote:
Hello Hari Prasad,
Please add the recommended reviewers mentioned in the TODO file of rtl8723bs directory.
I see the following emails in the TODO file.
Greg Kroah-Hartman <[email protected]>, Hans de Goede <[email protected]> and Larry Finger <[email protected]>
Quoted 59 lines
fix below issues reported by checkpatch
CHECK: Using comparison to false is error prone
CHECK: Using comparison to true is error proneSigned-off-by Hariprasad Kelam <[email protected]>--- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/staging/rtl8723bs/hal/hal_btcoex.c +5
-5@@ -290,7 +290,7 @@ static u8 halbtcoutsrc_IsWifiBusy(struct adapter *padapter)if (check_fwstate (pmlmepriv,WIFI_ASOC_STATE ) == true) {if (check_fwstate (pmlmepriv,WIFI_AP_STATE ) == true)return true; -if (true == pmlmepriv->LinkDetectInfo.bBusyTraffic) +if (pmlmepriv->LinkDetectInfo.bBusyTraffic)return true; }@@ -310,12 +310,12 @@ static u32 _halbtcoutsrc_GetWifiLinkStatus(struct adapter *padapter)if (check_fwstate (pmlmepriv,WIFI_ASOC_STATE ) == true) {if (check_fwstate (pmlmepriv,WIFI_AP_STATE ) == true) { -if (true == bp2p) +if (bp2p) portConnectedStatus |=WIFI_P2P_GO_CONNECTED ;else portConnectedStatus |=WIFI_AP_CONNECTED ; }else { -if (true == bp2p) +if (bp2p) portConnectedStatus |=WIFI_P2P_GC_CONNECTED ;else portConnectedStatus |=WIFI_STA_CONNECTED ;@@ -372,7 +372,7 @@ static u8 halbtcoutsrc_GetWifiScanAPNum(struct adapter *padapter) pmlmeext = &padapter->mlmeextpriv; -if (GLBtcWiFiInScanState == false) { +if (!GLBtcWiFiInScanState) {if (pmlmeext->sitesurvey_res.bss_cnt >0xFF ) scan_AP_num =0xFF ;else @@ -1444,7 +1444,7 @@ void hal_btcoex_IQKNotify(struct adapter *padapter, u8 state)void hal_btcoex_BtInfoNotify (struct adapter *padapter,u8 length,u8 *tmpBuf) { -if (GLBtcWiFiInIQKState == true) +if (GLBtcWiFiInIQKState)return ;EXhalbtcoutsrc_BtInfoNotify (&GLBtCoexist, tmpBuf, length);Signature · 1 line
2.7.4