Skip to contentSkip to conversation

Bluetooth: btsdio: Do not bind to non-removable BCM4356

PATCH In review Peter Robinson 3 participants 4 messages Jun 30, 2019 – Jul 6, 2019 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: btsdio: Do not bind to non-removable BCM4356

BCM4356 devices soldered onto the PCB (non-removable) use an UART connection for bluetooth, such as the Rock960, but it also advertise btsdio support as a sdio function.

CC Manivannan Sadhasivam <[email protected]>
---
 drivers/bluetooth/btsdio.c | 1 +
 1 file changed, 1 insertion(+)
drivers/bluetooth/btsdio.c +1 -0
index 83748b7b2033..fd9571d5fdac 100644
@@ -286,6 +286,7 @@ static int btsdio_probe(struct sdio_func *func,
 		switch (func->device) {
 		case SDIO_DEVICE_ID_BROADCOM_43341:
 		case SDIO_DEVICE_ID_BROADCOM_43430:
+		case SDIO_DEVICE_ID_BROADCOM_4356:
 			return -ENODEV;
 		}
 	}
Signature · 1 line
2.21.0
#1 lore raw

Hi Peter,

Quoted 3 lines · Peter Robinson

BCM4356 devices soldered onto the PCB (non-removable) use an UART connection for bluetooth, such as the Rock960, but it also advertise btsdio support as a sdio function.

Sorry, I don't get the point of this patch. What if BCM4356 is used in different configuration on some other platform (using SDIO for Bluetooth but still soldered on the PCB)? I haven't seen any such but just curious what if!

Thanks,
Mani

Quoted 19 lines
CC Manivannan Sadhasivam <[email protected]>

---
drivers/bluetooth/btsdio.c | 1 +

1 file changed, 1 insertion(+)
drivers/bluetooth/btsdio.c +1 -0
index 83748b7b2033..fd9571d5fdac 100644
@@ -286,6 +286,7 @@ static int btsdio_probe(struct sdio_func *func,
 		switch (func->device) {
 		case SDIO_DEVICE_ID_BROADCOM_43341:
 		case SDIO_DEVICE_ID_BROADCOM_43430:
+		case SDIO_DEVICE_ID_BROADCOM_4356:
 			return -ENODEV;
 		}
 	}
Signature · 1 line
Sent from my Android device with K-9 Mail. Please excuse my brevity.
#2 lore raw
Quoted 9 lines · Manivannan Sadhasivam

Hi Peter,

Quoted 3 lines · Peter Robinson

BCM4356 devices soldered onto the PCB (non-removable) use an UART connection for bluetooth, such as the Rock960, but it also advertise btsdio support as a sdio function.

Sorry, I don't get the point of this patch. What if BCM4356 is used in different configuration on some other platform (using SDIO for Bluetooth but still soldered on the PCB)? I haven't seen any such but just curious what if!

Without if you get duplicated interfaces, the SDIO one of which doesn't work and causes confusion:

hci1: Type: Primary Bus: UART

        BD Address: CC:4B:73:04:2F:1D  ACL MTU: 1021:8  SCO MTU: 64:1
        UP RUNNING
        RX bytes:1749 acl:0 sco:0 events:89 errors:0
        TX bytes:2950 acl:0 sco:0 commands:89 errors:0

hci0: Type: Primary Bus: SDIO
BD Address: 00:00:00:00:00:00 ACL MTU: 0:0 SCO MTU: 0:0 DOWN
RX bytes:0 acl:0 sco:0 events:0 errors:0
TX bytes:0 acl:0 sco:0 commands:0 errors:0

It was the same work around/fix that was used for a number of other devices, see commits b4cdaba27424 and 70ecdd3d8b36.

Peter

Quoted 24 lines

Thanks,
Mani

Quoted 12 lines
CC Manivannan Sadhasivam <[email protected]>

---
drivers/bluetooth/btsdio.c | 1 +

1 file changed, 1 insertion(+)
drivers/bluetooth/btsdio.c +0 -0
index 83748b7b2033..fd9571d5fdac 100644

drivers/bluetooth/btsdio.c static int btsdio_probe(struct sdio_func *func, · line 292

Quoted 7 lines
drivers/bluetooth/btsdio.c +1 -0
@@ -286,6 +286,7 @@ static int btsdio_probe(struct sdio_func *func,
              switch (func->device) {
              case SDIO_DEVICE_ID_BROADCOM_43341:
              case SDIO_DEVICE_ID_BROADCOM_43430:
+              case SDIO_DEVICE_ID_BROADCOM_4356:
                      return -ENODEV;
              }
      }

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.