poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support
PATCH 1/1 poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support
There is a regression seen on Poplar platform, which doesn't even show a U-Boot version banner on booting. It turns out that due to landing of commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver"), we need to increase SYS_MALLOC_F_LEN from its default size 0x400, as pre-relocation requires more memory there. Let's increase SYS_MALLOC_F_LEN to 0x4000 to fix the regression.
Thanks to Andreas Färber <[email protected]> for reporting, and Bin Meng <[email protected]> for trouble shooting.
--- configs/poplar_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/poplar_defconfig +1 -0
@@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_TARGET_POPLAR=y CONFIG_SYS_TEXT_BASE=0x37000000 +CONFIG_SYS_MALLOC_F_LEN=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_IDENT_STRING="poplar" CONFIG_DISTRO_DEFAULTS=y
Signature · 1 line
2.18.0
PATCH 1/1 poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support
Quoted 8 lines · Shawn Guo
There is a regression seen on Poplar platform, which doesn't even show a U-Boot version banner on booting. It turns out that due to landing of commit
3a7c45f6a772("simple-bus: addDM_FLAG_PRE_RELOCflag to simple-bus driver"), we need to increaseSYS_MALLOC_F_LENfrom its default size0x400, as pre-relocation requires more memory there. Let's increaseSYS_MALLOC_F_LENto0x4000to fix the regression.
Quoted 9 lines
Thanks to Andreas Färber <[email protected]> for reporting, and Bin Meng <[email protected]> for trouble shooting.
Reported-by Andreas Färber <[email protected]>Signed-off-by Shawn Guo <[email protected]>--- configs/poplar_defconfig | 1 + 1 file changed, 1 insertion(+)
PATCH 1/1 poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support
In reply to Shawn GuoAm 17.06.19 um 05:08 schrieb Shawn Guo:
Quoted 9 lines
There is a regression seen on Poplar platform, which doesn't even show a U-Boot version banner on booting. It turns out that due to landing of commit
3a7c45f6a772("simple-bus: addDM_FLAG_PRE_RELOCflag to simple-bus driver"), we need to increaseSYS_MALLOC_F_LENfrom its default size0x400, as pre-relocation requires more memory there. Let's increaseSYS_MALLOC_F_LENto0x4000to fix the regression.Thanks to Andreas Färber <[email protected]> for reporting, and Bin Meng <[email protected]> for trouble shooting.
Thanks - you could add a Suggested-by for Bin after Reported-by and drop the paragraph, if there's any other changes needed.
Quoted 3 lines
Reported-by Andreas Färber <[email protected]>Signed-off-by Shawn Guo <[email protected]>
Thanks for the quick solution,
Andreas
Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
PATCH 1/1 poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support
In reply to Shawn GuoQuoted 8 lines · Shawn Guo
There is a regression seen on Poplar platform, which doesn't even show a U-Boot version banner on booting. It turns out that due to landing of commit
3a7c45f6a772("simple-bus: addDM_FLAG_PRE_RELOCflag to simple-bus driver"), we need to increaseSYS_MALLOC_F_LENfrom its default size0x400, as pre-relocation requires more memory there. Let's increaseSYS_MALLOC_F_LENto0x4000to fix the regression.
Quoted 5 lines
Thanks to Andreas Färber <[email protected]> for reporting, and Bin Meng <[email protected]> for trouble shooting.
Reported-by Andreas Färber <[email protected]>Signed-off-by Shawn Guo <[email protected]>
Hi Tom,
Can you please have a look at this? Thanks.
Shawn
Quoted 19 lines
--- configs/poplar_defconfig | 1 + 1 file changed, 1 insertion(+)configs/poplar_defconfig +1
-1@@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_TARGET_POPLAR=y CONFIG_SYS_TEXT_BASE=0x37000000 +CONFIG_SYS_MALLOC_F_LEN=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_IDENT_STRING="poplar" CONFIG_DISTRO_DEFAULTS=y --2.18.0
PATCH 1/1 poplar: increase SYS_MALLOC_F_LEN for DM_FLAG_PRE_RELOC support
In reply to Shawn GuoQuoted 7 lines · Shawn Guo
There is a regression seen on Poplar platform, which doesn't even show a U-Boot version banner on booting. It turns out that due to landing of commit
3a7c45f6a772("simple-bus: addDM_FLAG_PRE_RELOCflag to simple-bus driver"), we need to increaseSYS_MALLOC_F_LENfrom its default size0x400, as pre-relocation requires more memory there. Let's increaseSYS_MALLOC_F_LENto0x4000to fix the regression.
Quoted 7 lines
Thanks to Andreas Färber <[email protected]> for reporting, and Bin Meng <[email protected]> for trouble shooting.
Reported-by Andreas Färber <[email protected]>Signed-off-by Shawn Guo <[email protected]>Reviewed-by Bin Meng <[email protected]>Tested-by Andreas Färber <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190701/5a22f377/attachment.sig>