fix spelling errors in comments and messages
cover fix spelling errors in comments and messages
Ran the codespell tool against the lib and examples. Lots of little repeated errors fixed.
Stephen Hemminger (30):
lpm: fix spelling errors
eal/windows: fix comment about fnmatch bsd/eal: fix spelling error
eal: fix spelling errors
bpf: fix spelling errors
power: fix spelling errors
ipsec: fix spelling errors
acl: fix spelling errors
bbdev: fix spelling error
eventdev: fix spelling error
ethdev: fix spelling error
ip_frag: fix spelling error examples/multi_process: fix spelling errors examples/l3fwd: fix misspelling of destination examples/performance-thread: fix spelling errors examples/ethtool: fix spelling errors examples/vmdq: fix spelling errors examples/bond: fix spelling errors examples/l3fwd-power: fix spelling errors examples/netmap_compat: fix spelling errors examples/packet_ordering: fix spelling errors examples/service_cores: fix spelling errors examples/vhost: fix spelling errors examples/vhost_scsi: fix spelling errors examples/tep_termination: fix spelling errors examples/vm_power_manager: fix spelling errors
test-pmd: fix spelling errors
test: fix multiple spelling errors
proc-info: fix spelling error
test-compress-perf: fix spelling errors
app/proc-info/main.c | 2 +- app/test-compress-perf/main.c | 4 ++-- app/test-pmd/cmdline.c | 11 ++++++----- app/test-pmd/config.c | 4 ++-- app/test-pmd/csumonly.c | 2 +- app/test-pmd/softnicfwd.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_kni.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_ring.c | 2 +- app/test/test_rwlock.c | 2 +- examples/bbdev_app/main.c | 2 +- examples/bond/main.c | 2 +- examples/ethtool/lib/rte_ethtool.c | 2 +- examples/ethtool/lib/rte_ethtool.h | 4 ++-- examples/ip_fragmentation/main.c | 2 +- examples/ipsec-secgw/parser.c | 2 +- examples/ipsec-secgw/test/linux_test4.sh | 4 ++-- examples/ipsec-secgw/test/linux_test6.sh | 4 ++-- examples/l3fwd-power/main.c | 2 +- examples/l3fwd/l3fwd_common.h | 2 +- examples/l3fwd/l3fwd_neon.h | 2 +- examples/l3fwd/l3fwd_sse.h | 2 +- examples/multi_process/hotplug_mp/commands.c | 2 +- examples/multi_process/simple_mp/main.c | 2 +- examples/multi_process/symmetric_mp/main.c | 2 +- examples/netmap_compat/lib/compat_netmap.c | 2 +- examples/packet_ordering/main.c | 2 +- examples/performance-thread/common/lthread_tls.c | 2 +- examples/performance-thread/l3fwd-thread/main.c | 4 ++-- examples/service_cores/main.c | 2 +- examples/tep_termination/main.c | 6 +++--- examples/vhost/main.c | 6 +++--- examples/vhost_scsi/scsi.c | 2 +- examples/vhost_scsi/vhost_scsi.c | 2 +- examples/vm_power_manager/channel_monitor.c | 2 +- examples/vmdq/main.c | 2 +- examples/vmdq_dcb/main.c | 2 +- lib/librte_acl/acl.h | 4 ++-- lib/librte_acl/acl_bld.c | 2 +- lib/librte_acl/acl_run_avx2.h | 2 +- lib/librte_bbdev/rte_bbdev.c | 2 +- lib/librte_bpf/bpf_jit_x86.c | 2 +- lib/librte_bpf/bpf_validate.c | 2 +- lib/librte_eal/common/eal_common_fbarray.c | 2 +- lib/librte_eal/common/eal_common_log.c | 2 +- lib/librte_eal/common/eal_common_proc.c | 2 +- lib/librte_eal/common/eal_hugepages.h | 2 +- .../common/include/arch/arm/rte_cycles_32.h | 2 +- .../common/include/arch/x86/rte_atomic.h | 2 +- lib/librte_eal/common/include/rte_dev.h | 2 +- lib/librte_eal/common/malloc_elem.c | 2 +- lib/librte_eal/freebsd/eal/eal_memory.c | 2 +- lib/librte_eal/linux/eal/eal_vfio.c | 6 +++--- lib/librte_eal/windows/eal/include/fnmatch.h | 2 +- lib/librte_ethdev/rte_ethdev.c | 2 +- lib/librte_eventdev/rte_event_timer_adapter.c | 2 +- lib/librte_ip_frag/rte_ipv4_reassembly.c | 2 +- lib/librte_ipsec/esp_inb.c | 2 +- lib/librte_ipsec/sa.c | 2 +- lib/librte_ipsec/sa.h | 4 ++-- lib/librte_lpm/rte_lpm6.c | 6 +++--- lib/librte_power/power_acpi_cpufreq.c | 6 +++--- lib/librte_power/power_pstate_cpufreq.c | 6 +++--- lib/librte_power/rte_power.h | 2 +- 74 files changed, 111 insertions(+), 110 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/30 lpm: fix spelling errors
Fix small spelling errors (found by codespell)
--- lib/librte_lpm/rte_lpm6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/librte_lpm/rte_lpm6.c +3 -3
@@ -824,7 +824,7 @@ VERSION_SYMBOL(rte_lpm6_add, _v20, 2.0);* * Returns: * 0 on success -* -ENOSPC not enought tbl8 left +* -ENOSPC not enough tbl8 left */ static int simulate_add (struct rte_lpm6 *lpm,const uint8_t *masked_ip,uint8_t depth)
@@ -854,7 +854,7 @@ simulate_add(struct rte_lpm6 *lpm, const uint8_t *masked_ip, uint8_t depth) }if (tbl8_available (lpm) < total_need_tbl_nb) -/* not enought tbl8 to add a rule */ +/* not enough tbl8 to add a rule */ return -ENOSPC ;return 0 ;
@@ -1314,7 +1314,7 @@ rule_find_range(struct rte_lpm6 *lpm, const uint8_t *ip, uint8_t depth,/* minus top level */ depth -=24 ; -/* interate through levels (tbl8s) +/* iterate through levels (tbl8s) * until we reach the last one */ while (depth >8 ) {
Signature · 1 line
2.20.1
PATCH 2/30 eal/windows: fix comment about fnmatch
In reply to Stephen HemmingerFix spelling error in comment, and clarify that pattern is supposed to be shell wildcare (not regex) in case someone ever decides to implement proper code for this.
--- lib/librte_eal/windows/eal/include/fnmatch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_eal/windows/eal/include/fnmatch.h +1 -1
@@ -21,7 +21,7 @@ extern "C" {* with the given regular expression pattern. * * @param pattern -* regular expression notation decribing the pattern to match +* shell wildcard describing the pattern to match * * @param string * source string to searcg for the pattern
Signature · 1 line
2.20.1
PATCH 3/30 bsd/eal: fix spelling error
In reply to Stephen HemmingerMinor spelling error found by codespell
--- lib/librte_eal/freebsd/eal/eal_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_eal/freebsd/eal/eal_memory.c +1 -1
@@ -435,7 +435,7 @@ memseg_primary_init(void)* * we need (N*2)-1 segments because we cannot guarantee that * each segment will be IOVA-contiguous with the previous one, -* so we will allocate more and put spaces inbetween segments +* so we will allocate more and put spaces in between segments * that are non-contiguous. */ avail_segs = (hpi->num_pages[0 ] *2 ) -1 ;
Signature · 1 line
2.20.1
PATCH 4/30 eal: fix spelling errors
In reply to Stephen HemmingerLots of little spelling errors found by codespell.
--- lib/librte_eal/common/eal_common_fbarray.c | 2 +- lib/librte_eal/common/eal_common_log.c | 2 +- lib/librte_eal/common/eal_common_proc.c | 2 +- lib/librte_eal/common/eal_hugepages.h | 2 +- lib/librte_eal/common/include/arch/arm/rte_cycles_32.h | 2 +- lib/librte_eal/common/include/arch/x86/rte_atomic.h | 2 +- lib/librte_eal/common/include/rte_dev.h | 2 +- lib/librte_eal/common/malloc_elem.c | 2 +- lib/librte_eal/linux/eal/eal_vfio.c | 6 +++--- 9 files changed, 11 insertions(+), 11 deletions(-)
lib/librte_eal/common/eal_common_fbarray.c +1 -1
@@ -1334,7 +1334,7 @@ fbarray_find_biggest(struct rte_fbarray *arr, unsigned int start, bool used,*/ /* the API's called are thread-safe, but something may still happen -* inbetween the API calls, so lock the fbarray. all other API's are +* in between the API calls, so lock the fbarray. all other API's are * read-locking the fbarray, so read lock here is OK. */ rte_rwlock_read_lock (&arr->rwlock);
lib/librte_eal/common/eal_common_log.c +1 -1
@@ -45,7 +45,7 @@ static struct rte_eal_opt_loglevel_list opt_loglevel_list =static FILE *default_log_stream;/** -* This global structure stores some informations about the message +* This global structure stores some information about the message * that is currently being processed by one lcore */ struct log_cur_msg {
lib/librte_eal/common/eal_common_proc.c +1 -1
@@ -1071,7 +1071,7 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts, }if (gettimeofday (&now,NULL ) <0 ) { -RTE_LOG (ERR ,EAL ,"Faile to get current time\n" ); +RTE_LOG (ERR ,EAL ,"Failed to get current time\n" ); rte_errno = errno;return -1 ; }
lib/librte_eal/common/eal_hugepages.h +1 -1
@@ -12,7 +12,7 @@#define MAX_HUGEPAGE_PATH PATH_MAX/** -* Structure used to store informations about hugepages that we mapped +* Structure used to store information about hugepages that we mapped * through the files in hugetlbfs. */ struct hugepage_file {
lib/librte_eal/common/include/arch/arm/rte_cycles_32.h +1 -1
@@ -57,7 +57,7 @@ __rte_rdtsc_syscall(void)* asm volatile("mcr p15, 0, %0, c9, c12, 0" : : "r"(29)); * asm volatile("mcr p15, 0, %0, c9, c12, 1" : : "r"(0x8000000f)); * -* which is possible only from the priviledged mode (kernel space). +* which is possible only from the privileged mode (kernel space). */ static inline uint64_t __rte_rdtsc_pmccntr (void )
lib/librte_eal/common/include/arch/x86/rte_atomic.h +1 -1
@@ -55,7 +55,7 @@ extern "C" {* * As pointed by Java guys, that makes possible to use lock-prefixed * instructions to get the same effect as mfence and on most modern HW -* that gives a better perfomance then using mfence: +* that gives a better performance then using mfence: * https://shipilev.net/blog/2014/on-the-fence-with-dependencies/ * Basic idea is to use lock prefixed add with some dummy memory location * as the destination. From their experiments 128B(2 cache lines) below
lib/librte_eal/common/include/rte_dev.h +1 -1
@@ -231,7 +231,7 @@ __attribute__((used)) = str* "pci:v8086:d*:sv*:sd*" all PCI devices supported by this driver * whose vendor id is 0x8086. * -* The format of the kernel modules list is a parenthesed expression +* The format of the kernel modules list is a parenthesized expression * containing logical-and (&) and logical-or (|). * * The device pattern and the kmod expression are separated by a space.
lib/librte_eal/common/malloc_elem.c +1 -1
@@ -171,7 +171,7 @@ malloc_elem_insert(struct malloc_elem *elem) next_elem =NULL ; heap->last = elem; }else { -/* the new memory is somewhere inbetween start and end */ +/* the new memory is somewhere in between start and end */ uint64_t dist_from_start, dist_from_end; dist_from_end =RTE_PTR_DIFF (heap->last, elem);
lib/librte_eal/linux/eal/eal_vfio.c +3 -3
@@ -1272,7 +1272,7 @@ vfio_type1_dma_mem_map(int vfio_container_fd, uint64_t vaddr, uint64_t iova,*/ if (errno ==EEXIST ) {RTE_LOG (DEBUG ,EAL , -" Memory segment is allready mapped," +" Memory segment is already mapped," " skipping" ); }else { RTE_LOG(ERR, EAL,
@@ -1345,7 +1345,7 @@ vfio_spapr_dma_do_map(int vfio_container_fd, uint64_t vaddr, uint64_t iova,*/ if (errno ==EBUSY ) {RTE_LOG (DEBUG ,EAL , -" Memory segment is allready mapped," +" Memory segment is already mapped," " skipping" ); }else { RTE_LOG(ERR, EAL,
@@ -1632,7 +1632,7 @@ vfio_dma_mem_map(struct vfio_config *vfio_cfg, uint64_t vaddr, uint64_t iova,if (!t->dma_user_map_func) {RTE_LOG (ERR ,EAL , -" VFIO custom DMA region maping not supported by IOMMU %s\n" , +" VFIO custom DMA region mapping not supported by IOMMU %s\n" , t->name); rte_errno =ENOTSUP ;return -1 ;
Signature · 1 line
2.20.1
PATCH 5/30 bpf: fix spelling errors
In reply to Stephen HemmingerMinor typo's found by codespell.
--- lib/librte_bpf/bpf_jit_x86.c | 2 +- lib/librte_bpf/bpf_validate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
lib/librte_bpf/bpf_jit_x86.c +1 -1
@@ -1074,7 +1074,7 @@ emit_epilog(struct bpf_jit_state *st)uint32_t i;int32_t spil, ofs; -/* if we allready have an epilog generate a jump to it */ +/* if we already have an epilog generate a jump to it */ if (st->exit.num++ !=0 ) {emit_abs_jmp (st, st->exit.off);return ;
lib/librte_bpf/bpf_validate.c +1 -1
@@ -1901,7 +1901,7 @@ validate(struct bpf_verifier *bvf)/* * construct CFG, jcc nodes have to outgoing edges, -* 'exit' nodes - none, all others nodes have exaclty one +* 'exit' nodes - none, all others nodes have exactly one * outgoing edge. */ switch (ins->code) {
Signature · 1 line
2.20.1
PATCH 6/30 power: fix spelling errors
In reply to Stephen HemmingerMinor typo's found by codespell.
--- lib/librte_power/power_acpi_cpufreq.c | 6 +++--- lib/librte_power/power_pstate_cpufreq.c | 6 +++--- lib/librte_power/rte_power.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-)
lib/librte_power/power_acpi_cpufreq.c +3 -3
@@ -30,7 +30,7 @@#define FOPEN_OR_ERR_RET (f, retval) do { \ if ((f) == NULL) { \ - RTE_LOG(ERR, POWER, "File not openned\n"); \ + RTE_LOG(ERR, POWER, "File not opened\n"); \ return retval; \ } \ } while (0)
@@ -109,7 +109,7 @@ set_freq_internal(struct rte_power_info *pi, uint32_t idx)if (idx == pi->curr_idx)return 0 ; -POWER_DEBUG_TRACE ("Freqency[%u] %u to be set for lcore %u\n" , +POWER_DEBUG_TRACE ("Frequency[%u] %u to be set for lcore %u\n" , idx, pi->freqs[idx], pi->lcore_id);if (fseek (pi->f,0 ,SEEK_SET ) <0 ) { RTE_LOG(ERR, POWER, "Fail to set file position indicator to 0 "
@@ -225,7 +225,7 @@ power_get_available_freqs(struct rte_power_info *pi) goto out; } -/* Store the available frequncies into power context */ +/* Store the available frequencies into power context */ for (i =0 , pi->nb_freqs =0 ; i < count; i++) {POWER_DEBUG_TRACE ("Lcore %u frequency[%d]: %s\n" , pi->lcore_id, i, freqs[i]);
lib/librte_power/power_pstate_cpufreq.c +3 -3
@@ -33,7 +33,7 @@#define FOPEN_OR_ERR_RET (f, retval) do { \ if ((f) == NULL) { \ - RTE_LOG(ERR, POWER, "File not openned\n"); \ + RTE_LOG(ERR, POWER, "File not opened\n"); \ return retval; \ } \ } while (0)
@@ -287,7 +287,7 @@ set_freq_internal(struct pstate_power_info *pi, uint32_t idx)return -1 ; } -POWER_DEBUG_TRACE ("Freqency '%u' to be set for lcore %u\n" , +POWER_DEBUG_TRACE ("Frequency '%u' to be set for lcore %u\n" , target_freq, pi->lcore_id);fflush (pi->f_cur_min);
@@ -310,7 +310,7 @@ set_freq_internal(struct pstate_power_info *pi, uint32_t idx)return -1 ; } -POWER_DEBUG_TRACE ("Freqency '%u' to be set for lcore %u\n" , +POWER_DEBUG_TRACE ("Frequency '%u' to be set for lcore %u\n" , target_freq, pi->lcore_id);fflush (pi->f_cur_max);
lib/librte_power/rte_power.h +1 -1
@@ -26,7 +26,7 @@ enum power_management_env {PM_ENV_NOT_SET, PM_ENV_ACPI_CPUFREQ, PM_ENV_KVM_VM,/** * Set the default power management implementation. If this is not called prior * to rte_power_init(), then auto-detect of the environment will take place. -* It is thread safe. New env can be set only in unitialized state +* It is thread safe. New env can be set only in uninitialized state * (thus rte_power_unset_env must be called if different env was already set). * * @param env
Signature · 1 line
2.20.1
PATCH 7/30 ipsec: fix spelling errors
In reply to Stephen HemmingerSpelling error found by codespell
--- examples/ipsec-secgw/parser.c | 2 +- examples/ipsec-secgw/test/linux_test4.sh | 4 ++-- examples/ipsec-secgw/test/linux_test6.sh | 4 ++-- lib/librte_ipsec/esp_inb.c | 2 +- lib/librte_ipsec/sa.c | 2 +- lib/librte_ipsec/sa.h | 4 ++-- 6 files changed, 9 insertions(+), 9 deletions(-)
examples/ipsec-secgw/parser.c +1 -1
@@ -506,7 +506,7 @@ cfg_parse_neigh(void *parsed_result, __rte_unused struct cmdline *cl, rc =parse_mac (res->mac, &mac);APP_CHECK (rc ==0 , st,"invalid ether addr:%s" , res->mac); rc =add_dst_ethaddr (res->port, &mac); -APP_CHECK (rc ==0 , st,"invalid port numer:%hu" , res->port); +APP_CHECK (rc ==0 , st,"invalid port number:%hu" , res->port);if (st->status <0 )return ; }
examples/ipsec-secgw/test/linux_test4.sh +2 -2
@@ -5,7 +5,7 @@ # ipsec-secgw (IPv4 mode) functional test script. # # Note that for most of them you required appropriate crypto PMD/device -# to be avaialble. +# to be available. # Also user has to setup properly the following environment variables: # SGW_PATH - path to the ipsec-secgw binary to test # REMOTE_HOST - ip/hostname of the DUT
@@ -33,7 +33,7 @@ # I.E: # DUT OS(NIC1)--(ipsec)-->(NIC1)ipsec-secgw(TAP)--(plain)-->(TAP)SUT OS # SUT OS(TAP)--(plain)-->(TAP)psec-secgw(NIC1)--(ipsec)-->(NIC1)DUT OS -# Then tries to perorm some data transfer using the scheme decribed above. +# Then tries to perform some data transfer using the scheme described above. # DIR=`dirname $0`
examples/ipsec-secgw/test/linux_test6.sh +2 -2
@@ -5,7 +5,7 @@ # ipsec-secgw (IPv6 mode) functional test script. # # Note that for most of them you required appropriate crypto PMD/device -# to be avaialble. +# to be available. # Also user has to setup properly the following environment variables: # SGW_PATH - path to the ipsec-secgw binary to test # REMOTE_HOST - ip/hostname of the DUT
@@ -34,7 +34,7 @@ # I.E: # DUT OS(NIC1)--(ipsec)-->(NIC1)ipsec-secgw(TAP)--(plain)-->(TAP)SUT OS # SUT OS(TAP)--(plain)-->(TAP)psec-secgw(NIC1)--(ipsec)-->(NIC1)DUT OS -# Then tries to perorm some data transfer using the scheme decribed above. +# Then tries to perform some data transfer using the scheme described above. # DIR=`dirname $0`
lib/librte_ipsec/esp_inb.c +1 -1
@@ -359,7 +359,7 @@ trs_process_step3(struct rte_mbuf *mb)static inline void tun_process_step3 (struct rte_mbuf *mb,uint64_t txof_msk,uint64_t txof_val) { -/* reset mbuf metatdata: L2/L3 len, packet type */ +/* reset mbuf metadata: L2/L3 len, packet type */ mb->packet_type =RTE_PTYPE_UNKNOWN ; mb->tx_offload = (mb->tx_offload & txof_msk) | txof_val;
lib/librte_ipsec/sa.c +1 -1
@@ -126,7 +126,7 @@ ipsec_sa_size(uint64_t type, uint32_t *wnd_sz, uint32_t *nb_bucket)/* * RFC 4303 recommends 64 as minimum window size. * there is no point to use ESN mode without SQN window, -* so make sure we have at least 64 window when ESN is enalbed. +* so make sure we have at least 64 window when ESN is enabled. */ wsz = ((type &RTE_IPSEC_SATP_ESN_MASK ) == RTE_IPSEC_SATP_ESN_DISABLE) ?
lib/librte_ipsec/sa.h +2 -2
@@ -111,8 +111,8 @@ struct rte_ipsec_sa {* sqn and replay window * In case of SA handled by multiple threads *sqn* cacheline * could be shared by multiple cores. -* To minimise perfomance impact, we try to locate in a separate -* place from other frequently accesed data. +* To minimize performance impact, we try to locate in a separate +* place from other frequently accessed data. */ union { union {
Signature · 1 line
2.20.1
PATCH 8/30 acl: fix spelling errors
In reply to Stephen HemmingerMinor typos in comments.
--- lib/librte_acl/acl.h | 4 ++-- lib/librte_acl/acl_bld.c | 2 +- lib/librte_acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
lib/librte_acl/acl.h +2 -2
@@ -45,7 +45,7 @@ struct rte_acl_bitset {* Each transition is 64 bit value with the following format: * | node_type_specific : 32 | node_type : 3 | node_addr : 29 | * For all node types except RTE_ACL_NODE_MATCH, node_addr is an index -* to the start of the node in the transtions array. +* to the start of the node in the transitions array. * Few different node types are used: * RTE_ACL_NODE_MATCH: * node_addr value is and index into an array that contains the return value
@@ -66,7 +66,7 @@ struct rte_acl_bitset {* RTE_ACL_NODE_SINGLE: * always transitions to the same node regardless of the input value. * RTE_ACL_NODE_DFA: -* that node consits of up to 256 transitions. +* that node consists of up to 256 transitions. * In attempt to conserve space all transitions are divided into 4 consecutive * groups, by 64 transitions per group: * group64[i] contains transitions[i * 64, .. i * 64 + 63].
lib/librte_acl/acl_bld.c +1 -1
@@ -1430,7 +1430,7 @@ acl_set_data_indexes(struct rte_acl_ctx *ctx)/* * Internal routine, performs 'build' phase of trie generation: * - setups build context. -* - analizes given set of rules. +* - analyzes given set of rules. * - builds internal tree(s). */ static int
lib/librte_acl/acl_run_avx2.h +1 -1
@@ -125,7 +125,7 @@ acl_process_matches_avx2x8(const struct rte_acl_ctx *ctx,/* For each transition: put low 32 into tr_lo and high 32 into tr_hi */ ACL_TR_HILO (mm256, __m256, t0, t1, lo, hi); -/* Keep transitions wth NOMATCH intact. */ +/* Keep transitions with NOMATCH intact. */ *tr_lo =_mm256_blendv_epi8 (*tr_lo, lo, matches); *tr_hi =_mm256_blendv_epi8 (*tr_hi, hi, matches); }
Signature · 1 line
2.20.1
PATCH 9/30 bbdev: fix spelling error
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/bbdev_app/main.c | 2 +- lib/librte_bbdev/rte_bbdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
examples/bbdev_app/main.c +1 -1
@@ -361,7 +361,7 @@ add_awgn(struct rte_mbuf **mbufs, uint16_t num_pkts)/* Encoder output to Decoder input adapter. The Decoder accepts only soft input * so each bit of the encoder output must be translated into one byte of LLR. If * Sub-block Deinterleaver is bypassed, which is the case, the padding bytes -* must additionally be insterted at the end of each sub-block. +* must additionally be inserted at the end of each sub-block. */ static inline void transform_enc_out_dec_in(struct rte_mbuf **mbufs, uint8_t *temp_buf,
lib/librte_bbdev/rte_bbdev.c +1 -1
@@ -139,7 +139,7 @@ rte_bbdev_data_alloc(void) }/* -* Find data alocated for the device or if not found return first unused bbdev +* Find data allocated for the device or if not found return first unused bbdev * data. If all structures are in use and none is used by the device return * NULL. */
Signature · 1 line
2.20.1
PATCH 10/30 eventdev: fix spelling error
In reply to Stephen HemmingerSpelling errors found by codespell.
--- lib/librte_eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_eventdev/rte_event_timer_adapter.c +1 -1
@@ -484,7 +484,7 @@ event_buffer_flush(struct event_buffer *bufp, uint8_t dev_id, uint8_t port_id, head_idx = bufp->head &EVENT_BUFFER_MASK ; tail_idx = bufp->tail &EVENT_BUFFER_MASK ; -/* Determine the largest contigous run we can attempt to enqueue to the +/* Determine the largest contiguous run we can attempt to enqueue to the * event device. */ if (head_idx > tail_idx)
Signature · 1 line
2.20.1
PATCH 11/30 ethdev: fix spelling error
In reply to Stephen HemmingerSpelling errors found by codespell.
--- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_ethdev/rte_ethdev.c +1 -1
@@ -3903,7 +3903,7 @@ rte_eth_add_first_rx_callback(uint16_t port_id, uint16_t queue_id, cb->param = user_param;rte_spinlock_lock (&rte_eth_rx_cb_lock); -/* Add the callbacks at fisrt position*/ +/* Add the callbacks at first position*/ cb->next = rte_eth_devices[port_id].post_rx_burst_cbs[queue_id];rte_smp_wmb (); rte_eth_devices[port_id].post_rx_burst_cbs[queue_id] = cb;
Signature · 1 line
2.20.1
PATCH 12/30 ip_frag: fix spelling error
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/ip_fragmentation/main.c | 2 +- lib/librte_ip_frag/rte_ipv4_reassembly.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
examples/ip_fragmentation/main.c +1 -1
@@ -635,7 +635,7 @@ check_all_ports_link_status(uint32_t port_mask) } } -/* Check L3 packet type detection capablity of the NIC port */ +/* Check L3 packet type detection capability of the NIC port */ static int check_ptype (int portid) {
lib/librte_ip_frag/rte_ipv4_reassembly.c +1 -1
@@ -83,7 +83,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp)/* * Process new mbuf with fragment of IPV4 packet. -* Incoming mbuf should have it's l2_len/l3_len fields setuped correclty. +* Incoming mbuf should have it's l2_len/l3_len fields setuped correctly. * @param tbl * Table where to lookup/add the fragmented packet. * @param mb
Signature · 1 line
2.20.1
Re: [dpdk-dev] [PATCH 12/30] ip_frag: fix spelling error
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Stephen Hemminger
Sent: Monday, July 1, 2019 20:25
To: [email protected]
Cc: Stephen Hemminger <[email protected]>
Subject: [dpdk-dev] [PATCH 12/30] ip_frag: fix spelling error
Spelling errors found by codespell.
--- examples/ip_fragmentation/main.c | 2 +- lib/librte_ip_frag/rte_ipv4_reassembly.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
examples/ip_fragmentation/main.c +1 -1
@@ -635,7 +635,7 @@ check_all_ports_link_status(uint32_t port_mask) } } -/* Check L3 packet type detection capablity of the NIC port */ +/* Check L3 packet type detection capability of the NIC port */ static int check_ptype (int portid) {
lib/librte_ip_frag/rte_ipv4_reassembly.c +1 -1
@@ -83,7 +83,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp)/* * Process new mbuf with fragment of IPV4 packet. -* Incoming mbuf should have it's l2_len/l3_len fields setuped correclty. +* Incoming mbuf should have it's l2_len/l3_len fields setuped correctly.
[Artur] "Incoming mbuf should have its l2_len/l3_len fields set up correctly." Isn't it better?
* @param tbl
* Table where to lookup/add the fragmented packet.
* @param mb
Signature · 1 line
2.20.1
Re: [dpdk-dev] [PATCH 12/30] ip_frag: fix spelling error
In reply to Stephen Hemminger-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Stephen Hemminger
Sent: Monday, July 1, 2019 20:25
To: [email protected]
Cc: Stephen Hemminger <[email protected]>
Subject: [dpdk-dev] [PATCH 12/30] ip_frag: fix spelling error
Spelling errors found by codespell.
--- examples/ip_fragmentation/main.c | 2 +- lib/librte_ip_frag/rte_ipv4_reassembly.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
examples/ip_fragmentation/main.c +1 -1
@@ -635,7 +635,7 @@ check_all_ports_link_status(uint32_t port_mask) } } -/* Check L3 packet type detection capablity of the NIC port */ +/* Check L3 packet type detection capability of the NIC port */ static int check_ptype (int portid) {
lib/librte_ip_frag/rte_ipv4_reassembly.c +1 -1
@@ -83,7 +83,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp)/* * Process new mbuf with fragment of IPV4 packet. -* Incoming mbuf should have it's l2_len/l3_len fields setuped correclty. +* Incoming mbuf should have it's l2_len/l3_len fields setuped correctly.
[Artur] should be without apostrophe: "... have its ...."
* @param tbl
* Table where to lookup /add the fragmented packet.
* @param mb
Signature · 1 line
2.20.1
PATCH 13/30 examples/multi_process: fix spelling errors
In reply to Stephen HemmingerMinor typos caught by codespell.
--- examples/multi_process/hotplug_mp/commands.c | 2 +- examples/multi_process/simple_mp/main.c | 2 +- examples/multi_process/symmetric_mp/main.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
examples/multi_process/hotplug_mp/commands.c +1 -1
@@ -178,7 +178,7 @@ static void cmd_dev_detach_parsed(void *parsed_result,cmdline_printf (cl,"detached device %s\n" , da.name); else - cmdline_printf(cl, "failed to dettach device %s\n", + cmdline_printf(cl, "failed to detach device %s\n", da.name); }
examples/multi_process/simple_mp/main.c +1 -1
@@ -4,7 +4,7 @@/* * This sample application is a simple multi-process application which -* demostrates sharing of queues and memory pools between processes, and +* demonstrates sharing of queues and memory pools between processes, and * using those queues/pools for communication between the processes. * * Application is designed to run with two processes, a primary and a
examples/multi_process/symmetric_mp/main.c +1 -1
@@ -3,7 +3,7 @@*/ /* -* Sample application demostrating how to do packet I/O in a multi-process +* Sample application demonstrating how to do packet I/O in a multi-process * environment. The same code can be run as a primary process and as a * secondary process, just with a different proc-id parameter in each case * (apart from the EAL flag to indicate a secondary process).
Signature · 1 line
2.20.1
PATCH 14/30 examples/l3fwd: fix misspelling of destination
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/l3fwd/l3fwd_common.h | 2 +- examples/l3fwd/l3fwd_neon.h | 2 +- examples/l3fwd/l3fwd_sse.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
examples/l3fwd/l3fwd_common.h +1 -1
@@ -51,7 +51,7 @@ rfc1812_process(struct rte_ipv4_hdr *ipv4_hdr, uint16_t *dp, uint32_t ptype)#endif /* DO_RFC_1812_CHECKS */ /* -* We group consecutive packets with the same destionation port into one burst. +* We group consecutive packets with the same destination port into one burst. * To avoid extra latency this is done together with some other packet * processing, but after we made a final decision about packet's destination. * To do this we maintain:
examples/l3fwd/l3fwd_neon.h +1 -1
@@ -64,7 +64,7 @@ processx4_step3(struct rte_mbuf *pkt[FWDSTEP], uint16_t dst_port[FWDSTEP])/* * Group consecutive packets with the same destination port in bursts of 4. -* Suppose we have array of destionation ports: +* Suppose we have array of destination ports: * dst_port[] = {a, b, c, d,, e, ... } * dp1 should contain: <a, b, c, d>, dp2: <b, c, d, e>. * We doing 4 comparisons at once and the result is 4 bit mask.
examples/l3fwd/l3fwd_sse.h +1 -1
@@ -64,7 +64,7 @@ processx4_step3(struct rte_mbuf *pkt[FWDSTEP], uint16_t dst_port[FWDSTEP])/* * Group consecutive packets with the same destination port in bursts of 4. -* Suppose we have array of destionation ports: +* Suppose we have array of destination ports: * dst_port[] = {a, b, c, d,, e, ... } * dp1 should contain: <a, b, c, d>, dp2: <b, c, d, e>. * We doing 4 comparisons at once and the result is 4 bit mask.
Signature · 1 line
2.20.1
PATCH 15/30 examples/performance-thread: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/performance-thread/common/lthread_tls.c | 2 +- examples/performance-thread/l3fwd-thread/main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
examples/performance-thread/common/lthread_tls.c +1 -1
@@ -214,7 +214,7 @@ void _lthread_tls_alloc(struct lthread *lt) tls->root_sched = (THIS_SCHED ); lt->tls = tls; -/* allocate data for TLS varaiables using RTE_PER_LTHREAD macros */ +/* allocate data for TLS variables using RTE_PER_LTHREAD macros */ if (sizeof (void *) < (uint64_t )RTE_PER_LTHREAD_SECTION_SIZE ) { lt->per_lthread_data =_lthread_objcache_alloc ((THIS_SCHED )->per_lthread_cache);
examples/performance-thread/l3fwd-thread/main.c +2 -2
@@ -1523,7 +1523,7 @@ processx4_step3(struct rte_mbuf *pkt[FWDSTEP], uint16_t dst_port[FWDSTEP]) }/* -* We group consecutive packets with the same destionation port into one burst. +* We group consecutive packets with the same destination port into one burst. * To avoid extra latency this is done together with some other packet * processing, but after we made a final decision about packet's destination. * To do this we maintain:
@@ -1548,7 +1548,7 @@ processx4_step3(struct rte_mbuf *pkt[FWDSTEP], uint16_t dst_port[FWDSTEP])/* * Group consecutive packets with the same destination port in bursts of 4. -* Suppose we have array of destionation ports: +* Suppose we have array of destination ports: * dst_port[] = {a, b, c, d,, e, ... } * dp1 should contain: <a, b, c, d>, dp2: <b, c, d, e>. * We doing 4 comparisons at once and the result is 4 bit mask.
Signature · 1 line
2.20.1
PATCH 16/30 examples/ethtool: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/ethtool/lib/rte_ethtool.c | 2 +- examples/ethtool/lib/rte_ethtool.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
examples/ethtool/lib/rte_ethtool.c +1 -1
@@ -376,7 +376,7 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)rte_eth_dev_info_get (port_id, &dev_info); num_vfs = dev_info.max_vfs; -/* Set VF vf_rx_mode, VF unsupport status is discard */ +/* Set VF vf_rx_mode, VF unsupported status is discard */ for (vf =0 ; vf < num_vfs; vf++) {#ifdef RTE_LIBRTE_IXGBE_PMD rte_pmd_ixgbe_set_vf_rxmode(port_id, vf,
examples/ethtool/lib/rte_ethtool.h +2 -2
@@ -189,7 +189,7 @@ int rte_ethtool_get_module_eeprom(uint16_t port_id,/** * Retrieve the Ethernet device pause frame configuration according to -* parameter attributes desribed by ethtool data structure, +* parameter attributes described by ethtool data structure, * ethtool_pauseparam. * * @param port_id
@@ -209,7 +209,7 @@ int rte_ethtool_get_pauseparam(uint16_t port_id,/** * Setting the Ethernet device pause frame configuration according to -* parameter attributes desribed by ethtool data structure, ethtool_pauseparam. +* parameter attributes described by ethtool data structure, ethtool_pauseparam. * * @param port_id * The port identifier of the Ethernet device.
Signature · 1 line
2.20.1
Re: [dpdk-dev] [PATCH 16/30] examples/ethtool: fix spelling errors
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Stephen Hemminger
Sent: Monday, July 1, 2019 20:25
To: [email protected]
Cc: Stephen Hemminger <[email protected]>
Subject: [dpdk-dev] [PATCH 16/30] examples/ethtool: fix spelling errors
Spelling errors found by codespell.
--- examples/ethtool/lib/rte_ethtool.c | 2 +- examples/ethtool/lib/rte_ethtool.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
examples/ethtool/lib/rte_ethtool.c +1 -1
@@ -376,7 +376,7 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)rte_eth_dev_info_get (port_id, &dev_info); num_vfs = dev_info.max_vfs; -/* Set VF vf_rx_mode, VF unsupport status is discard */ +/* Set VF vf_rx_mode, VF unsupported status is discard */
[Artur] "... is discarded"?
for (vf = 0; vf < num_vfs; vf++) {
#ifdef RTE_LIBRTE_IXGBE_PMD
rte_pmd_ixgbe_set_vf_rxmode(port_id, vf, diff --git a/examples/ethtool/lib/rte_ethtool.h b/examples/ethtool/lib/rte_ethtool.h
index f17709663644..d27e0102b1ca 100644
examples/ethtool/lib/rte_ethtool.h +2 -2
@@ -189,7 +189,7 @@ int rte_ethtool_get_module_eeprom(uint16_t port_id,/** * Retrieve the Ethernet device pause frame configuration according to -* parameter attributes desribed by ethtool data structure, +* parameter attributes described by ethtool data structure, * ethtool_pauseparam. * * @param port_id
@@ -209,7 +209,7 @@ int rte_ethtool_get_pauseparam(uint16_t port_id,/** * Setting the Ethernet device pause frame configuration according to -* parameter attributes desribed by ethtool data structure, ethtool_pauseparam. +* parameter attributes described by ethtool data structure, ethtool_pauseparam. * * @param port_id * The port identifier of the Ethernet device.
--
2.20.1
PATCH 17/30 examples/vmdq: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/vmdq/main.c | 2 +- examples/vmdq_dcb/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
examples/vmdq/main.c +1 -1
@@ -60,7 +60,7 @@ static uint32_t enabled_port_mask;static uint32_t num_queues =8 ;static uint32_t num_pools =8 ; -/* empty vmdq configuration structure. Filled in programatically */ +/* empty vmdq configuration structure. Filled in programmatically */ static const struct rte_eth_conf vmdq_conf_default = { .rxmode = { .mq_mode =ETH_MQ_RX_VMDQ_ONLY ,
examples/vmdq_dcb/main.c +1 -1
@@ -66,7 +66,7 @@ static uint16_t num_queues, num_vmdq_queues;static uint16_t vmdq_pool_base, vmdq_queue_base;static uint8_t rss_enable; -/* empty vmdq+dcb configuration structure. Filled in programatically */ +/* empty vmdq+dcb configuration structure. Filled in programmatically */ static const struct rte_eth_conf vmdq_dcb_conf_default = { .rxmode = { .mq_mode =ETH_MQ_RX_VMDQ_DCB ,
Signature · 1 line
2.20.1
PATCH 18/30 examples/bond: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/bond/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/bond/main.c +1 -1
@@ -375,7 +375,7 @@ static int lcore_main(__attribute__((unused)) void *arg1) struct rte_ether_hdr *); ether_type = eth_hdr->ether_type;if (ether_type ==rte_cpu_to_be_16 (RTE_ETHER_TYPE_VLAN )) -printf ("VLAN taged frame, offset:" ); +printf ("VLAN tagged frame, offset:" ); offset =get_vlan_offset (eth_hdr, ðer_type);if (offset >0 )printf ("%d\n" , offset);
Signature · 1 line
2.20.1
PATCH 19/30 examples/l3fwd-power: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/l3fwd-power/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/l3fwd-power/main.c +1 -1
@@ -469,7 +469,7 @@ signal_exit_now(int sigtype)rte_exit (EXIT_SUCCESS ,"User forced exit\n" ); } -/* Freqency scale down timer callback */ +/* Frequency scale down timer callback */ static void power_timer_cb (__attribute__((unused))struct rte_timer *tim, __attribute__((unused))void *arg)
Signature · 1 line
2.20.1
PATCH 20/30 examples/netmap_compat: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/netmap_compat/lib/compat_netmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/netmap_compat/lib/compat_netmap.c +1 -1
@@ -700,7 +700,7 @@ rte_netmap_init_port(uint16_t portid, const struct rte_netmap_port_conf *conf)if (ret <0 ) {RTE_LOG (ERR ,USER1 , -"Couldn't ot adjust number of descriptors for port %u\n" , +"Couldn't adjust number of descriptors for port %u\n" , portid);return ret; }
Signature · 1 line
2.20.1
PATCH 21/30 examples/packet_ordering: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/packet_ordering/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/packet_ordering/main.c +1 -1
@@ -631,7 +631,7 @@ main(int argc, char **argv)if (ret <0 )return -1 ; -/* Check if we have enought cores */ +/* Check if we have enough cores */ if (rte_lcore_count () <3 )rte_exit (EXIT_FAILURE ,"Error, This application needs at " "least 3 logical cores to run:\n"
Signature · 1 line
2.20.1
PATCH 22/30 examples/service_cores: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/service_cores/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/service_cores/main.c +1 -1
@@ -119,7 +119,7 @@ apply_profile(int profile_id)const uint8_t core_off =1 ;if (p->num_cores >rte_lcore_count () +1 ) { -printf ("insufficent cores to run (%s)" , +printf ("insufficient cores to run (%s)" , p->name);return ; }
Signature · 1 line
2.20.1
Re: [dpdk-dev] [PATCH 22/30] examples/service_cores: fix spelling errors
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Stephen Hemminger
Sent: Monday, July 1, 2019 20:25
To: [email protected]
Cc: Stephen Hemminger <[email protected]>
Subject: [dpdk-dev] [PATCH 22/30] examples/service_cores: fix spelling errors
Spelling errors found by codespell.
--- examples/service_cores/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/service_cores/main.c +1 -1
@@ -119,7 +119,7 @@ apply_profile(int profile_id)const uint8_t core_off =1 ;if (p->num_cores >rte_lcore_count () +1 ) { - printf("insufficent cores to run (%s)", + printf("insufficient cores to run (%s)",
[Artur] "insufficient number of cores..." ?
p->name);
return;
}
--
2.20.1
PATCH 23/30 examples/vhost: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/vhost/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
examples/vhost/main.c +3 -3
@@ -105,7 +105,7 @@ static uint32_t burst_rx_retry_num = BURST_RX_RETRIES;static char *socket_files;static int nb_sockets; -/* empty vmdq configuration structure. Filled in programatically */ +/* empty vmdq configuration structure. Filled in programmatically */ static struct rte_eth_conf vmdq_conf_default = { .rxmode = { .mq_mode =ETH_MQ_RX_VMDQ_ONLY ,
@@ -1109,7 +1109,7 @@ switch_worker(void *arg __rte_unused)struct vhost_dev *vdev;struct mbuf_table *tx_q; -RTE_LOG (INFO ,VHOST_DATA ,"Procesing on Core %u started\n" , lcore_id); +RTE_LOG (INFO ,VHOST_DATA ,"Processing on Core %u started\n" , lcore_id); tx_q = &lcore_tx_queue[lcore_id];for (i =0 ; i <rte_lcore_count (); i++) {
@@ -1153,7 +1153,7 @@ switch_worker(void *arg __rte_unused)/* * Remove a device from the specific data core linked list and from the -* main linked list. Synchonization occurs through the use of the +* main linked list. Synchronization occurs through the use of the * lcore dev_removal_flag. Device is made volatile here to avoid re-ordering * of dev->remove=1 which can cause an infinite loop in the rte_pause loop. */
Signature · 1 line
2.20.1
PATCH 24/30 examples/vhost_scsi: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/vhost_scsi/scsi.c | 2 +- examples/vhost_scsi/vhost_scsi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
examples/vhost_scsi/scsi.c +1 -1
@@ -70,7 +70,7 @@ vhost_bdev_scsi_set_naa_ieee_extended(const char *name, uint8_t *buf) local_value = *(uint64_t *)buf;/* * see spc3r23 7.6.3.6.2, -* NAA IEEE Extended identifer format +* NAA IEEE Extended identiifier format */ local_value &=0x0fff000000ffffffull ;/* NAA 02, and 00 03 47 for IEEE Intel */
examples/vhost_scsi/vhost_scsi.c +1 -1
@@ -191,7 +191,7 @@ vhost_scsi_bdev_construct(const char *bdev_name, const char *bdev_serial,/* use memory as disk storage space */ bdev->data =rte_zmalloc (NULL , blk_cnt * blk_size,0 );if (!bdev->data) { -fprintf (stderr,"no enough reseverd huge memory for disk\n" ); +fprintf (stderr,"no enough reserved huge memory for disk\n" );return NULL ; }
Signature · 1 line
2.20.1
Re: [dpdk-dev] [PATCH 24/30] examples/vhost_scsi: fix spelling errors
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Stephen Hemminger
Sent: Monday, July 1, 2019 20:26
To: [email protected]
Cc: Stephen Hemminger <[email protected]>
Subject: [dpdk-dev] [PATCH 24/30] examples/vhost_scsi: fix spelling errors
Spelling errors found by codespell.
--- examples/vhost_scsi/scsi.c | 2 +- examples/vhost_scsi/vhost_scsi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
examples/vhost_scsi/scsi.c +1 -1
@@ -70,7 +70,7 @@ vhost_bdev_scsi_set_naa_ieee_extended(const char *name, uint8_t *buf) local_value = *(uint64_t *)buf;/* * see spc3r23 7.6.3.6.2, -* NAA IEEE Extended identifer format +* NAA IEEE Extended identiifier format
[Artur] "... identifier format"?
*/
local_value &= 0x0fff000000ffffffull;
/* NAA 02, and 00 03 47 for IEEE Intel */ diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost_scsi.c
index 513af0cca4bc..14385be56ae2 100644
examples/vhost_scsi/vhost_scsi.c +1 -1
@@ -191,7 +191,7 @@ vhost_scsi_bdev_construct(const char *bdev_name, const char *bdev_serial,/* use memory as disk storage space */ bdev->data =rte_zmalloc (NULL , blk_cnt * blk_size,0 );if (!bdev->data) { -fprintf (stderr,"no enough reseverd huge memory for disk\n" ); +fprintf (stderr,"no enough reserved huge memory for disk\n" );
[Artur] "Not enough huge memory reserved for disk" ?
return NULL;
}
--
2.20.1
PATCH 25/30 examples/tep_termination: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/tep_termination/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
examples/tep_termination/main.c +3 -3
@@ -596,7 +596,7 @@ switch_worker(__rte_unused void *arg)uint16_t tx_count;uint32_t retry =0 ; -RTE_LOG (INFO ,VHOST_DATA ,"Procesing on Core %u started\n" , lcore_id); +RTE_LOG (INFO ,VHOST_DATA ,"Processing on Core %u started\n" , lcore_id); lcore_ll = lcore_info[lcore_id].lcore_ll; prev_tsc =0 ;
@@ -872,7 +872,7 @@ init_data_ll(void)/** * Remove a device from the specific data core linked list and -* from the main linked list. Synchonization occurs through the use +* from the main linked list. Synchronization occurs through the use * of the lcore dev_removal_flag. */ static void
@@ -1150,7 +1150,7 @@ main(int argc, char *argv[])if (rte_lcore_is_enabled (lcore_id)) lcore_ids[core_id++] = lcore_id; -/* set the number of swithcing cores available */ +/* set the number of switching cores available */ nb_switching_cores =rte_lcore_count ()-1 ;/* Get the number of physical ports. */
Signature · 1 line
2.20.1
PATCH 26/30 examples/vm_power_manager: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- examples/vm_power_manager/channel_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/vm_power_manager/channel_monitor.c +1 -1
@@ -368,7 +368,7 @@ get_pcpu_to_control(struct policy *pol)/* * So now that we're handling virtual and physical cores, we need to -* differenciate between them when adding them to the branch monitor. +* differentiate between them when adding them to the branch monitor. * Virtual cores need to be converted to physical cores. */ if (pol->pkt.core_type ==CORE_TYPE_VIRTUAL ) {
Signature · 1 line
2.20.1
PATCH 27/30 test-pmd: fix spelling errors
In reply to Stephen HemmingerMultiple spelling problems found by codespell.
--- app/test-pmd/cmdline.c | 11 ++++++----- app/test-pmd/config.c | 4 ++-- app/test-pmd/csumonly.c | 2 +- app/test-pmd/softnicfwd.c | 2 +- 4 files changed, 10 insertions(+), 9 deletions(-)
app/test-pmd/cmdline.c +6 -5
@@ -100,7 +100,7 @@ static void cmd_help_brief_parsed(__attribute__((unused)) void *parsed_result," help ports : Configuring ports.\n" " help registers : Reading and setting port registers.\n" " help filters : Filters configuration help.\n" -" help traffic_management : Traffic Management commmands.\n" +" help traffic_management : Traffic Management commands.\n" " help all : All of the above sections.\n\n" );
@@ -3503,7 +3503,7 @@ parse_item_list(char* str, const char* item_name, unsigned int max_items,return nb_item;/* -* Then, check that all values in the list are differents. +* Then, check that all values in the list are different. * No optimization here... */ for (i =0 ; i < nb_item; i++) {
@@ -5010,7 +5010,7 @@ cmd_gso_size_parsed(void *parsed_result,if (test_done ==0 ) {printf ("Before setting GSO segsz, please first" -" stop fowarding\n" ); +" stop forwarding\n" );return ; }
@@ -6942,7 +6942,7 @@ cmd_link_flow_ctrl_set_parsed(void *parsed_result, ret =rte_eth_dev_flow_ctrl_set (res->port_id, &fc_conf);if (ret !=0 ) -printf ("bad flow contrl parameter, return code = %d \n" , ret); +printf ("bad flow control parameter, return code = %d\n" , ret); }/* *** SETUP ETHERNET PRIORITY FLOW CONTROL *** */
@@ -6990,7 +6990,8 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result, ret =rte_eth_dev_priority_flow_ctrl_set (res->port_id, &pfc_conf);if (ret !=0 ) -printf ("bad priority flow contrl parameter, return code = %d \n" , ret); +printf ("bad priority flow control parameter, return code = %d\n" , + ret); } cmdline_parse_token_string_t cmd_pfc_set_set =
app/test-pmd/config.c +2 -2
@@ -1745,7 +1745,7 @@ port_rss_reta_info(portid_t port_id, }/* -* Displays the RSS hash functions of a port, and, optionaly, the RSS hash +* Displays the RSS hash functions of a port, and, optionally, the RSS hash * key of the port. */ void
@@ -3492,7 +3492,7 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx) { port->mc_addr_nb--;if (addr_idx == port->mc_addr_nb) { -/* No need to recompact the set of multicast addressses. */ +/* No need to recompact the set of multicast addresses. */ if (port->mc_addr_nb ==0 ) {/* free the pool of multicast addresses. */ free (port->mc_addr_pool);
app/test-pmd/csumonly.c +1 -1
@@ -685,7 +685,7 @@ pkt_copy_split(const struct rte_mbuf *pkt)* * The testpmd command line for this forward engine sets the flags * TESTPMD_TX_OFFLOAD_* in ports[tx_port].tx_ol_flags. They control -* wether a checksum must be calculated in software or in hardware. The +* whether a checksum must be calculated in software or in hardware. The * IP, UDP, TCP and SCTP flags always concern the inner layer. The * OUTER_IP is only useful for tunnel packets. */
app/test-pmd/softnicfwd.c +1 -1
@@ -277,7 +277,7 @@ softport_tm_subport_node_add(portid_t port_id, snp.nonleaf.n_sp_priorities =1 ; snp.stats_mask =STATS_MASK_DEFAULT ; -/* Add Node to TM Hiearchy */ +/* Add Node to TM Hierarchy */ if (rte_tm_node_add(port_id, h->subport_node_id[i], subport_parent_node_id,
Signature · 1 line
2.20.1
PATCH 28/30 test: fix multiple spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- app/test/test_barrier.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c | 2 +- app/test/test_kni.c | 2 +- app/test/test_link_bonding.c | 2 +- app/test/test_lpm.c | 6 +++--- app/test/test_lpm6.c | 14 +++++++------- app/test/test_mbuf.c | 2 +- app/test/test_mempool.c | 2 +- app/test/test_mempool_perf.c | 2 +- app/test/test_meter.c | 6 +++--- app/test/test_pmd_perf.c | 2 +- app/test/test_ring.c | 2 +- app/test/test_rwlock.c | 2 +- 14 files changed, 26 insertions(+), 26 deletions(-)
app/test/test_barrier.c +1 -1
@@ -66,7 +66,7 @@ struct plock_test {struct lcore_plock_test {struct plock_test *pt[2 ];/* shared, lock-protected data */ uint64_t sum[2 ];/* local copy of the shared data */ -uint64_t iter;/* number of iterations to perfom */ +uint64_t iter;/* number of iterations to perform */ uint32_t lc;/* given lcore id */ };
app/test/test_func_reentrancy.c +3 -3
@@ -242,7 +242,7 @@ hash_create_free(__attribute__((unused)) void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple times simultaneously */ +/* create multiple times simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (hash_name,sizeof (hash_name),"fr_test_%d_%d" , lcore_self, i); hash_params.name = hash_name;
@@ -306,7 +306,7 @@ fbk_create_free(__attribute__((unused)) void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_ITER_MULTI ; i++) {snprintf (fbk_name,sizeof (fbk_name),"fr_test_%d_%d" , lcore_self, i); fbk_params.name = fbk_name;
@@ -368,7 +368,7 @@ lpm_create_free(__attribute__((unused)) void *arg)rte_atomic32_inc (&obj_count); } -/* create mutiple fbk tables simultaneously */ +/* create multiple fbk tables simultaneously */ for (i =0 ; i <MAX_LPM_ITER_TIMES ; i++) {snprintf (lpm_name,sizeof (lpm_name),"fr_test_%d_%d" , lcore_self, i); lpm =rte_lpm_create (lpm_name,SOCKET_ID_ANY , &config);
app/test/test_ipsec.c +1 -1
@@ -650,7 +650,7 @@ create_crypto_session(struct ipsec_unitest_params *ut,if (s ==NULL )return -ENOMEM ; -/* initiliaze SA crypto session for device */ +/* initialaze SA crypto session for device */ rc =rte_cryptodev_sym_session_init (dev_id, s, ut->crypto_xforms, qp->mp_session_private);if (rc ==0 ) {
app/test/test_kni.c +1 -1
@@ -556,7 +556,7 @@ test_kni(void) }closedir (dir); -/* Initialize KNI subsytem */ +/* Initialize KNI subsystem */ rte_kni_init (KNI_TEST_MAX_PORTS );if (test_kni_allocate_lcores () <0 ) {
app/test/test_link_bonding.c +1 -1
@@ -2920,7 +2920,7 @@ test_balance_tx_burst_slave_tx_fail(void) first_tx_fail_idx =TEST_BAL_SLAVE_TX_FAIL_BURST_SIZE_1 -TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; -/* copy mbuf referneces for expected transmission failures */ +/* copy mbuf references for expected transmission failures */ for (i =0 ; i <TEST_BAL_SLAVE_TX_FAIL_PACKETS_COUNT ; i++) expected_fail_pkts[i] = pkts_burst_1[i + first_tx_fail_idx];
app/test/test_lpm.c +3 -3
@@ -173,7 +173,7 @@ test3(void) status =rte_lpm_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -211,7 +211,7 @@ test4(void) status =rte_lpm_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -249,7 +249,7 @@ test5(void) status =rte_lpm_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
app/test/test_lpm6.c +7 -7
@@ -262,7 +262,7 @@ test4(void) status =rte_lpm6_add (NULL , ip, depth, next_hop);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -300,7 +300,7 @@ test5(void) status =rte_lpm6_delete (NULL , ip, depth);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -338,7 +338,7 @@ test6(void) status =rte_lpm6_lookup (NULL , ip, &next_hop_return);TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -376,7 +376,7 @@ test7(void) status =rte_lpm6_lookup_bulk_func (NULL , ip, next_hop_return,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -414,7 +414,7 @@ test8(void) status =rte_lpm6_delete_bulk_func (NULL , ip, depth,10 );TEST_LPM_ASSERT (status <0 ); -/*Create vaild lpm to use in rest of test. */ +/*Create valid lpm to use in rest of test. */ lpm =rte_lpm6_create (__func__,SOCKET_ID_ANY , &config);TEST_LPM_ASSERT (lpm !=NULL );
@@ -434,7 +434,7 @@ test8(void)/* * Call add, lookup and delete for a single rule with depth < 24. * Check all the combinations for the first three bytes that result in a hit. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test9 (void )
@@ -1739,7 +1739,7 @@ test27(void)* Call add, lookup and delete for a single rule with maximum 21bit next_hop * size. * Check that next_hop returned from lookup is equal to provisioned value. -* Delete the rule and check that the same test returs a miss. +* Delete the rule and check that the same test returns a miss. */ int32_t test28 (void )
app/test/test_mbuf.c +1 -1
@@ -803,7 +803,7 @@ test_refcnt_mbuf(void) tref += refcnt_lcore[slave];if (tref != refcnt_lcore[master]) -rte_panic ("refernced mbufs: %u, freed mbufs: %u\n" , +rte_panic ("referenced mbufs: %u, freed mbufs: %u\n" , tref, refcnt_lcore[master]);rte_mempool_dump (stdout, refcnt_pool);
app/test/test_mempool.c +1 -1
@@ -561,7 +561,7 @@ test_mempool(void)if (test_mempool_basic_ex (mp_nocache) <0 ) goto err; -/* mempool operation test based on single producer and single comsumer */ +/* mempool operation test based on single producer and single consumer */ if (test_mempool_sp_sc () <0 ) goto err;
app/test/test_mempool_perf.c +1 -1
@@ -89,7 +89,7 @@ static rte_atomic32_t synchro;static unsigned n_get_bulk;static unsigned n_put_bulk; -/* number of objects retrived from mempool before putting them back */ +/* number of objects retrieved from mempool before putting them back */ static unsigned n_keep;/* number of enqueues / dequeues */
app/test/test_meter.c +3 -3
@@ -444,7 +444,7 @@ tm_test_srtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -551,7 +551,7 @@ tm_test_trtcm_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
@@ -648,7 +648,7 @@ tm_test_trtcm_rfc4115_color_aware_check(void)* if using blind check */ -/* previouly have a green, test points should keep unchanged */ +/* previously have a green, test points should keep unchanged */ in[0 ] = in[1 ] = in[2 ] = in[3 ] =RTE_COLOR_GREEN ; out[0 ] =RTE_COLOR_GREEN ; out[1 ] =RTE_COLOR_YELLOW ;
app/test/test_pmd_perf.c +1 -1
@@ -744,7 +744,7 @@ test_pmd_perf(void)"rte_eth_dev_start: err=%d, port=%d\n" , ret, portid); -/* always eanble promiscuous */ +/* always enable promiscuous */ rte_eth_promiscuous_enable (portid); lcore_conf[slave_id].portlist[num++] = portid;
app/test/test_ring.c +1 -1
@@ -655,7 +655,7 @@ test_lookup_null(void)struct rte_ring *rlp =rte_ring_lookup ("ring_not_found" );if (rlp ==NULL )if (rte_errno !=ENOENT ){ -printf ("test failed to returnn error on null pointer\n" ); +printf ("test failed to return error on null pointer\n" );return -1 ; }return 0 ;
app/test/test_rwlock.c +1 -1
@@ -461,7 +461,7 @@ try_rwlock_test_rda(void) {try_test_reset (); -/* start read test on all avaialble lcores */ +/* start read test on all available lcores */ rte_eal_mp_remote_launch (try_read_lcore,NULL ,CALL_MASTER );rte_eal_mp_wait_lcore ();
Signature · 1 line
2.20.1
PATCH 29/30 proc-info: fix spelling error
In reply to Stephen HemmingerSpelling errors found by codespell.
--- app/proc-info/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
app/proc-info/main.c +1 -1
@@ -714,7 +714,7 @@ show_port(void) } } -printf (" - cyrpto context\n" ); +printf (" - crypto context\n" );void *p_ctx =rte_eth_dev_get_sec_ctx (i);printf ("\t -- security context - %p\n" , p_ctx);
Signature · 1 line
2.20.1
PATCH 30/30 test-compress-perf: fix spelling errors
In reply to Stephen HemmingerSpelling errors found by codespell.
--- app/test-compress-perf/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
app/test-compress-perf/main.c +2 -2
@@ -68,7 +68,7 @@ comp_perf_check_capabilities(struct comp_test_data *test_data)uint64_t comp_flags = cap->comp_feature_flags; -/* Huffman enconding */ +/* Huffman encoding */ if (test_data->huffman_enc ==RTE_COMP_HUFFMAN_FIXED && (comp_flags &RTE_COMP_FF_HUFFMAN_FIXED ) ==0 ) { RTE_LOG(ERR, USER1,
@@ -124,7 +124,7 @@ find_buf_size(uint32_t input_size)* power of 2 but also should be enough to store incompressible data */ -/* We're looking for nearest power of 2 buffer size, which is greather +/* We're looking for nearest power of 2 buffer size, which is greater * than input_size */ uint32_t size =
Signature · 1 line
2.20.1
Quoted 26 lines · Stephen Hemminger
Ran the codespell tool against the lib and examples. Lots of little repeated errors fixed.
Stephen Hemminger (30):
lpm: fix spelling errors
eal/windows: fix comment about fnmatch bsd/eal: fix spelling error
eal: fix spelling errors
bpf: fix spelling errors
power: fix spelling errors
ipsec: fix spelling errors
acl: fix spelling errors
bbdev: fix spelling error
eventdev: fix spelling error
ethdev: fix spelling error
ip_frag: fix spelling error examples/multi_process: fix spelling errors examples/l3fwd: fix misspelling of destination examples/performance-thread: fix spelling errors examples/ethtool: fix spelling errors examples/vmdq: fix spelling errors examples/bond: fix spelling errors examples/l3fwd-power: fix spelling errors examples/netmap_compat: fix spelling errors examples/packet_ordering: fix spelling errors examples/service_cores: fix spelling errors
Quoted 9 lines
examples/vhost: fix spelling errors
examples/vhost_scsi: fix spelling errors
examples/tep_termination: fix spelling errors
examples/vm_power_manager: fix spelling errors
test-pmd: fix spelling errors
test: fix multiple spelling errors
proc-info: fix spelling error
test-compress-perf: fix spelling errors
If we are not going to backport those, we might as well squash this as a single patch.
Signature · 1 line
David Marchand
01/07/2019 20:25, Stephen Hemminger:
Quoted 2 lines
Ran the codespell tool against the lib and examples. Lots of little repeated errors fixed.
Please could you send a v2 addresing comments?
I think it can be only all squashed in one patch.
16/07/2019 13:07, Thomas Monjalon:
Quoted 6 lines
01/07/2019 20:25, Stephen Hemminger:
Quoted 2 lines
Ran the codespell tool against the lib and examples. Lots of little repeated errors fixed.
Please could you send a v2 addresing comments?
I think it can be only all squashed in one patch.
Stephen, is it the right time for it?
Please squash all in one patch for v2.
Thanks