Skip to contentSkip to conversation

tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

PATCH In review Eric Auger 3 participants 6 messages Jul 1, 2019 – Jul 2, 2019

lore
Share & tools
lore

Eric Auger

author
#0 lore raw

PATCH 1/1 tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

PCDIMM hotplug addition updated the DSDT. Update the reference table.

---
 tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
tests/data/acpi/virt/DSDT binary +0 -0
index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
GIT binary patch
Signature · 1 line
2.20.1
#1 lore raw

Hi Eric,

Quoted 1 line · Eric Auger

PCDIMM hotplug addition updated the DSDT. Update the reference table.

Can you point the commit sha1 please?

Quoted 19 lines
---
 tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
tests/data/acpi/virt/DSDT binary +0 -0
index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
GIT binary patch
author
#2 lore raw

Hi Philippe,

Quoted 6 lines · Philippe Mathieu-Daudé

Hi Eric,

Quoted 1 line · Eric Auger

PCDIMM hotplug addition updated the DSDT. Update the reference table.

Can you point the commit sha1 please?

this follows Peter's make check failure report sent yesterday and follow-up discussion on IRC. The series is not yet upstream so I cannot point to any SHA1 yet.

https://www.mail-archive.com/[email protected]/msg627971.html

Thanks

Eric

Quoted 20 lines
Quoted 20 lines
---
 tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
tests/data/acpi/virt/DSDT binary +0 -0
index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
GIT binary patch
#3 lore raw
Quoted 7 lines · Auger Eric

Hi Philippe,

Quoted 5 lines · Philippe Mathieu-Daudé

Hi Eric,

Quoted 1 line · Eric Auger

PCDIMM hotplug addition updated the DSDT. Update the reference table.

Quoted 7 lines
Quoted 1 line

Can you point the commit sha1 please?

this follows Peter's make check failure report sent yesterday and follow-up discussion on IRC. The series is not yet upstream so I cannot point to any SHA1 yet.

https://www.mail-archive.com/[email protected]/msg627971.html

I hadn't review this series, so this patch was making no sense at all to me, now it does.

I think it has to be squashed with:
"hw/arm/virt: Enable device memory cold/hot plug with ACPI boot" in the series you mentioned.

Regards,

Phil.

Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
---
 tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
tests/data/acpi/virt/DSDT binary +0 -0
index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
GIT binary patch
author
#4 lore raw

Hi Philippe,

Quoted 14 lines · Philippe Mathieu-Daudé
Quoted 13 lines · Auger Eric

Hi Philippe,

Quoted 6 lines · Philippe Mathieu-Daudé

Hi Eric,

Quoted 1 line · Eric Auger

PCDIMM hotplug addition updated the DSDT. Update the reference table.

Can you point the commit sha1 please?

this follows Peter's make check failure report sent yesterday and follow-up discussion on IRC. The series is not yet upstream so I cannot point to any SHA1 yet.

Quoted 8 lines
Quoted 1 line

https://www.mail-archive.com/[email protected]/msg627971.html

I hadn't review this series, so this patch was making no sense at all to me, now it does.

I think it has to be squashed with:
"hw/arm/virt: Enable device memory cold/hot plug with ACPI boot" in the series you mentioned.

Yep sorry for that. I was trying to fix the issue quickly for unblocking the series for 4.1.

Actually it looks really weird as the test is passing on some hosts (Igor is currently experiencing it). At the beginning I was not able to reproduce Peter's issue and eventually after many various tweaks in the environment I was able to. I used the script to regenerate the DSDT and this definitively fixes the issue for me. Now we are not sure this isn't an issue in the test itself.

Thanks

Eric

Quoted 25 lines

Regards,

Phil.

Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
---
 tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
tests/data/acpi/virt/DSDT binary +0 -0
index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
GIT binary patch
Reviewed-by on v1 1/1
#5 lore raw
In reply to Eric Auger
Quoted 3 lines · On Mon, 1 Jul 2019 21:08:19 +0200 Eric Auger <[email protected]> wrote:

PCDIMM hotplug addition updated the DSDT. Update the reference table.

checked ASL after applying it.
Modulo minor issue with generated ASL (reference to non existing method when running without memory hotplug enabled) which lax linux AML interpreter happily ignores if method is not actually accessed. (could be fixed later on top of Shameer's series as trivial bugfix)

Quoted 18 lines
---
 tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
tests/data/acpi/virt/DSDT binary +0 -0
index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
GIT binary patch

Ni>WOjJjjWw0RY`tDw+TQ

delta 134 zcmdlxfpN_QMlP3Nmk=Ef1_q{ziCof5?F}2%bKIpo*xdvC4LIUGJY9GlgM2*<49pA} zIN}{$f+ogc$P_2rw{ovN13+sxvS!RDxt&Jq4Ay6ndl?7@-g-A<n=c$sh-0Ff)LR Z11c2ZjdwLLW@rlt4|3vam^{&45den68LI#Q