Skip to contentSkip to conversation

fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads.patch removed from -mm tree

merged [email protected] 1 participant 1 message Jul 1, 2019 Stable branch

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: fs/proc/array.c: allow reporting eip/esp for all coredumping threads
has been removed from the -mm tree. Its filename was
fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: John Ogness <[email protected]>
Subject: fs/proc/array.c: allow reporting eip/esp for all coredumping threads

0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in /proc/PID/stat") stopped reporting eip/esp and fd7d56270b52 ("fs/proc: Report eip/esp in /prod/PID/stat for coredumping") reintroduced the feature to fix a regression with userspace core dump handlers (such as minicoredumper).

Because PF_DUMPCORE is only set for the primary thread, this didn't fix the original problem for secondary threads. Allow reporting the eip/esp for all threads by checking for PF_EXITING as well. This is set for all the other threads when they are killed. coredump_wait() waits for all the tasks to become inactive before proceeding to invoke a core dumper.

Fixes fd7d56270b526ca3 ("fs/proc: Report eip/esp in /prod/PID/stat for coredumping")
Cc Alexey Dobriyan <[email protected]>
Cc Andy Lutomirski <[email protected]>

---

 fs/proc/array.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/proc/array.c renamed from fs/proc/array.c~fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads +1 -1
@@ -462,7 +462,7 @@ static int do_task_stat(struct seq_file
 		 * a program is not able to use ptrace(2) in that case. It is
 		 * safe because the task has stopped executing permanently.
 		 */
-		if (permitted && (task->flags & PF_DUMPCORE)) {
+		if (permitted && (task->flags & (PF_EXITING|PF_DUMPCORE))) {
 			if (try_get_task_stack(task)) {
 				eip = KSTK_EIP(task);
 				esp = KSTK_ESP(task);

_

Patches currently in -mm which might be from [email protected] are