Skip to contentSkip to conversation

docs: substitute XEN_CONFIG_DIR in xl.conf.5

PATCH In review Olaf Hering 4 participants 7 messages Jun 21, 2019 – Aug 19, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs: substitute XEN_CONFIG_DIR in xl.conf.5

xl(1) opens xl.conf in XEN_CONFIG_DIR.
Substitute this variable also in the man page.

---
 docs/man/xl.1.pod.in      | 2 +-
 docs/man/xl.conf.5.pod.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
docs/man/xl.1.pod.in +1 -1
index 3d64eaa5b2..fb17153635 100644
@@ -50,7 +50,7 @@ setup the bridge.
 
 If you specify the amount of memory dom0 has, passing B<dom0_mem> to
 Xen, it is highly recommended to disable B<autoballoon>. Edit
-B</etc/xen/xl.conf> and set it to 0.
+B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
 
 =item run xl as B<root>
 
docs/man/xl.conf.5.pod.in +1 -1
index 2beb2119a8..b16036aaeb 100644
@@ -1,6 +1,6 @@
 =head1 NAME
 
-/etc/xen/xl.conf - XL Global/Host Configuration 
+@XEN_CONFIG_DIR@/xl.conf - XL Global/Host Configuration 
 
 =head1 DESCRIPTION
 

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Olaf Hering

xl(1) opens xl.conf in XEN_CONFIG_DIR.
Substitute this variable also in the man page.

---
 docs/man/xl.1.pod.in      | 2 +-
 docs/man/xl.conf.5.pod.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
docs/man/xl.1.pod.in +1 -1
index 3d64eaa5b2..fb17153635 100644
@@ -50,7 +50,7 @@ setup the bridge.
 
 If you specify the amount of memory dom0 has, passing B<dom0_mem> to
 Xen, it is highly recommended to disable B<autoballoon>. Edit
-B</etc/xen/xl.conf> and set it to 0.
+B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
 
 =item run xl as B<root>
 
docs/man/xl.conf.5.pod.in +0 -0
index 2beb2119a8..b16036aaeb 100644

docs/man/xl.conf.5.pod.in line 3

Quoted 4 lines
docs/man/xl.conf.5.pod.in +1 -1
@@ -1,6 +1,6 @@
 =head1 NAME
 
-/etc/xen/xl.conf - XL Global/Host Configuration 
+@XEN_CONFIG_DIR@/xl.conf - XL Global/Host Configuration 

There's a trailing whitespace, it would be worth removing it. git complain about it.

The patch seems to depends on "Use XEN_SCRIPT_DIR to refer to /etc/xen/scripts", but the email doesn't mention it. It would have been useful to add a note bellow the '---' line or send in a series of patch.

Beside that:

Thanks,

Signature · 6 lines
Anthony PERARD

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#2 lore raw
In reply to Olaf Hering

docs/man/xl.conf.5.pod.in

Quoted 26 lines · Olaf Hering

xl(1) opens xl.conf in XEN_CONFIG_DIR.
Substitute this variable also in the man page.

---
 docs/man/xl.1.pod.in      | 2 +-
 docs/man/xl.conf.5.pod.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
docs/man/xl.1.pod.in +1 -1
index 3d64eaa5b2..fb17153635 100644
@@ -50,7 +50,7 @@ setup the bridge.
 
 If you specify the amount of memory dom0 has, passing B<dom0_mem> to
 Xen, it is highly recommended to disable B<autoballoon>. Edit
-B</etc/xen/xl.conf> and set it to 0.
+B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
 
 =item run xl as B<root>
 
docs/man/xl.conf.5.pod.in +0 -0
index 2beb2119a8..b16036aaeb 100644

Sorry for the late reply.

This doesn't apply. There is no such file.

Wei.

docs/man/xl.conf.5.pod.in line 6

Quoted 8 lines
docs/man/xl.conf.5.pod.in +1 -1
@@ -1,6 +1,6 @@
 =head1 NAME
 
-/etc/xen/xl.conf - XL Global/Host Configuration 
+@XEN_CONFIG_DIR@/xl.conf - XL Global/Host Configuration 
 
 =head1 DESCRIPTION
 

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
Quoted 23 lines · Wei Liu
Quoted 22 lines · Olaf Hering

xl(1) opens xl.conf in XEN_CONFIG_DIR.
Substitute this variable also in the man page.

---
 docs/man/xl.1.pod.in      | 2 +-
 docs/man/xl.conf.5.pod.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
docs/man/xl.1.pod.in +1 -1
index 3d64eaa5b2..fb17153635 100644
@@ -50,7 +50,7 @@ setup the bridge.
 
 If you specify the amount of memory dom0 has, passing B<dom0_mem> to
 Xen, it is highly recommended to disable B<autoballoon>. Edit
-B</etc/xen/xl.conf> and set it to 0.
+B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
 
 =item run xl as B<root>
 
Quoted 7 lines

docs/man/xl.conf.5.pod.in

Quoted 4 lines
docs/man/xl.conf.5.pod.in +0 -0
index 2beb2119a8..b16036aaeb 100644

Sorry for the late reply.

This doesn't apply. There is no such file.

Hmm.  We have a xl.conf.5.pod which has no substitutions in, and I don't recall this changing.  Perhaps a logical dependency earlier in the SUSE patch queue?

I think this patch needs a {pod=>pod.in} rename as well, for it to apply to staging and work as intended.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw
Quoted 30 lines · Andrew Cooper
Quoted 29 lines · Wei Liu

docs/man/xl.conf.5.pod.in

Quoted 26 lines · Olaf Hering

xl(1) opens xl.conf in XEN_CONFIG_DIR.
Substitute this variable also in the man page.

---
 docs/man/xl.1.pod.in      | 2 +-
 docs/man/xl.conf.5.pod.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
docs/man/xl.1.pod.in +1 -1
index 3d64eaa5b2..fb17153635 100644
@@ -50,7 +50,7 @@ setup the bridge.
 
 If you specify the amount of memory dom0 has, passing B<dom0_mem> to
 Xen, it is highly recommended to disable B<autoballoon>. Edit
-B</etc/xen/xl.conf> and set it to 0.
+B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
 
 =item run xl as B<root>
 
docs/man/xl.conf.5.pod.in +0 -0
index 2beb2119a8..b16036aaeb 100644

Sorry for the late reply.

Quoted 8 lines
Quoted 1 line

This doesn't apply. There is no such file.

Hmm.  We have a xl.conf.5.pod which has no substitutions in, and I don't recall this changing.  Perhaps a logical dependency earlier in the SUSE patch queue?

I think this patch needs a {pod=>pod.in} rename as well, for it to apply to staging and work as intended.

I figured that as well.

Perhaps I missed the patch that did the renaming from Olaf. Unfortunately I don't have the full xen-devel archive in my mailbox now.

Wei.

Quoted 2 lines

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#5 lore raw
In reply to Wei Liu

Am Sun, 18 Aug 2019 18:20:26 +0100
schrieb Wei Liu <[email protected]>:

Quoted 1 line

This doesn't apply. There is no such file.

My changes need to be applied in this order, some of them may apply in any order:

[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Olaf

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw
Quoted 5 lines · Olaf Hering

Am Sun, 18 Aug 2019 18:20:26 +0100
schrieb Wei Liu <[email protected]>:

Quoted 1 line

This doesn't apply. There is no such file.

Quoted 8 lines

My changes need to be applied in this order, some of them may apply in any order:

[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Thanks. I will take a look.

Wei.

Quoted 3 lines

Olaf

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel