crypto: ccp/gcm - use const time tag comparison.
PATCH v2 1/1 crypto: ccp/gcm - use const time tag comparison.
Avoid leaking GCM tag through timing side channel.
Fixes 36cf515b9bbe ("crypto: ccp - Enable support for AES GCM on v5 CCPs")
Cc <[email protected]> # v4.12+
Signed-off-by Cfir Cohen <[email protected]>
--- drivers/crypto/ccp/ccp-ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/crypto/ccp/ccp-ops.c +2 -1
@@ -840,7 +840,8 @@ static int ccp_run_aes_gcm_cmd(struct ccp_cmd_queue *cmd_q,if (ret) goto e_tag; - ret =memcmp (tag.address, final_wa.address,AES_BLOCK_SIZE ); + ret =crypto_memneq (tag.address, final_wa.address, +AES_BLOCK_SIZE ) ? -EBADMSG :0 ;ccp_dm_free (&tag); }
Signature · 1 line
2.22.0.410.gd8fdbe21b5-goog
Quoted 5 lines · Cfir Cohen
Avoid leaking GCM tag through timing side channel.
Fixes 36cf515b9bbe ("crypto: ccp - Enable support for AES GCM on v5 CCPs")Cc <[email protected]> # v4.12+Signed-off-by Cfir Cohen <[email protected]>
Acked-by Gary R Hook <[email protected]>
Quoted 19 lines
--- drivers/crypto/ccp/ccp-ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/crypto/ccp/ccp-ops.c +2
-1@@ -840,7 +840,8 @@ static int ccp_run_aes_gcm_cmd(struct ccp_cmd_queue *cmd_q,if (ret) goto e_tag; - ret =memcmp (tag.address, final_wa.address,AES_BLOCK_SIZE ); + ret =crypto_memneq (tag.address, final_wa.address, +AES_BLOCK_SIZE ) ? -EBADMSG :0 ;ccp_dm_free (&tag); }
Herbert Xu
maintainerQuoted 8 lines · Cfir Cohen
Avoid leaking GCM tag through timing side channel.
Fixes 36cf515b9bbe ("crypto: ccp - Enable support for AES GCM on v5 CCPs")Cc <[email protected]> # v4.12+Signed-off-by Cfir Cohen <[email protected]>--- drivers/crypto/ccp/ccp-ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt