Skip to contentSkip to conversation

fs: ocfs2: dlmglue: Unneeded variable: "status"

PATCH In review Hariprasad Kelam 2 participants 2 messages Jul 2, 2019 – Jul 5, 2019 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: ocfs2: dlmglue: Unneeded variable: "status"

fix below issue reported by coccicheck fs/ocfs2/dlmglue.c:4410:5-11: Unneeded variable: "status". Return "0" on line 4428

We can not change return type of ocfs2_downconvert_thread as its registered as callback of kthread_create.

---
 fs/ocfs2/dlmglue.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/ocfs2/dlmglue.c +1 -2
index dc987f5..1420723 100644
@@ -4407,7 +4407,6 @@ static int ocfs2_downconvert_thread_should_wake(struct ocfs2_super *osb)
 
 static int ocfs2_downconvert_thread(void *arg)
 {
-	int status = 0;
 	struct ocfs2_super *osb = arg;
 
 	/* only quit once we've been asked to stop and there is no more
@@ -4425,7 +4424,7 @@ static int ocfs2_downconvert_thread(void *arg)
 	}
 
 	osb->dc_task = NULL;
-	return status;
+	return 0;
 }
 
 void ocfs2_wake_downconvert_thread(struct ocfs2_super *osb)
Signature · 1 line
2.7.4
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Hariprasad Kelam

fix below issue reported by coccicheck fs/ocfs2/dlmglue.c:4410:5-11: Unneeded variable: "status". Return "0" on line 4428

We can not change return type of ocfs2_downconvert_thread as its registered as callback of kthread_create.

Quoted 26 lines
---
 fs/ocfs2/dlmglue.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/ocfs2/dlmglue.c +1 -2
index dc987f5..1420723 100644
@@ -4407,7 +4407,6 @@ static int ocfs2_downconvert_thread_should_wake(struct ocfs2_super *osb)
 
 static int ocfs2_downconvert_thread(void *arg)
 {
-	int status = 0;
 	struct ocfs2_super *osb = arg;
 
 	/* only quit once we've been asked to stop and there is no more
@@ -4425,7 +4424,7 @@ static int ocfs2_downconvert_thread(void *arg)
 	}
 
 	osb->dc_task = NULL;
-	return status;
+	return 0;
 }
 
 void ocfs2_wake_downconvert_thread(struct ocfs2_super *osb)