Skip to contentSkip to conversation

drm/rockchip: fix VOP_WIN_GET macro

PATCH Applied John Keeping 2 participants 2 messages Jul 3, 2019 – Aug 7, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/rockchip: fix VOP_WIN_GET macro

Commit 9a61c54b9bff ("drm/rockchip: vop: group vop registers") seems to have unintentionally changed the defintion of this macro. Since it is unused, this was not spotted but any attempt to use it results in compilation errors.

Revert to the previous definition.

Fixes 9a61c54b9bff ("drm/rockchip: vop: group vop registers")
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +1 -1
index 09a790c2f3a1..a3430da3c008 100644
@@ -79,7 +79,7 @@
 		vop_get_intr_type(vop, &vop->data->intr->name, type)
 
 #define VOP_WIN_GET(vop, win, name) \
-		vop_read_reg(vop, win->offset, win->phy->name)
+		vop_read_reg(vop, win->base, &win->phy->name)
 
 #define VOP_WIN_HAS_REG(win, name) \
 	(!!(win->phy->name.mask))
Signature · 1 line
2.22.0
maintainer Applied
#1 lore raw

Am Mittwoch, 3. Juli 2019, 11:51:11 CEST schrieb John Keeping:

Quoted 9 lines

Commit 9a61c54b9bff ("drm/rockchip: vop: group vop registers") seems to have unintentionally changed the defintion of this macro. Since it is unused, this was not spotted but any attempt to use it results in compilation errors.

Revert to the previous definition.

Fixes 9a61c54b9bff ("drm/rockchip: vop: group vop registers")

applied to drm-misc-next

Thanks
Heiko

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel