Skip to contentSkip to conversation

dt-bindings: i2c: mv64xxx: Fix the example compatible

PATCH Applied Maxime Ripard 4 participants 8 messages Jul 3, 2019 – Jul 5, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: i2c: mv64xxx: Fix the example compatible

One example has a compatible that isn't a valid combination according to the binding, and now that the examples are validated as well, this generates a warning.

Let's fix this.

---
 Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml +1 -1
index 9a5654ef5670..001f2b7abad0 100644
@@ -105,7 +105,7 @@ examples:
 
   - |
     i2c@11000 {
-        compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
+        compatible = "marvell,mv78230-i2c";
         reg = <0x11000 0x100>;
         interrupts = <29>;
         clock-frequency = <100000>;
Signature · 1 line
2.21.0
#1 lore raw

PATCH 2/2 dt-bindings: i2c: sun6i-p2wi: Fix the binding example

Even though the binding claims that the frequency can go up to 6MHz, the common i2c binding sets a limit at 3MHz, which then triggers a warning.

Since the only SoC that uses that bus uses a frequency of 100kHz, and that this bus hasn't been found in an SoC for something like 5 years, let's just fix the example to have a frequency within the acceptable range for i2c.

---
 .../devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml +1 -1
index 1804abe24f14..f9d526b7da01 100644
@@ -51,7 +51,7 @@ examples:
         reg = <0x01f03400 0x400>;
         interrupts = <0 39 4>;
         clocks = <&apb0_gates 3>;
-        clock-frequency = <6000000>;
+        clock-frequency = <100000>;
         resets = <&apb0_rst 3>;
         #address-cells = <1>;
         #size-cells = <0>;
Signature · 1 line
2.21.0
maintainer Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example

Quoted 8 lines · Maxime Ripard

Even though the binding claims that the frequency can go up to 6MHz, the common i2c binding sets a limit at 3MHz, which then triggers a warning.

Since the only SoC that uses that bus uses a frequency of 100kHz, and that this bus hasn't been found in an SoC for something like 5 years, let's just fix the example to have a frequency within the acceptable range for i2c.

Thanks,

Gregory

Quoted 20 lines
---
 .../devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml +1 -1
index 1804abe24f14..f9d526b7da01 100644
@@ -51,7 +51,7 @@ examples:
         reg = <0x01f03400 0x400>;
         interrupts = <0 39 4>;
         clocks = <&apb0_gates 3>;
-        clock-frequency = <6000000>;
+        clock-frequency = <100000>;
         resets = <&apb0_rst 3>;
         #address-cells = <1>;
         #size-cells = <0>;
Signature · 1 line
2.21.0
Signature · 3 lines
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example

In reply to Maxime Ripard
Quoted 4 lines · Maxime Ripard

Even though the binding claims that the frequency can go up to 6MHz, the common i2c binding sets a limit at 3MHz, which then triggers a warning.

Quoted 8 lines

Since the only SoC that uses that bus uses a frequency of 100kHz, and that this bus hasn't been found in an SoC for something like 5 years, let's just fix the example to have a frequency within the acceptable range for i2c.

---
 .../devicetree/bindings/i2c/allwinner,sun6i-a31-p2wi.yaml       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied
#4 lore raw

Re: [PATCH 2/2] dt-bindings: i2c: sun6i-p2wi: Fix the binding example

In reply to Maxime Ripard
Quoted 8 lines · Maxime Ripard

Even though the binding claims that the frequency can go up to 6MHz, the common i2c binding sets a limit at 3MHz, which then triggers a warning.

Since the only SoC that uses that bus uses a frequency of 100kHz, and that this bus hasn't been found in an SoC for something like 5 years, let's just fix the example to have a frequency within the acceptable range for i2c.

Applied to for-next, thanks!

maintainer Acked-by on v1 1/2
#5 lore raw
In reply to Maxime Ripard
Quoted 7 lines · Maxime Ripard

One example has a compatible that isn't a valid combination according to the binding, and now that the examples are validated as well, this generates a warning.

Let's fix this.

Thanks,

Gregory

Quoted 20 lines
---
 Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml +1 -1
index 9a5654ef5670..001f2b7abad0 100644
@@ -105,7 +105,7 @@ examples:
 
   - |
     i2c@11000 {
-        compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
+        compatible = "marvell,mv78230-i2c";
         reg = <0x11000 0x100>;
         interrupts = <29>;
         clock-frequency = <100000>;
Signature · 1 line
2.21.0
Signature · 3 lines
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
Reviewed-by on v1 1/2
#6 lore raw
In reply to Maxime Ripard
Quoted 11 lines · Maxime Ripard

One example has a compatible that isn't a valid combination according to the binding, and now that the examples are validated as well, this generates a warning.

Let's fix this.

---
 Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)