lib/igt_eld: print debug message when no ELD is found
PATCH 1/1 lib/igt_eld: print debug message when no ELD is found
When this happens, the logs were completely empty previously, which can be quite confusing.
--- lib/igt_eld.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
lib/igt_eld.c +7 -1
@@ -207,10 +207,11 @@ bool eld_get_igt(struct eld_entry *eld) {DIR *dir;struct dirent *dirent; -int i; +int i, n_elds;char card[64 ];char path[PATH_MAX ]; + n_elds =0 ;for (i =0 ; i <8 ; i++) {snprintf (card,sizeof (card),"/proc/asound/card%d" , i); dir =opendir (card);
@@ -222,6 +223,8 @@ bool eld_get_igt(struct eld_entry *eld) strlen(ELD_PREFIX)) != 0)continue ; + n_elds++; +snprintf (path,sizeof (path),"%s/%s" , card, dirent->d_name);if (!eld_parse_entry (path, eld)) {
@@ -246,6 +249,9 @@ bool eld_get_igt(struct eld_entry *eld)closedir (dir); } +if (n_elds ==0 ) +igt_debug ("Found zero ELDs\n" ); +return false; }
--
2.22.0
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 4 lines · Simon Ser
When this happens, the logs were completely empty previously, which can be quite confusing.
Signed-off-by Simon Ser <[email protected]>
Quoted 47 lines
--- lib/igt_eld.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)lib/igt_eld.c +7
-2@@ -207,10 +207,11 @@ bool eld_get_igt(struct eld_entry *eld) {DIR *dir;struct dirent *dirent; -int i; +int i, n_elds;char card[64 ];char path[PATH_MAX ]; + n_elds =0 ;for (i =0 ; i <8 ; i++) {snprintf (card,sizeof (card),"/proc/asound/card%d" , i); dir =opendir (card);@@ -222,6 +223,8 @@ bool eld_get_igt(struct eld_entry *eld) strlen(ELD_PREFIX)) != 0)continue ; + n_elds++; +snprintf (path,sizeof (path),"%s/%s" , card, dirent->d_name);if (!eld_parse_entry (path, eld)) {@@ -246,6 +249,9 @@ bool eld_get_igt(struct eld_entry *eld)closedir (dir); } +if (n_elds ==0 ) +igt_debug ("Found zero ELDs\n" ); +return false; } --2.22.0
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_eld: print debug message when no ELD is found
In reply to Simon Ser== Series Details ==
== Series Details ==
Series: lib/igt_eld: print debug message when no ELD is found
URL : https://patchwork.freedesktop.org/series/63073/
State : success
== Summary ==
CI Bug Log - changes from IGT_5079 -> IGTPW_3223
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/63073/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3223 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_blt:
- fi-skl-iommu: [PASS][1] -> [INCOMPLETE][2] ([fdo#108602])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/fi-skl-iommu/igt@i915_selftest@live_blt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/fi-skl-iommu/igt@i915_selftest@live_blt.html
#### Possible fixes ####
* igt@core_auth@basic-auth:
- fi-icl-u3: [DMESG-WARN][3] ([fdo#107724]) -> [PASS][4] +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/fi-icl-u3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/fi-icl-u3/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][5] ([fdo#109485]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/fi-kbl-7500u/igt@[email protected]
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
Participating hosts (53 -> 47)
------------------------------
Additional (2): fi-icl-guc fi-pnv-d510
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5079 -> IGTPW_3223
CI_DRM_6395: f80b22d5965c56053080a5ce2234d52bdec871c1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3223: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/
IGT_5079: 873df2fa9e8f5fd02d4532b30ef2579f4fe4f27f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for lib/igt_eld: print debug message when no ELD is found
In reply to Simon Ser== Series Details ==
== Series Details ==
Series: lib/igt_eld: print debug message when no ELD is found
URL : https://patchwork.freedesktop.org/series/63073/
State : success
== Summary ==
CI Bug Log - changes from IGT_5079_full -> IGTPW_3223_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/63073/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3223_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-apl8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-apl7/igt@[email protected]
* igt@gem_exec_await@wide-all:
- shard-hsw: [PASS][3] -> [INCOMPLETE][4] ([fdo#103540])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-hsw4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-hsw4/igt@[email protected]
* igt@gem_tiled_swapping@non-threaded:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108686] / [fdo#110853])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-kbl3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-kbl3/igt@[email protected]
- shard-snb: [PASS][7] -> [DMESG-WARN][8] ([fdo#108686])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-snb4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-snb2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-kbl: [PASS][9] -> [FAIL][10] ([fdo#103232])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-kbl1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-kbl7/igt@[email protected]
- shard-apl: [PASS][11] -> [FAIL][12] ([fdo#103232])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-apl7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-apl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +5 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][17] -> [FAIL][18] ([fdo#99912])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-kbl4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-kbl7/igt@[email protected]
#### Possible fixes ####
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [DMESG-WARN][19] ([fdo#108686]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-glk4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-glk8/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][21] ([fdo#108566]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-apl4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-apl1/igt@[email protected]
* igt@kms_flip@basic-plain-flip:
- shard-hsw: [INCOMPLETE][23] ([fdo#103540]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-hsw2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-hsw1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-iclb: [FAIL][25] ([fdo#103167]) -> [PASS][26] +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-iclb6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-iclb6/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][27] ([fdo#109642]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-iclb4/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][29] ([fdo#109441]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
#### Warnings ####
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][31] ([fdo#107724]) -> [SKIP][32] ([fdo#109349])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5079/shard-iclb2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/shard-iclb8/igt@[email protected]
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110853]: https://bugs.freedesktop.org/show_bug.cgi?id=110853
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 6)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_5079 -> IGTPW_3223
CI_DRM_6395: f80b22d5965c56053080a5ce2234d52bdec871c1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3223: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/
IGT_5079: 873df2fa9e8f5fd02d4532b30ef2579f4fe4f27f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3223/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev