Skip to contentSkip to conversation

netfilter: nft_meta: fix bridge port vlan ID selector

PATCH In review Pablo Neira Ayuso 3 participants 9 messages Jul 3, 2019

Subsystems (4)
lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 netfilter: nft_meta: fix bridge port vlan ID selector

Use br_vlan_enabled() and br_vlan_get_pvid() helpers as Nikolay suggests.

Rename NFT_META_BRI_PVID to NFT_META_BRI_IIFPVID before this patch hits the 5.3 release cycle, to leave room for matching for the output bridge port in the future.

Fixes da4f10a4265b ("netfilter: nft_meta: add NFT_META_BRI_PVID support")
---
 include/uapi/linux/netfilter/nf_tables.h |  4 ++--
 net/netfilter/nft_meta.c                 | 17 ++++++++++-------
 2 files changed, 12 insertions(+), 9 deletions(-)
include/uapi/linux/netfilter/nf_tables.h +2 -2
index 8859535031e2..8a1bd0b1ec8c 100644
@@ -795,7 +795,7 @@ enum nft_exthdr_attributes {
  * @NFT_META_SECPATH: boolean, secpath_exists (!!skb->sp)
  * @NFT_META_IIFKIND: packet input interface kind name (dev->rtnl_link_ops->kind)
  * @NFT_META_OIFKIND: packet output interface kind name (dev->rtnl_link_ops->kind)
- * @NFT_META_BRI_PVID: packet input bridge port pvid
+ * @NFT_META_BRI_IIFPVID: packet input bridge port pvid
  */
 enum nft_meta_keys {
 	NFT_META_LEN,
@@ -826,7 +826,7 @@ enum nft_meta_keys {
 	NFT_META_SECPATH,
 	NFT_META_IIFKIND,
 	NFT_META_OIFKIND,
-	NFT_META_BRI_PVID,
+	NFT_META_BRI_IIFPVID,
 };
 
 /**
net/netfilter/nft_meta.c +10 -7
index 4f8116de70f8..b8d8adc0852e 100644
@@ -240,14 +240,17 @@ void nft_meta_get_eval(const struct nft_expr *expr,
 			goto err;
 		strncpy((char *)dest, p->br->dev->name, IFNAMSIZ);
 		return;
-	case NFT_META_BRI_PVID:
+	case NFT_META_BRI_IIFPVID: {
+		u16 p_pvid;
+
 		if (in == NULL || (p = br_port_get_rtnl_rcu(in)) == NULL)
 			goto err;
-		if (br_opt_get(p->br, BROPT_VLAN_ENABLED)) {
-			nft_reg_store16(dest, br_get_pvid(nbp_vlan_group_rcu(p)));
-			return;
-		}
-		goto err;
+		if (!br_vlan_enabled(in))
+			goto err;
+		br_vlan_get_pvid(in, &p_pvid);
+		nft_reg_store16(dest, p_pvid);
+		return;
+	}
 #endif
 	case NFT_META_IIFKIND:
 		if (in == NULL || in->rtnl_link_ops == NULL)
@@ -375,7 +378,7 @@ static int nft_meta_get_init(const struct nft_ctx *ctx,
 			return -EOPNOTSUPP;
 		len = IFNAMSIZ;
 		break;
-	case NFT_META_BRI_PVID:
+	case NFT_META_BRI_IIFPVID:
 		if (ctx->family != NFPROTO_BRIDGE)
 			return -EOPNOTSUPP;
 		len = sizeof(u16);
Signature · 1 line
2.11.0
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Pablo Neira Ayuso

Use br_vlan_enabled() and br_vlan_get_pvid() helpers as Nikolay suggests.

Rename NFT_META_BRI_PVID to NFT_META_BRI_IIFPVID before this patch hits the 5.3 release cycle, to leave room for matching for the output bridge port in the future.

Quoted 8 lines
Fixes da4f10a4265b ("netfilter: nft_meta: add NFT_META_BRI_PVID support")
---
 include/uapi/linux/netfilter/nf_tables.h |  4 ++--
 net/netfilter/nft_meta.c                 | 17 ++++++++++-------
 2 files changed, 12 insertions(+), 9 deletions(-)

Awesome, thanks!

#2 lore raw
In reply to Pablo Neira Ayuso
Quoted 7 lines · Pablo Neira Ayuso

Use br_vlan_enabled() and br_vlan_get_pvid() helpers as Nikolay suggests.

Rename NFT_META_BRI_PVID to NFT_META_BRI_IIFPVID before this patch hits the 5.3 release cycle, to leave room for matching for the output bridge port in the future.

Quoted 8 lines
Fixes da4f10a4265b ("netfilter: nft_meta: add NFT_META_BRI_PVID support")
---
 include/uapi/linux/netfilter/nf_tables.h |  4 ++--
 net/netfilter/nft_meta.c                 | 17 ++++++++++-------
 2 files changed, 12 insertions(+), 9 deletions(-)

Ah actually I might've hurried too much with the suggestion, we don't have a helper to check through a port if vlan filtering has been enabled. The helper assumes that the device is a bridge. So below you'll have to use p->br->dev with br_vlan_enabled(). And in fact the proper way would be to get the "upper" device via netdev_master_upper_dev_get() and then to use that in order to avoid direct dereferencing.

Quoted 60 lines
include/uapi/linux/netfilter/nf_tables.h +2 -2
index 8859535031e2..8a1bd0b1ec8c 100644
@@ -795,7 +795,7 @@ enum nft_exthdr_attributes {
  * @NFT_META_SECPATH: boolean, secpath_exists (!!skb->sp)
  * @NFT_META_IIFKIND: packet input interface kind name (dev->rtnl_link_ops->kind)
  * @NFT_META_OIFKIND: packet output interface kind name (dev->rtnl_link_ops->kind)
- * @NFT_META_BRI_PVID: packet input bridge port pvid
+ * @NFT_META_BRI_IIFPVID: packet input bridge port pvid
  */
 enum nft_meta_keys {
 	NFT_META_LEN,
@@ -826,7 +826,7 @@ enum nft_meta_keys {
 	NFT_META_SECPATH,
 	NFT_META_IIFKIND,
 	NFT_META_OIFKIND,
-	NFT_META_BRI_PVID,
+	NFT_META_BRI_IIFPVID,
 };
 
 /**
net/netfilter/nft_meta.c +10 -7
index 4f8116de70f8..b8d8adc0852e 100644
@@ -240,14 +240,17 @@ void nft_meta_get_eval(const struct nft_expr *expr,
 			goto err;
 		strncpy((char *)dest, p->br->dev->name, IFNAMSIZ);
 		return;
-	case NFT_META_BRI_PVID:
+	case NFT_META_BRI_IIFPVID: {
+		u16 p_pvid;
+
 		if (in == NULL || (p = br_port_get_rtnl_rcu(in)) == NULL)
 			goto err;
-		if (br_opt_get(p->br, BROPT_VLAN_ENABLED)) {
-			nft_reg_store16(dest, br_get_pvid(nbp_vlan_group_rcu(p)));
-			return;
-		}
-		goto err;
+		if (!br_vlan_enabled(in))
+			goto err;
+		br_vlan_get_pvid(in, &p_pvid);
+		nft_reg_store16(dest, p_pvid);
+		return;
+	}
 #endif
 	case NFT_META_IIFKIND:
 		if (in == NULL || in->rtnl_link_ops == NULL)
@@ -375,7 +378,7 @@ static int nft_meta_get_init(const struct nft_ctx *ctx,
 			return -EOPNOTSUPP;
 		len = IFNAMSIZ;
 		break;
-	case NFT_META_BRI_PVID:
+	case NFT_META_BRI_IIFPVID:
 		if (ctx->family != NFPROTO_BRIDGE)
 			return -EOPNOTSUPP;
 		len = sizeof(u16);
#3 lore raw
Quoted 17 lines · Nikolay Aleksandrov
Quoted 7 lines · Pablo Neira Ayuso

Use br_vlan_enabled() and br_vlan_get_pvid() helpers as Nikolay suggests.

Rename NFT_META_BRI_PVID to NFT_META_BRI_IIFPVID before this patch hits the 5.3 release cycle, to leave room for matching for the output bridge port in the future.

Quoted 8 lines
Fixes da4f10a4265b ("netfilter: nft_meta: add NFT_META_BRI_PVID support")
---
 include/uapi/linux/netfilter/nf_tables.h |  4 ++--
 net/netfilter/nft_meta.c                 | 17 ++++++++++-------
 2 files changed, 12 insertions(+), 9 deletions(-)
Quoted 6 lines

Ah actually I might've hurried too much with the suggestion, we don't have a helper to check through a port if vlan filtering has been enabled. The helper assumes that the device is a bridge. So below you'll have to use p->br->dev with br_vlan_enabled(). And in fact the proper way would be to get the "upper" device via netdev_master_upper_dev_get() and then to use that in order to avoid direct dereferencing.

Sorry for the multiple replies, I just noticed this is running from fast-path so you'll have to use the _rcu variant and check for null since they are unlinked before the port flag is removed in del_nbp() (bridge/bf_if.c).

Quoted 61 lines
Quoted 60 lines
include/uapi/linux/netfilter/nf_tables.h +2 -2
index 8859535031e2..8a1bd0b1ec8c 100644
@@ -795,7 +795,7 @@ enum nft_exthdr_attributes {
  * @NFT_META_SECPATH: boolean, secpath_exists (!!skb->sp)
  * @NFT_META_IIFKIND: packet input interface kind name (dev->rtnl_link_ops->kind)
  * @NFT_META_OIFKIND: packet output interface kind name (dev->rtnl_link_ops->kind)
- * @NFT_META_BRI_PVID: packet input bridge port pvid
+ * @NFT_META_BRI_IIFPVID: packet input bridge port pvid
  */
 enum nft_meta_keys {
 	NFT_META_LEN,
@@ -826,7 +826,7 @@ enum nft_meta_keys {
 	NFT_META_SECPATH,
 	NFT_META_IIFKIND,
 	NFT_META_OIFKIND,
-	NFT_META_BRI_PVID,
+	NFT_META_BRI_IIFPVID,
 };
 
 /**
net/netfilter/nft_meta.c +10 -7
index 4f8116de70f8..b8d8adc0852e 100644
@@ -240,14 +240,17 @@ void nft_meta_get_eval(const struct nft_expr *expr,
 			goto err;
 		strncpy((char *)dest, p->br->dev->name, IFNAMSIZ);
 		return;
-	case NFT_META_BRI_PVID:
+	case NFT_META_BRI_IIFPVID: {
+		u16 p_pvid;
+
 		if (in == NULL || (p = br_port_get_rtnl_rcu(in)) == NULL)
 			goto err;
-		if (br_opt_get(p->br, BROPT_VLAN_ENABLED)) {
-			nft_reg_store16(dest, br_get_pvid(nbp_vlan_group_rcu(p)));
-			return;
-		}
-		goto err;
+		if (!br_vlan_enabled(in))
+			goto err;
+		br_vlan_get_pvid(in, &p_pvid);
+		nft_reg_store16(dest, p_pvid);
+		return;
+	}
 #endif
 	case NFT_META_IIFKIND:
 		if (in == NULL || in->rtnl_link_ops == NULL)
@@ -375,7 +378,7 @@ static int nft_meta_get_init(const struct nft_ctx *ctx,
 			return -EOPNOTSUPP;
 		len = IFNAMSIZ;
 		break;
-	case NFT_META_BRI_PVID:
+	case NFT_META_BRI_IIFPVID:
 		if (ctx->family != NFPROTO_BRIDGE)
 			return -EOPNOTSUPP;
 		len = sizeof(u16);
#4 lore raw
Quoted 25 lines · Nikolay Aleksandrov
Quoted 17 lines · Nikolay Aleksandrov
Quoted 7 lines · Pablo Neira Ayuso

Use br_vlan_enabled() and br_vlan_get_pvid() helpers as Nikolay suggests.

Rename NFT_META_BRI_PVID to NFT_META_BRI_IIFPVID before this patch hits the 5.3 release cycle, to leave room for matching for the output bridge port in the future.

Quoted 8 lines
Fixes da4f10a4265b ("netfilter: nft_meta: add NFT_META_BRI_PVID support")
---
 include/uapi/linux/netfilter/nf_tables.h |  4 ++--
 net/netfilter/nft_meta.c                 | 17 ++++++++++-------
 2 files changed, 12 insertions(+), 9 deletions(-)
Quoted 6 lines

Ah actually I might've hurried too much with the suggestion, we don't have a helper to check through a port if vlan filtering has been enabled. The helper assumes that the device is a bridge. So below you'll have to use p->br->dev with br_vlan_enabled(). And in fact the proper way would be to get the "upper" device via netdev_master_upper_dev_get() and then to use that in order to avoid direct dereferencing.

Quoted 4 lines

Sorry for the multiple replies, I just noticed this is running from fast-path so you'll have to use the _rcu variant and check for null since they are unlinked before the port flag is removed in del_nbp() (bridge/bf_if.c).

And then just scratch all of that and use p->br->dev directly, I saw it's already dereferenced before. :) Apologies for the noise.

Quoted 62 lines
Quoted 61 lines
Quoted 60 lines
include/uapi/linux/netfilter/nf_tables.h +2 -2
index 8859535031e2..8a1bd0b1ec8c 100644
@@ -795,7 +795,7 @@ enum nft_exthdr_attributes {
  * @NFT_META_SECPATH: boolean, secpath_exists (!!skb->sp)
  * @NFT_META_IIFKIND: packet input interface kind name (dev->rtnl_link_ops->kind)
  * @NFT_META_OIFKIND: packet output interface kind name (dev->rtnl_link_ops->kind)
- * @NFT_META_BRI_PVID: packet input bridge port pvid
+ * @NFT_META_BRI_IIFPVID: packet input bridge port pvid
  */
 enum nft_meta_keys {
 	NFT_META_LEN,
@@ -826,7 +826,7 @@ enum nft_meta_keys {
 	NFT_META_SECPATH,
 	NFT_META_IIFKIND,
 	NFT_META_OIFKIND,
-	NFT_META_BRI_PVID,
+	NFT_META_BRI_IIFPVID,
 };
 
 /**
net/netfilter/nft_meta.c +10 -7
index 4f8116de70f8..b8d8adc0852e 100644
@@ -240,14 +240,17 @@ void nft_meta_get_eval(const struct nft_expr *expr,
 			goto err;
 		strncpy((char *)dest, p->br->dev->name, IFNAMSIZ);
 		return;
-	case NFT_META_BRI_PVID:
+	case NFT_META_BRI_IIFPVID: {
+		u16 p_pvid;
+
 		if (in == NULL || (p = br_port_get_rtnl_rcu(in)) == NULL)
 			goto err;
-		if (br_opt_get(p->br, BROPT_VLAN_ENABLED)) {
-			nft_reg_store16(dest, br_get_pvid(nbp_vlan_group_rcu(p)));
-			return;
-		}
-		goto err;
+		if (!br_vlan_enabled(in))
+			goto err;
+		br_vlan_get_pvid(in, &p_pvid);
+		nft_reg_store16(dest, p_pvid);
+		return;
+	}
 #endif
 	case NFT_META_IIFKIND:
 		if (in == NULL || in->rtnl_link_ops == NULL)
@@ -375,7 +378,7 @@ static int nft_meta_get_init(const struct nft_ctx *ctx,
 			return -EOPNOTSUPP;
 		len = IFNAMSIZ;
 		break;
-	case NFT_META_BRI_PVID:
+	case NFT_META_BRI_IIFPVID:
 		if (ctx->family != NFPROTO_BRIDGE)
 			return -EOPNOTSUPP;
 		len = sizeof(u16);
#5 lore raw
In reply to Pablo Neira Ayuso
Quoted 49 lines · Pablo Neira Ayuso

Use br_vlan_enabled() and br_vlan_get_pvid() helpers as Nikolay suggests.

Rename NFT_META_BRI_PVID to NFT_META_BRI_IIFPVID before this patch hits the 5.3 release cycle, to leave room for matching for the output bridge port in the future.

Fixes da4f10a4265b ("netfilter: nft_meta: add NFT_META_BRI_PVID support")
---
 include/uapi/linux/netfilter/nf_tables.h |  4 ++--
 net/netfilter/nft_meta.c                 | 17 ++++++++++-------
 2 files changed, 12 insertions(+), 9 deletions(-)
include/uapi/linux/netfilter/nf_tables.h +2 -2
index 8859535031e2..8a1bd0b1ec8c 100644
@@ -795,7 +795,7 @@ enum nft_exthdr_attributes {
  * @NFT_META_SECPATH: boolean, secpath_exists (!!skb->sp)
  * @NFT_META_IIFKIND: packet input interface kind name (dev->rtnl_link_ops->kind)
  * @NFT_META_OIFKIND: packet output interface kind name (dev->rtnl_link_ops->kind)
- * @NFT_META_BRI_PVID: packet input bridge port pvid
+ * @NFT_META_BRI_IIFPVID: packet input bridge port pvid
  */
 enum nft_meta_keys {
 	NFT_META_LEN,
@@ -826,7 +826,7 @@ enum nft_meta_keys {
 	NFT_META_SECPATH,
 	NFT_META_IIFKIND,
 	NFT_META_OIFKIND,
-	NFT_META_BRI_PVID,
+	NFT_META_BRI_IIFPVID,
 };
 
 /**
net/netfilter/nft_meta.c +3 -1
index 4f8116de70f8..b8d8adc0852e 100644
@@ -240,14 +240,17 @@ void nft_meta_get_eval(const struct nft_expr *expr,
 			goto err;
 		strncpy((char *)dest, p->br->dev->name, IFNAMSIZ);
 		return;
-	case NFT_META_BRI_PVID:
+	case NFT_META_BRI_IIFPVID: {
+		u16 p_pvid;
+

net/netfilter/nft_meta.c void nft_meta_get_eval(const struct nft_expr *expr, · line 250

Quoted 10 lines
net/netfilter/nft_meta.c +3 -5
 		if (in == NULL || (p = br_port_get_rtnl_rcu(in)) == NULL)
 			goto err;
-		if (br_opt_get(p->br, BROPT_VLAN_ENABLED)) {
-			nft_reg_store16(dest, br_get_pvid(nbp_vlan_group_rcu(p)));
-			return;
-		}
-		goto err;
+		if (!br_vlan_enabled(in))
+			goto err;
+		br_vlan_get_pvid(in, &p_pvid);

I find the function br_vlan_get_pvid is ASSERT_RTNL();. But in this senario is under packet path.

Quoted 15 lines
net/netfilter/nft_meta.c +4 -1
+		nft_reg_store16(dest, p_pvid);
+		return;
+	}
 #endif
 	case NFT_META_IIFKIND:
 		if (in == NULL || in->rtnl_link_ops == NULL)
@@ -375,7 +378,7 @@ static int nft_meta_get_init(const struct nft_ctx *ctx,
 			return -EOPNOTSUPP;
 		len = IFNAMSIZ;
 		break;
-	case NFT_META_BRI_PVID:
+	case NFT_META_BRI_IIFPVID:
 		if (ctx->family != NFPROTO_BRIDGE)
 			return -EOPNOTSUPP;
 		len = sizeof(u16);
author maintainer
#6 lore raw

Hi,

I'm planning to revert from nf-next

da4f10a4265b netfilter: nft_meta: add NFT_META_BRI_PVID support

because:

* Nikolay wants us to use the helpers, however, through the existing approach this creates a dependency between nft_meta and the bridge module. I think I suggested this already, but it seems there is a need for nft_meta_bridge, otherwise nft_meta pulls in the bridge modules as a dependency.

* NFT_META_BRI_PVID needs to be rename to NFT_META_BRI_IIFPVID.

* We need new helpers to access this information from rcu path, I'm attaching a patch for such helper for review.

so we take the time to get this right :-)

From 260cb904228b23d62fddad0e1898c82218a69c57 Mon Sep 17 00:00:00 2001
From: Pablo Neira Ayuso <[email protected]>
Date: Wed, 3 Jul 2019 16:03:12 +0200
Subject: [PATCH] bridge: add br_vlan_get_pvid_rcu()

This new function allows you to fetch bridge pvid from packet path.

---
 include/linux/if_bridge.h |  6 ++++++
 net/bridge/br_vlan.c      | 19 +++++++++++++++----
 2 files changed, 21 insertions(+), 4 deletions(-)
include/linux/if_bridge.h +6 -0
index f3fab5d0ea97..950db1dad830 100644
@@ -88,6 +88,7 @@ static inline bool br_multicast_router(const struct net_device *dev)
 #if IS_ENABLED(CONFIG_BRIDGE) && IS_ENABLED(CONFIG_BRIDGE_VLAN_FILTERING)
 bool br_vlan_enabled(const struct net_device *dev);
 int br_vlan_get_pvid(const struct net_device *dev, u16 *p_pvid);
+int br_vlan_get_pvid_rcu(const struct net_device *dev, u16 *p_pvid);
 int br_vlan_get_info(const struct net_device *dev, u16 vid,
 		     struct bridge_vlan_info *p_vinfo);
 #else
@@ -101,6 +102,11 @@ static inline int br_vlan_get_pvid(const struct net_device *dev, u16 *p_pvid)
 	return -EINVAL;
 }
 
+static inline int br_vlan_get_pvid_rcu(const struct net_device *dev, u16 *p_pvid)
+{
+	return -EINVAL;
+}
+
 static inline int br_vlan_get_info(const struct net_device *dev, u16 vid,
 				   struct bridge_vlan_info *p_vinfo)
 {
net/bridge/br_vlan.c +15 -4
index f47f526b4f19..8d97b91ad503 100644
@@ -1227,13 +1227,11 @@ void br_vlan_get_stats(const struct net_bridge_vlan *v,
 	}
 }
 
-int br_vlan_get_pvid(const struct net_device *dev, u16 *p_pvid)
+static int __br_vlan_get_pvid(const struct net_device *dev,
+			      struct net_bridge_port *p, u16 *p_pvid)
 {
 	struct net_bridge_vlan_group *vg;
-	struct net_bridge_port *p;
 
-	ASSERT_RTNL();
-	p = br_port_get_check_rtnl(dev);
 	if (p)
 		vg = nbp_vlan_group(p);
 	else if (netif_is_bridge_master(dev))
@@ -1244,8 +1242,21 @@ int br_vlan_get_pvid(const struct net_device *dev, u16 *p_pvid)
 	*p_pvid = br_get_pvid(vg);
 	return 0;
 }
+
+int br_vlan_get_pvid(const struct net_device *dev, u16 *p_pvid)
+{
+	ASSERT_RTNL();
+
+	return __br_vlan_get_pvid(dev, br_port_get_check_rtnl(dev), p_pvid);
+}
 EXPORT_SYMBOL_GPL(br_vlan_get_pvid);
 
+int br_vlan_get_pvid_rcu(const struct net_device *dev, u16 *p_pvid)
+{
+	return __br_vlan_get_pvid(dev, br_port_get_check_rcu(dev), p_pvid);
+}
+EXPORT_SYMBOL_GPL(br_vlan_get_pvid_rcu);
+
 int br_vlan_get_info(const struct net_device *dev, u16 vid,
 		     struct bridge_vlan_info *p_vinfo)
 {
Signature · 1 line
2.11.0
#7 lore raw
Quoted 14 lines · Pablo Neira Ayuso

Hi,

I'm planning to revert from nf-next

da4f10a4265b netfilter: nft_meta: add NFT_META_BRI_PVID support

because:

* Nikolay wants us to use the helpers, however, through the existing approach this creates a dependency between nft_meta and the bridge module. I think I suggested this already, but it seems there is a need for nft_meta_bridge, otherwise nft_meta pulls in the bridge modules as a dependency.

Quoted 7 lines

* NFT_META_BRI_PVID needs to be rename to NFT_META_BRI_IIFPVID.

* We need new helpers to access this information from rcu path, I'm attaching a patch for such helper for review.

so we take the time to get this right :-)

Hi,
The plan sounds good to me. I also went over the patch and it looks good. I think it'd be nice if we can get rid of the br_private.h include and make nft_meta (or meta_bridge) use linux/if_bridge.h instead. Having a clear distinction between what is supposed to be exported and what remains internal would be great. I will help out with that.

Thanks,
Nik

#8 lore raw
In reply to Pablo Neira Ayuso

Agree with you, After add the rcu patch I will resent the series fo nft_meta_bridge!.

Quoted 20 lines · Pablo Neira Ayuso

Hi,

I'm planning to revert from nf-next

da4f10a4265b netfilter: nft_meta: add NFT_META_BRI_PVID support

because:

* Nikolay wants us to use the helpers, however, through the existing approach this creates a dependency between nft_meta and the bridge module. I think I suggested this already, but it seems there is a need for nft_meta_bridge, otherwise nft_meta pulls in the bridge modules as a dependency.

* NFT_META_BRI_PVID needs to be rename to NFT_META_BRI_IIFPVID.

* We need new helpers to access this information from rcu path, I'm attaching a patch for such helper for review.

so we take the time to get this right :-)