build failures due to pigz host tool

Hi,

This came up as a topic in yesterday's Engineering Sync meeting. For roughly a year I've been seeing random build failures on my Jenkins setup due to pigz failing; apparently the project is now seeing them on their builds, so I'll share what I know of them.

At the time I started seeing these failures (Aug 2018) I had just upgraded my system to openSUSE 15.0. Since nobody else was seeing them, I assumed they were related to my setup. When I went out searching for an answer, I found there wasn't very much out there to help me. But I did notice that there were reports of other people seeing the issue who weren't using openSUSE and who weren't doing anything related to OE builds using Jenkins.

The build failure looks something like this:

	| DEBUG: Executing shell function sstate_create_package
	| pigz: abort: internal threads error
	| tar: /z/jenkins-workspace/nightly/cubietruck/build/sstate-cache/8a/sstate:linux-mainline:cubietruck-oe-linux-gnueabi:4.19.46:r0:cubietruck:3:8a159ba1ffefb5fc2feeeff5b40abf8ad67658e5ff3ed3bf67d25d9c8f2805e0_package.tgz.9bA8tCje: Wrote only 6144 of 10240 bytes
	| tar: Child returned status 16
	| tar: Error is not recoverable: exiting now
	| WARNING: /z/jenkins-workspace/nightly/cubietruck/build/tmp-glibc/work/cubietruck-oe-linux-gnueabi/linux-mainline/4.19.46-r0/temp/run.sstate_create_package.19996:1 exit 1 from 'exit 1'
	| DEBUG: Python function sstate_task_postfunc finished
	| ERROR: Function failed: sstate_create_package (log file is located at /z/jenkins-workspace/nightly/cubietruck/build/tmp-glibc/work/cubietruck-oe-linux-gnueabi/linux-mainline/4.19.46-r0/temp/log.do_package.19996)

NOTE: recipe linux-mainline-4.19.46-r0: task do_package: Failed
ERROR: Task (/opt/oe/configs/z/jenkins-workspace/nightly/cubietruck/layers/meta-sunxi/recipes-kernel/linux/linux-mainline_4.19.46.bb:do_package) failed with exit code '1'

Here's another example:

	| DEBUG: Executing shell function sstate_create_package
	| pigz: abort: internal threads error
	| tar: /z/jenkins-workspace/nightly/odroid-xu4/build/sstate-cache/d4/sstate:sqlite3:cortexa15t2hf-neon-vfpv4-oe-linux-gnueabi:3.28.0:r0:cortexa15t2hf-neon-vfpv4:3:d4eb5692a1756a832d72fb2003a3d431108fbc736044747d33698ad7b6881dd9_package.tgz.herLUpYQ: Wrote only 2048 of 10240 bytes
	| tar: Child returned status 16
	| tar: Error is not recoverable: exiting now
	| WARNING: /z/jenkins-workspace/nightly/odroid-xu4/build/tmp-glibc/work/cortexa15t2hf-neon-vfpv4-oe-linux-gnueabi/sqlite3/3_3.28.0-r0/temp/run.sstate_create_package.24136:1 exit 1 from 'exit 1'
	| DEBUG: Python function sstate_task_postfunc finished
	| ERROR: Function failed: sstate_create_package (log file is located at /z/jenkins-workspace/nightly/odroid-xu4/build/tmp-glibc/work/cortexa15t2hf-neon-vfpv4-oe-linux-gnueabi/sqlite3/3_3.28.0-r0/temp/log.do_package.24136)
	NOTE: recipe sqlite3-3_3.28.0-r0: task do_package: Failed
	ERROR: Task (/opt/oe/configs/z/jenkins-workspace/nightly/odroid-xu4/layers/openembedded-core/meta/recipes-support/sqlite/sqlite3_3.28.0.bb:do_package) failed with exit code '1'

When I first started seeing this problem, I would see it quite frequently. Every morning, out of roughly 15 nightly builds, around 4-5 of them would have failed in this way. Back then I would also get a lot of errors that would report something along the lines of the following:

fork: Resource temporarily unavailable
Cannot spawn thread (?)

I don't have an example of that error on hand, but I used to get a lot of those around the same time too.

My observations are:
- I've never seen any of these errors with builds that I run by hand, oddly enough, these errors only ever happen to builds that are run by Jenkins. I have no idea if this is just a coincidence, or if there is something going on related to kicking off a build from a large program (Jenkins)

- Back then these failures were quite frequent. Today, of the 20-ish or so Jenkins builds that are kicked off every night, in a 2-week span I have only 2 such failures. So it seems that I've been able to reduce the occurrence rate, but not eliminate it completely

- I haven't seen the "resource" failure in a while. I don't know if these are two separate issues that just happened to start at the same time, or if they're related in some way.

Quoted 1 line

From what little information I was able to find online, here are the things I

tweaked (which may or may not have contributed to the reduction in the rate of occurrence):

- At that time, I had been setting a "barrier=6000" on the disk I was using for the builds. I removed that tweak.

- I edited /etc/systemd/logind.conf and set
UserTaskMax=infinity

- I edited /etc/systemd/system.conf and set:
DefaultTaskAccounting=no
DefaultTaskMax=infinity

- I edited /etc/sysconfig/jenkins and added/set:
JENKINS_JAVA_OPTIONS="-Djava.awt.headless=true -Xmx1g"

Since this build failure is so intermittent, it's quite hard to dig into it. As I said above, of the last roughly 280 builds my system has done in the last 2 weeks, only 2 such failures occurred.

It's possible that overriding CONVERSION_CMD_gz in my builds to not use pigz would probably fix the issue at the cost of losing the parallelism of the sstate_create_package task.

My host machine's version of pigz is: 2.3.3

Best regards,
Trevor

Signature · 4 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

This came up as a topic in yesterday's Engineering Sync meeting. For roughly a year I've been seeing random build failures on my Jenkins setup due to pigz failing; apparently the project is now seeing them on their builds, so I'll share what I know of them.

At the time I started seeing these failures (Aug 2018) I had just upgraded my system to openSUSE 15.0. Since nobody else was seeing them, I assumed they were related to my setup. When I went out searching for an answer, I found there wasn't very much out there to help me. But I did notice that there were reports of other people seeing the issue who weren't using openSUSE and who weren't doing anything related to OE builds using Jenkins.

The build failure looks something like this:

	| DEBUG: Executing shell function sstate_create_package
	| pigz: abort: internal threads error
	| tar: /z/jenkins-workspace/nightly/cubietruck/build/sstate-cache/8a/sstate:linux-mainline:cubietruck-oe-linux-gnueabi:4.19.46:r0:cubietruck:3:8a159ba1ffefb5fc2feeeff5b40abf8ad67658e5ff3ed3bf67d25d9c8f2805e0_package.tgz.9bA8tCje: Wrote only 6144 of 10240 bytes
	| tar: Child returned status 16
	| tar: Error is not recoverable: exiting now
	| WARNING: /z/jenkins-workspace/nightly/cubietruck/build/tmp-glibc/work/cubietruck-oe-linux-gnueabi/linux-mainline/4.19.46-r0/temp/run.sstate_create_package.19996:1 exit 1 from 'exit 1'
	| DEBUG: Python function sstate_task_postfunc finished
	| ERROR: Function failed: sstate_create_package (log file is located at /z/jenkins-workspace/nightly/cubietruck/build/tmp-glibc/work/cubietruck-oe-linux-gnueabi/linux-mainline/4.19.46-r0/temp/log.do_package.19996)

NOTE: recipe linux-mainline-4.19.46-r0: task do_package: Failed
ERROR: Task (/opt/oe/configs/z/jenkins-workspace/nightly/cubietruck/layers/meta-sunxi/recipes-kernel/linux/linux-mainline_4.19.46.bb:do_package) failed with exit code '1'

When I first started seeing this problem, I would see it quite frequently. Every morning, out of roughly 15 nightly builds, around 4-5 of them would have failed in this way. Back then I would also get a lot of errors that would report something along the lines of the following:

fork: Resource temporarily unavailable
Cannot spawn thread (?)

I don't have an example of that error on hand, but I used to get a lot of those around the same time too.

My observations are:
- I've never seen any of these errors with builds that I run by hand, oddly enough, these errors only ever happen to builds that are run by Jenkins. I have no idea if this is just a coincidence, or if there is something going on related to kicking off a build from a large program (Jenkins)

- Back then these failures were quite frequent. Today, of the 20-ish or so Jenkins builds that are kicked off every night, in a 2-week span I have only 2 such failures. So it seems that I've been able to reduce the occurrence rate, but not eliminate it completely

- I haven't seen the "resource" failure in a while. I don't know if these are two separate issues that just happened to start at the same time, or if they're related in some way.

From what little information I was able to find online, here are the things I tweaked (which may or may not have contributed to the reduction in the rate of occurrence):

- At that time, I had been setting a "barrier=6000" on the disk I was using for the builds. I removed that tweak.

- I edited /etc/systemd/logind.conf and set
UserTaskMax=infinity

- I edited /etc/systemd/system.conf and set:
DefaultTaskAccounting=no
DefaultTaskMax=infinity

- I edited /etc/sysconfig/jenkins and added/set:
JENKINS_JAVA_OPTIONS="-Djava.awt.headless=true -Xmx1g"

Since this build failure is so intermittent, it's quite hard to dig into it. As I said above, of the last roughly 280 builds my system has done in the last 2 weeks, only 2 such failures occurred.

It's possible that overriding CONVERSION_CMD_gz in my builds to not use pigz would probably fix the issue at the cost of losing the parallelism of the sstate_create_package task.

My host machine's version of pigz is: 2.3.3

Is there any way you could try pigz 2.4 on your machine, see if the problem still occurred there? If you do rebuild pigz, could you apply the debug patch in master-next?

Quoted 4 lines · Richard Purdie

Is there any way you could try pigz 2.4 on your machine, see if the problem still occurred there? If you do rebuild pigz, could you apply
the debug patch in master-next?

I've updated the pigz in the $PATH jenkins sees to pigz-2.4.

However, my builds are always updated automatically and always build from master; there's no way to insert ad-hoc patches into a build.

Quoted 7 lines · Trevor Woerner

Quoted 5 lines · Richard Purdie

Is there any way you could try pigz 2.4 on your machine, see if the
problem still occurred there? If you do rebuild pigz, could you apply
the debug patch in master-next?

Quoted 5 lines

I've updated the pigz in the $PATH jenkins sees to pigz-2.4.

However, my builds are always updated automatically and always build
from master; there's no way to insert ad-hoc patches into a build.

That is fine, even just the PATH adjustment will be interesting to see
the results with, thanks!

Was that version of pigz patched? FWIW I've patched the one on our opensuse151 worker so we'll see if that helps shed any light on things.

Quoted 15 lines · Richard Purdie

Quoted 7 lines · Trevor Woerner

Quoted 5 lines · Richard Purdie

Is there any way you could try pigz 2.4 on your machine, see if the
problem still occurred there? If you do rebuild pigz, could you apply
the debug patch in master-next?

Quoted 6 lines

I've updated the pigz in the $PATH jenkins sees to pigz-2.4.

However, my builds are always updated automatically and always build
from master; there's no way to insert ad-hoc patches into a build.

Quoted 7 lines

That is fine, even just the PATH adjustment will be interesting to see
the results with, thanks!

Was that version of pigz patched? FWIW I've patched the one on our opensuse151 worker so we'll see if that helps shed any light on things.

and it did:

http://errors.yoctoproject.org/Errors/Details/250609/

pigz: abort: internal threads error (16, 10)

which means from:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?h=master-next&id=110ccb56b88af177c0153741a31a9d34b1f75abf

(quoted diff) +5 -0

+     if ((ret = pthread_cond_destroy(&(bolt->cond))) ||
+         (ret = pthread_mutex_destroy(&(bolt->mutex))))
+-        fail(ret);
++        fail(ret, 10);
+     my_free(bolt);

so pthread_cond_destroy or pthread_mutex_destroy returned EBUSY. Further digging required but at least we know which code path we're on. I wonder if suse did something odd to libpthread...

I can't see anything obvious wrong with the way job->calc is being handled.

I get the feeling this doesn't happen when uninative is in use which suggests its something odd going on with libpthread on opensuse but its hard to know that for sure.