Drop unused return value to build_power_updown_phy
Subsystems (2)
PATCH 1/1 Drop unused return value to build_power_updown_phy
--- drivers/gpu/drm/drm_dp_mst_topology.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_dp_mst_topology.c +3 -4
@@ -780,7 +780,7 @@ static int build_allocate_payload(struct drm_dp_sideband_msg_tx *msg, int port_nreturn 0 ; } -static int build_power_updown_phy (struct drm_dp_sideband_msg_tx *msg, +static void build_power_updown_phy (struct drm_dp_sideband_msg_tx *msg,int port_num,bool power_up) {struct drm_dp_sideband_msg_req_body req;
@@ -793,7 +793,6 @@ static int build_power_updown_phy(struct drm_dp_sideband_msg_tx *msg, req.u.port_num.port_number = port_num;drm_dp_encode_sideband_req (&req, msg); msg->path_msg = true; -return 0 ; } static int drm_dp_mst_assign_payload_id(struct drm_dp_mst_topology_mgr *mgr,
@@ -2212,7 +2211,7 @@ int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, bool power_up) {struct drm_dp_sideband_msg_tx *txmsg; -int len, ret; +int ret; port =drm_dp_mst_topology_get_port_validated (mgr, port);if (!port)
@@ -2225,7 +2224,7 @@ int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr, } txmsg->dst = port->parent; - len =build_power_updown_phy (txmsg, port->port_num, power_up); +build_power_updown_phy (txmsg, port->port_num, power_up);drm_dp_queue_down_tx (mgr, txmsg); ret =drm_dp_mst_wait_tx_reply (port->parent, txmsg);
Signature · 6 lines
2.11.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Thanks for doing this patch!
Quoted 1 line · Maya Rashish
---
We can't apply this patch because it doesn't follow necassary form (sob line missing). Please check out:
But the entire doc is relevant in general.
Thanks, Daniel
Quoted 49 lines
drivers/gpu/drm/drm_dp_mst_topology.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_dp_mst_topology.c +3
-4@@ -780,7 +780,7 @@ static int build_allocate_payload(struct drm_dp_sideband_msg_tx *msg, int port_nreturn 0 ; } -static int build_power_updown_phy (struct drm_dp_sideband_msg_tx *msg, +static void build_power_updown_phy (struct drm_dp_sideband_msg_tx *msg,int port_num,bool power_up) {struct drm_dp_sideband_msg_req_body req;@@ -793,7 +793,6 @@ static int build_power_updown_phy(struct drm_dp_sideband_msg_tx *msg, req.u.port_num.port_number = port_num;drm_dp_encode_sideband_req (&req, msg); msg->path_msg = true; -return 0 ; } static int drm_dp_mst_assign_payload_id(struct drm_dp_mst_topology_mgr *mgr,@@ -2212,7 +2211,7 @@ int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, bool power_up) {struct drm_dp_sideband_msg_tx *txmsg; -int len, ret; +int ret; port =drm_dp_mst_topology_get_port_validated (mgr, port);if (!port)@@ -2225,7 +2224,7 @@ int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr, } txmsg->dst = port->parent; - len =build_power_updown_phy (txmsg, port->port_num, power_up); +build_power_updown_phy (txmsg, port->port_num, power_up);drm_dp_queue_down_tx (mgr, txmsg); ret =drm_dp_mst_wait_tx_reply (port->parent, txmsg);Signature · 6 lines
2.11.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel