tracing: make exported ftrace_set_clr_event non-static
PATCH 1/1 tracing: make exported ftrace_set_clr_event non-static
The function ftrace_set_clr_event is declared static and marked EXPORT_SYMBOL_GPL(), which is at best an odd combination. Because the function was decided to be a part of API, this commit removes the static attribute and adds the declaration to the header.
Fixes f45d1225adb04 ("tracing: Kernel access to Ftrace instances")
Signed-off-by Denis Efremov <[email protected]>
--- include/linux/trace_events.h | 1 + kernel/trace/trace_events.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
include/linux/trace_events.h +1 -0
@@ -539,6 +539,7 @@ extern int trace_event_get_offsets(struct trace_event_call *call);#define is_signed_type (type) (((type)(-1)) < (type)1) +int ftrace_set_clr_event (struct trace_array *tr,char *buf,int set);int trace_set_clr_event (const char *system,const char *event,int set);/*
kernel/trace/trace_events.c +1 -1
@@ -795,7 +795,7 @@ static int __ftrace_set_clr_event(struct trace_array *tr, const char *match,return ret; } -static int ftrace_set_clr_event (struct trace_array *tr,char *buf,int set) +int ftrace_set_clr_event (struct trace_array *tr,char *buf,int set) {char *event =NULL , *sub =NULL , *match;int ret;
Signature · 1 line
2.21.0
Patch looks good to me.
Reviewed-by Joe Jin <[email protected]>
Thanks,
Joe
Quoted 38 lines · Denis Efremov
The function
ftrace_set_clr_eventis declared static and markedEXPORT_SYMBOL_GPL(), which is at best an odd combination. Because the function was decided to be a part of API, this commit removes the static attribute and adds the declaration to the header.Fixes f45d1225adb04 ("tracing: Kernel access to Ftrace instances")Signed-off-by Denis Efremov <[email protected]>--- include/linux/trace_events.h | 1 + kernel/trace/trace_events.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)include/linux/trace_events.h +1
-0@@ -539,6 +539,7 @@ extern int trace_event_get_offsets(struct trace_event_call *call);#define is_signed_type (type) (((type)(-1)) < (type)1) +int ftrace_set_clr_event (struct trace_array *tr,char *buf,int set);int trace_set_clr_event (const char *system,const char *event,int set);/* kernel/trace/trace_events.c +1
-1@@ -795,7 +795,7 @@ static int __ftrace_set_clr_event(struct trace_array *tr, const char *match,return ret; } -static int ftrace_set_clr_event (struct trace_array *tr,char *buf,int set) +int ftrace_set_clr_event (struct trace_array *tr,char *buf,int set) {char *event =NULL , *sub =NULL , *match;int ret;