package/gstreamer1/gst1-plugins-good: add option to enable/disable shout2 plugin
PATCH 1/1 package/gstreamer1/gst1-plugins-good: add option to enable/disable shout2 plugin
Currently there is no way to turn the shout2 plugin on. Create a menu entry allowing users to disable or enable the plugin, like we have for other features (for example the Pulseaudio plugin).
--- package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++ .../gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 9 +++++++-- 2 files changed, 13 insertions(+), 2 deletions(-)
package/gstreamer1/gst1-plugins-good/Config.in +6 -0
@@ -300,6 +300,12 @@ comment "qmlgl (qt5) plugin needs an OpenGL-capable Qt5 backend" depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE depends on !BR2_PACKAGE_QT5_GL_AVAILABLE && !BR2_PACKAGE_QT5_VERSION_LATEST +config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 + bool "shout2" + select BR2_PACKAGE_LIBSHOUT + help + Elements to send data to an icecast server using libshout2 + config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2 bool "v4l2" depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +7 -2
@@ -25,8 +25,7 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \ # Options which require currently unpackaged libraries GST1_PLUGINS_GOOD_CONF_OPTS += \ --disable-libdv \ - --disable-dv1394 \ - --disable-shout2 + --disable-dv1394 GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base
@@ -343,6 +342,12 @@ else GST1_PLUGINS_GOOD_CONF_OPTS += --disable-qt endif +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2),y) +GST1_PLUGINS_GOOD_CONF_OPTS += --enable-shout2 +else +GST1_PLUGINS_GOOD_CONF_OPTS += --disable-shout2 +endif + ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y) GST1_PLUGINS_GOOD_CONF_OPTS += --enable-gst_v4l2 else
Signature · 1 line
2.22.0
PATCH 1/1 package/gstreamer1/gst1-plugins-good: add option to enable/disable shout2 plugin
Hello Arnould,
a little shorter subject line as the following should be enough:
package/gst1-plugins-good: add shout2 plugin option
Quoted 3 lines · Arnold Bloemert
Currently there is no way to turn the shout2 plugin on. Create a menu entry allowing users to disable or enable the plugin, like we have for other features (for example the Pulseaudio plugin).
Given text is more suitable for a cover letter ;-), no special justification for adding a missing option needed....
Quoted 39 lines
Signed-off-by Arnold Bloemert <[email protected]>--- package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++ .../gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 9 +++++++-- 2 files changed, 13 insertions(+), 2 deletions(-)package/gstreamer1/gst1-plugins-good/Config.in +6
-0@@ -300,6 +300,12 @@ comment "qmlgl (qt5) plugin needs an OpenGL-capable Qt5 backend" depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE depends on !BR2_PACKAGE_QT5_GL_AVAILABLE && !BR2_PACKAGE_QT5_VERSION_LATEST +config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 + bool "shout2" + select BR2_PACKAGE_LIBSHOUT + help + Elements to send data to an icecast server using libshout2 + config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2 bool "v4l2" depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar apipackage/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +1
-2@@ -25,8 +25,7 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \ # Options which require currently unpackaged libraries GST1_PLUGINS_GOOD_CONF_OPTS += \ --disable-libdv \ - --disable-dv1394 \ - --disable-shout2 + --disable-dv1394 GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk else · line 346
Quoted 5 lines
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +2
-0@@ -343,6 +342,12 @@ else GST1_PLUGINS_GOOD_CONF_OPTS += --disable-qt endif +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2),y) +GST1_PLUGINS_GOOD_CONF_OPTS += --enable-shout2
...missing:
GST1_PLUGINS_GOOD_DEPENDENCIES += libshout
Otherwise looks good!
Regards,
Peter
Quoted 7 lines
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +4
-0+else +GST1_PLUGINS_GOOD_CONF_OPTS += --disable-shout2 +endif + ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y) GST1_PLUGINS_GOOD_CONF_OPTS += --enable-gst_v4l2 else
PATCH 1/1 package/gstreamer1/gst1-plugins-good: add option to enable/disable shout2 plugin
Hi Peter,
I tried to create a patch in the same style as the patch for jack by Adam, but I like your proposal to simplify.
The missing dependency in the .mk file was a stupid mistake, thanks for noticing it!
I'll create a new revision of the patch, contributing to Buildroot is new for me, so hopefully I'm doing it right.
Kind regards,
Arnold
Op vr 5 jul. 2019 om 17:18 schreef Peter Seiderer <[email protected]>:
Quoted 76 lines
Hello Arnould,
a little shorter subject line as the following should be enough:
package/gst1-plugins-good: add shout2 plugin option
Quoted 3 lines · Arnold Bloemert
Currently there is no way to turn the shout2 plugin on. Create a menu entry allowing users to disable or enable the plugin, like we have for other features (for example the Pulseaudio plugin).
Given text is more suitable for a cover letter ;-), no special justification
for adding a missing option needed....Review
Quoted 8 lines
Signed-off-by Arnold Bloemert <[email protected]>--- package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++ .../gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 9 +++++++-- 2 files changed, 13 insertions(+), 2 deletions(-)(quoted diff) +0
-0b/package/gstreamer1/gst1-plugins-good/Config.in
package/gstreamer1/gst1-plugins-good/Config.in comment "qmlgl (qt5) plugin needs an OpenGL-capable
Quoted 4 lines
index
433084fd6b..ce85388eb0100644package/gstreamer1/gst1-plugins-good/Config.in +0
-0@@ -300,6 +300,12 @@ comment "qmlgl (qt5) plugin needs an OpenGL-capableQt5 backend"
package/gstreamer1/gst1-plugins-good/Config.in comment "qmlgl (qt5) plugin needs an OpenGL-capable · line 301
Quoted 2 lines
package/gstreamer1/gst1-plugins-good/Config.in +0
-0depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE depends on !BR2_PACKAGE_QT5_GL_AVAILABLE &&!BR2_PACKAGE_QT5_VERSION_LATEST
Review
Quoted 11 lines
package/gstreamer1/gst1-plugins-good/Config.in +6
-0+config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 + bool "shout2" + select BR2_PACKAGE_LIBSHOUT + help + Elements to send data to an icecast server using libshout2 + config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2 bool "v4l2" depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api(quoted diff) +0
-0
b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mkQuoted 14 lines
index
829d27a2da..0a6cc77208100644package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +1
-2@@ -25,8 +25,7 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \ # Options which require currently unpackaged libraries GST1_PLUGINS_GOOD_CONF_OPTS += \ --disable-libdv \ - --disable-dv1394 \ - --disable-shout2 + --disable-dv1394 GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-basepackage/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk else · line 346
Quoted 5 lines
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +2
-0@@ -343,6 +342,12 @@ else GST1_PLUGINS_GOOD_CONF_OPTS += --disable-qt endif +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2),y) +GST1_PLUGINS_GOOD_CONF_OPTS += --enable-shout2...missing:
GST1_PLUGINS_GOOD_DEPENDENCIES += libshoutOtherwise looks good!
Regards,
Peter
Quoted 9 lines
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk else · line 353
Quoted 7 lines
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +4
-0+else +GST1_PLUGINS_GOOD_CONF_OPTS += --disable-shout2 +endif + ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y) GST1_PLUGINS_GOOD_CONF_OPTS += --enable-gst_v4l2 else
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190705/6961eb0c/attachment.html>
PATCH 1/1 package/gstreamer1/gst1-plugins-good: add option to enable/disable shout2 plugin
Hello Arnold,
Quoted 4 lines · Arnold Bloemert
Hi Peter,
I tried to create a patch in the same style as the patch for jack by Adam, but I like your proposal to simplify.
Ohhh, I see (the comments are mainly a matter of taste)...
Quoted 3 lines
The missing dependency in the .mk file was a stupid mistake, thanks for noticing it!
No problem (catching it is the main purpose of the review process ;-) )...
Quoted 3 lines
I'll create a new revision of the patch, contributing to Buildroot is new for me, so hopefully I'm doing it right.
Many thanks for contributing, every patch is welcome! Yours is nearly perfect, only one nitpick (see comment on v2 of the patch)...
Regards,
Peter
Quoted 92 lines
Kind regards,
Arnold
Op vr 5 jul. 2019 om 17:18 schreef Peter Seiderer <[email protected]>:
Quoted 85 lines
Hello Arnould,
a little shorter subject line as the following should be enough:
package/gst1-plugins-good: add shout2 plugin option
Quoted 3 lines · Arnold Bloemert
Currently there is no way to turn the shout2 plugin on. Create a menu entry allowing users to disable or enable the plugin, like we have for other features (for example the Pulseaudio plugin).
Given text is more suitable for a cover letter ;-), no special justification
for adding a missing option needed....Review
Quoted 8 lines
Signed-off-by Arnold Bloemert <[email protected]>--- package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++ .../gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 9 +++++++-- 2 files changed, 13 insertions(+), 2 deletions(-)(quoted diff) +0
-0b/package/gstreamer1/gst1-plugins-good/Config.in
package/gstreamer1/gst1-plugins-good/Config.in comment "qmlgl (qt5) plugin needs an OpenGL-capable
Quoted 4 lines
index
433084fd6b..ce85388eb0100644package/gstreamer1/gst1-plugins-good/Config.in +0
-0@@ -300,6 +300,12 @@ comment "qmlgl (qt5) plugin needs an OpenGL-capableQt5 backend"
package/gstreamer1/gst1-plugins-good/Config.in comment "qmlgl (qt5) plugin needs an OpenGL-capable · line 301
Quoted 2 lines
package/gstreamer1/gst1-plugins-good/Config.in +0
-0depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE depends on !BR2_PACKAGE_QT5_GL_AVAILABLE &&!BR2_PACKAGE_QT5_VERSION_LATEST
Review
Quoted 11 lines
package/gstreamer1/gst1-plugins-good/Config.in +6
-0+config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 + bool "shout2" + select BR2_PACKAGE_LIBSHOUT + help + Elements to send data to an icecast server using libshout2 + config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2 bool "v4l2" depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api(quoted diff) +0
-0
b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mkQuoted 14 lines
index
829d27a2da..0a6cc77208100644package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +1
-2@@ -25,8 +25,7 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \ # Options which require currently unpackaged libraries GST1_PLUGINS_GOOD_CONF_OPTS += \ --disable-libdv \ - --disable-dv1394 \ - --disable-shout2 + --disable-dv1394 GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-basepackage/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk else · line 346
Quoted 5 lines
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +2
-0@@ -343,6 +342,12 @@ else GST1_PLUGINS_GOOD_CONF_OPTS += --disable-qt endif +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2),y) +GST1_PLUGINS_GOOD_CONF_OPTS += --enable-shout2...missing:
GST1_PLUGINS_GOOD_DEPENDENCIES += libshoutOtherwise looks good!
Regards,
PeterQuoted 7 lines
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +4
-0+else +GST1_PLUGINS_GOOD_CONF_OPTS += --disable-shout2 +endif + ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y) GST1_PLUGINS_GOOD_CONF_OPTS += --enable-gst_v4l2 else
PATCH v2 1/1 package/gst1-plugins-good: add shout2 plugin option
In reply to Arnold Bloemert---
Changes v1 -> v2:
- add dependency to .mk file and simplify commit message (suggested by Peter Seiderer)
--- package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++ .../gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 10 ++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-)
package/gstreamer1/gst1-plugins-good/Config.in +6 -0
@@ -300,6 +300,12 @@ comment "qmlgl (qt5) plugin needs an OpenGL-capable Qt5 backend" depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE depends on !BR2_PACKAGE_QT5_GL_AVAILABLE && !BR2_PACKAGE_QT5_VERSION_LATEST +config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 + bool "shout2" + select BR2_PACKAGE_LIBSHOUT + help + Elements to send data to an icecast server using libshout2 + config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2 bool "v4l2" depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +8 -2
@@ -25,8 +25,7 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \ # Options which require currently unpackaged libraries GST1_PLUGINS_GOOD_CONF_OPTS += \ --disable-libdv \ - --disable-dv1394 \ - --disable-shout2 + --disable-dv1394 GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base
@@ -343,6 +342,13 @@ else GST1_PLUGINS_GOOD_CONF_OPTS += --disable-qt endif +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2),y) +GST1_PLUGINS_GOOD_CONF_OPTS += --enable-shout2 +GST1_PLUGINS_GOOD_DEPENDENCIES += libshout +else +GST1_PLUGINS_GOOD_CONF_OPTS += --disable-shout2 +endif + ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y) GST1_PLUGINS_GOOD_CONF_OPTS += --enable-gst_v4l2 else
Signature · 1 line
2.22.0
PATCH v2 1/1 package/gst1-plugins-good: add shout2 plugin option
Hello Arnold,
Quoted 47 lines · Arnold Bloemert
Signed-off-by Arnold Bloemert <[email protected]>---
Changes v1 -> v2:
- add dependency to .mk file and simplify commit message (suggested by Peter Seiderer)Signed-off-by Arnold Bloemert <[email protected]>--- package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++ .../gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 10 ++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-)package/gstreamer1/gst1-plugins-good/Config.in +6
-0@@ -300,6 +300,12 @@ comment "qmlgl (qt5) plugin needs an OpenGL-capable Qt5 backend" depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE depends on !BR2_PACKAGE_QT5_GL_AVAILABLE && !BR2_PACKAGE_QT5_VERSION_LATEST +config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 + bool "shout2" + select BR2_PACKAGE_LIBSHOUT + help + Elements to send data to an icecast server using libshout2 + config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2 bool "v4l2" depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar apipackage/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +1
-2@@ -25,8 +25,7 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \ # Options which require currently unpackaged libraries GST1_PLUGINS_GOOD_CONF_OPTS += \ --disable-libdv \ - --disable-dv1394 \ - --disable-shout2 + --disable-dv1394 GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base@@ -343,6 +342,13 @@ else GST1_PLUGINS_GOOD_CONF_OPTS += --disable-qt endif
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk else · line 354
Quoted 10 lines
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +7
-0+ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2),y) +GST1_PLUGINS_GOOD_CONF_OPTS += --enable-shout2 +GST1_PLUGINS_GOOD_DEPENDENCIES += libshout +else +GST1_PLUGINS_GOOD_CONF_OPTS += --disable-shout2 +endif + ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y) GST1_PLUGINS_GOOD_CONF_OPTS += --enable-gst_v4l2 else
The other gstreamer1 files state for the options (see e.g. [1]):
# These plugins are listed in the order from ./configure --help
For shout2 this should be after qt (right) and before soup (false), but taking a look at Config.in/gst1-plugins-good.mk the option order is not very strict....so I am o.k. with your patch ;-), you can add my
Regards,
Peter
PATCH v2 1/1 package/gst1-plugins-good: add shout2 plugin option
In reply to Arnold BloemertOn 05/07/2019 23:50, Arnold Bloemert wrote:
[snip]
package/gstreamer1/gst1-plugins-good/Config.in comment "qmlgl (qt5) plugin needs an OpenGL-capable Qt5 backend" · line 307
Quoted 5 lines
package/gstreamer1/gst1-plugins-good/Config.in +5
-0+config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 + bool "shout2" + select BR2_PACKAGE_LIBSHOUT + help + Elements to send data to an icecast server using libshout2
The indentation was wrong here. Please use utils/check-package to check things
before sending.
I've fixed it and applied to master, so no need to resend, thanks.
Regards,
Arnout
[snip]