Skip to contentSkip to conversation

dmaengine: qcom: bam_dma: Fix completed descriptors count

PATCH Applied Sricharan R 3 participants 3 messages Jun 28, 2019 – Jul 5, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: qcom: bam_dma: Fix completed descriptors count

One space is left unused in circular FIFO to differentiate 'full' and 'empty' cases. So take that in to account while counting for the descriptors completed.

Fixes the issue reported here,

	https://lkml.org/lkml/2019/6/18/669
---
 drivers/dma/qcom/bam_dma.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/dma/qcom/bam_dma.c +3 -0
index 4b43844..8e90a40 100644
@@ -799,6 +799,9 @@ static u32 process_channel_irqs(struct bam_device *bdev)
 		/* Number of bytes available to read */
 		avail = CIRC_CNT(offset, bchan->head, MAX_DESCRIPTORS + 1);
 
+		if (offset < bchan->head)
+			avail--;
+
 		list_for_each_entry_safe(async_desc, tmp,
 					 &bchan->desc_list, desc_node) {
 			/* Not enough data to read */
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Tested-by on v1 1/1
#1 lore raw
Quoted 10 lines · Sricharan R

One space is left unused in circular FIFO to differentiate 'full' and 'empty' cases. So take that in to account while counting for the descriptors completed.

Fixes the issue reported here,

	https://lkml.org/lkml/2019/6/18/669

Thanks for the patch, It works for me now!

--srini

Quoted 19 lines
---
  drivers/dma/qcom/bam_dma.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/dma/qcom/bam_dma.c +3 -0
index 4b43844..8e90a40 100644
@@ -799,6 +799,9 @@ static u32 process_channel_irqs(struct bam_device *bdev)
  		/* Number of bytes available to read */
  		avail = CIRC_CNT(offset, bchan->head, MAX_DESCRIPTORS + 1);
 
+		if (offset < bchan->head)
+			avail--;
+
  		list_for_each_entry_safe(async_desc, tmp,
  					 &bchan->desc_list, desc_node) {
  			/* Not enough data to read */