Sched: Change type of 'overrun' from int to u64
PATCH 1/1 Sched: Change type of 'overrun' from int to u64
Callers of hrtimer_forward_now() should save the return value in u64. function sched_rt_period_timer() stores
it in variable 'overrun' of type int
change type of overrun from int to u64 to solve the issue.
Signed-off-by Puranjay Mohan <puranjay12 at gmail.com>
--- kernel/sched/rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/rt.c +1 -1
@@ -19,7 +19,7 @@ static enum hrtimer_restart sched_rt_period_timer(struct hrtimer *timer)struct rt_bandwidth *rt_b = container_of(timer, struct rt_bandwidth, rt_period_timer);int idle =0 ; -int overrun; +u64 overrun;raw_spin_lock (&rt_b->rt_runtime_lock);for (;;) {
Signature · 1 line
2.21.0
Peter Zijlstra
maintainerQuoted 4 lines · Puranjay Mohan
Callers of
hrtimer_forward_now()should save the return value in u64. functionsched_rt_period_timer()stores
it in variable 'overrun' of type int
change type of overrun from int to u64 to solve the issue.
Is there an actual issue? If we've missed _that_ many periods, something is really buggered.
Quoted 1 line
From a code consistency PoV this patch makes sense, but I don't think
there anything really wrong with the current code.
Quoted 21 lines
Signed-off-by Puranjay Mohan <puranjay12 at gmail.com>--- kernel/sched/rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/sched/rt.c +1
-1@@ -19,7 +19,7 @@ static enum hrtimer_restart sched_rt_period_timer(struct hrtimer *timer)struct rt_bandwidth *rt_b = container_of(timer, struct rt_bandwidth, rt_period_timer);int idle =0 ; -int overrun; +u64 overrun;raw_spin_lock (&rt_b->rt_runtime_lock);for (;;) {Signature · 1 line
2.21.0