Skip to contentSkip to conversation

drivers: net: phy: Ignore PHY ID 0 during PHY probing

PATCH In review Alex Marginean 2 participants 3 messages Jul 5, 2019 – Jul 18, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 drivers: net: phy: Ignore PHY ID 0 during PHY probing

Current code fails to probe some C45 PHYs that also respond to C22 reads. This is the case for PHYs like Aquantia AQR112, Marvell 88X2242 (as previously posted on the u-boot list).
If the PHY ID reads all 0s just ignore it and try the next devad.

---

Changes in v2:
- continue with next addr instead of returning NULL right away
- check get_phy_id return code too

Changes in v3:
- fixed multi-line comment format

 drivers/net/phy/phy.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/net/phy/phy.c +11 -0
index c1c1af9abd..ae37dd6c1e 100644
@@ -727,12 +727,23 @@ static struct phy_device *create_phy_by_mask(struct mii_dev *bus,
 	while (phy_mask) {
 		int addr = ffs(phy_mask) - 1;
 		int r = get_phy_id(bus, addr, devad, &phy_id);
+
+		/*
+		 * If the PHY ID is flat 0 we ignore it.  There are C45 PHYs
+		 * that return all 0s for C22 reads (like Aquantia AQR112) and
+		 * there are C22 PHYs that return all 0s for C45 reads (like
+		 * Atheros AR8035).
+		 */
+		if (r == 0 && phy_id == 0)
+			goto next;
+
 		/* If the PHY ID is mostly f's, we didn't find anything */
 		if (r == 0 && (phy_id & 0x1fffffff) != 0x1fffffff) {
 			is_c45 = (devad == MDIO_DEVAD_NONE) ? false : true;
 			return phy_device_create(bus, addr, phy_id, is_c45,
 						 interface);
 		}
+next:
 		phy_mask &= ~(1 << addr);
 	}
 	return NULL;
Signature · 1 line
2.17.1
#1 lore raw

PATCH v3 1/1 drivers: net: phy: Ignore PHY ID 0 during PHY probing

Quoted 9 lines · Alex Marginean

Current code fails to probe some C45 PHYs that also respond to C22 reads. This is the case for PHYs like Aquantia AQR112, Marvell 88X2242 (as previously posted on the u-boot list).
If the PHY ID reads all 0s just ignore it and try the next devad.