drm/komeda: Disable slave pipeline support
Subsystems (4)
PATCH 1/2 drm/komeda: Disable slave pipeline support
Since the property slave_planes have been removed, to avoid the resource assignment problem in user disable slave pipeline support temporarily.
--- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +1 -1
@@ -481,7 +481,7 @@ int komeda_kms_setup_crtcs(struct komeda_kms_dev *kms, master = mdev->pipelines[i]; crtc->master = master; - crtc->slave =komeda_pipeline_get_slave (master); + crtc->slave =NULL ;if (crtc->slave)sprintf (str,"pipe-%d" , crtc->slave->id);
Signature · 1 line
2.20.1
Quoted 4 lines · james qian wang (Arm Technology China)
Since the property
slave_planeshave been removed, to avoid the resource assignment problem in user disable slave pipeline support temporarily.
I guess the way you have to enumerate the planes listing the slave planes wont just automatically work in any fashion and force a lot more fallbacks to primary plane only. At least until virtualization of plane hw is done. So makes sense to outright disable all the slave plane stuff for now. And I think it's ok to keep all the code still, we'll use it again.
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c int komeda_kms_setup_crtcs(struct komeda_kms_dev *kms, · line 484
Quoted 13 lines
--- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +0
-1@@ -481,7 +481,7 @@ int komeda_kms_setup_crtcs(struct komeda_kms_dev *kms, master = mdev->pipelines[i]; crtc->master = master; - crtc->slave =komeda_pipeline_get_slave (master);
This might cause an unused function warning, might need to annotate it with __unused.
-Daniel
Quoted 11 lines
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +1
-0+ crtc->slave =NULL ;if (crtc->slave)sprintf (str,"pipe-%d" , crtc->slave->id);Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 25 lines · Daniel Vetter
Quoted 4 lines · james qian wang (Arm Technology China)
Since the property
slave_planeshave been removed, to avoid the resource assignment problem in user disable slave pipeline support temporarily.I guess the way you have to enumerate the planes listing the slave planes wont just automatically work in any fashion and force a lot more fallbacks to primary plane only. At least until virtualization of plane hw is done. So makes sense to outright disable all the slave plane stuff for now. And I think it's ok to keep all the code still, we'll use it again.
Acked-by Daniel Vetter <[email protected]>Quoted 11 lines
--- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +0
-0@@ -481,7 +481,7 @@ int komeda_kms_setup_crtcs(struct komeda_kms_dev *kms, master = mdev->pipelines[i];
Quoted 6 lines
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c int komeda_kms_setup_crtcs(struct komeda_kms_dev *kms, · line 484
Quoted 2 lines
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +0
-1crtc->master = master; -crtc->slave =komeda_pipeline_get_slave (master);This might cause an unused function warning, might need to annotate it with
__unused.
-Daniel
If so, I'd like to drop this change.
Since even with this change, that still can not pass all our tests. we have to update the user tests or the komeda implementation. Once we finished the updating, we still need to revert this change. So maybe just drop it is more better.
Thanks
James
Quoted 12 lines
Quoted 11 lines
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +1
-1+crtc->slave =NULL ;if (crtc->slave)sprintf (str,"pipe-%d" , crtc->slave->id); --2.20.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 4 lines
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.