Skip to contentSkip to conversation

gpu: drm: pl111: pl111_vexpress.c: Add of_node_put() before return

PATCH In review Nishka Dasgupta 2 participants 2 messages Jul 6, 2019 – Jul 16, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: drm: pl111: pl111_vexpress.c: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a break from the middle of the loop there is no put, thus causing a memory leak. Hence add an of_node_put before the break.
Issue found with Coccinelle.

---
 drivers/gpu/drm/pl111/pl111_vexpress.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/pl111/pl111_vexpress.c +1 -0
index 38c938c9adda..350570fe06b5 100644
@@ -51,6 +51,7 @@ int pl111_vexpress_clcd_init(struct device *dev,
 		}
 		if (of_device_is_compatible(child, "arm,hdlcd")) {
 			has_coretile_hdlcd = true;
+			of_node_put(child);
 			break;
 		}
 	}
Signature · 6 lines
2.19.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
Quoted 5 lines · Nishka Dasgupta

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a break from the middle of the loop there is no put, thus causing a memory leak. Hence add an of_node_put before the break.
Issue found with Coccinelle.

Pushed. Thanks!

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel