Skip to contentSkip to conversation

debugfs: make error message a bit more verbose

PATCH In review Greg Kroah-Hartman 2 participants 2 messages Jul 6, 2019 Driver core

lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 1/1 debugfs: make error message a bit more verbose

When a file/directory is already present in debugfs, and it is attempted to be created again, be more specific about what file/directory is being created and where it is trying to be created to give a bit more help to developers to figure out the problem.

Cc Stephen Rothwell <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
Cc Mark Brown <[email protected]>
Cc Takashi Iwai <[email protected]>
---
 fs/debugfs/inode.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
fs/debugfs/inode.c +6 -1
index 7f43c8acfcbf..5836312269e0 100644
@@ -311,8 +311,13 @@ static struct dentry *start_creating(const char *name, struct dentry *parent)
 	inode_lock(d_inode(parent));
 	dentry = lookup_one_len(name, parent, strlen(name));
 	if (!IS_ERR(dentry) && d_really_is_positive(dentry)) {
+		if (d_is_dir(dentry))
+			pr_err("Directory '%s' with parent '%s' already present!\n",
+			       name, parent->d_name.name);
+		else
+			pr_err("File '%s' in directory '%s' already present!\n",
+			       name, parent->d_name.name);
 		dput(dentry);
-		pr_err("File '%s' already present!\n", name);
 		dentry = ERR_PTR(-EEXIST);
 	}
 
Signature · 1 line
2.22.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Greg Kroah-Hartman

When a file/directory is already present in debugfs, and it is attempted to be created again, be more specific about what file/directory is being created and where it is trying to be created to give a bit more help to developers to figure out the problem.