Skip to contentSkip to conversation

arm: mediatek: remove arch_misc_init

PATCH New Weijie Gao 2 participants 2 messages May 16, 2019 – Jul 8, 2019

Subsystems (3)
lore
Share & tools
lore

Weijie Gao

author
#0 lore raw

PATCH v2 3/3 arm: mediatek: remove arch_misc_init

The watchdog of mediatek chips is enabled by bootrom before u-boot is running. Previously we choose to enable the wdt driver only to disable the watchdog hardware.

Now wdt service is enabled by default. The function arch_misc_init which is only used to disable wdt is no longer needed.

---
Changes since v1: none

---
 arch/arm/mach-mediatek/Kconfig |  3 ---
 arch/arm/mach-mediatek/cpu.c   | 12 ------------
 2 files changed, 15 deletions(-)
arch/arm/mach-mediatek/Kconfig +0 -3
index b5e91d4a7d..60aef15f15 100644
@@ -12,7 +12,6 @@ choice
 config TARGET_MT7623
 	bool "MediaTek MT7623 SoC"
 	select CPU_V7A
-	select ARCH_MISC_INIT
 	help
 	  The MediaTek MT7623 is a ARM-based SoC with a quad-core Cortex-A7
 	  including NEON and GPU, Mali-450 graphics, several DDR3 options,
@@ -25,7 +24,6 @@ config TARGET_MT7629
 	bool "MediaTek MT7629 SoC"
 	select CPU_V7A
 	select SPL
-	select ARCH_MISC_INIT
 	help
 	  The MediaTek MT7629 is a ARM-based SoC with a dual-core Cortex-A7
 	  including DDR3, crypto engine, 3x3 11n/ac Wi-Fi, Gigabit Ethernet,
@@ -34,7 +32,6 @@ config TARGET_MT7629
 config TARGET_MT8516
 	bool "MediaTek MT8516 SoC"
 	select ARM64
-	select ARCH_MISC_INIT
 	help
 	  The MediaTek MT8516 is a ARM64-based SoC with a quad-core Cortex-A35.
 	  including UART, SPI, USB2.0 and OTG, SD and MMC cards, NAND, PWM,
arch/arm/mach-mediatek/cpu.c +0 -12
index b37e299b74..1923c9e527 100644
@@ -8,18 +8,6 @@
 #include <wdt.h>
 #include <dm/uclass-internal.h>
 
-int arch_misc_init(void)
-{
-	struct udevice *wdt;
-	int ret;
-
-	ret = uclass_first_device_err(UCLASS_WDT, &wdt);
-	if (!ret)
-		wdt_stop(wdt);
-
-	return 0;
-}
-
 int arch_cpu_init(void)
 {
 	icache_enable();
Signature · 1 line
2.18.0
#1 lore raw

PATCH v2 3/3 arm: mediatek: remove arch_misc_init

Quoted 10 lines · Weijie Gao

The watchdog of mediatek chips is enabled by bootrom before u-boot is running. Previously we choose to enable the wdt driver only to disable the watchdog hardware.

Now wdt service is enabled by default. The function arch_misc_init which is only used to disable wdt is no longer needed.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190707/701fc898/attachment.sig>