rtc: bd70528: fix link error
PATCH 1/1 rtc: bd70528: fix link error
With CONFIG_BD70528_WATCHDOG=m, a built-in rtc driver cannot call into the low-level functions that are part of the watchdog module:
drivers/rtc/rtc-bd70528.o: In function `bd70528_set_time':
rtc-bd70528.c:(.text+0x22c): undefined reference to bd70528_wdt_lock' rtc-bd70528.c:(.text+0x2a8): undefined reference to bd70528_wdt_unlock' drivers/rtc/rtc-bd70528.o: In function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x50c): undefined reference to `bd70528_wdt_set'
Add a Kconfig dependency on this driver, but still allow compile-testing without it.
--- drivers/rtc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/rtc/Kconfig +2 -0
@@ -498,8 +498,10 @@ config RTC_DRV_M41T80_WDT help If you say Y here you will get support for the watchdog timer in the ST M41T60 and M41T80 RTC chips series. + config RTC_DRV_BD70528 tristate "ROHM BD70528 PMIC RTC" + depends on BD70528_WATCHDOG || (COMPILE_TEST && !BD70528_WATCHDOG) help If you say Y here you will get support for the RTC on ROHM BD70528 Power Management IC.
Signature · 1 line
2.20.0
Hello Arnd,
Thanks for taking a look on this!
Quoted 28 lines · Arnd Bergmann
With
CONFIG_BD70528_WATCHDOG=m, a built-in rtc driver cannot call into the low-level functions that are part of the watchdog module:
drivers/rtc/rtc-bd70528.o: In function `bd70528_set_time':
rtc-bd70528.c:(.text+0x22c): undefined reference to `bd70528_wdt_lock'
rtc-bd70528.c:(.text+0x2a8): undefined reference to `bd70528_wdt_unlock'drivers/rtc/rtc-bd70528.o: In function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x50c): undefined reference to `bd70528_wdt_set'Add a
Kconfigdependency on this driver, but still allow compile- testing
without it.Fixes 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528RTC")
Signed-off-by Arnd Bergmann <[email protected]>--- drivers/rtc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/rtc/Kconfig +0
-0
drivers/rtc/Kconfig config RTC_DRV_M41T80_WDT · line 505
Quoted 8 lines
drivers/rtc/Kconfig +2
-0@@ -498,8 +498,10 @@ config RTC_DRV_M41T80_WDT help If you say Y here you will get support for the watchdog timer in the ST M41T60 and M41T80 RTC chips series. + config RTC_DRV_BD70528 tristate "ROHM BD70528 PMIC RTC" + depends on BD70528_WATCHDOG || (COMPILE_TEST && !BD70528_WATCHDOG)
I am not fan of this. There may well be use-cases where it is desirable to leave the watchdog out but still compile in the RTC. This is why we have static inline stubs in the header for cases where WDG is not compiled in. (RTC does not need to stop WDG if WDG driver is not included)
Adding dependency from RTC to MFD for BD70528 should be done - this will avoid most of the issues (And there has been few patches sent for this already). But that's still not complete solution because configuring RTC and MFD to be built in-kernel and WDG as a module will cause errors again.
Is there a way to force WDG in-kernel if RTC is in-kernel? (Or disallow configuring RTC in-kernel if WDG is a module - while still allow RTC to be built without WDG?
Quoted 3 lines
drivers/rtc/Kconfig +0
-0help If you say Y here you will get support for the RTCon ROHM BD70528 Power Management IC.
Quoted 50 lines · Matti
Quoted 28 lines · Arnd Bergmann
With
CONFIG_BD70528_WATCHDOG=m, a built-in rtc driver cannot call into the low-level functions that are part of the watchdog module:
drivers/rtc/rtc-bd70528.o: In function `bd70528_set_time':
rtc-bd70528.c:(.text+0x22c): undefined reference to `bd70528_wdt_lock'
rtc-bd70528.c:(.text+0x2a8): undefined reference to `bd70528_wdt_unlock'drivers/rtc/rtc-bd70528.o: In function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x50c): undefined reference to `bd70528_wdt_set'Add a
Kconfigdependency on this driver, but still allow compile- testing
without it.Fixes 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528RTC")
Signed-off-by Arnd Bergmann <[email protected]>--- drivers/rtc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/rtc/Kconfig +0
-0drivers/rtc/Kconfig config RTC_DRV_M41T80_WDT · line 505
Quoted 8 lines
drivers/rtc/Kconfig +2
-0@@ -498,8 +498,10 @@ config RTC_DRV_M41T80_WDT help If you say Y here you will get support for the watchdog timer in the ST M41T60 and M41T80 RTC chips series. + config RTC_DRV_BD70528 tristate "ROHM BD70528 PMIC RTC" + depends on BD70528_WATCHDOG || (COMPILE_TEST && !BD70528_WATCHDOG)I am not fan of this. There may well be use-cases where it is desirable to leave the watchdog out but still compile in the RTC. This is why we have static inline stubs in the header for cases where WDG is not compiled in. (RTC does not need to stop WDG if WDG driver is not included)
Adding dependency from RTC to MFD for BD70528 should be done - this will avoid most of the issues (And there has been few patches sent for this already). But that's still not complete solution because configuring RTC and MFD to be built in-kernel and WDG as a module will cause errors again.
Quoted 3 lines
Is there a way to force WDG in-kernel if RTC is in-kernel? (Or disallow configuring RTC in-kernel if WDG is a module - while still allow RTC to be built without WDG?
We could make this
depends on BD70528_WATCHDOG || !BD70528_WATCHDOG
which would allow building with or without watchdog, even when not compile-testing, but still disallow the combination of BD70528_WATCHDOG=m with RTC_DRV_BD70528=y.
Arnd
Hello Arnd,
(Added Randy who also sent a patch to fix this)
Quoted 65 lines · Arnd Bergmann
Quoted 58 lines · Matti
Quoted 39 lines · Arnd Bergmann
With
CONFIG_BD70528_WATCHDOG=m, a built-in rtc driver cannot call into the low-level functions that are part of the watchdog module:
drivers/rtc/rtc-bd70528.o: In function `bd70528_set_time':
rtc-bd70528.c:(.text+0x22c): undefined reference to `bd70528_wdt_lock'
rtc-bd70528.c:(.text+0x2a8): undefined reference to `bd70528_wdt_unlock'drivers/rtc/rtc-bd70528.o: In function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x50c): undefined reference to `bd70528_wdt_set'Add a
Kconfigdependency on this driver, but still allow compile- testing
without it.Fixes 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHMbd70528
RTC")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/rtc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/rtc/Kconfig +0
-0@@ -498,8 +498,10 @@ config RTC_DRV_M41T80_WDT help If you say Y here you will get support for the watchdog timer in the ST M41T60 and M41T80 RTC chipsseries.
drivers/rtc/Kconfig +2
-0+ config RTC_DRV_BD70528 tristate "ROHM BD70528 PMIC RTC" + depends on BD70528_WATCHDOG || (COMPILE_TEST &&Quoted 1 line
!BD70528_WATCHDOG)
I am not fan of this. There may well be use-cases where it is desirable
to leave the watchdog out but still compile in the RTC. This is why we
have static inline stubs in the header for cases where WDG is not compiled in. (RTC does not need to stop WDG if WDG driver is not included)Adding dependency from RTC to MFD for BD70528 should be done - this will avoid most of the issues (And there has been few patches sent for
this already). But that's still not complete solution because configuring RTC and MFD to be built in-kernel and WDG as a module will
cause errors again.Quoted 3 lines
Is there a way to force WDG in-kernel if RTC is in-kernel? (Or disallow configuring RTC in-kernel if WDG is a module - while still allow RTC to be built without WDG?
Quoted 7 lines
We could make this
depends on BD70528_WATCHDOG || !BD70528_WATCHDOGwhich would allow building with or without watchdog, even when not compile-testing, but still disallow the combination of .
Thanks for teaching me Arnd! That is clever :) We need something like
depends on MFD_ROHM_BD70528 && (BD70528_WATCHDOG || !BD70528_WATCHDOG)
(I'm not sure if parenthesis are Ok and respected in Kconfig). I would never have thought of BD70528_WATCHDOG || !BD70528_WATCHDOG - it looks awkward at first sight but indeed - depends on BD70528_WATCHDOG disallows BD70528_WATCHDOG=m with RTC_DRV_BD70528=y while !BD70528_WATCHDOG allows BD70528_WATCHDOG=n. Brilliant and exactly what we need :) Thanks a bunch!
Quoted 2 lines
Arnd
Quoted 80 lines · Matti
Hello Arnd,
(Added Randy who also sent a patch to fix this)
Quoted 65 lines · Arnd Bergmann
Quoted 58 lines · Matti
Quoted 39 lines · Arnd Bergmann
With
CONFIG_BD70528_WATCHDOG=m, a built-in rtc driver cannot call into the low-level functions that are part of the watchdog module:
drivers/rtc/rtc-bd70528.o: In function `bd70528_set_time':
rtc-bd70528.c:(.text+0x22c): undefined reference to `bd70528_wdt_lock'
rtc-bd70528.c:(.text+0x2a8): undefined reference to `bd70528_wdt_unlock'drivers/rtc/rtc-bd70528.o: In function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x50c): undefined reference to `bd70528_wdt_set'Add a
Kconfigdependency on this driver, but still allow compile- testing
without it.Fixes 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHMbd70528
RTC")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/rtc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/rtc/Kconfig +0
-0@@ -498,8 +498,10 @@ config RTC_DRV_M41T80_WDT help If you say Y here you will get support for the watchdog timer in the ST M41T60 and M41T80 RTC chipsseries.
drivers/rtc/Kconfig +2
-0+ config RTC_DRV_BD70528 tristate "ROHM BD70528 PMIC RTC" + depends on BD70528_WATCHDOG || (COMPILE_TEST &&Quoted 1 line
!BD70528_WATCHDOG)
I am not fan of this. There may well be use-cases where it is desirable
to leave the watchdog out but still compile in the RTC. This is why we
have static inline stubs in the header for cases where WDG is not compiled in. (RTC does not need to stop WDG if WDG driver is not included)Adding dependency from RTC to MFD for BD70528 should be done - this will avoid most of the issues (And there has been few patches sent for
this already). But that's still not complete solution because configuring RTC and MFD to be built in-kernel and WDG as a module will
cause errors again.Quoted 3 lines
Is there a way to force WDG in-kernel if RTC is in-kernel? (Or disallow configuring RTC in-kernel if WDG is a module - while still allow RTC to be built without WDG?
Quoted 7 lines
We could make this
depends on BD70528_WATCHDOG || !BD70528_WATCHDOGwhich would allow building with or without watchdog, even when not compile-testing, but still disallow the combination of .
Thanks for teaching me Arnd! That is clever :) We need something like
Quoted 8 lines
depends on
MFD_ROHM_BD70528&& (BD70528_WATCHDOG|| !BD70528_WATCHDOG)(I'm not sure if parenthesis are Ok and respected in
Kconfig). I would never have thought ofBD70528_WATCHDOG|| !BD70528_WATCHDOG - it looks awkward at first sight but indeed - depends onBD70528_WATCHDOGdisallows BD70528_WATCHDOG=m with RTC_DRV_BD70528=y while !BD70528_WATCHDOG allows BD70528_WATCHDOG=n. Brilliant and exactly what we need :) Thanks a bunch!
Hello Vaittinen,
the issue still exists in linux-next 20190807, any plan?
Quoted 3 lines
Quoted 3 lines
Arnd
Hello All,
Quoted 105 lines · Yuehaibing
Quoted 94 lines · Matti
Hello Arnd,
(Added Randy who also sent a patch to fix this)
Quoted 74 lines · Arnd Bergmann
Quoted 66 lines · Matti
Quoted 41 lines · Arnd Bergmann
With
CONFIG_BD70528_WATCHDOG=m, a built-in rtc driver cannot call
into the low-level functions that are part of the watchdog module:
drivers/rtc/rtc-bd70528.o: In function `bd70528_set_time':
rtc-bd70528.c:(.text+0x22c): undefined reference to `bd70528_wdt_lock'
rtc-bd70528.c:(.text+0x2a8): undefined reference to `bd70528_wdt_unlock'drivers/rtc/rtc-bd70528.o: In function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x50c): undefined reference to `bd70528_wdt_set'Add a
Kconfigdependency on this driver, but still allow compile-
testing
without it.Fixes 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHMbd70528
RTC")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/rtc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/rtc/Kconfig +0
-0@@ -498,8 +498,10 @@ config RTC_DRV_M41T80_WDT help If you say Y here you will get support for the watchdog timer in the ST M41T60 and M41T80 RTC chipsseries.
drivers/rtc/Kconfig +2
-0+ config RTC_DRV_BD70528 tristate "ROHM BD70528 PMIC RTC" + depends on BD70528_WATCHDOG || (COMPILE_TEST &&Quoted 1 line
!BD70528_WATCHDOG)
I am not fan of this. There may well be use-cases where it is desirable
to leave the watchdog out but still compile in the RTC. This is why
we
have static inline stubs in the header for cases where WDG is not
compiled in. (RTC does not need to stop WDG if WDG driver is not
included)Adding dependency from RTC to MFD for BD70528 should be done - this
will avoid most of the issues (And there has been few patches sent
for
this already). But that's still not complete solution because configuring RTC and MFD to be built in-kernel and WDG as a module
will
cause errors again.Quoted 4 lines
Is there a way to force WDG in-kernel if RTC is in-kernel? (Or disallow configuring RTC in-kernel if WDG is a module - while still
allow RTC to be built without WDG?Quoted 8 lines
We could make this
depends on BD70528_WATCHDOG || !BD70528_WATCHDOGwhich would allow building with or without watchdog, even when not
compile-testing, but still disallow the combination of .Thanks for teaching me Arnd! That is clever :) We need something like
depends on
MFD_ROHM_BD70528&& (BD70528_WATCHDOG|| !BD70528_WATCHDOG)Quoted 9 lines
(I'm not sure if parenthesis are Ok and respected in
Kconfig). I would
never have thought ofBD70528_WATCHDOG|| !BD70528_WATCHDOG - it looks
awkward at first sight but indeed - depends onBD70528_WATCHDOGdisallows BD70528_WATCHDOG=m with RTC_DRV_BD70528=y while !BD70528_WATCHDOG allows BD70528_WATCHDOG=n. Brilliant and exactly what
we need :) Thanks a bunch!
Quoted 8 lines
Hello Vaittinen,
the issue still exists in linux-next 20190807, any plan?
Sorry folks. I thought Arnd would send new patch - I didn't want to steal his work ;) I will be back to my normal life next week so I will send a patch at monday if the issue is still open!
Br,
Matti
Quoted 8 lines · Matti
Quoted 7 lines · Yuehaibing
Quoted 5 lines · Matti
awkward at first sight but indeed - depends on
BD70528_WATCHDOGdisallows BD70528_WATCHDOG=m with RTC_DRV_BD70528=y while !BD70528_WATCHDOG allows BD70528_WATCHDOG=n. Brilliant and exactly what
we need :) Thanks a bunch!
Quoted 8 lines
Quoted 4 lines
Hello Vaittinen,
the issue still exists in linux-next 20190807, any plan?
Sorry folks. I thought Arnd would send new patch - I didn't want to steal his work ;) I will be back to my normal life next week so I will send a patch at monday if the issue is still open!
Sorry I lost track, and thanks for the offer to take care of it.
Please add my one
and/or
as appropriate when you create that patch.
Arnd